Merge branch 'MDL-51461' of https://github.com/andrewhancox/moodle

diff --git a/lib/amd/build/localstorage.min.js b/lib/amd/build/localstorage.min.js
index c757939..372e525 100644 (file)
Binary files a/lib/amd/build/localstorage.min.js and b/lib/amd/build/localstorage.min.js differ

diff --git a/lib/amd/src/localstorage.js b/lib/amd/src/localstorage.js
index 7cd824e..48cda61 100644 (file)
--- a/lib/amd/src/localstorage.js
+++ b/lib/amd/src/localstorage.js
@@ -46,13 +46,22 @@ define(['core/config'], function(config) {
             // Disable cache if debugging.
             return false;
         }
-        if (typeof(window.localStorage) !== "undefined") {
-            try {
-                localStorage = window.localStorage;
-                return localStorage !== null;
-            } catch (ex) {
+        if (typeof(window.localStorage) === "undefined") {
+            return false;
+        }
+        var testKey = 'test';
+        try {
+            localStorage = window.localStorage;
+            if (localStorage === null) {
                 return false;
             }
+           // MDL-51461 - Some browsers misreport availability of local storage
+           // so check it is actually usable.
+            localStorage.setItem(testKey, '1');
+            localStorage.removeItem(testKey);
+            return true;
+        } catch (ex) {
+            return false;
         }
     };