MDL-23856 fixed incorrect integer comparison, we should not use === or !== because...

diff --git a/login/change_password.php b/login/change_password.php
index 5188ea5..b020cb3 100644 (file)
--- a/login/change_password.php
+++ b/login/change_password.php
@@ -30,7 +30,7 @@ require_once('change_password_form.php');
 $id = optional_param('id', SITEID, PARAM_INT); // current course
 
 $url = new moodle_url('/login/change_password.php');
-if ($id !== SITEID) {
+if ($id != SITEID) {
     $url->param('id', $id);
 }
 $PAGE->set_url($url);

diff --git a/message/edit.php b/message/edit.php
index c3ed9f1..d04c78e 100644 (file)
--- a/message/edit.php
+++ b/message/edit.php
@@ -32,7 +32,7 @@ $url = new moodle_url('/message/edit.php');
 if ($userid !== $USER->id) {
     $url->param('id', $userid);
 }
-if ($course !== SITEID) {
+if ($course != SITEID) {
     $url->param('course', $course);
 }
 $PAGE->set_url($url);

diff --git a/notes/index.php b/notes/index.php
index 53fed7d..0059449 100644 (file)
--- a/notes/index.php
+++ b/notes/index.php
@@ -16,7 +16,7 @@ $filtertype   = optional_param('filtertype', '', PARAM_ALPHA);
 $filterselect = optional_param('filterselect', 0, PARAM_INT);
 
 $url = new moodle_url('/notes/index.php');
-if ($courseid !== SITEID) {
+if ($courseid != SITEID) {
     $url->param('course', $courseid);
 }
 if ($userid !== 0) {

diff --git a/pluginfile.php b/pluginfile.php
index de97303..c62b413 100644 (file)
--- a/pluginfile.php
+++ b/pluginfile.php
@@ -146,7 +146,7 @@ if ($component === 'blog') {
         //TODO: nobody implemented this yet in grade edit form!!
         send_file_not_found();
 
-        if ($CFG->forcelogin || $course->id !== SITEID) {
+        if ($CFG->forcelogin || $course->id != SITEID) {
             require_login($course);
         }
 
@@ -244,7 +244,7 @@ if ($component === 'blog') {
 
         // Respect forcelogin and require login unless this is the site.... it probably
         // should NEVER be the site
-        if ($CFG->forcelogin || $course->id !== SITEID) {
+        if ($CFG->forcelogin || $course->id != SITEID) {
             require_login($course);
         }
 
@@ -488,7 +488,7 @@ if ($component === 'blog') {
     } else if ($filearea === 'section') {
         if ($CFG->forcelogin) {
             require_login($course);
-        } else if ($course->id !== SITEID) {
+        } else if ($course->id != SITEID) {
             require_login($course);
         }
 

diff --git a/repository/manage_instances.php b/repository/manage_instances.php
index 3973dda..5478dd6 100644 (file)
--- a/repository/manage_instances.php
+++ b/repository/manage_instances.php
@@ -61,7 +61,7 @@ if ($contextid !== 0) {
     $url->param('contextid', $contextid);
     $baseurl->param('contextid', $contextid);
 }
-if ($usercourseid !== SITEID) {
+if ($usercourseid != SITEID) {
     $url->param('usercourseid', $usercourseid);
 }