MDL-38713 course: correctly set visibleold on mod creation

Remove uncessary set of visibleold in the form

diff --git a/course/modlib.php b/course/modlib.php
index 166c638..614ac8a 100644 (file)
--- a/course/modlib.php
+++ b/course/modlib.php
@@ -61,6 +61,7 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
     $newcm->module           = $moduleinfo->module;
     $newcm->instance         = 0; // Not known yet, will be updated later (this is similar to restore code).
     $newcm->visible          = $moduleinfo->visible;
+    $newcm->visibleold       = $moduleinfo->visible;
     $newcm->groupmode        = $moduleinfo->groupmode;
     $newcm->groupingid       = $moduleinfo->groupingid;
     $newcm->groupmembersonly = $moduleinfo->groupmembersonly;
@@ -128,7 +129,6 @@ function add_moduleinfo($moduleinfo, $course, $mform = null) {
     // Make sure visibility is set correctly (in particular in calendar).
     // Note: allow them to set it even without moodle/course:activityvisibility.
     set_coursemodule_visible($moduleinfo->coursemodule, $moduleinfo->visible);
-    $DB->set_field('course_modules', 'visibleold', 1, array('id' => $moduleinfo->coursemodule));
 
     if (isset($moduleinfo->cmidnumber)) { // Label.
         // Set cm idnumber - uniqueness is already verified by form validation.