MDL-50583 upgrade: Optimize upgrade_minmaxgrade

Reverse join order to use existing database keys. Changed query to use the
more easily read NOT IN.

diff --git a/lib/upgradelib.php b/lib/upgradelib.php
index 68978e2..0c2349b 100644 (file)
--- a/lib/upgradelib.php
+++ b/lib/upgradelib.php
@@ -2303,10 +2303,10 @@ function upgrade_minmaxgrade() {
 
     // Identify the courses that have inconsistencies grade_item vs grade_grade.
     $sql = "SELECT DISTINCT(gi.courseid)
-              FROM {grade_items} gi
-              JOIN {grade_grades} gg
+              FROM {grade_grades} gg
+              JOIN {grade_items} gi
                 ON gg.itemid = gi.id
-             WHERE (gi.itemtype != ? AND gi.itemtype != ?)
+             WHERE gi.itemtype NOT IN (?, ?)
                AND (gg.rawgrademax != gi.grademax OR gg.rawgrademin != gi.grademin)";
 
     $rs = $DB->get_recordset_sql($sql, array('course', 'category'));