MDL-57920 mod_data: Fix var dynamic creation (failing in php7)

diff --git a/mod/data/classes/external.php b/mod/data/classes/external.php
index e6862df..e71c98c 100644 (file)
--- a/mod/data/classes/external.php
+++ b/mod/data/classes/external.php
@@ -742,8 +742,12 @@ class mod_data_external extends external_api {
             $fn = $ln = ''; // Defaults for first and last name.
             // Force defaults for advanced search.
             foreach ($params['advsearch'] as $adv) {
-                if ($adv['name'] == 'fn' || $adv['name'] == 'ln') {
-                    $$adv['name'] = json_decode($adv['value']);
+                if ($adv['name'] == 'fn') {
+                    $fn = json_decode($adv['value']);
+                    continue;
+                }
+                if ($adv['name'] == 'ln') {
+                    $ln = json_decode($adv['value']);
                     continue;
                 }
                 $defaults[$adv['name']] = json_decode($adv['value']);