MDL-65448 core_course: Restyle non-JS activity moving.
authorLuca Bösch <luca.boesch@bfh.ch>
Sat, 15 Feb 2020 16:43:55 +0000 (17:43 +0100)
committerLuca Bösch <luca.boesch@bfh.ch>
Fri, 16 Oct 2020 12:50:10 +0000 (14:50 +0200)
course/renderer.php
theme/boost/scss/moodle/core.scss
theme/boost/style/moodle.css
theme/classic/style/moodle.css

index 89b7e0c..8d25c22 100644 (file)
@@ -1004,7 +1004,6 @@ class core_course_renderer extends plugin_renderer_base {
         // check if we are currently in the process of moving a module with JavaScript disabled
         $ismoving = $this->page->user_is_editing() && ismoving($course->id);
         if ($ismoving) {
-            $movingpix = new pix_icon('movehere', get_string('movehere'), 'moodle', array('class' => 'movetarget'));
             $strmovefull = strip_tags(get_string("movefull", "", "'$USER->activitycopyname'"));
         }
 
@@ -1032,7 +1031,7 @@ class core_course_renderer extends plugin_renderer_base {
                 if ($ismoving) {
                     $movingurl = new moodle_url('/course/mod.php', array('moveto' => $modnumber, 'sesskey' => sesskey()));
                     $sectionoutput .= html_writer::tag('li',
-                            html_writer::link($movingurl, $this->output->render($movingpix), array('title' => $strmovefull)),
+                            html_writer::link($movingurl, '', array('title' => $strmovefull, 'class' => 'movehere')),
                             array('class' => 'movehere'));
                 }
 
@@ -1042,7 +1041,7 @@ class core_course_renderer extends plugin_renderer_base {
             if ($ismoving) {
                 $movingurl = new moodle_url('/course/mod.php', array('movetosection' => $section->id, 'sesskey' => sesskey()));
                 $sectionoutput .= html_writer::tag('li',
-                        html_writer::link($movingurl, $this->output->render($movingpix), array('title' => $strmovefull)),
+                        html_writer::link($movingurl, '', array('title' => $strmovefull, 'class' => 'movehere')),
                         array('class' => 'movehere'));
             }
         }
index e49aaae..4653e2d 100644 (file)
@@ -219,6 +219,17 @@ div.dropdown-item {
     padding: 0;
 }
 
+section a.movehere,
+.section li.movehere a.movehere {
+    outline: 0;
+    box-shadow: $input-btn-focus-box-shadow;
+}
+
+.editing .course-content .hidden.sectionname {
+    visibility: hidden;
+    display: initial;
+}
+
 .inline,
 .inline-list li {
     display: inline;
index 82cbcd9..6576a02 100644 (file)
@@ -9840,6 +9840,15 @@ div.dropdown-item:focus-within {
   margin: 0;
   padding: 0; }
 
+section a.movehere,
+.section li.movehere a.movehere {
+  outline: 0;
+  box-shadow: 0 0 0 0.2rem rgba(17, 119, 209, 0.75); }
+
+.editing .course-content .hidden.sectionname {
+  visibility: hidden;
+  display: initial; }
+
 .inline,
 .inline-list li {
   display: inline; }
index 95385c8..cfb53dc 100644 (file)
@@ -10044,6 +10044,15 @@ div.dropdown-item:focus-within {
   margin: 0;
   padding: 0; }
 
+section a.movehere,
+.section li.movehere a.movehere {
+  outline: 0;
+  box-shadow: 0 0 0 0.2rem rgba(17, 119, 209, 0.75); }
+
+.editing .course-content .hidden.sectionname {
+  visibility: hidden;
+  display: initial; }
+
 .inline,
 .inline-list li {
   display: inline; }