MDL-57791 analytics: Remove reference to removed config var

diff --git a/course/classes/analytics/indicator/no_teacher.php b/course/classes/analytics/indicator/no_teacher.php
index d240a96..78e3597 100644 (file)
--- a/course/classes/analytics/indicator/no_teacher.php
+++ b/course/classes/analytics/indicator/no_teacher.php
@@ -35,6 +35,13 @@ defined('MOODLE_INTERNAL') || die();
  */
 class no_teacher extends \core_analytics\local\indicator\binary {
 
  */
 class no_teacher extends \core_analytics\local\indicator\binary {
 

+    /**
+     * Teacher role ids.
+     *
+     * @var array|null
+     */
+    protected $teacherroleids = null;
+

     /**
      * get_name
      *
     /**
      * get_name
      *


@@ -68,9 +75,11 @@ class no_teacher extends \core_analytics\local\indicator\binary {
 
         $context = $this->retrieve('context', $sampleid);
 
 
         $context = $this->retrieve('context', $sampleid);
 

-        $teacherroles = get_config('analytics', 'teacherroles');
-        $teacherroleids = explode(',', $teacherroles);
-        foreach ($teacherroleids as $role) {
+        if (is_null($this->teacherroleids)) {
+            $this->teacherroleids = array_keys(get_archetype_roles('editingteacher') + get_archetype_roles('teacher'));
+        }
+
+        foreach ($this->teacherroleids as $role) {

             // We look for roles, not enrolments as a teacher assigned at category level is supposed to be a
             // course teacher.
             $teachers = get_role_users($role, $context, false, 'u.id', 'u.id');
             // We look for roles, not enrolments as a teacher assigned at category level is supposed to be a
             // course teacher.
             $teachers = get_role_users($role, $context, false, 'u.id', 'u.id');