MDL-63102 core_block: Reduced spacing between blocks
authorPeter <peter@moodle.com>
Tue, 9 Oct 2018 05:54:11 +0000 (13:54 +0800)
committerPeter <peter@moodle.com>
Fri, 12 Oct 2018 02:13:36 +0000 (10:13 +0800)
Reduce the calculated bottom margin between blocks to half

theme/boost/scss/moodle/blocks.scss
theme/boost/scss/moodle/core.scss
theme/boost/style/moodle.css
theme/boost/templates/columns2.mustache
theme/boost/templates/core/block.mustache

index 4ab424a..c56f8fd 100644 (file)
@@ -63,6 +63,9 @@ $blocks-plus-gutter: $blocks-column-width + ( $grid-gutter-width / 2 );
     width: calc(100% - #{$blocks-plus-gutter});
     @include media-breakpoint-down(lg) {
         width: 100%;
     width: calc(100% - #{$blocks-plus-gutter});
     @include media-breakpoint-down(lg) {
         width: 100%;
+        /* MDL-63102 - Remove extra space at bottom.
+        If modifying make sure block-region is horizontally stacked when in full screen */
+        display: block;
     }
 }
 
     }
 }
 
index 52b02fb..4a45d63 100644 (file)
@@ -2140,4 +2140,4 @@ div.editor_atto_toolbar button .icon {
     .dir-ltr-hide {
         display: none;
     }
     .dir-ltr-hide {
         display: none;
     }
-}
\ No newline at end of file
+}
index b0f897b..569c981 100644 (file)
@@ -11118,7 +11118,10 @@ div.editor_atto_toolbar button .icon {
   @media (max-width: 1199.98px) {
     #region-main-settings-menu.has-blocks,
     #region-main.has-blocks {
   @media (max-width: 1199.98px) {
     #region-main-settings-menu.has-blocks,
     #region-main.has-blocks {
-      width: 100%; } }
+      width: 100%;
+      /* MDL-63102 - Remove extra space at bottom.
+        If modifying make sure block-region is horizontally stacked when in full screen */
+      display: block; } }
 
 @media (max-width: 1199.98px) {
   [data-region="blocks-column"] {
 
 @media (max-width: 1199.98px) {
   [data-region="blocks-column"] {
index 7047055..4ff79b6 100644 (file)
@@ -68,7 +68,7 @@
                     <div> {{{ output.region_main_settings_menu }}} </div>
                 </div>
                 {{/hasregionmainsettingsmenu}}
                     <div> {{{ output.region_main_settings_menu }}} </div>
                 </div>
                 {{/hasregionmainsettingsmenu}}
-                <section id="region-main" {{#hasblocks}}class="has-blocks mb-3"{{/hasblocks}}>
+                <section id="region-main" {{#hasblocks}}class="has-blocks mb-2"{{/hasblocks}}>
 
                     {{#hasregionmainsettingsmenu}}
                         <div class="region_main_settings_menu_proxy"></div>
 
                     {{#hasregionmainsettingsmenu}}
                         <div class="region_main_settings_menu_proxy"></div>
index 8eb1abb..7123185 100644 (file)
@@ -20,7 +20,7 @@
 
 {{! Start Block Container }}
 <section id="{{id}}"
 
 {{! Start Block Container }}
 <section id="{{id}}"
-     class="{{#hidden}}hidden{{/hidden}} block block_{{type}} {{#hascontrols}}block_with_controls{{/hascontrols}} card mb-3"
+     class="{{#hidden}}hidden{{/hidden}} block block_{{type}} {{#hascontrols}}block_with_controls{{/hascontrols}} card mb-2"
      role="{{ariarole}}"
      data-block="{{type}}"
      {{#arialabel}}
      role="{{ariarole}}"
      data-block="{{type}}"
      {{#arialabel}}