MDL-40406 libraries: Deprecate create_contexts()

diff --git a/lib/accesslib.php b/lib/accesslib.php
index 221f1b3..dbb3a29 100644 (file)
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -7230,18 +7230,6 @@ class context_block extends context {
 // before removing devs will be warned with a debugging message first,
 // then we will add error message and only after that we can remove the functions
 // completely.
-/**
- * Precreates all contexts including all parents
- *
- * @deprecated since 2.2
- * @param int $contextlevel empty means all
- * @param bool $buildpaths update paths and depths
- * @return void
- */
-function create_contexts($contextlevel = null, $buildpaths = true) {
-    context_helper::create_instances($contextlevel, $buildpaths);
-}
-
 /**
  * Remove stale context records
  *

diff --git a/lib/deprecatedlib.php b/lib/deprecatedlib.php
index 5555d40..8a687e3 100644 (file)
--- a/lib/deprecatedlib.php
+++ b/lib/deprecatedlib.php
@@ -4986,3 +4986,17 @@ function get_child_contexts(context $context) {
     debugging('get_child_contexts() is deprecated, please use $context->get_child_contexts() instead.', DEBUG_DEVELOPER);
     return $context->get_child_contexts();
 }
+
+/**
+ * Precreates all contexts including all parents.
+ *
+ * @see context_helper::create_instances()
+ * @deprecated since 2.2
+ * @param int $contextlevel empty means all
+ * @param bool $buildpaths update paths and depths
+ * @return void
+ */
+function create_contexts($contextlevel = null, $buildpaths = true) {
+    debugging('create_contexts() is deprecated, please use context_helper::create_instances() instead.', DEBUG_DEVELOPER);
+    context_helper::create_instances($contextlevel, $buildpaths);
+}

diff --git a/lib/tests/accesslib_test.php b/lib/tests/accesslib_test.php
index 261e2a1..9f8c15e 100644 (file)
--- a/lib/tests/accesslib_test.php
+++ b/lib/tests/accesslib_test.php
@@ -2292,7 +2292,6 @@ class accesslib_testcase extends advanced_testcase {
         $this->assertEquals($DB->count_records('context', array('depth'=>0)), 0);
         $this->assertEquals($DB->count_records('context', array('path'=>NULL)), 0);
 
-
         // ======= context_helper::cleanup_instances() ==========================
 
         $lastcourse = $DB->get_field_sql("SELECT MAX(id) FROM {course}");
@@ -2385,6 +2384,7 @@ class accesslib_testcase extends advanced_testcase {
 
         $DB->delete_records('context', array('contextlevel'=>CONTEXT_BLOCK));
         create_contexts();
+        $this->assertDebuggingCalled('create_contexts() is deprecated, please use context_helper::create_instances() instead.', DEBUG_DEVELOPER);
         $this->assertFalse($DB->record_exists('context', array('contextlevel'=>CONTEXT_BLOCK)));
 
         $DB->set_field('context', 'depth', 0, array('contextlevel'=>CONTEXT_BLOCK));

diff --git a/lib/upgrade.txt b/lib/upgrade.txt
index 614a275..c02fcc1 100644 (file)
--- a/lib/upgrade.txt
+++ b/lib/upgrade.txt
@@ -12,6 +12,7 @@ information provided here is intended especially for developers.
 * get_parent_contexts() is deprecated, please use $context->get_parent_context_ids().
 * get_parent_contextid() is deprecated, please use $context->get_parent_context().
 * get_child_contexts() is deprecated, please use $context->get_child_contexts().
+* create_contexts() is deprecated, please use context_helper::create_instances().
 
 === 2.5.1 ===