MDL-40162 badges: Image url breaks when slashargumets is not supported

diff --git a/lib/badgeslib.php b/lib/badgeslib.php
index c8e18af..4901456 100644 (file)
--- a/lib/badgeslib.php
+++ b/lib/badgeslib.php
@@ -1025,7 +1025,8 @@ function print_badge_image(badge $badge, stdClass $context, $size = 'small') {
 
     $imageurl = moodle_url::make_pluginfile_url($context->id, 'badges', 'badgeimage', $badge->id, '/', $fsize, false);
     // Appending a random parameter to image link to forse browser reload the image.
 
     $imageurl = moodle_url::make_pluginfile_url($context->id, 'badges', 'badgeimage', $badge->id, '/', $fsize, false);
     // Appending a random parameter to image link to forse browser reload the image.

-    $attributes = array('src' => $imageurl . '?' . rand(1, 10000), 'alt' => s($badge->name), 'class' => 'activatebadge');
+    $imageurl->param('refresh', rand(1, 10000));
+    $attributes = array('src' => $imageurl, 'alt' => s($badge->name), 'class' => 'activatebadge');

 
     return html_writer::empty_tag('img', $attributes);
 }
 
     return html_writer::empty_tag('img', $attributes);
 }