MDL-60925 theme: Fix SCSS precompilation.
authorDamyon Wiese <damyon@moodle.com>
Wed, 29 Nov 2017 02:41:50 +0000 (10:41 +0800)
committerDamyon Wiese <damyon@moodle.com>
Wed, 29 Nov 2017 09:01:07 +0000 (17:01 +0800)
There is no point pre-compiling the theme SCSS if it is not stored somewhere that is available
to all webserving nodes. Localcache needs to be backed by the MUC cache.

lib/outputlib.php

index 6d101b3..7a8beff 100644 (file)
@@ -201,10 +201,13 @@ function theme_build_css_for_themes($themeconfigs = [], $directions = ['rtl', 'l
 
         // First generate all the new css.
         foreach ($directions as $direction) {
+            // Lock it on. Technically we should build all themes for SVG and no SVG - but ie9 is out of support.
+            $themeconfig->force_svg_use(true);
             $themeconfig->set_rtl_mode(($direction === 'rtl'));
 
             $themecss[$direction] = $themeconfig->get_css_content();
             if ($cache) {
+                $themeconfig->set_css_content_cache($themecss[$direction]);
                 $filename = theme_get_css_filename($themeconfig->name, $themerev, $newrevision, $direction);
                 css_store_css($themeconfig, $filename, $themecss[$direction]);
             }