MDL-56822 messaging: Hide notification icons on site policy screen

If we have the nofications and messaging popovers displaying on the
policy confirmation screen we hit an exception since the webservices
won't work if the policy hasn't been agreed to.

This patch simply stops them from showing if the site policy hasn't
been agreed to.

diff --git a/message/output/popup/lib.php b/message/output/popup/lib.php
index 8875855..6ab437b 100644 (file)
--- a/message/output/popup/lib.php
+++ b/message/output/popup/lib.php
@@ -35,7 +35,8 @@ function message_popup_render_navbar_output(\renderer_base $renderer) {
 
     // Early bail out conditions.
     if (!isloggedin() || isguestuser() || user_not_fully_set_up($USER) ||
-        get_user_preferences('auth_forcepasswordchange')) {
+        get_user_preferences('auth_forcepasswordchange') ||
+        (!$USER->policyagreed && $CFG->sitepolicy)) {
         return '';
     }