MDL-64394 core: Fixed bug when using access log with pre_loginpage_hook

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index fc88a13..7aa02d8 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -2692,6 +2692,7 @@ function require_login($courseorid = null, $autologinguest = true, $cm = null, $
                 $authplugin = get_auth_plugin($authname);
                 $authplugin->pre_loginpage_hook();
                 if (isloggedin()) {
+                    set_access_log_user();
                     break;
                 }
             }

diff --git a/lib/setup.php b/lib/setup.php
index 1fc52f0..52f67c7 100644 (file)
--- a/lib/setup.php
+++ b/lib/setup.php
@@ -922,53 +922,8 @@ if (!empty($CFG->debugvalidators) and !empty($CFG->guestloginbutton)) {
 // LogFormat to get the current logged in username in moodle.
 // Alternatvely for other web servers a header X-MOODLEUSER can be set which
 // can be using in the logfile and stripped out if needed.
-if ($USER && isset($USER->username)) {
-    $logmethod = '';
-    $logvalue = 0;
-    if (!empty($CFG->apacheloguser) && function_exists('apache_note')) {
-        $logmethod = 'apache';
-        $logvalue = $CFG->apacheloguser;
-    }
-    if (!empty($CFG->headerloguser)) {
-        $logmethod = 'header';
-        $logvalue = $CFG->headerloguser;
-    }
-    if (!empty($logmethod)) {
-        $loguserid = $USER->id;
-        $logusername = clean_filename($USER->username);
-        $logname = '';
-        if (isset($USER->firstname)) {
-            // We can assume both will be set
-            // - even if to empty.
-            $logname = clean_filename($USER->firstname . " " . $USER->lastname);
-        }
-        if (\core\session\manager::is_loggedinas()) {
-            $realuser = \core\session\manager::get_realuser();
-            $logusername = clean_filename($realuser->username." as ".$logusername);
-            $logname = clean_filename($realuser->firstname." ".$realuser->lastname ." as ".$logname);
-            $loguserid = clean_filename($realuser->id." as ".$loguserid);
-        }
-        switch ($logvalue) {
-            case 3:
-                $logname = $logusername;
-                break;
-            case 2:
-                $logname = $logname;
-                break;
-            case 1:
-            default:
-                $logname = $loguserid;
-                break;
-        }
-        if ($logmethod == 'apache') {
-            apache_note('MOODLEUSER', $logname);
-        }
+set_access_log_user();
 
-        if ($logmethod == 'header') {
-            header("X-MOODLEUSER: $logname");
-        }
-    }
-}
 
 // Ensure the urlrewriteclass is setup correctly (to avoid crippling site).
 if (isset($CFG->urlrewriteclass)) {

diff --git a/lib/setuplib.php b/lib/setuplib.php
index 76a4fea..ff46be6 100644 (file)
--- a/lib/setuplib.php
+++ b/lib/setuplib.php
@@ -1822,6 +1822,60 @@ function make_localcache_directory($directory, $exceptiononerror = true) {
     return make_writable_directory("$CFG->localcachedir/$directory", $exceptiononerror);
 }
 
+/**
+ * Webserver access user logging
+ */
+function set_access_log_user() {
+    global $USER, $CFG;
+    if ($USER && isset($USER->username)) {
+        $logmethod = '';
+        $logvalue = 0;
+        if (!empty($CFG->apacheloguser) && function_exists('apache_note')) {
+            $logmethod = 'apache';
+            $logvalue = $CFG->apacheloguser;
+        }
+        if (!empty($CFG->headerloguser)) {
+            $logmethod = 'header';
+            $logvalue = $CFG->headerloguser;
+        }
+        if (!empty($logmethod)) {
+            $loguserid = $USER->id;
+            $logusername = clean_filename($USER->username);
+            $logname = '';
+            if (isset($USER->firstname)) {
+                // We can assume both will be set
+                // - even if to empty.
+                $logname = clean_filename($USER->firstname . " " . $USER->lastname);
+            }
+            if (\core\session\manager::is_loggedinas()) {
+                $realuser = \core\session\manager::get_realuser();
+                $logusername = clean_filename($realuser->username." as ".$logusername);
+                $logname = clean_filename($realuser->firstname." ".$realuser->lastname ." as ".$logname);
+                $loguserid = clean_filename($realuser->id." as ".$loguserid);
+            }
+            switch ($logvalue) {
+                case 3:
+                    $logname = $logusername;
+                    break;
+                case 2:
+                    $logname = $logname;
+                    break;
+                case 1:
+                default:
+                    $logname = $loguserid;
+                    break;
+            }
+            if ($logmethod == 'apache') {
+                apache_note('MOODLEUSER', $logname);
+            }
+
+            if ($logmethod == 'header') {
+                header("X-MOODLEUSER: $logname");
+            }
+        }
+    }
+}
+
 /**
  * This class solves the problem of how to initialise $OUTPUT.
  *