MDL-51302 scorm: do not use invalid course urls
authorDan Poltawski <dan@moodle.com>
Fri, 9 Oct 2015 07:58:33 +0000 (08:58 +0100)
committerDan Poltawski <dan@moodle.com>
Fri, 9 Oct 2015 08:04:35 +0000 (09:04 +0100)
Previous behaviour of setting an empty sectionid was incorrect and we
were doing work which course_get_url() does for us.

mod/scorm/view.php

index fd98432..61ca320 100644 (file)
@@ -91,14 +91,10 @@ if (!empty($scorm->popup)) {
     // Redirect back to the section with one section per page ?
 
     $courseformat = course_get_format($course)->get_course();
-    $sectionid = '';
-    if (isset($courseformat->coursedisplay) && $courseformat->coursedisplay == COURSE_DISPLAY_MULTIPAGE) {
-        $sectionid = $cm->sectionnum;
-    }
     if ($courseformat->format == 'singleactivity') {
         $courseurl = $url->out(false, array('preventskip' => '1'));
     } else {
-        $courseurl = course_get_url($course, $sectionid)->out(false);
+        $courseurl = course_get_url($course, $cm->sectionnum)->out(false);
     }
     $PAGE->requires->data_for_js('scormplayerdata', Array('launch' => $launch,
                                                            'currentorg' => $orgidentifier,