MDL-35257 lib: if $CFG->logguests is disabled, avoid some log actions

This is for performance, else there can be great contention on the guest
user record as we've seen on moodle.org.

diff --git a/lib/datalib.php b/lib/datalib.php
index 99f6b91..dde0f20 100644 (file)
--- a/lib/datalib.php
+++ b/lib/datalib.php
@@ -1764,6 +1764,11 @@ function user_accesstime_log($courseid=0) {
         return;
     }
 
+    if (isguestuser()) {
+        // Do not update guest access times/ips for performance.
+        return;
+    }
+
     if (empty($courseid)) {
         $courseid = SITEID;
     }

diff --git a/lib/moodlelib.php b/lib/moodlelib.php
index 1c8f966..1d10587 100644 (file)
--- a/lib/moodlelib.php
+++ b/lib/moodlelib.php
@@ -3289,6 +3289,11 @@ function get_user_key($script, $userid, $instance=null, $iprestriction=null, $va
 function update_user_login_times() {
     global $USER, $DB;
 
+    if (isguestuser()) {
+        // Do not update guest access times/ips for performance.
+        return true;
+    }
+
     $now = time();
 
     $user = new stdClass();