MDL-44972 Atto dialogues: Change M.core.dialogue attribute name to "focusOnShowSelector"
authorDamyon Wiese <damyon@moodle.com>
Mon, 5 May 2014 08:27:36 +0000 (16:27 +0800)
committerDamyon Wiese <damyon@moodle.com>
Mon, 5 May 2014 08:27:36 +0000 (16:27 +0800)
And some minor cleanups.

24 files changed:
lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-debug.js
lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-min.js
lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button.js
lib/editor/atto/plugins/equation/yui/src/button/js/button.js
lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-debug.js
lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-min.js
lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button.js
lib/editor/atto/plugins/image/yui/src/button/js/button.js
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-debug.js
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-min.js
lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button.js
lib/editor/atto/plugins/link/yui/src/button/js/button.js
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-debug.js
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-min.js
lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button.js
lib/editor/atto/plugins/media/yui/src/button/js/button.js
lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-debug.js
lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-min.js
lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button.js
lib/editor/atto/plugins/table/yui/src/button/js/button.js
lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-debug.js
lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue.js
lib/yui/src/notification/js/dialogue.js

index c02b48a..1f4b0d8 100644 (file)
Binary files a/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-debug.js and b/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-debug.js differ
index c3943e6..42f6886 100644 (file)
Binary files a/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-min.js and b/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button-min.js differ
index aacec8b..e5a5e72 100644 (file)
Binary files a/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button.js and b/lib/editor/atto/plugins/equation/yui/build/moodle-atto_equation-button/moodle-atto_equation-button.js differ
index 0c4bfad..59c07c9 100644 (file)
@@ -208,7 +208,7 @@ Y.namespace('M.atto_equation').Button = Y.Base.create('button', Y.M.editor_atto.
             headerContent: M.util.get_string('pluginname', COMPONENTNAME),
             focusAfterHide: true,
             width: 600,
-            focusSelector: SELECTORS.EQUATION_TEXT
+            focusOnShowSelector: SELECTORS.EQUATION_TEXT
         });
 
         var content = this._getDialogueContent();
index 39c4fbc..b92532c 100644 (file)
Binary files a/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-debug.js and b/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-debug.js differ
index 44886ce..df9ace1 100644 (file)
Binary files a/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-min.js and b/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button-min.js differ
index 39c4fbc..b92532c 100644 (file)
Binary files a/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button.js and b/lib/editor/atto/plugins/image/yui/build/moodle-atto_image-button/moodle-atto_image-button.js differ
index 5c5186f..c34a748 100644 (file)
@@ -255,7 +255,7 @@ Y.namespace('M.atto_image').Button = Y.Base.create('button', Y.M.editor_atto.Edi
             headerContent: M.util.get_string('imageproperties', COMPONENTNAME),
             width: '480px',
             focusAfterHide: true,
-            focusSelector: SELECTORS.INPUTURL
+            focusOnShowSelector: SELECTORS.INPUTURL
         });
 
         // Set the dialogue content, and then show the dialogue.
index 91cb360..49f60b1 100644 (file)
Binary files a/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-debug.js and b/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-debug.js differ
index 9c4c7df..390e14c 100644 (file)
Binary files a/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-min.js and b/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button-min.js differ
index 91cb360..49f60b1 100644 (file)
Binary files a/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button.js and b/lib/editor/atto/plugins/link/yui/build/moodle-atto_link-button/moodle-atto_link-button.js differ
index 61b6f99..88f929f 100644 (file)
@@ -114,7 +114,7 @@ Y.namespace('M.atto_link').Button = Y.Base.create('button', Y.M.editor_atto.Edit
         var dialogue = this.getDialogue({
             headerContent: M.util.get_string('createlink', COMPONENTNAME),
             focusAfterHide: true,
-            focusSelector: SELECTORS.URLINPUT
+            focusOnShowSelector: SELECTORS.URLINPUT
         });
 
         // Set the dialogue content, and then show the dialogue.
index caeed22..e04cfb0 100644 (file)
Binary files a/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-debug.js and b/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-debug.js differ
index f73b35c..f619e29 100644 (file)
Binary files a/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-min.js and b/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button-min.js differ
index caeed22..e04cfb0 100644 (file)
Binary files a/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button.js and b/lib/editor/atto/plugins/media/yui/build/moodle-atto_media-button/moodle-atto_media-button.js differ
index 628cbb8..0ea937d 100644 (file)
 
 var COMPONENTNAME = 'atto_media',
     CSS = {
-        URLINPUT: 'urlentry'
+        URLINPUT: 'atto_media_urlentry',
+        NAMEINPUT: 'atto_media_nameentry'
     },
     SELECTORS = {
-        URLINPUT: '.' + CSS.URLINPUT
+        URLINPUT: '.' + CSS.URLINPUT,
+        NAMEINPUT: '.' + CSS.NAMEINPUT
     },
     TEMPLATE = '' +
         '<form class="atto_form">' +
@@ -44,7 +46,7 @@ var COMPONENTNAME = 'atto_media',
             '<input class="fullwidth {{CSS.URLINPUT}}" type="url" id="{{elementid}}_atto_media_urlentry" size="32"/><br/>' +
             '<button class="openmediabrowser" type="button">{{get_string "browserepositories" component}}</button>' +
             '<label for="{{elementid}}_atto_media_nameentry">{{get_string "entername" component}}</label>' +
-            '<input class="fullwidth nameentry" type="text" id="{{elementid}}_atto_media_nameentry" size="32" required="true"/>' +
+            '<input class="fullwidth {{CSS.NAMEINPUT}}" type="text" id="{{elementid}}_atto_media_nameentry" size="32" required="true"/>' +
             '<div class="mdl-align">' +
                 '<br/>' +
                 '<button class="submit" type="submit">{{get_string "createmedia" component}}</button>' +
@@ -97,7 +99,7 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
         var dialogue = this.getDialogue({
             headerContent: M.util.get_string('createmedia', COMPONENTNAME),
             focusAfterHide: true,
-            focusSelector: SELECTORS.URLINPUT
+            focusOnShowSelector: SELECTORS.URLINPUT
         });
 
         // Set the dialogue content, and then show the dialogue.
@@ -141,9 +143,9 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
      */
     _filepickerCallback: function(params) {
         if (params.url !== '') {
-            this._content.one('.urlentry')
+            this._content.one(SELECTORS.URLINPUT)
                     .set('value', params.url);
-            this._content.one('.nameentry')
+            this._content.one(SELECTORS.NAMEINPUT)
                     .set('value', params.file);
         }
     },
@@ -162,8 +164,8 @@ Y.namespace('M.atto_media').Button = Y.Base.create('button', Y.M.editor_atto.Edi
         }).hide();
 
         var form = e.currentTarget.ancestor('.atto_form'),
-            url = form.one('.urlentry').get('value'),
-            name = form.one('.nameentry').get('value'),
+            url = form.one(SELECTORS.URLINPUT).get('value'),
+            name = form.one(SELECTORS.NAMEINPUT).get('value'),
             host = this.get('host');
 
         if (url !== '' && name !== '') {
index 0dd0bbe..221375f 100644 (file)
Binary files a/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-debug.js and b/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-debug.js differ
index 0c9ea2a..d175700 100644 (file)
Binary files a/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-min.js and b/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button-min.js differ
index 0dd0bbe..221375f 100644 (file)
Binary files a/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button.js and b/lib/editor/atto/plugins/table/yui/build/moodle-atto_table-button/moodle-atto_table-button.js differ
index f3386cc..a34ef41 100644 (file)
@@ -158,7 +158,7 @@ Y.namespace('M.atto_table').Button = Y.Base.create('button', Y.M.editor_atto.Edi
             var dialogue = this.getDialogue({
                 headerContent: M.util.get_string('createtable', COMPONENT),
                 focusAfterHide: true,
-                focusSelector: SELECTORS.CAPTION
+                focusOnShowSelector: SELECTORS.CAPTION
             });
 
             // Set the dialogue content, and then show the dialogue.
@@ -879,7 +879,7 @@ Y.namespace('M.atto_table').Button = Y.Base.create('button', Y.M.editor_atto.Edi
         var dialogue = this.getDialogue({
             headerContent: M.util.get_string('edittable', COMPONENT),
             focusAfterHide: false,
-            focusSelector: SELECTORS.CAPTION
+            focusOnShowSelector: SELECTORS.CAPTION
         });
 
         // Set the dialogue content, and then show the dialogue.
index e73cc8a..bb7a4a7 100644 (file)
Binary files a/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-debug.js and b/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-debug.js differ
index 2c66435..1995629 100644 (file)
Binary files a/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js and b/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js differ
index 11749f8..f12ff3b 100644 (file)
Binary files a/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue.js and b/lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue.js differ
index 957cffe..3ec989f 100644 (file)
@@ -284,7 +284,7 @@ Y.extend(DIALOGUE, Y.Panel, {
         var result = null,
             header = this.headerNode,
             content = this.bodyNode,
-            focusSelector = this.get('focusSelector'),
+            focusSelector = this.get('focusOnShowSelector'),
             focusNode = null;
 
         result = DIALOGUE.superclass.show.call(this);
@@ -296,8 +296,8 @@ Y.extend(DIALOGUE, Y.Panel, {
             this.lockScroll.enableScrollLock(this.shouldResizeFullscreen());
         }
 
-        // Try and find a node to focus on using the focusSelector attribute.
-        if (focusSelector !== '') {
+        // Try and find a node to focus on using the focusOnShowSelector attribute.
+        if (focusSelector !== null) {
             focusNode = this.get('boundingBox').one(focusSelector);
         }
         if (!focusNode) {
@@ -308,7 +308,9 @@ Y.extend(DIALOGUE, Y.Panel, {
                 focusNode = content;
             }
         }
-        focusNode.focus();
+        if (focusNode) {
+            focusNode.focus();
+        }
         return result;
     },
 
@@ -475,7 +477,21 @@ Y.extend(DIALOGUE, Y.Panel, {
          */
         responsiveWidth : {
             value : 768
+        },
+
+        /**
+         * Selector to a node that should recieve focus when this dialogue is shown.
+         *
+         * The default behaviour is to focus on the header.
+         *
+         * @attribute focusOnShowSelector
+         * @default null
+         * @type String
+         */
+        focusOnShowSelector: {
+            value: null
         }
+
     }
 });
 
@@ -515,19 +531,6 @@ Y.Base.modifyAttrs(DIALOGUE, {
         value: false
     },
 
-    /**
-     * Selector to a node that should recieve focus when this dialogue is shown.
-     *
-     * The default behaviour is to focus on the header.
-     *
-     * @attribute focusSelector
-     * @default ''
-     * @type String
-     */
-    focusSelector: {
-        value: ''
-    },
-
     /**
      * A convenience Attribute, which can be used as a shortcut for the
      * `align` Attribute.