// let the plugin add the fields they want (either statically or not)
if (portfolio_static_function($this->plugin, 'has_admin_config')) {
- if (!$this->instance) {
- require_once($CFG->libdir . '/portfolio/plugin.php');
- require_once($CFG->dirroot . '/portfolio/' . $this->plugin . '/lib.php');
- call_user_func(array('portfolio_plugin_' . $this->plugin, 'admin_config_form'), $mform);
- } else {
- $this->instance->admin_config_form($mform);
- }
+ require_once($CFG->libdir . '/portfolio/plugin.php');
+ require_once($CFG->dirroot . '/portfolio/' . $this->plugin . '/lib.php');
+ call_user_func(array('portfolio_plugin_' . $this->plugin, 'admin_config_form'), $mform);
}
// and set the data if we have some.
}
$pluginerrors = array();
- if ($this->instance) {
- $pluginerrors = $this->instance->admin_config_validation($data);
- }
- else {
- $pluginerrors = portfolio_static_function($this->plugin, 'admin_config_validation', $data);
- }
+ $pluginerrors = portfolio_static_function($this->plugin, 'admin_config_validation', $data);
if (is_array($pluginerrors)) {
$errors = array_merge($errors, $pluginerrors);
}
*
* @param moodleform $mform passed by reference, add elements to it.
*/
- public function admin_config_form(&$mform) {}
+ public static function admin_config_form(&$mform) {}
/**
* Just like the moodle form validation function,
*
* @param array $data data from form.
*/
- public function admin_config_validation($data) {}
+ public static function admin_config_validation($data) {}
/**
* mform to display to the user exporting data using this plugin.
}
}
- public function admin_config_form(&$mform) {
+ public static function admin_config_form(&$mform) {
global $CFG;
$mform->addElement('text', 'apikey', get_string('apikey', 'portfolio_boxnet'));
return true;
}
- public function admin_config_form(&$mform) {
+ public static function admin_config_form(&$mform) {
global $CFG;
$strrequired = get_string('required');
return array('clientid', 'secret');
}
- public function admin_config_form(&$mform) {
+ public static function admin_config_form(&$mform) {
$a = new stdClass;
$a->docsurl = get_docs_url('Google_OAuth2_Setup');
$a->callbackurl = google_oauth::callback_url()->out(false);
return true;
}
- public function admin_config_form(&$mform) {
+ public static function admin_config_form(&$mform) {
$strrequired = get_string('required');
$hosts = self::get_mnet_hosts(); // this is called by sanity check but it's ok because it's cached
foreach ($hosts as $host) {
return array('clientid', 'secret');
}
- public function admin_config_form(&$mform) {
+ public static function admin_config_form(&$mform) {
$a = new stdClass;
$a->docsurl = get_docs_url('Google_OAuth2_Setup');
$a->callbackurl = google_oauth::callback_url()->out(false);
--- /dev/null
+This files describes API changes in /portfolio/ portfolio system,
+information provided here is intended especially for developers.
+
+=== 2.3 ===
+
+required changes:
+* The following methods must now be declared static for php5 compatibility:
+ - admin_config_form
+ - admin_config_validation