MDL-43595: The dropdowns for editpdf stopped working due to a recent change.
authorDamyon Wiese <damyon@moodle.com>
Wed, 8 Jan 2014 01:15:58 +0000 (09:15 +0800)
committerDamyon Wiese <damyon@moodle.com>
Wed, 8 Jan 2014 01:15:58 +0000 (09:15 +0800)
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-debug.js
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-min.js
mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor.js
mod/assign/feedback/editpdf/yui/src/editor/js/dropdown.js

index b1929ee..e00100a 100644 (file)
Binary files a/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-debug.js and b/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-debug.js differ
index 9bbcef0..066f2e0 100644 (file)
Binary files a/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-min.js and b/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor-min.js differ
index b1929ee..e00100a 100644 (file)
Binary files a/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor.js and b/mod/assign/feedback/editpdf/yui/build/moodle-assignfeedback_editpdf-editor/moodle-assignfeedback_editpdf-editor.js differ
index ecc6fe9..dc941cc 100644 (file)
@@ -46,7 +46,8 @@ Y.extend(DROPDOWN, M.core.dialogue, {
 
         body.on('clickoutside', function(e) {
             if (this.get('visible')) {
-                if (e.target !== button && e.target.ancestor() !== button) {
+                // Note: we need to compare ids because for some reason - sometimes button is an Object, not a Y.Node.
+                if (e.target.get('id') !== button.get('id') && e.target.ancestor().get('id') !== button.get('id')) {
                     e.preventDefault();
                     this.hide();
                 }