//get the value
$frmvaluename = $feedbackitem->typ . '_'. $feedbackitem->id;
if (isset($savereturn)) {
- if (isset($formdata->{$frmvaluename})) {
- $value = $formdata->{$frmvaluename};
- } else {
- $value = null;
- }
+ $value = isset($formdata->{$frmvaluename}) ? $formdata->{$frmvaluename} : null;
+ $value = feedback_clean_input_value($feedbackitem, $value);
} else {
if (isset($feedbackcompletedtmp->id)) {
$value = feedback_get_item_value($feedbackcompletedtmp->id,
feedback_print_item_complete($feedbackitem, $value, $highlightrequired);
echo $OUTPUT->box_end();
}
+
echo $OUTPUT->box_end();
$lastbreakposition = $feedbackitem->position; //last item-pos (item or pagebreak)
!isset($formdata->gonextpage) AND
!isset($formdata->gopreviouspage)) {
- $gopage = $formdata->lastpage;
+ $gopage = (int) $formdata->lastpage;
}
if (isset($formdata->savevalues)) {
$savevalues = true;
echo $OUTPUT->box_start('feedback_item_box_'.$align.$dependstyle);
$value = '';
//get the value
- $frmvaluename = $feedbackitem->typ.'_'.$feedbackitem->id;
+ $frmvaluename = $feedbackitem->typ . '_'. $feedbackitem->id;
if (isset($savereturn)) {
- if (isset($formdata->{$frmvaluename})) {
- $value = $formdata->{$frmvaluename};
- } else {
- $value = null;
- }
+ $value = isset($formdata->{$frmvaluename}) ? $formdata->{$frmvaluename} : null;
+ $value = feedback_clean_input_value($feedbackitem, $value);
} else {
if (isset($feedbackcompletedtmp->id)) {
$value = feedback_get_item_value($feedbackcompletedtmp->id,
feedback_print_item_complete($feedbackitem, $value, $highlightrequired);
echo $OUTPUT->box_end();
}
+
echo $OUTPUT->box_end();
$lastbreakposition = $feedbackitem->position; //last item-pos (item or pagebreak)
public function can_switch_require() {
return false;
}
+
+ public function value_type() {
+ return PARAM_RAW;
+ }
+
+ public function clean_input_value($value) {
+ return clean_param($value, $this->value_type());
+ }
}
*/
abstract public function print_item_show_value($item, $value = '');
+ /**
+ * cleans the userinput while submitting the form
+ *
+ * @param mixed $value
+ * @return mixed
+ */
+ abstract public function clean_input_value($value);
+
}
//a dummy class to realize pagebreaks
}
public function can_switch_require() {
}
+ public function value_type() {
+ }
+ public function clean_input_value($value) {
+ }
}
-
-
public function can_switch_require() {
return false;
}
+
+ public function value_type() {
+ return PARAM_INT;
+ }
+
+ public function clean_input_value($value) {
+ return clean_param($value, $this->value_type());
+ }
}
}
public function get_analysed($item, $groupid = false, $courseid = false) {
}
+ public function value_type() {
+ return PARAM_BOOL;
+ }
+ public function clean_input_value($value) {
+ return '';
+ }
}
public function value_is_array() {
return true;
}
+
+ public function clean_input_value($value) {
+ return clean_param_array($value, $this->value_type());
+ }
}
return true;
}
+ public function value_type() {
+ return PARAM_INT;
+ }
+
+ public function clean_input_value($value) {
+ return clean_param($value, $this->value_type());
+ }
}
'name="'.$item->typ.'_'.$item->id.'" '.
'size="10" '.
'maxlength="10" '.
- 'value="'.($value ? $value : '').'" />';
+ 'value="'.$value.'" />';
echo '</span>';
echo '</div>';
public function can_switch_require() {
return true;
}
+
+ public function value_type() {
+ return PARAM_FLOAT;
+ }
+
+ public function clean_input_value($value) {
+ if (!is_numeric($value)) {
+ return null;
+ }
+ return clean_param($value, $this->value_type());
+ }
}
echo '<textarea name="'.$item->typ.'_'.$item->id.'" '.
'cols="'.$presentation[0].'" '.
'rows="'.$presentation[1].'">';
- echo ($value ? htmlspecialchars($value) : '');
+ echo $value;
echo '</textarea>';
echo '</span>';
echo '</div>';
}
public function create_value($data) {
- $data = clean_text($data);
+ $data = s($data);
return $data;
}
public function can_switch_require() {
return true;
}
+
+ public function value_type() {
+ return PARAM_RAW;
+ }
+
+ public function clean_input_value($value) {
+ return s($value);
+ }
}
'name="'.$item->typ.'_'.$item->id.'" '.
'size="'.$presentation[0].'" '.
'maxlength="'.$presentation[1].'" '.
- 'value="'.($value ? htmlspecialchars($value) : '').'" />';
+ 'value="'.$value.'" />';
echo '</span>';
echo '</div>';
}
}
public function create_value($data) {
- $data = clean_text($data);
+ $data = s($data);
return $data;
}
public function can_switch_require() {
return true;
}
+
+ public function value_type() {
+ return PARAM_RAW;
+ }
+
+ public function clean_input_value($value) {
+ return s($value);
+ }
}
//functions to handle the values
////////////////////////////////////////////////
+/**
+ * cleans the userinput while submitting the form.
+ *
+ * @param mixed $value
+ * @return mixed
+ */
+function feedback_clean_input_value($item, $value) {
+ $itemobj = feedback_get_item_class($item->typ);
+ return $itemobj->clean_input_value($value);
+}
+
/**
* this saves the values of an completed.
* if the param $tmp is set true so the values are saved temporary in table feedback_valuetmp.