MDL-29471 php warning when adding function to a new web service

diff --git a/admin/webservice/forms.php b/admin/webservice/forms.php
index dab9a42..5185b9b 100644 (file)
--- a/admin/webservice/forms.php
+++ b/admin/webservice/forms.php
@@ -160,7 +160,7 @@ class external_service_functions_form extends moodleform {
             $functions[$functionid] = $function->name . ':' . $function->description;
         }
 
-        $mform->addElement('searchableselector', 'fid', get_string('name'),
+        $mform->addElement('searchableselector', 'fids', get_string('name'),
                 $functions, array('multiple'));
 
         $mform->addElement('hidden', 'id');

diff --git a/admin/webservice/service_functions.php b/admin/webservice/service_functions.php
index d4f7da8..fc0e886 100644 (file)
--- a/admin/webservice/service_functions.php
+++ b/admin/webservice/service_functions.php
@@ -67,7 +67,7 @@ switch ($action) {
             //add the function to the service then redirect to function list page
             if ($data = $mform->get_data()) {
                 ignore_user_abort(true); // no interruption here!
-                foreach ($data->fid as $fid) {
+                foreach ($data->fids as $fid) {
                     $function = $webservicemanager->get_external_function_by_id(
                             $fid, MUST_EXIST);
                     // make sure the function is not there yet