MDL-36804 Assign attempt history: Fix course unit tests

Handle missing attemptreopenmethod in add/update instance.

diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php
index 4dee4b8..9f8bc37 100644 (file)
--- a/mod/assign/locallib.php
+++ b/mod/assign/locallib.php
@@ -530,7 +530,10 @@ class assign {
         $update->requireallteammemberssubmit = $formdata->requireallteammemberssubmit;
         $update->teamsubmissiongroupingid = $formdata->teamsubmissiongroupingid;
         $update->blindmarking = $formdata->blindmarking;
-        $update->attemptreopenmethod = $formdata->attemptreopenmethod;
+        $update->attemptreopenmethod = ASSIGN_ATTEMPT_REOPEN_METHOD_NONE;
+        if (!empty($formdata->attemptreopenmethod)) {
+            $update->attemptreopenmethod = $formdata->attemptreopenmethod;
+        }
         if (!empty($formdata->maxattempts)) {
             $update->maxattempts = $formdata->maxattempts;
         }
@@ -848,7 +851,10 @@ class assign {
         $update->requireallteammemberssubmit = $formdata->requireallteammemberssubmit;
         $update->teamsubmissiongroupingid = $formdata->teamsubmissiongroupingid;
         $update->blindmarking = $formdata->blindmarking;
-        $update->attemptreopenmethod = $formdata->attemptreopenmethod;
+        $update->attemptreopenmethod = ASSIGN_ATTEMPT_REOPEN_METHOD_NONE;
+        if (!empty($formdata->attemptreopenmethod)) {
+            $update->attemptreopenmethod = $formdata->attemptreopenmethod;
+        }
         if (!empty($formdata->maxattempts)) {
             $update->maxattempts = $formdata->maxattempts;
         }