MDL-55022 mod_lti: Fix undefined variable
authorJun Pataleta <jun@moodle.com>
Mon, 27 Jun 2016 03:32:11 +0000 (11:32 +0800)
committerJun Pataleta <jun@moodle.com>
Mon, 27 Jun 2016 03:40:03 +0000 (11:40 +0800)
mod/lti/classes/external.php
mod/lti/tests/externallib_test.php

index fca7c77..e6d5181 100644 (file)
@@ -523,7 +523,7 @@ class mod_lti_external extends external_api {
         }
 
         if (!empty($capabilityoffered)) {
-            $config->lti_capabilities = $capabilitiesoffered;
+            $config->lti_capabilities = $capabilityoffered;
         }
 
         if (!empty($serviceoffered)) {
index b3ba4ea..a7f0323 100644 (file)
@@ -285,10 +285,12 @@ class mod_lti_external_testcase extends externallib_advanced_testcase {
      * Test create tool proxy
      */
     public function test_mod_lti_create_tool_proxy() {
-        $proxy = mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), array(), array());
+        $capabilities = ['AA', 'BB'];
+        $proxy = mod_lti_external::create_tool_proxy('Test proxy', $this->getExternalTestFileUrl('/test.html'), $capabilities, []);
         $this->assertEquals('Test proxy', $proxy->name);
         $this->assertEquals($this->getExternalTestFileUrl('/test.html'), $proxy->regurl);
         $this->assertEquals(LTI_TOOL_PROXY_STATE_PENDING, $proxy->state);
+        $this->assertEquals(implode("\n", $capabilities), $proxy->capabilityoffered);
     }
 
     /*