Portfolio plugins explicitly requires parent library with superclass definition

I have discovered a bug with GoogleDocs portfolio in events. An event
handler was defined in googledocs/lib.php and so the cron included just
this library. But the inclusion failed because the superclass
portfolio_plugin_push_base was not known to cron.

IMHO it is generally good habit to require_once the file which defines
the parent classes.

diff --git a/portfolio/boxnet/lib.php b/portfolio/boxnet/lib.php
index d5dac38..784262a 100644 (file)
--- a/portfolio/boxnet/lib.php
+++ b/portfolio/boxnet/lib.php
@@ -1,4 +1,5 @@
 <?php
+require_once($CFG->libdir.'/portfolio/plugin.php');
 require_once($CFG->libdir.'/filelib.php');
 require_once($CFG->libdir.'/boxlib.php');
 

diff --git a/portfolio/flickr/lib.php b/portfolio/flickr/lib.php
index 7c12b95..977d81a 100755 (executable)
--- a/portfolio/flickr/lib.php
+++ b/portfolio/flickr/lib.php
@@ -1,4 +1,5 @@
 <?php
+require_once($CFG->libdir.'/portfolio/plugin.php');
 require_once($CFG->libdir.'/filelib.php');
 require_once($CFG->libdir.'/flickrlib.php');
 

diff --git a/portfolio/googledocs/lib.php b/portfolio/googledocs/lib.php
index 7590530..2223f9d 100644 (file)
--- a/portfolio/googledocs/lib.php
+++ b/portfolio/googledocs/lib.php
@@ -5,6 +5,7 @@
  * @author Dan Poltawski <talktodan@gmail.com>
  * @license http://www.gnu.org/copyleft/gpl.html GNU Public License
  */
+require_once($CFG->libdir.'/portfolio/plugin.php');
 require_once($CFG->libdir.'/googleapi.php');
 
 class portfolio_plugin_googledocs extends portfolio_plugin_push_base {

diff --git a/portfolio/picasa/lib.php b/portfolio/picasa/lib.php
index 5b8551e..a9ba23f 100644 (file)
--- a/portfolio/picasa/lib.php
+++ b/portfolio/picasa/lib.php
@@ -5,7 +5,7 @@
  * @author Dan Poltawski <talktodan@gmail.com>
  * @license http://www.gnu.org/copyleft/gpl.html GNU Public License
  */
-
+require_once($CFG->libdir.'/portfolio/plugin.php');
 require_once($CFG->libdir.'/googleapi.php');
 
 class portfolio_plugin_picasa extends portfolio_plugin_push_base {