Sara Arjona [Thu, 26 Jan 2023 08:59:06 +0000 (09:59 +0100)]
weekly release 4.2dev
Jun Pataleta [Wed, 25 Jan 2023 08:10:28 +0000 (16:10 +0800)]
Merge branch 'MDL-76977' of https://github.com/paulholden/moodle
Jun Pataleta [Wed, 25 Jan 2023 08:02:37 +0000 (16:02 +0800)]
Merge branch 'MDL-77036-master' of https://github.com/lameze/moodle
Jun Pataleta [Wed, 25 Jan 2023 07:33:52 +0000 (15:33 +0800)]
Merge branch 'MDL-77027-master' of https://github.com/andrewnicols/moodle
Sara Arjona [Wed, 25 Jan 2023 07:22:23 +0000 (08:22 +0100)]
Merge branch 'MDL-76968-master' of https://github.com/junpataleta/moodle
Simey Lameze [Wed, 25 Jan 2023 07:11:52 +0000 (15:11 +0800)]
MDL-77036 core_iplookup: update test_ipv4 test expectations
Andrew Nicols [Wed, 25 Jan 2023 03:13:58 +0000 (11:13 +0800)]
MDL-77027 webservice: Add missing class requires
Jun Pataleta [Wed, 25 Jan 2023 00:57:24 +0000 (08:57 +0800)]
Merge branch 'MDL-76967-master' of https://github.com/lucaboesch/moodle
Jun Pataleta [Tue, 24 Jan 2023 15:19:43 +0000 (23:19 +0800)]
Merge branch 'MDL-76899' of https://github.com/timhunt/moodle
Sara Arjona [Tue, 24 Jan 2023 15:07:35 +0000 (16:07 +0100)]
Merge branch 'MDL-75337-master' of https://github.com/laurentdavid/moodle
Jun Pataleta [Tue, 24 Jan 2023 13:03:28 +0000 (21:03 +0800)]
Merge branch 'MDL-76430-master' of https://github.com/ferranrecio/moodle
Ferran Recio [Wed, 14 Dec 2022 09:56:44 +0000 (10:56 +0100)]
MDL-76430 core_courseformat: implement fragment to course format
Jun Pataleta [Tue, 24 Jan 2023 10:59:38 +0000 (18:59 +0800)]
Merge branch 'MDL-76639-master' of https://github.com/andelacruz/moodle
Jun Pataleta [Tue, 24 Jan 2023 10:45:46 +0000 (18:45 +0800)]
Merge branch 'MDL-76652-master' of https://github.com/lameze/moodle
Jun Pataleta [Tue, 24 Jan 2023 10:27:10 +0000 (18:27 +0800)]
Merge branch 'MDL-76655-master' of https://github.com/andelacruz/moodle
Jun Pataleta [Tue, 24 Jan 2023 06:02:56 +0000 (14:02 +0800)]
Merge branch 'MDL-76973' of https://github.com/paulholden/moodle
Laurent David [Mon, 3 Oct 2022 06:06:08 +0000 (08:06 +0200)]
MDL-75337 mod_data: Single button - mod_data changes
* Update mod_data module to use the new button style
Laurent David [Wed, 14 Dec 2022 09:46:40 +0000 (10:46 +0100)]
MDL-75337 core: Single button - core changes
* Change all core calls toward single_button to use single_button::BUTTON_PRIMARY
when needed
Andrew Nicols [Tue, 24 Jan 2023 03:45:27 +0000 (11:45 +0800)]
Merge branch 'MDL-69164-master' of https://github.com/JBThong/moodle
Jun Pataleta [Tue, 24 Jan 2023 02:38:55 +0000 (10:38 +0800)]
Merge branch 'MDL-76362-master-extra' of https://github.com/andrewnicols/moodle
Jun Pataleta [Tue, 24 Jan 2023 01:03:09 +0000 (09:03 +0800)]
Merge branch 'MDL-76987-master' of https://github.com/andrewnicols/moodle
Angelia Dela Cruz [Mon, 16 Jan 2023 09:42:47 +0000 (17:42 +0800)]
MDL-76655 behat: Coverage for workshop grading strategies
Laurent David [Wed, 14 Dec 2022 09:31:22 +0000 (10:31 +0100)]
MDL-75337 core: Single button - API changes
* Update component library for new features of single_button and modal
* Update core_notification javascript
Andrew Nicols [Mon, 23 Jan 2023 12:37:05 +0000 (20:37 +0800)]
MDL-76987 webservice: Correct namespace for external_api
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 17:18:21 +0000 (18:18 +0100)]
MDL-76362 workshop: check for empty (null included) feedbackreviewer
As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 15:01:33 +0000 (16:01 +0100)]
MDL-76362 enrol_lti: Prevent calling to DataConnector with null keys
While it could have been fixed in DataConnector (3rd part lib), better
prevent in our code to call to it with null keys.
Covered by unit tests.
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 12:24:00 +0000 (13:24 +0100)]
MDL-76362 output: Preserve original behaviour for PHP 8.1
Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.
It's covered by an explicit test:
test_js_fix_url_coding_exception with data set "Provide a null argument"
Andrew Nicols [Mon, 9 Jan 2023 03:43:30 +0000 (11:43 +0800)]
MDL-76362 core: Coding style fixes
Andrew Nicols [Fri, 6 Jan 2023 14:37:59 +0000 (22:37 +0800)]
MDL-76362 core_privacy: Shortcircuit URL rewriting on empty content
Andrew Nicols [Fri, 6 Jan 2023 14:37:07 +0000 (22:37 +0800)]
MDL-76362 core: Short circuit s() on empty values
Andrew Nicols [Fri, 6 Jan 2023 14:36:54 +0000 (22:36 +0800)]
MDL-76362 core: Short-circuit strip_querystring on empty values
Andrew Nicols [Fri, 6 Jan 2023 14:31:42 +0000 (22:31 +0800)]
MDL-76362 core_file: Check prefix exists before checking length
Andrew Nicols [Fri, 6 Jan 2023 14:30:16 +0000 (22:30 +0800)]
MDL-76362 core: plugin names must be strings to be valid
Andrew Nicols [Fri, 6 Jan 2023 14:34:26 +0000 (22:34 +0800)]
MDL-76362 core: Update core_component plugin name tests
Andrew Nicols [Fri, 6 Jan 2023 14:29:49 +0000 (22:29 +0800)]
MDL-76362 core: Test coursealias before using
Andrew Nicols [Fri, 6 Jan 2023 14:29:25 +0000 (22:29 +0800)]
MDL-76362 h5p: Use string as default lang param
Andrew Nicols [Fri, 6 Jan 2023 14:29:02 +0000 (22:29 +0800)]
MDL-76362 qtype_numerical: Fix bug in phpdoc
Andrew Nicols [Fri, 6 Jan 2023 14:26:45 +0000 (22:26 +0800)]
MDL-76362 qtype_calculated*: Address issues with null strings
Andrew Nicols [Fri, 6 Jan 2023 14:17:22 +0000 (22:17 +0800)]
MDL-76362 qtype: Update formatting of qtype_calculated* upgradelib
Andrew Nicols [Fri, 6 Jan 2023 14:11:22 +0000 (22:11 +0800)]
MDL-76362 qtype_numerical: Support empty units for apply_units
Andrew Nicols [Fri, 6 Jan 2023 14:07:58 +0000 (22:07 +0800)]
MDL-76362 qtype_numeric: Refactor answer tests
Andrew Nicols [Fri, 6 Jan 2023 13:21:09 +0000 (21:21 +0800)]
MDL-76362 question: Add test for number(null)
Andrew Nicols [Fri, 6 Jan 2023 13:20:20 +0000 (21:20 +0800)]
MDL-76362 question: Refactor question number unit tests
Andrew Nicols [Fri, 6 Jan 2023 13:10:51 +0000 (21:10 +0800)]
MDL-76362 core: Use empty default string when getting prefs
The json_decode function does not accept a null, which is the
traditional default for get_user_preferences. By passing a default of
am empty string we avoid issues in PHP 8.1.
Marina Glancy [Thu, 17 Nov 2022 15:04:24 +0000 (16:04 +0100)]
MDL-76362 various: Avoid passing nulls to functions that don't allow nulls
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
Marina Glancy [Thu, 17 Nov 2022 15:00:44 +0000 (16:00 +0100)]
MDL-76362 mustache: Override parent method to avoid PHP notices
Parent method checks baseDir that is null in this case. This shows notices under PHP 8.1
Paul Holden [Fri, 20 Jan 2023 17:19:16 +0000 (17:19 +0000)]
MDL-76977 phpunit: ensure unique data provider keys in mustache test.
Sara Arjona [Fri, 20 Jan 2023 15:20:09 +0000 (16:20 +0100)]
Merge branch 'MDL-76942-master-2' of https://github.com/junpataleta/moodle
Sara Arjona [Fri, 20 Jan 2023 15:11:54 +0000 (16:11 +0100)]
Merge branch 'MDL-76139-master' of https://github.com/kevpercy/moodle
Jun Pataleta [Wed, 18 Jan 2023 14:32:05 +0000 (22:32 +0800)]
MDL-76942 course: Adjust activity chooser Behat tests
* Try to use the button name instead of CSS selectors whenever possible.
Jun Pataleta [Wed, 18 Jan 2023 14:31:16 +0000 (22:31 +0800)]
MDL-76942 core: Revert change to insertresourceoractivitybefore
Revert the lang string "Add an activity or resource before [xx]" back to
its original form of "Insert an activity or resource before [xx]" in
order to avoid conflicts with the "Add an activity or resource" button
especially when running Behat tests.
Paul Holden [Fri, 20 Jan 2023 11:30:02 +0000 (11:30 +0000)]
MDL-76973 user: correct testcase reference to external_api class.
Jun Pataleta [Fri, 20 Jan 2023 09:06:04 +0000 (17:06 +0800)]
MDL-76968 mod_quiz: Use proper external_api reference
Luca Bösch [Fri, 20 Jan 2023 08:56:55 +0000 (09:56 +0100)]
MDL-76967 questions: Questions last used line height
Kevin Percy [Mon, 28 Nov 2022 02:43:32 +0000 (10:43 +0800)]
MDL-76139 gradebook_grader: Move group selector to tertiary navigation
Ilya Tregubov [Fri, 20 Jan 2023 01:41:37 +0000 (09:41 +0800)]
weekly release 4.2dev
Jun Pataleta [Thu, 19 Jan 2023 04:05:12 +0000 (12:05 +0800)]
Merge branch 'MDL-76725' of https://github.com/paulholden/moodle
Jun Pataleta [Thu, 19 Jan 2023 03:24:04 +0000 (11:24 +0800)]
Merge branch 'MDL-76537' of https://github.com/stronk7/moodle
Jun Pataleta [Thu, 19 Jan 2023 03:18:43 +0000 (11:18 +0800)]
Merge branch 'MDL-76583-master-withoutrename' of https://github.com/andrewnicols/moodle
Ilya Tregubov [Thu, 19 Jan 2023 03:14:46 +0000 (11:14 +0800)]
Merge branch 'MDL-76870-master' of https://github.com/lameze/moodle
Ilya Tregubov [Thu, 19 Jan 2023 03:03:40 +0000 (11:03 +0800)]
Merge branch 'MDL-76766-master' of https://github.com/aanabit/moodle
Andrew Nicols [Thu, 19 Jan 2023 03:02:31 +0000 (11:02 +0800)]
MDL-76583 external: Add unit test for deprecated test helper
Ilya Tregubov [Thu, 19 Jan 2023 02:29:35 +0000 (10:29 +0800)]
Merge branch 'MDL-74756-master' of https://github.com/sh-csg/moodle
Jun Pataleta [Thu, 19 Jan 2023 01:44:48 +0000 (09:44 +0800)]
Merge branch 'MDL-76583-master-withoutrename' of https://github.com/andrewnicols/moodle
Andrew Nicols [Thu, 19 Jan 2023 01:05:46 +0000 (09:05 +0800)]
Merge branch 'MDL-69643' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 19 Jan 2023 01:01:39 +0000 (09:01 +0800)]
Merge branch 'MDL-69127' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 19 Jan 2023 00:58:01 +0000 (08:58 +0800)]
Merge branch 'MDL-69126' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 19 Jan 2023 00:54:07 +0000 (08:54 +0800)]
Merge branch 'MDL-76841' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 19 Jan 2023 00:47:51 +0000 (08:47 +0800)]
Merge branch 'MDL-70070' of https://github.com/paulholden/moodle
Andrew Nicols [Thu, 5 Jan 2023 02:00:24 +0000 (10:00 +0800)]
MDL-76583 core_external: Update util_test coding style
Andrew Nicols [Fri, 16 Dec 2022 03:00:58 +0000 (11:00 +0800)]
MDL-76583 core: Update uses of external_* classes
Andrew Nicols [Wed, 7 Dec 2022 13:32:18 +0000 (21:32 +0800)]
MDL-76583 core_external: Note deprecations and renames
Andrew Nicols [Wed, 7 Dec 2022 03:46:03 +0000 (11:46 +0800)]
MDL-76583 core_external: External API Test coding style fixes
Andrew Nicols [Fri, 16 Dec 2022 02:50:04 +0000 (10:50 +0800)]
MDL-76583 core_external: Update service management functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:50 +0000 (14:43 +0800)]
MDL-76583 core_external: Update util string formatting functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:38 +0000 (14:43 +0800)]
MDL-76583 core_external: Update token functions
Andrew Nicols [Thu, 15 Dec 2022 06:43:19 +0000 (14:43 +0800)]
MDL-76583 core_external: util class coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:56:49 +0000 (14:56 +0800)]
MDL-76583 core_external: external_files coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 07:53:33 +0000 (15:53 +0800)]
MDL-76583 core_external: external_value coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:23 +0000 (14:52 +0800)]
MDL-76583 core_external: external_format_value coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:49 +0000 (14:52 +0800)]
MDL-76583 core_external: external_single_structure coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:44 +0000 (14:52 +0800)]
MDL-76583 core_external: external_multiple_structure coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:52:32 +0000 (14:52 +0800)]
MDL-76583 core_external: external_function_params coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:41:38 +0000 (14:41 +0800)]
MDL-76583 core_external: external_warnings coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 06:40:56 +0000 (14:40 +0800)]
MDL-76583 core_external: external_api unit tests coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 04:06:18 +0000 (12:06 +0800)]
MDL-76583 core_external: external_description coding style fixes
Andrew Nicols [Thu, 15 Dec 2022 07:46:11 +0000 (15:46 +0800)]
MDL-76583 core_external: external settings coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 02:52:59 +0000 (10:52 +0800)]
MDL-76583 core_external: core_external\external_api coding style fixes
Andrew Nicols [Wed, 7 Dec 2022 21:32:28 +0000 (05:32 +0800)]
MDL-76583 core_external: Implement Privacy API for core_external
AMOS BEGIN
MOV [privacy:metadata:serviceusers,core_webservice],[privacy:metadata:serviceusers,core_external]
MOV [privacy:metadata:serviceusers:iprestriction,core_webservice],[privacy:metadata:serviceusers:iprestriction,core_external]
MOV [privacy:metadata:serviceusers:timecreated,core_webservice],[privacy:metadata:serviceusers:timecreated,core_external]
MOV [privacy:metadata:serviceusers:userid,core_webservice],[privacy:metadata:serviceusers:userid,core_external]
MOV [privacy:metadata:serviceusers:validuntil,core_webservice],[privacy:metadata:serviceusers:validuntil,core_external]
MOV [privacy:metadata:tokens,core_webservice],[privacy:metadata:tokens,core_external]
MOV [privacy:metadata:tokens:creatorid,core_webservice],[privacy:metadata:tokens:creatorid,core_external]
MOV [privacy:metadata:tokens:iprestriction,core_webservice],[privacy:metadata:tokens:iprestriction,core_external]
MOV [privacy:metadata:tokens:lastaccess,core_webservice],[privacy:metadata:tokens:lastaccess,core_external]
MOV [privacy:metadata:tokens:privatetoken,core_webservice],[privacy:metadata:tokens:privatetoken,core_external]
MOV [privacy:metadata:tokens:timecreated,core_webservice],[privacy:metadata:tokens:timecreated,core_external]
MOV [privacy:metadata:tokens:token,core_webservice],[privacy:metadata:tokens:token,core_external]
MOV [privacy:metadata:tokens:tokentype,core_webservice],[privacy:metadata:tokens:tokentype,core_external]
MOV [privacy:metadata:tokens:userid,core_webservice],[privacy:metadata:tokens:userid,core_external]
MOV [privacy:metadata:tokens:validuntil,core_webservice],[privacy:metadata:tokens:validuntil,core_external]
MOV [privacy:request:notexportedsecurity,core_webservice],[privacy:request:notexportedsecurity,core_external]
AMOS END
Andrew Nicols [Fri, 16 Dec 2022 02:49:02 +0000 (10:49 +0800)]
MDL-76583 core_external: Migrate service management to util
Andrew Nicols [Wed, 7 Dec 2022 08:47:50 +0000 (16:47 +0800)]
MDL-76583 core_external: Migrate string formatting functions to util
Andrew Nicols [Wed, 7 Dec 2022 07:15:04 +0000 (15:15 +0800)]
MDL-76583 core_external: Migrate token functions class
Andrew Nicols [Wed, 7 Dec 2022 05:34:17 +0000 (13:34 +0800)]
MDL-76583 core_external: Move util test and update
Andrew Nicols [Wed, 7 Dec 2022 05:27:52 +0000 (13:27 +0800)]
MDL-76583 core_external: Move files test and update
Andrew Nicols [Wed, 7 Dec 2022 05:25:13 +0000 (13:25 +0800)]
MDL-76583 core_external: Move settings test and update
Andrew Nicols [Wed, 7 Dec 2022 05:14:18 +0000 (13:14 +0800)]
MDL-76583 core_external: Migrate external_settings class
Andrew Nicols [Wed, 7 Dec 2022 05:10:17 +0000 (13:10 +0800)]
MDL-76583 core_external: Migrate external_format_value class
Andrew Nicols [Wed, 7 Dec 2022 04:51:13 +0000 (12:51 +0800)]
MDL-76583 core_external: Migrate external_warnings class
Andrew Nicols [Wed, 7 Dec 2022 04:33:43 +0000 (12:33 +0800)]
MDL-76583 core_external: Migrate external_files class
Andrew Nicols [Wed, 7 Dec 2022 13:30:09 +0000 (21:30 +0800)]
MDL-76583 core_external: Migrate external_util class