3 years agoMerge branch 'MDL-65204_oraclemssql_assert_equals' of git://
Jun Pataleta [Thu, 4 Apr 2019 01:08:06 +0000 (09:08 +0800)]
Merge branch 'MDL-65204_oraclemssql_assert_equals' of git://

3 years agoMDL-65204 phpunit: more isEqual() strict string fixes
Eloy Lafuente (stronk7) [Wed, 3 Apr 2019 15:09:05 +0000 (17:09 +0200)]
MDL-65204 phpunit: more isEqual() strict string fixes

This is a followup of 85f47ba, where we were relaxing
the (new since phpunit 7.x) strict (===) isEqual()
comparison for strings. Copying the explanations for
easier understanding.

Solution here is one of:
  a) Return to the previous situation, making the comparison
     softer. That can achieved by forcing different types, so
     float == string works.
  b) Changing APIs (both forms and database return strings) to
     perform some conversion to floats. That would make float
     comparison (with floats or strings) to work too.
The patch here follows the a) approach. Changing all the internals
for proper float handling sounds excesive when it has been working
perfectly since ever. So we went the easier route, just getting
rid of the new === comparisons when needed by changing expectation
types to float.

3 years agoMerge branch 'MDL-64506' of git://
Sara Arjona [Wed, 3 Apr 2019 17:30:28 +0000 (19:30 +0200)]
Merge branch 'MDL-64506' of git://

3 years agoMDL-64506 templates: BS2 pull-x -> BS4 float-x
Mathew May [Fri, 29 Mar 2019 04:16:36 +0000 (12:16 +0800)]
MDL-64506 templates: BS2 pull-x -> BS4 float-x

3 years agoMDL-64506 templates: replace spans where and col-x appears
Mathew May [Fri, 29 Mar 2019 04:10:09 +0000 (12:10 +0800)]
MDL-64506 templates: replace spans where and col-x appears

3 years agoMDL-64506 templates: BS2 m-x-x to BS4 mx-x
Mathew May [Fri, 29 Mar 2019 03:39:23 +0000 (11:39 +0800)]
MDL-64506 templates: BS2 m-x-x to BS4 mx-x

3 years agoMDL-64506 behat: Modify usertours behat.
Mathew May [Wed, 13 Mar 2019 01:54:10 +0000 (09:54 +0800)]
MDL-64506 behat: Modify usertours behat.

Original test relied on a 3rd theme to test against.
With only two themes in core now we need to make the test
theme/ suite specific.

3 years agoMDL-64506 Javascript: Remove docking JS.
Mathew May [Tue, 12 Mar 2019 03:09:06 +0000 (11:09 +0800)]
MDL-64506 Javascript: Remove docking JS.

Deprecate related lang strings & base functions now return false.

3 years agoMDL-64506 templates: Move BS2 labels to BS4 badges
Mathew May [Thu, 7 Mar 2019 02:42:32 +0000 (10:42 +0800)]
MDL-64506 templates: Move BS2 labels to BS4 badges

3 years agoMDL-64506 templates: Move BS2 btns' to BS4 btns'
Mathew May [Thu, 7 Mar 2019 01:54:01 +0000 (09:54 +0800)]
MDL-64506 templates: Move BS2 btns' to BS4 btns'

well bs2 class is now card in bs4

3 years agoMDL-64506 templates: Remove BS2 spans from elements.
Mathew May [Thu, 7 Mar 2019 01:40:47 +0000 (09:40 +0800)]
MDL-64506 templates: Remove BS2 spans from elements.

3 years agoMDL-64506 upgrade: Add upgrade steps to remove BS2 themes.
Mathew May [Wed, 6 Mar 2019 08:38:29 +0000 (16:38 +0800)]
MDL-64506 upgrade: Add upgrade steps to remove BS2 themes.

3 years agoMDL-64506 grades: Fix regression of MDL-58428
Mathew May [Wed, 6 Mar 2019 03:57:32 +0000 (11:57 +0800)]
MDL-64506 grades: Fix regression of MDL-58428

3 years agoMDL-64506 theme: Update BSB references and upgrade texts
Mathew May [Fri, 1 Mar 2019 06:14:47 +0000 (14:14 +0800)]
MDL-64506 theme: Update BSB references and upgrade texts

3 years agoMDL-64506 Grunt: Remove old Bootstrapbase tasks
Mathew May [Fri, 1 Mar 2019 06:02:04 +0000 (14:02 +0800)]
MDL-64506 Grunt: Remove old Bootstrapbase tasks

3 years agoMDL-64506 phpunit: Update unit tests to use classic
Mathew May [Thu, 28 Feb 2019 05:42:23 +0000 (13:42 +0800)]
MDL-64506 phpunit: Update unit tests to use classic

3 years agoMDL-64506 theme_bootstrapbase: Remove bootstrapbase from core
Mathew May [Thu, 28 Feb 2019 04:03:38 +0000 (12:03 +0800)]
MDL-64506 theme_bootstrapbase: Remove bootstrapbase from core

3 years agoMerge branch 'MDL-62307_master' of
Jun Pataleta [Wed, 3 Apr 2019 08:50:31 +0000 (16:50 +0800)]
Merge branch 'MDL-62307_master' of

3 years agoMerge branch 'MDL-65168' of git://
Jun Pataleta [Wed, 3 Apr 2019 08:42:41 +0000 (16:42 +0800)]
Merge branch 'MDL-65168' of git://

3 years agoMerge branch 'MDL-65112-master' of
Jun Pataleta [Wed, 3 Apr 2019 08:19:35 +0000 (16:19 +0800)]
Merge branch 'MDL-65112-master' of

3 years agoMerge branch 'session-debug' of
Adrian Greeve [Wed, 3 Apr 2019 06:57:38 +0000 (14:57 +0800)]
Merge branch 'session-debug' of

3 years agoMerge branch 'MDL-65087-master' of git://
Jake Dallimore [Wed, 3 Apr 2019 06:12:24 +0000 (14:12 +0800)]
Merge branch 'MDL-65087-master' of git://

3 years agoMerge branch 'MDL-65247-master' of git://
Jake Dallimore [Wed, 3 Apr 2019 05:46:05 +0000 (13:46 +0800)]
Merge branch 'MDL-65247-master' of git://

3 years agoMerge branch 'MDL-65130-master' of git://
Adrian Greeve [Wed, 3 Apr 2019 05:39:28 +0000 (13:39 +0800)]
Merge branch 'MDL-65130-master' of git://

3 years agoMDL-64449 core: Added Session lock debugging option
Trisha Milan [Tue, 2 Apr 2019 12:17:18 +0000 (23:17 +1100)]
MDL-64449 core: Added Session lock debugging option

3 years agoMerge branch 'MDL-65204-master' of git://
Jun Pataleta [Wed, 3 Apr 2019 02:57:12 +0000 (10:57 +0800)]
Merge branch 'MDL-65204-master' of git://

3 years agoMDL-65204 phpunit: Fix valid CiBoT errors and warnings
Jun Pataleta [Wed, 3 Apr 2019 02:44:24 +0000 (10:44 +0800)]
MDL-65204 phpunit: Fix valid CiBoT errors and warnings

3 years agoMDL-65204 phpunit: tweak constraint_object_is_equal_with_exceptions
Eloy Lafuente (stronk7) [Thu, 28 Mar 2019 00:37:28 +0000 (01:37 +0100)]
MDL-65204 phpunit: tweak constraint_object_is_equal_with_exceptions

In PHPUnit 7.x and above, IsEqual->value became private and, as far
as our with exceptions class inherits from it, we cannot access to
that anymore.

So, in order to avoid that, we are overriding the constructor, capturing
the original value for own use and forgetting.

A more formal, alternative, solution would be to make our
exceptional class to inherit from Constraint and make the
class a pure dispatcher to different constraints, with IsEqual being
just one of them.

But we followed the easiest path here. Not ideal, but efective.

3 years agoMDL-65204 phpunit: various fixes to assertions
Eloy Lafuente (stronk7) [Wed, 27 Mar 2019 12:05:35 +0000 (13:05 +0100)]
MDL-65204 phpunit: various fixes to assertions

   - 3rd param of assertEquals() cannot be null.
   - Some incorrect uses of assertNotEmpty().
   - Comparing 2 strings now uses strict (===) evaluation.
     Solution here is one of:
       a) Return to the previous situation, making the comparison
          softer. That can achieved by forcing different types, so
          float == string works.
       b) Changing APIs (both forms and database return strings) to
          perform some conversion to floats. That would make float
          comparison (with floats or strings) to work too.
     The patch here follows the a) approach. Changing all the internals
     for proper float handling sounds excesive when it has been working
     perfectly since ever. So we went the easier route, just getting
     rid of the new === comparisons when needed by changing expectation
     types to float.

3 years agoMDL-65204 phpunit: make testcases match their expected signature
Eloy Lafuente (stronk7) [Sun, 24 Mar 2019 22:21:48 +0000 (23:21 +0100)]
MDL-65204 phpunit: make testcases match their expected signature

3 years agoMDL-65204 phpunit: update composer to use phpunit 7.5.x
Eloy Lafuente (stronk7) [Sun, 24 Mar 2019 22:11:35 +0000 (23:11 +0100)]
MDL-65204 phpunit: update composer to use phpunit 7.5.x

To generate a new composer.lock for a given Moodle branch:
- Remove composer.lock
- Remove vendor
- Remove composer caches:
      php composer.phar clearcache
- Using lower PHP version supported (7.1.x for Moodle 3.7), update:
      php composer.phar update

3 years agoMDL-64506 theme: Move templates from lib/form
Mathew May [Wed, 6 Mar 2019 04:01:27 +0000 (12:01 +0800)]
MDL-64506 theme: Move templates from lib/form

3 years agoMDL-64506 theme: Create empty form templates
Mathew May [Wed, 6 Mar 2019 04:01:15 +0000 (12:01 +0800)]
MDL-64506 theme: Create empty form templates

3 years agoMDL-64506 theme_clean: Remove Clean from core
Mathew May [Thu, 28 Feb 2019 04:02:50 +0000 (12:02 +0800)]
MDL-64506 theme_clean: Remove Clean from core

3 years agoMDL-64506 theme_more: Remove More from core
Mathew May [Thu, 28 Feb 2019 04:01:40 +0000 (12:01 +0800)]
MDL-64506 theme_more: Remove More from core

3 years agoMerge branch 'MDL-65214' of git://
Jun Pataleta [Wed, 3 Apr 2019 01:48:00 +0000 (09:48 +0800)]
Merge branch 'MDL-65214' of git://

3 years agoMerge branch 'MDL-63569-email-header-master' of
Jake Dallimore [Wed, 3 Apr 2019 01:43:51 +0000 (09:43 +0800)]
Merge branch 'MDL-63569-email-header-master' of

3 years agoMDL-65247 core: Fix action_modal Behat tests
Jun Pataleta [Wed, 3 Apr 2019 00:42:01 +0000 (08:42 +0800)]
MDL-65247 core: Fix action_modal Behat tests

3 years agoMerge branch 'MDL-65213-master' of git://
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 22:22:54 +0000 (00:22 +0200)]
Merge branch 'MDL-65213-master' of git://

3 years agoMerge branch 'MDL-64994-master-pythonmlversion' of git://
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 22:09:28 +0000 (00:09 +0200)]
Merge branch 'MDL-64994-master-pythonmlversion' of git://

3 years agoMerge branch 'MDL-64693-master' of
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 21:46:24 +0000 (23:46 +0200)]
Merge branch 'MDL-64693-master' of

3 years agoMerge branch 'MDL-64779_master' of git://
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 21:23:13 +0000 (23:23 +0200)]
Merge branch 'MDL-64779_master' of git://

3 years agoMDL-65213 core_message: fix random failures when declining contacts
Sara Arjona [Tue, 2 Apr 2019 18:26:26 +0000 (20:26 +0200)]
MDL-65213 core_message: fix random failures when declining contacts

3 years agoMDL-64693 analytics: new course_competencies target
Víctor Déniz Falcón [Tue, 2 Apr 2019 16:46:39 +0000 (17:46 +0100)]
MDL-64693 analytics: new course_competencies target

Added new target to predict which students are at risk of not achieving the
competencies assigned to a course.

3 years agoon-demand release 3.7dev+
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 13:54:35 +0000 (15:54 +0200)]
on-demand release 3.7dev+

3 years agoMerge branch 'install_master' of
Eloy Lafuente (stronk7) [Tue, 2 Apr 2019 13:54:29 +0000 (15:54 +0200)]
Merge branch 'install_master' of

3 years agoMerge branch 'MDL-64331-master' of git://
Jun Pataleta [Tue, 2 Apr 2019 02:58:15 +0000 (10:58 +0800)]
Merge branch 'MDL-64331-master' of git://

3 years agoMerge branch 'MDL-65138-master' of git://
Adrian Greeve [Tue, 2 Apr 2019 02:37:34 +0000 (10:37 +0800)]
Merge branch 'MDL-65138-master' of git://

3 years agoMerge branch 'MDL-65144-master' of git://
Adrian Greeve [Tue, 2 Apr 2019 02:15:18 +0000 (10:15 +0800)]
Merge branch 'MDL-65144-master' of git://

3 years agoMDL-64331 modals: Be careful closing modals
Damyon Wiese [Thu, 28 Mar 2019 01:14:10 +0000 (09:14 +0800)]
MDL-64331 modals: Be careful closing modals

Don't close a modal when the user clicks outside of it and the modal contains a form.

3 years agoMDL-63569 email: New setting to prefix the subject of outgoing emails
Paul Damiani [Thu, 10 Jan 2019 06:18:00 +0000 (17:18 +1100)]
MDL-63569 email: New setting to prefix the subject of outgoing emails

3 years agoMerge branch 'MDL-61667-master-modelsinstall' of git://
Eloy Lafuente (stronk7) [Mon, 1 Apr 2019 22:20:47 +0000 (00:20 +0200)]
Merge branch 'MDL-61667-master-modelsinstall' of git://

3 years agoMerge branch 'MDL-64636-master' of
Eloy Lafuente (stronk7) [Mon, 1 Apr 2019 22:01:22 +0000 (00:01 +0200)]
Merge branch 'MDL-64636-master' of

3 years agoMDL-61667 analytics: Remove duplicated capability checks
David Monllaó [Mon, 1 Apr 2019 09:57:14 +0000 (11:57 +0200)]
MDL-61667 analytics: Remove duplicated capability checks

\core_analytics\model::create and \core_analytics\model::enable methods
are called from install/upgrade scripts. Therefore, they should not
include any capability check. Their capability checks are actually
redundant, as the user capabilities are already checked in the
entry-point scripts.

3 years agoMDL-61667 analytics: Fix coding style issues in the existing code
David Mudrák [Wed, 6 Mar 2019 11:20:20 +0000 (12:20 +0100)]
MDL-61667 analytics: Fix coding style issues in the existing code

These coding style issues were spotted while working on the issue. No
real changes here, just the coding style fixes attached to the patchset
for convenience.

3 years agoMDL-61667 analytics: Create missing models on install/upgrade
David Mudrák [Tue, 12 Mar 2019 08:45:26 +0000 (09:45 +0100)]
MDL-61667 analytics: Create missing models on install/upgrade

Similarly to how the scheduled tasks work, we now automatically check
and make sure that all the models specified in the component's
db/analytics.php file exist during the installation or upgrade of the

3 years agoMDL-61667 analytics: Fix checking that a given model does not exist
David Mudrák [Tue, 12 Mar 2019 08:09:26 +0000 (09:09 +0100)]
MDL-61667 analytics: Fix checking that a given model does not exist

The original implementation did not work well for checking that the
given model does NOT exist. If no record was found in the
analytics_models table, the code execution continued and it reached the
moment when indicators were checked. If no indicators were provided, the
call ended up with error 'array_keys() expects parameter 1 to be array,
boolean given' (because indicators were set to false).

3 years agoMDL-61667 analytics: Deprecate the add_builtin_models() method
David Mudrák [Tue, 12 Mar 2019 07:50:47 +0000 (08:50 +0100)]
MDL-61667 analytics: Deprecate the add_builtin_models() method

The functionality of the \core_analytics\manager::add_builtin_models()
method is to be replaced with automatic update of models provided by the
core moodle component. There is no need to call this method explicitly
any more. Instead, adding new models will be done by updating the
lib/db/analytics.php file and bumping the core version.

3 years agoMDL-61667 analytics: Add method to actually create a declared model
David Mudrák [Mon, 11 Mar 2019 13:11:17 +0000 (14:11 +0100)]
MDL-61667 analytics: Add method to actually create a declared model

This is simply a wrapper around the model's create() method that works
with the model declaration syntax from the db/analytics.php file.

3 years agoMDL-61667 analytics: Add methods to read and validate model declarations
David Mudrák [Wed, 6 Mar 2019 19:24:06 +0000 (20:24 +0100)]
MDL-61667 analytics: Add methods to read and validate model declarations

Allow every component to declare prediction models it provides via the
db/analytics.php file.

3 years agoMDL-61667 analytics: Don't autoenable models with time splitting defined
David Mudrák [Mon, 25 Mar 2019 11:57:31 +0000 (12:57 +0100)]
MDL-61667 analytics: Don't autoenable models with time splitting defined

When the API had originally been designed, it was assumed that the
presence of the time splitting method implies no requirement for the
machine learning backend and that it is a sign of less performance
demanding models. So it seemed to be safe and useful to have such models
automatically enabled. That assumption did not prove to be valid. Most
of the time is spent calculating indicators that depend on log tables.

We realized it would be useful to be able to specify the default time
splitting method without the need to have such models auto-enabled.

3 years agoMDL-64779 tool_analytics: Export selector
David Monllaó [Tue, 26 Mar 2019 12:57:09 +0000 (13:57 +0100)]
MDL-64779 tool_analytics: Export selector

3 years agoMerge branch 'MDL-65050-master-fix' of git://
Adrian Greeve [Mon, 1 Apr 2019 08:05:34 +0000 (16:05 +0800)]
Merge branch 'MDL-65050-master-fix' of git://

3 years agoMDL-65050 core: add missing lib file include
Simey Lameze [Mon, 1 Apr 2019 07:28:30 +0000 (15:28 +0800)]
MDL-65050 core: add missing lib file include

3 years agoMDL-65144 output: Add img-fluid to logo
Damyon Wiese [Fri, 22 Mar 2019 01:06:56 +0000 (09:06 +0800)]
MDL-65144 output: Add img-fluid to logo

Extra wide logos do not scale to the screen size - this change adds the bootstrap class
img-fluid to logos on the loginpage, signupform and in the context header.

Thanks to Maksud R for working on this.

3 years agoMDL-65138 course: add a setting for course publishing
Simey Lameze [Tue, 26 Mar 2019 01:46:23 +0000 (09:46 +0800)]
MDL-65138 course: add a setting for course publishing

3 years agoMerge branch 'MDL-65089_master' of
Jake Dallimore [Mon, 1 Apr 2019 07:28:48 +0000 (15:28 +0800)]
Merge branch 'MDL-65089_master' of

3 years agoMerge branch 'MDL-64194-37_block_myoverview_incorrect_pagination' of https://github...
Jake Dallimore [Mon, 1 Apr 2019 06:36:01 +0000 (14:36 +0800)]
Merge branch 'MDL-64194-37_block_myoverview_incorrect_pagination' of

3 years agoMerge branch 'MDL-64524-master' of git://
Jun Pataleta [Mon, 1 Apr 2019 05:46:48 +0000 (13:46 +0800)]
Merge branch 'MDL-64524-master' of git://

3 years agoMerge branch 'MDL-65050-master' of git://
Adrian Greeve [Mon, 1 Apr 2019 05:32:38 +0000 (13:32 +0800)]
Merge branch 'MDL-65050-master' of git://

3 years agoMDL-65050 core: delete orphaned files and functions
Simey Lameze [Thu, 28 Mar 2019 08:38:49 +0000 (16:38 +0800)]
MDL-65050 core: delete orphaned files and functions

3 years agoMDL-65050 core: add question_stats_cleanup_task scheduled task
Simey Lameze [Thu, 28 Mar 2019 08:32:21 +0000 (16:32 +0800)]
MDL-65050 core: add question_stats_cleanup_task scheduled task

This commit also removes orphaned question/engine/statisticslib.php

3 years agoMDL-65050 core: move function code to question_preview_cleanup_task
Simey Lameze [Thu, 28 Mar 2019 08:28:04 +0000 (16:28 +0800)]
MDL-65050 core: move function code to question_preview_cleanup_task

This commit also deletes the legacy question_preview_cron() function.

3 years agoMDL-65050 core: rename task to question_preview_cleanup_task
Simey Lameze [Thu, 28 Mar 2019 08:15:37 +0000 (16:15 +0800)]
MDL-65050 core: rename task to question_preview_cleanup_task

3 years agoMDL-64524 gradingform_guide: Marking guide comments
Damyon Wiese [Wed, 9 Jan 2019 02:28:02 +0000 (10:28 +0800)]
MDL-64524 gradingform_guide: Marking guide comments

When there are too many comments, scroll the list so they still fit in the dialogue.

3 years agoMDL-64524 assign: Styles editpdf comments
Damyon Wiese [Wed, 9 Jan 2019 02:19:55 +0000 (10:19 +0800)]
MDL-64524 assign: Styles editpdf comments

Properly display the list of comments, but limiting their size (use title to indicate the full comments).
When there are too many comments, show a scrollbar in the menu.

3 years agoMerge branch 'MDL-63906_master' of git://
Jun Pataleta [Mon, 1 Apr 2019 02:32:10 +0000 (10:32 +0800)]
Merge branch 'MDL-63906_master' of git://

3 years agoMerge branch 'MDL-65173_master' of git://
Adrian Greeve [Mon, 1 Apr 2019 02:21:10 +0000 (10:21 +0800)]
Merge branch 'MDL-65173_master' of git://

3 years ago MDL-64636 analytics: new course_completion target
Victor Deniz Falcon [Fri, 29 Mar 2019 10:29:45 +0000 (10:29 +0000)]
 MDL-64636 analytics: new course_completion target

Added new target to predict which students are at risk of not meeting
the course completion criteria.

3 years agoMDL-64636 analytics: base class for course completion targets
Víctor Déniz Falcón [Tue, 26 Mar 2019 22:52:58 +0000 (22:52 +0000)]
MDL-64636 analytics: base class for course completion targets

Added new parent class for targets that use course as analysable and
student enrolments as samples. course_dropout target was modified to
extend that parent class.

3 years agoMDL-65214 install: update the list of stale files for 3.7
Eloy Lafuente (stronk7) [Fri, 29 Mar 2019 09:00:38 +0000 (10:00 +0100)]
MDL-65214 install: update the list of stale files for 3.7

3 years agoMDL-65087 message: add aria-label to some buttons on bootstrapbase
Sara Arjona [Fri, 15 Mar 2019 13:39:34 +0000 (14:39 +0100)]
MDL-65087 message: add aria-label to some buttons on bootstrapbase

The aria-label has been added to the settings and search buttons and
also to the starred image displayed when a conversation is favourited.

3 years agoMDL-65087 message: add aria-label to search, settings and starred
Sara Arjona [Fri, 15 Mar 2019 13:35:44 +0000 (14:35 +0100)]
MDL-65087 message: add aria-label to search, settings and starred

3 years agoMDL-65087 message: add button role to action links on bootstrapbase
Sara Arjona [Fri, 15 Mar 2019 13:12:05 +0000 (14:12 +0100)]
MDL-65087 message: add button role to action links on bootstrapbase

For accessibility reasons, add the role="button" attribute to the links
with href="#" performing actions for the bootstrapbase theme, like
the settings icon.

3 years agoMDL-65087 message: add button role to all the links that perfom actions
Sara Arjona [Fri, 15 Mar 2019 12:36:58 +0000 (13:36 +0100)]
MDL-65087 message: add button role to all the links that perfom actions

For accessibility reasons, add the role="button" attribute to the links
with href="#" performing actions, like the icon to open the messaging

3 years agoMerge branch 'MDL-63876-master-fix' of git://
Jun Pataleta [Fri, 29 Mar 2019 04:15:00 +0000 (12:15 +0800)]
Merge branch 'MDL-63876-master-fix' of git://

3 years agoMDL-63876 tool_lp: Fix illegal whitespace
Jun Pataleta [Fri, 29 Mar 2019 04:13:48 +0000 (12:13 +0800)]
MDL-63876 tool_lp: Fix illegal whitespace

3 years agoMerge branch 'MDL-63876-master' of git://
Jun Pataleta [Fri, 29 Mar 2019 03:45:29 +0000 (11:45 +0800)]
Merge branch 'MDL-63876-master' of git://

3 years agoMDL-63876 badges: Competency deletion
Damyon Wiese [Fri, 29 Mar 2019 01:48:10 +0000 (09:48 +0800)]
MDL-63876 badges: Competency deletion

Do not delete a competency if it is a criteria for a badge.

3 years agoMDL-63876 competencies: Skip enabled check
Damyon Wiese [Fri, 15 Mar 2019 08:06:32 +0000 (16:06 +0800)]
MDL-63876 competencies: Skip enabled check

Allow rendering a competency summary if competencies are disabled, but do not include
links to competencies pages.

3 years agoMDL-63876 badges: Coding style
Damyon Wiese [Tue, 19 Feb 2019 04:49:01 +0000 (12:49 +0800)]
MDL-63876 badges: Coding style

Add comments to document function params and template example context.

3 years agoMDL-63876 badges: Allow criteria to be optional
Damyon Wiese [Tue, 19 Feb 2019 04:10:58 +0000 (12:10 +0800)]
MDL-63876 badges: Allow criteria to be optional

Competencies criteria type is only added if competencies are enabled.

3 years agoMDL-63876 competencies: Use direct URL
Damyon Wiese [Fri, 25 Jan 2019 03:04:59 +0000 (11:04 +0800)]
MDL-63876 competencies: Use direct URL

Instead of showing competencies in a dialogue, give them their own full url to
display the competency in the framework it belongs to. This is useful for exported
data that won't have access to javascript.

3 years agoMDL-63876 badges: Do not call tool_lp directly
Damyon Wiese [Wed, 23 Jan 2019 08:29:52 +0000 (16:29 +0800)]
MDL-63876 badges: Do not call tool_lp directly

3 years agoMDL-63876 badges: Add competency criteria
Damyon Wiese [Thu, 17 Jan 2019 03:35:57 +0000 (11:35 +0800)]
MDL-63876 badges: Add competency criteria

Properly integration badges with competencies provided in Moodle.

Automatically grant the badge when the defined competencies are marked as proficient.

3 years agoMDL-63876 badges: Remove invalid table from badges
Damyon Wiese [Mon, 21 Jan 2019 04:10:07 +0000 (12:10 +0800)]
MDL-63876 badges: Remove invalid table from badges

3 years agoMDL-64194 block_myoverview: incorrect pagination
Tom Dickman [Sun, 17 Mar 2019 23:36:45 +0000 (10:36 +1100)]
MDL-64194 block_myoverview: incorrect pagination

The pagination was found to be incorrect due to the all the items event not being triggered if the amount
of courses the user has is equal to the amount set via pagination.
The condition could not just be changed to `>=` as this would trigger the event when there were further
pages to display.
A check of `remainingCourses` was added to condition so if the amount of courses on the current loaded
page is less than the pagination amount, or there are no remaining courses, the all items event is
triggered and the pagination bar hidden correctly.

3 years agoAutomatically generated installer lang files
AMOS bot [Fri, 29 Mar 2019 00:15:16 +0000 (00:15 +0000)]
Automatically generated installer lang files

3 years agoMDL-65089 glossary: Enforcing case comparison in SQL.
David Castro [Fri, 15 Mar 2019 17:09:43 +0000 (12:09 -0500)]
MDL-65089 glossary: Enforcing case comparison in SQL.

3 years agoMDL-65112 mod_lesson: fix html for shortanswer responses
Dmitrii Metelkin [Tue, 19 Mar 2019 22:43:15 +0000 (09:43 +1100)]
MDL-65112 mod_lesson: fix html for shortanswer responses