moodle.git
18 months agoMerge branch 'MDL-70727-master' of https://github.com/NashTechOpenUniversity/moodle
Víctor Déniz [Tue, 23 Mar 2021 16:52:46 +0000 (16:52 +0000)]
Merge branch 'MDL-70727-master' of https://github.com/NashTechOpenUniversity/moodle

18 months agoMerge branch 'MDL-71149' of https://github.com/stronk7/moodle
Travis CI [Tue, 23 Mar 2021 07:56:00 +0000 (15:56 +0800)]
Merge branch 'MDL-71149' of https://github.com/stronk7/moodle

18 months agoMerge branch 'MDL-71084-master' of git://github.com/peterRd/moodle
Travis CI [Tue, 23 Mar 2021 05:57:13 +0000 (13:57 +0800)]
Merge branch 'MDL-71084-master' of git://github.com/peterRd/moodle

18 months agoMDL-71084 core_navigation: Move secondary_test to proper location with namespace
Peter Dias [Tue, 23 Mar 2021 03:41:16 +0000 (11:41 +0800)]
MDL-71084 core_navigation: Move secondary_test to proper location with namespace

18 months agoMDL-71084 core_navigation: Provide a header title and active node text
Peter Dias [Thu, 18 Mar 2021 00:53:32 +0000 (08:53 +0800)]
MDL-71084 core_navigation: Provide a header title and active node text

18 months agoMerge branch 'MDL-69792-master' of git://github.com/sarjona/moodle
Travis CI [Tue, 23 Mar 2021 05:53:01 +0000 (13:53 +0800)]
Merge branch 'MDL-69792-master' of git://github.com/sarjona/moodle

18 months agoMerge branch 'MDL-71104-master-2' of git://github.com/mickhawkins/moodle
Travis CI [Tue, 23 Mar 2021 05:46:20 +0000 (13:46 +0800)]
Merge branch 'MDL-71104-master-2' of git://github.com/mickhawkins/moodle

18 months agoMDL-71104 core_completion: Fix fetching of grade completion status
Michael Hawkins [Thu, 18 Mar 2021 06:27:36 +0000 (14:27 +0800)]
MDL-71104 core_completion: Fix fetching of grade completion status

We should be able to fetch the grade completion status for modules
that do not have custom completion configured. This also improves
unit testing coverage.

18 months agoMDL-71104 completion: Fix completion_info::get_data() unit tests
Jun Pataleta [Mon, 15 Mar 2021 06:39:08 +0000 (14:39 +0800)]
MDL-71104 completion: Fix completion_info::get_data() unit tests

* Fixed inverted $sameuser test data.
* Fixed caching expectation check. Caching only relies on whether the
user accessing the completion data is the same user or not.
* Fixed checking for the caching of other modules. Should have been
checking cm ID and not instance ID.
* Additional test case when whole course parameter is passed as
true, but the requesting user is different from the target user.

18 months agoMerge branch 'MDL-71039-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Tue, 23 Mar 2021 03:17:44 +0000 (11:17 +0800)]
Merge branch 'MDL-71039-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-70313-master' of git://github.com/peterRd/moodle
Andrew Nicols [Tue, 23 Mar 2021 01:58:57 +0000 (09:58 +0800)]
Merge branch 'MDL-70313-master' of git://github.com/peterRd/moodle

18 months agoMerge branch 'MDL-69036' of git://github.com/paulholden/moodle
Andrew Nicols [Tue, 23 Mar 2021 01:51:39 +0000 (09:51 +0800)]
Merge branch 'MDL-69036' of git://github.com/paulholden/moodle

18 months agoMerge branch 'MDL-67870-master' of git://github.com/mihailges/moodle
Andrew Nicols [Tue, 23 Mar 2021 01:16:28 +0000 (09:16 +0800)]
Merge branch 'MDL-67870-master' of git://github.com/mihailges/moodle

18 months agoMDL-67870 backup: Skip value change if setting is locked by hierarchy
Mihail Geshoski [Wed, 10 Mar 2021 03:08:48 +0000 (11:08 +0800)]
MDL-67870 backup: Skip value change if setting is locked by hierarchy

The given condition in the if statement did not take into account cases
when the setting is locked by hierarchy. Settings which are locked by
hierarchy should should keep their current values which were inherited
from the parent.

18 months agoMerge branch 'MDL-70816-master-4' of git://github.com/rezaies/moodle
Andrew Nicols [Mon, 22 Mar 2021 05:29:09 +0000 (13:29 +0800)]
Merge branch 'MDL-70816-master-4' of git://github.com/rezaies/moodle

18 months agoMDL-70816 mod_choice: activity_dates implementation
Shamim Rezaie [Thu, 18 Feb 2021 16:25:57 +0000 (03:25 +1100)]
MDL-70816 mod_choice: activity_dates implementation

18 months agoMDL-70816 core: Activity date details base class
Shamim Rezaie [Thu, 18 Feb 2021 15:43:30 +0000 (02:43 +1100)]
MDL-70816 core: Activity date details base class

* Base class for fetching an activity module's important date for a user

18 months agoMerge branch 'MDL-71139-master-trademark' of git://github.com/mudrd8mz/moodle
Andrew Nicols [Mon, 22 Mar 2021 03:58:31 +0000 (11:58 +0800)]
Merge branch 'MDL-71139-master-trademark' of git://github.com/mudrd8mz/moodle

18 months agoMerge branch 'MDL-70919-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Sun, 21 Mar 2021 23:44:26 +0000 (07:44 +0800)]
Merge branch 'MDL-70919-master' of git://github.com/marinaglancy/moodle

18 months agoMDL-71149 install: update the list of stale files for 3.11
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 12:00:27 +0000 (13:00 +0100)]
MDL-71149 install: update the list of stale files for 3.11

18 months agoMDL-69792 core_badges: deprecated backpack.js and BADGE_BACKPACKURL
Sara Arjona [Tue, 23 Feb 2021 11:01:55 +0000 (12:01 +0100)]
MDL-69792 core_badges: deprecated backpack.js and BADGE_BACKPACKURL

Final deprecation for constant BADGE_BACKPACKURL (it has been removed)
and badges/backpack.js file (it has been removed too).
Besides, some methods have started the deprecation process too:
 - badges_check_backpack_accessibility
 - badges_setup_backpack_js()
 - badges_local_backpack_js()

Apart from that, string 'addbackpack' has been deprecated here
because it's not used anywhere.

18 months agoweekly release 4.0dev
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:19 +0000 (14:06 +0100)]
weekly release 4.0dev

18 months agoNOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:19 +0000 (14:06 +0100)]
NOBUG: Fixed file access permissions

18 months agoMerge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:15 +0000 (14:06 +0100)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install

18 months agoMDL-70919 core_form: non-static method can not be called statically
Marina Glancy [Thu, 18 Mar 2021 11:15:49 +0000 (12:15 +0100)]
MDL-70919 core_form: non-static method can not be called statically

18 months agoMDL-71139 trademark: Improve the trademark messaging
Chris Brown [Thu, 18 Mar 2021 09:31:56 +0000 (10:31 +0100)]
MDL-71139 trademark: Improve the trademark messaging

18 months agoMerge branch 'MDL-70992-master' of https://github.com/NashTechOpenUniversity/moodle
Jun Pataleta [Thu, 18 Mar 2021 04:23:48 +0000 (12:23 +0800)]
Merge branch 'MDL-70992-master' of https://github.com/NashTechOpenUniversity/moodle

18 months agoMerge branch 'MDL-70924' of git://github.com/paulholden/moodle
Adrian Greeve [Thu, 18 Mar 2021 03:53:58 +0000 (11:53 +0800)]
Merge branch 'MDL-70924' of git://github.com/paulholden/moodle

18 months agoMerge branch 'MDL-70198-master-2' of git://github.com/peterRd/moodle
Jun Pataleta [Thu, 18 Mar 2021 03:41:51 +0000 (11:41 +0800)]
Merge branch 'MDL-70198-master-2' of git://github.com/peterRd/moodle

18 months agoMerge branch 'MDL-71048' of https://github.com/paulholden/moodle
Adrian Greeve [Thu, 18 Mar 2021 03:11:46 +0000 (11:11 +0800)]
Merge branch 'MDL-71048' of https://github.com/paulholden/moodle

18 months agoMerge branch 'MDL-70977' of git://github.com/paulholden/moodle
Adrian Greeve [Thu, 18 Mar 2021 02:49:42 +0000 (10:49 +0800)]
Merge branch 'MDL-70977' of git://github.com/paulholden/moodle

18 months agoMerge branch 'MDL-70978-master' of git://github.com/aanabit/moodle
Jun Pataleta [Thu, 18 Mar 2021 01:55:44 +0000 (09:55 +0800)]
Merge branch 'MDL-70978-master' of git://github.com/aanabit/moodle

18 months agoMerge branch 'MDL-71068-protectusername-confirmed' of https://github.com/brendanheywo...
Adrian Greeve [Thu, 18 Mar 2021 01:53:44 +0000 (09:53 +0800)]
Merge branch 'MDL-71068-protectusername-confirmed' of https://github.com/brendanheywood/moodle

18 months agoAutomatically generated installer lang files
AMOS bot [Thu, 18 Mar 2021 00:07:48 +0000 (00:07 +0000)]
Automatically generated installer lang files

18 months agoMerge branch 'MDL-70901-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:40:46 +0000 (00:40 +0100)]
Merge branch 'MDL-70901-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-70896-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:34:05 +0000 (00:34 +0100)]
Merge branch 'MDL-70896-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-70968-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:29:38 +0000 (00:29 +0100)]
Merge branch 'MDL-70968-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-70893-master' of git://github.com/marinaglancy/moodle
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:23:26 +0000 (00:23 +0100)]
Merge branch 'MDL-70893-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-70689-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 22:20:37 +0000 (23:20 +0100)]
Merge branch 'MDL-70689-master' of git://github.com/sarjona/moodle

18 months agoMerge branch 'MDL-71036' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 17 Mar 2021 12:05:25 +0000 (20:05 +0800)]
Merge branch 'MDL-71036' of https://github.com/stronk7/moodle

18 months agoMDL-71068 login: Fix edge cases with $CFG->protectusernames
Brendan Heywood [Wed, 17 Mar 2021 06:37:29 +0000 (17:37 +1100)]
MDL-71068 login: Fix edge cases with $CFG->protectusernames

18 months agoMDL-70198 core_navigation: Secondary nav unit tests
Peter Dias [Wed, 17 Mar 2021 04:07:22 +0000 (12:07 +0800)]
MDL-70198 core_navigation: Secondary nav unit tests

18 months agoMDL-70198 core_navigation: Implement secondary nav and curate nodes
Peter Dias [Wed, 17 Mar 2021 04:06:53 +0000 (12:06 +0800)]
MDL-70198 core_navigation: Implement secondary nav and curate nodes

Implement the new secondary nav and curate the nodes from flatnav and settingsnav

18 months agoMDL-70198 core_navigation: Create new base view class
Peter Dias [Wed, 17 Mar 2021 04:05:48 +0000 (12:05 +0800)]
MDL-70198 core_navigation: Create new base view class

18 months agoMDL-70992 Folder: Unnecessary tab stops to the left of files
sangnguyen [Mon, 1 Mar 2021 09:48:14 +0000 (16:48 +0700)]
MDL-70992 Folder: Unnecessary tab stops to the left of files

18 months agoMerge branch 'MDL-70565' of git://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 21:48:57 +0000 (22:48 +0100)]
Merge branch 'MDL-70565' of git://github.com/paulholden/moodle

18 months agoMerge branch 'master-MDL-71044_v3' of https://github.com/golenkovm/moodle
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 21:38:48 +0000 (22:38 +0100)]
Merge branch 'master-MDL-71044_v3' of https://github.com/golenkovm/moodle

18 months agoMerge branch 'MDL-67748-master-managewebservices' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 18:02:10 +0000 (19:02 +0100)]
Merge branch 'MDL-67748-master-managewebservices' of git://github.com/mudrd8mz/moodle

18 months agoMDL-67748 admin: Add Behat tests for tokens filtering features
David Mudrák [Mon, 15 Mar 2021 20:19:33 +0000 (21:19 +0100)]
MDL-67748 admin: Add Behat tests for tokens filtering features

Credit goes to Andrew for Behat data generators for webservices.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
18 months agoMerge branch 'MDL-44613-integration-master' of git://github.com/mihailges/moodle
Sara Arjona [Tue, 16 Mar 2021 07:26:48 +0000 (08:26 +0100)]
Merge branch 'MDL-44613-integration-master' of git://github.com/mihailges/moodle

18 months agoMerge branch 'MDL-69474' of https://github.com/stronk7/moodle
Adrian Greeve [Tue, 16 Mar 2021 04:54:21 +0000 (12:54 +0800)]
Merge branch 'MDL-69474' of https://github.com/stronk7/moodle

18 months agoMerge branch 'MDL-70780-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Tue, 16 Mar 2021 02:54:46 +0000 (10:54 +0800)]
Merge branch 'MDL-70780-master' of git://github.com/andrewnicols/moodle

18 months agoMDL-44613 mod_assign: Fix behat failure in classic
Mihail Geshoski [Tue, 16 Mar 2021 02:26:09 +0000 (10:26 +0800)]
MDL-44613 mod_assign: Fix behat failure in classic

The link to the calendar page is missing in the navigation block in
classic which causes a behat failure in the 'Set availibility dates
for an assignment' feature. The fix includes adding the calendar block
to the Course page which can be used to navigate to the calendar page.

18 months agoMDL-69474 accessibility: page->url can be not set, protect against that
Eloy Lafuente (stronk7) [Mon, 15 Mar 2021 19:20:33 +0000 (20:20 +0100)]
MDL-69474 accessibility: page->url can be not set, protect against that

Both in unit tests, but also in other areas (say blocks, for example)
it's possible that page->url has not been set yet.

So, let's change current code to always check if we have something
(page->url) to compare.

Note the use of has_set_url() is needed, because page->url is magic
method and it doesn't work as expected. Hate magics!

18 months agoMDL-67748 admin: Do not show missing capabilities for mobile app service
David Mudrák [Fri, 24 Apr 2020 17:20:54 +0000 (19:20 +0200)]
MDL-67748 admin: Do not show missing capabilities for mobile app service

We used to display capabilities like "Manage any calendar entries",
"Delete evidence", "Manage competency frameworks", "View hidden courses"
and others as "Missing capabilities" for the mobile app service tokens.

This gave dangerous impression that the app will not work for students
without these capabilities granted. There are known cases of admins who
started to grant all these caps to the Authenticated user role because
they were afraid the app would not work for them.

The problem here is that the official mobile app service includes some
functions that have these capabilities declared as required. But they
are not really required to use the app. Either the app makes its own
clever checks of capabilities before calling the functions, or sometimes
the capabilities are not even correctly declared.

It is safer for everybody to display this information for custom
services only where the risk of the falsely missing caps is lower and
the information is more accurate.

Also, the help text has been improved so it does not suggest that these
capabilities must be always added. We do not know why the service has
them declared. In some cases, a service has capabilities declared just
because it makes use of them in the if-then fashion.

Additionally, the patch also displays the service short name because it
is actually needed to know.

18 months agoMDL-67748 admin: Show user identity fields on the manage tokens page
David Mudrák [Fri, 24 Apr 2020 16:33:36 +0000 (18:33 +0200)]
MDL-67748 admin: Show user identity fields on the manage tokens page

On sites with many users, the fullname itself may not be unique
identifier of users. Display the user identity fields below the token
owner's name.

18 months agoMDL-67748 admin: Add filter to the WS tokens management page
David Mudrák [Wed, 22 Apr 2020 20:22:13 +0000 (22:22 +0200)]
MDL-67748 admin: Add filter to the WS tokens management page

The patch adds ability to filter the list of token by the token value,
the user and the service. Also the button to create a new token is made
more prominent and easier to spot.

18 months agoMDL-67748 admin: Improve the display of tokens the user cannot see
David Mudrák [Wed, 22 Apr 2020 15:55:27 +0000 (17:55 +0200)]
MDL-67748 admin: Improve the display of tokens the user cannot see

18 months agoMDL-67748 admin: Refactor tokens management as an external page
David Mudrák [Fri, 17 Apr 2020 14:14:53 +0000 (16:14 +0200)]
MDL-67748 admin: Refactor tokens management as an external page

No need to have a dedicated admin_setting_managewebservicetokens admin
setting subclass, and yet do not use almost any of its features. So the
patch merges the list and the forms handling into a single external
page.

Similarly, it feels like overkill to have a renderer method for a
simple confirmation widget - especially given that the URLs were
hard-coded in it. So that one was dropped.

18 months agoMDL-67748 admin: Improve the display of missing capabilities
David Mudrák [Thu, 16 Apr 2020 14:20:19 +0000 (16:20 +0200)]
MDL-67748 admin: Improve the display of missing capabilities

The patch improves the display of the missing capabilities on the Manage
tokens page and the Select authorised users page. The list of
capabilities is rendered in a collapsible area and does not occupy too
much space by default.

Additionally on the later page, the patch improves the display of the
list of existing authorised users so that it respects the configured
identity fields.

18 months agoMDL-67748 admin: Improve get_missing_capabilities_by_users()
David Mudrák [Thu, 23 Jan 2020 21:49:23 +0000 (22:49 +0100)]
MDL-67748 admin: Improve get_missing_capabilities_by_users()

The previous implementation falsely reported all implicit capabilities
inherited from the authenticated user archetype. That caused a lot of
capabilities reported as missing, even if they were correctly granted.

This new implementation uses a different logic. Instead of seeking for
explicitly assigned capabilities, it searches for capabilities that are
not assigned to any of the user's role across the system.

Please refer to the inline documentation. This should be still used for
informative reports only, not for actual permissions evaluation. The
context has been ignored here, as well as all the overrides etc. This
patch just makes it a lesser evil.

18 months agoMDL-67748 admin: Simplify the webservice token form
David Mudrák [Thu, 23 Jan 2020 07:46:54 +0000 (08:46 +0100)]
MDL-67748 admin: Simplify the webservice token form

We can now use the autocomplete element to select the user. No need to
for the legacy behaviour.

18 months agoMDL-67748 admin: Respect the viewfullnames cap at manage tokens table
David Mudrák [Wed, 22 Jan 2020 22:57:06 +0000 (23:57 +0100)]
MDL-67748 admin: Respect the viewfullnames cap at manage tokens table

18 months agoMDL-67748 user: Add new core_user/form_user_selector JS module
David Mudrák [Wed, 22 Jan 2020 22:18:11 +0000 (23:18 +0100)]
MDL-67748 user: Add new core_user/form_user_selector JS module

The module provides AJAX support for the autocomplete form element.

18 months agoMDL-67748 user: Add a new core_user_search_identity external function
David Mudrák [Wed, 22 Jan 2020 22:00:58 +0000 (23:00 +0100)]
MDL-67748 user: Add a new core_user_search_identity external function

The purpose of this external function is to provide data for
asynchronous user selectors and similar widgets. It allows to search
users matching the given query in their name or other available identity
fields.

18 months agoMDL-67748 user: Fix @link docs tag usage
David Mudrák [Mon, 22 Feb 2021 10:08:48 +0000 (11:08 +0100)]
MDL-67748 user: Fix @link docs tag usage

Not related to this issue, just spotted while working on it.

18 months agoMDL-67748 admin: Move the web service token form to its own file
David Mudrák [Tue, 21 Jan 2020 12:21:58 +0000 (13:21 +0100)]
MDL-67748 admin: Move the web service token form to its own file

18 months agoMDL-67748 admin: Move the web services under the server administration
David Mudrák [Tue, 21 Jan 2020 09:38:23 +0000 (10:38 +0100)]
MDL-67748 admin: Move the web services under the server administration

I suppose the original reasoning was that the web services protocols are
pluggable and that plugins can provide external function. But those are
not good reasons to put the whole Web services section under plugins.
Web services are not a plugin type and they always felt very
counter-intuitive there.

From the server administrtaion perspective, web services are similar to
scheduled tasks and therefore, they should live in the same section.

18 months agoMerge branch 'MDL-69474-master' of https://github.com/NashTechOpenUniversity/moodle
Eloy Lafuente (stronk7) [Mon, 15 Mar 2021 15:27:02 +0000 (16:27 +0100)]
Merge branch 'MDL-69474-master' of https://github.com/NashTechOpenUniversity/moodle

18 months agoMerge branch 'MDL-44613-master-1' of git://github.com/mihailges/moodle
Sara Arjona [Mon, 15 Mar 2021 14:53:34 +0000 (15:53 +0100)]
Merge branch 'MDL-44613-master-1' of git://github.com/mihailges/moodle

18 months agoMerge branch 'MDL-65974-master-iteration03' of git://github.com/ferranrecio/moodle
Eloy Lafuente (stronk7) [Mon, 15 Mar 2021 13:07:17 +0000 (14:07 +0100)]
Merge branch 'MDL-65974-master-iteration03' of git://github.com/ferranrecio/moodle

18 months agoMDL-70977 mod_forum: fix empty equality check updating post content.
Paul Holden [Mon, 22 Feb 2021 23:19:46 +0000 (23:19 +0000)]
MDL-70977 mod_forum: fix empty equality check updating post content.

Using the external method for updating posts, the check for empty
subject/message content wasn't correct (disallowed the string '0'),
in addition to being impossible to set a posts message format
property to FORMAT_MOODLE (integer 0).

18 months agoMDL-70924 course: ensure required fields present when getting courses.
Paul Holden [Wed, 17 Feb 2021 09:54:24 +0000 (09:54 +0000)]
MDL-70924 course: ensure required fields present when getting courses.

18 months agoMDL-65974 course: fix return section in modchooser
Ferran Recio [Mon, 15 Mar 2021 12:11:53 +0000 (13:11 +0100)]
MDL-65974 course: fix return section in modchooser

18 months agoMerge branch 'MDL-66667-cache-course-image-master' of https://github.com/dmitriim...
Jun Pataleta [Mon, 15 Mar 2021 09:19:06 +0000 (17:19 +0800)]
Merge branch 'MDL-66667-cache-course-image-master' of https://github.com/dmitriim/moodle

18 months agoMerge branch 'MDL-65974-master-iteration03' of git://github.com/ferranrecio/moodle
Adrian Greeve [Mon, 15 Mar 2021 07:16:44 +0000 (15:16 +0800)]
Merge branch 'MDL-65974-master-iteration03' of git://github.com/ferranrecio/moodle

18 months agoMerge branch 'MDL-70306-master' of git://github.com/peterRd/moodle
Adrian Greeve [Mon, 15 Mar 2021 03:17:31 +0000 (11:17 +0800)]
Merge branch 'MDL-70306-master' of git://github.com/peterRd/moodle

18 months agoMDL-70306 auth: Update the thirdpartylib.xml
Peter Dias [Wed, 10 Mar 2021 00:24:02 +0000 (08:24 +0800)]
MDL-70306 auth: Update the thirdpartylib.xml

18 months agoMDL-70313 core: Update the thirdpartylib.xml
Peter Dias [Wed, 10 Mar 2021 01:21:38 +0000 (09:21 +0800)]
MDL-70313 core: Update the thirdpartylib.xml

18 months agoMDL-70313 core: Rebuilt module files
Peter Dias [Wed, 10 Mar 2021 01:20:07 +0000 (09:20 +0800)]
MDL-70313 core: Rebuilt module files

18 months agoMDL-70313 core: Update codemirror to 5.59.4
Peter Dias [Wed, 10 Mar 2021 01:15:54 +0000 (09:15 +0800)]
MDL-70313 core: Update codemirror to 5.59.4

18 months agoMDL-66667 course: add course image cache
Dmitrii Metelkin [Mon, 15 Mar 2021 01:50:35 +0000 (12:50 +1100)]
MDL-66667 course: add course image cache

18 months agoMDL-44613 mod_assign: Automate testing of the assignment availability
Mihail Geshoski [Tue, 9 Feb 2021 03:26:05 +0000 (11:26 +0800)]
MDL-44613 mod_assign: Automate testing of the assignment availability

18 months agoMDL-44613 tool_behat: Update datetime format usages to strftime
Mihail Geshoski [Fri, 19 Feb 2021 06:47:44 +0000 (14:47 +0800)]
MDL-44613 tool_behat: Update datetime format usages to strftime

Updates all existing datetime format usages to strftime in the
'time to timestamp' transformation in tool_behat behat tests.

18 months agoMDL-44613 core_message: Update datetime format usages to strftime
Mihail Geshoski [Fri, 19 Feb 2021 06:35:24 +0000 (14:35 +0800)]
MDL-44613 core_message: Update datetime format usages to strftime

Updates all existing datetime format usages to strftime in the
'time to timestamp' transformation in core_message behat tests.

18 months agoMDL-44613 behat: strftime format in time to timestamp transformation
Mihail Geshoski [Fri, 19 Feb 2021 06:02:10 +0000 (14:02 +0800)]
MDL-44613 behat: strftime format in time to timestamp transformation

Modifies the 'string time to timestamp' behat trasformation to use
userdate() instead of date(). The userdate() method is generally used
throught Moodle for constructing formatted date strings and this change
will provide more consistency and prevent any potential behat failures.
Therefore, if the date format is defined in the given trasformation, it
has to be strftime compatible. Example:
'I should see "##tomorrow noon##%A, %d %B %Y, %I:%M %p##"'

18 months agoAutomatically generated installer lang files
AMOS bot [Sat, 13 Mar 2021 00:07:49 +0000 (00:07 +0000)]
Automatically generated installer lang files

18 months agoMDL-70978 core_contentbank: Increasing contrast for unlisted content
Amaia Anabitarte [Wed, 24 Feb 2021 15:00:16 +0000 (16:00 +0100)]
MDL-70978 core_contentbank: Increasing contrast for unlisted content

18 months agoMDL-70689 oauth2: unit tests for new IMS OBv2.1
Sara Arjona [Mon, 25 Jan 2021 16:42:08 +0000 (17:42 +0100)]
MDL-70689 oauth2: unit tests for new IMS OBv2.1

Apart from adding new unit tests for covering new IMS OBv2.1 issuer,
some extra tests have been added to test existing issuers and confirm
they are still working as expected after the changes.

18 months agoMDL-70689 oauth2: deprecate unused strings
Sara Arjona [Mon, 25 Jan 2021 11:20:29 +0000 (12:20 +0100)]
MDL-70689 oauth2: deprecate unused strings

18 months agoMDL-70689 oauth2: self-register IMS OBv2.1 services
Sara Arjona [Tue, 26 Jan 2021 14:50:11 +0000 (15:50 +0100)]
MDL-70689 oauth2: self-register IMS OBv2.1 services

IMS OBv2.1 services have a registration endpoint to get client id
and secret.
This patch adds and implements the "register" method for the IMS
Open Badges Connect discovery system, to get the proper client id
and secret values.

18 months agoMDL-70689 oauth2: add support to IMS OBv2.1 service
Sara Arjona [Wed, 20 Jan 2021 16:23:18 +0000 (17:23 +0100)]
MDL-70689 oauth2: add support to IMS OBv2.1 service

In order to make easier to create and maintain new OAuth2 services,
a couple of classes have been added:

- discovery\* contains methods related to the discovery system. Until
now, only OpenID Connect was supported by Moodle so all the code was
centralised in api.php.
With this patch, as IMS OBv2.1 has a different discovery system, a new
abstract class (base_definition) has been added to be called and let
every discovery system (OpenID Connect, IMS Badge Connect...)
implement their own methods.

- service\* . Instead of keep adding methods to the api, the service
namespace has been created to store all the standard issuer services.
An interface (issuer_interface) has been created and all the services
should implement it.
This patch creates the "IMS OBv2.1" and "Custom" services and moves
the methods for "Google" service because it uses the OpenID connect
discovery system.

18 months agoMDL-70565 user: filter course participants by country.
Paul Holden [Wed, 24 Feb 2021 10:37:18 +0000 (10:37 +0000)]
MDL-70565 user: filter course participants by country.

18 months agoMDL-71036 phpunit: Coding style changes, 99% whitespace only
Eloy Lafuente (stronk7) [Sun, 7 Mar 2021 16:36:53 +0000 (17:36 +0100)]
MDL-71036 phpunit: Coding style changes, 99% whitespace only

I've gone over a few of the mofified files (those
which were showing warnings and errors to CiBoT. Some of them
have been fixed completely, while others only have fixed
for the lines belonging to this issue (lib/tests/moodlelib_test.php)
for example.

18 months agoMDL-71036 phpunit: Add all the noticeable changes to upgrade notes
Eloy Lafuente (stronk7) [Thu, 4 Mar 2021 11:23:00 +0000 (12:23 +0100)]
MDL-71036 phpunit: Add all the noticeable changes to upgrade notes

18 months agoMDL-71036 phpunit: xml config - switch coverage info to new includes
Eloy Lafuente (stronk7) [Sun, 28 Feb 2021 22:45:33 +0000 (23:45 +0100)]
MDL-71036 phpunit: xml config - switch coverage info to new includes

This applies the "whitelist" => "include" changes to all the core
phpunit_coverage_info occurrences, so core won't emit any deprecation
warning (see previous commit).

At the same time, modified a bunch of comments in coverage files
to be more readable/understandable.

18 months agoMDL-71036 phpunit: xml config - deprecate whitelist from coverage
Eloy Lafuente (stronk7) [Sun, 28 Feb 2021 22:37:35 +0000 (23:37 +0100)]
MDL-71036 phpunit: xml config - deprecate whitelist from coverage

Following the changes in the schema, from "whitelists" to "includes",
we are deprecating these two properties from phpunit_coverage_info:

- whitelistfolders => includelistfolders
- whitelistfiles   => includelistfiles

They will continue working over the deprecation period but the init/util
scripts will throw some warnings about them being deprecated for 3.11 and
the way to replace them.

Standard 2y deprecation applies with final removed to happen @ MDL-71067

18 months agoMDL-71036 phpunit: xml config - change dist file to spread them to final
Eloy Lafuente (stronk7) [Sun, 28 Feb 2021 22:33:53 +0000 (23:33 +0100)]
MDL-71036 phpunit: xml config - change dist file to spread them to final

Basically switch to 2-space indenting and small tweaks to comments,
so both the main phpunit.xml file and also the individual components
ones, all them based in the dist one will be consistent.

18 months agoMDL-71036 phpunit: xml config - change generation code to follow xsd
Eloy Lafuente (stronk7) [Sun, 28 Feb 2021 22:22:33 +0000 (23:22 +0100)]
MDL-71036 phpunit: xml config - change generation code to follow xsd

This performs all the changes needed in the util generator to
produce XML files compliant with the new schema (see previous
commit for description of changes).

- All the occurrences in code of filter => coverage.
- All the occurrences in code of whitelist => include.
- Apply all the changes to comply with the new schema.

- Remove processUncoveredFilesFromWhitelist attribute, useless (false
    is its default value, and now have another name).
- Move from 4-spaces indented XML to 2-spaces indented.
- Small linefeed tweaks to generate better-looking XML.

18 months agoMDL-71036 phpunit: xml config - add new (9.5) validation xsd
Eloy Lafuente (stronk7) [Sun, 28 Feb 2021 22:06:51 +0000 (23:06 +0100)]
MDL-71036 phpunit: xml config - add new (9.5) validation xsd

PHPUnit 9 comes with various changes in the XML
configuration file, namely:

  - the old "filter" section has been renamed to "coverage".
  - "whitelist" has been renamed to "include"
  - "exclude" is not a child of "include" anymore, but of "coverage".
  - "include" cannot have configuration attributes anymore, only
    "coverage" can"

Visually it means that the old section (invented example):
```
<filter>
  <whitelist attributes_may_go_here="xx">
    <directory suffix=".php">classes</directory>
    <directory suffix=".php">externallib.php</directory>
    <exclude>
      <directory suffix="_test.php">.</directory>
    </exclude>
  </whitelist>
</filter>
```
Now looks like:
```
<coverage attributes_may_go_here="xx">
  <include>
    <directory suffix=".php">classes</directory>
    <directory suffix=".php">externallib.php</directory>
  </include>
  <exclude>
    <directory suffix="_test.php">.</directory>
  </exclude>
</filter>
```

So, switching to the new xsd so we can validate the remaining changes.