moodle.git
18 months agoMerge branch 'MDL-66980' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Mon, 21 Oct 2019 18:26:34 +0000 (20:26 +0200)]
Merge branch 'MDL-66980' of https://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-61121-master-5' of git://github.com/mihailges/moodle
Sara Arjona [Mon, 21 Oct 2019 12:46:17 +0000 (14:46 +0200)]
Merge branch 'MDL-61121-master-5' of git://github.com/mihailges/moodle

18 months agoMerge branch 'MDL-64739_master' of git://github.com/dmonllao/moodle
Eloy Lafuente (stronk7) [Mon, 21 Oct 2019 11:29:29 +0000 (13:29 +0200)]
Merge branch 'MDL-64739_master' of git://github.com/dmonllao/moodle

18 months agoMerge branch 'MDL-66631-master-test' of git://github.com/rezaies/moodle
Sara Arjona [Mon, 21 Oct 2019 10:18:19 +0000 (12:18 +0200)]
Merge branch 'MDL-66631-master-test' of git://github.com/rezaies/moodle

18 months agoMDL-66980 question bank: fix load_many_for_cache missing record check
Tim Hunt [Mon, 21 Oct 2019 10:18:12 +0000 (11:18 +0100)]
MDL-66980 question bank: fix load_many_for_cache missing record check

18 months agoMerge branch 'MDL-65774-master2' of git://github.com/peterRd/moodle
Eloy Lafuente (stronk7) [Mon, 21 Oct 2019 08:48:12 +0000 (10:48 +0200)]
Merge branch 'MDL-65774-master2' of git://github.com/peterRd/moodle

18 months agoMerge branch 'MDL-66808-master' of git://github.com/rezaies/moodle
Eloy Lafuente (stronk7) [Mon, 21 Oct 2019 08:32:23 +0000 (10:32 +0200)]
Merge branch 'MDL-66808-master' of git://github.com/rezaies/moodle

18 months agoMerge branch 'MDL-66912-master' of https://github.com/snake/moodle
Jun Pataleta [Mon, 21 Oct 2019 08:26:28 +0000 (16:26 +0800)]
Merge branch 'MDL-66912-master' of https://github.com/snake/moodle

18 months agoMerge branch 'MDL-66009-master' of https://github.com/grabs/moodle
Jun Pataleta [Mon, 21 Oct 2019 08:15:20 +0000 (16:15 +0800)]
Merge branch 'MDL-66009-master' of https://github.com/grabs/moodle

18 months agoMerge branch 'MDL-66612-master' of git://github.com/crazyserver/moodle
Jake Dallimore [Mon, 21 Oct 2019 08:06:07 +0000 (16:06 +0800)]
Merge branch 'MDL-66612-master' of git://github.com/crazyserver/moodle

18 months agoMerge branch 'MDL-66915-master' of https://github.com/MartinGauk/moodle
Jake Dallimore [Mon, 21 Oct 2019 07:54:12 +0000 (15:54 +0800)]
Merge branch 'MDL-66915-master' of https://github.com/MartinGauk/moodle

18 months agoMDL-64739 analytics: Contexts autocomplete with ajax
David Monllaó [Mon, 21 Oct 2019 05:20:13 +0000 (13:20 +0800)]
MDL-64739 analytics: Contexts autocomplete with ajax

18 months agoMDL-66612 calendar: Change global events to site events
Pau Ferrer Ocaña [Fri, 6 Sep 2019 06:46:28 +0000 (08:46 +0200)]
MDL-66612 calendar: Change global events to site events

AMOS BEGIN
 CPY [category,moodle],[category,calendar]
 CPY [site,notes],[eventtypesite,calendar]
 CPY [site,moodle],[site,calendar]
 MOV [typesite,moodle],[siteevent,calendar]
AMOS END

18 months agoMerge branch 'MDL-66962-master' of https://github.com/lucaboesch/moodle
Andrew Nicols [Mon, 21 Oct 2019 06:22:57 +0000 (14:22 +0800)]
Merge branch 'MDL-66962-master' of https://github.com/lucaboesch/moodle

18 months agoMDL-66962 questions: Question bank table T title non breaking.
Luca Bösch [Fri, 18 Oct 2019 15:53:30 +0000 (17:53 +0200)]
MDL-66962 questions: Question bank table T title non breaking.

18 months agoMerge branch 'MDL-66944_master' of https://github.com/t-schroeder/moodle
Andrew Nicols [Mon, 21 Oct 2019 05:47:42 +0000 (13:47 +0800)]
Merge branch 'MDL-66944_master' of https://github.com/t-schroeder/moodle

18 months agoMerge branch 'MDL-66946' of https://github.com/timhunt/moodle
Andrew Nicols [Mon, 21 Oct 2019 04:54:06 +0000 (12:54 +0800)]
Merge branch 'MDL-66946' of https://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-66930-master' of https://github.com/lucaboesch/moodle
Jake Dallimore [Mon, 21 Oct 2019 03:55:00 +0000 (11:55 +0800)]
Merge branch 'MDL-66930-master' of https://github.com/lucaboesch/moodle

18 months agoMerge branch 'MDL-66960-master' of https://github.com/lucaboesch/moodle
Jake Dallimore [Mon, 21 Oct 2019 02:41:10 +0000 (10:41 +0800)]
Merge branch 'MDL-66960-master' of https://github.com/lucaboesch/moodle

18 months agoMDL-64739 tool_analytics: Restrict models to specific contexts
David Monllaó [Mon, 16 Sep 2019 02:56:42 +0000 (10:56 +0800)]
MDL-64739 tool_analytics: Restrict models to specific contexts

18 months agoMDL-64739 core_analytics: New db field for model contexts
Mitxel Moriana [Mon, 16 Sep 2019 02:30:00 +0000 (10:30 +0800)]
MDL-64739 core_analytics: New db field for model contexts

18 months agoMDL-64739 tool_analytics: Remove filter option from evaluate CLI script
David Monllaó [Thu, 15 Aug 2019 06:11:59 +0000 (14:11 +0800)]
MDL-64739 tool_analytics: Remove filter option from evaluate CLI script

It can be considered that we replaced it with the new contexts field.

18 months agoMDL-64739 core_analytics: Contexts param for get_analysables_iterator
David Monllaó [Thu, 15 Aug 2019 06:00:15 +0000 (14:00 +0800)]
MDL-64739 core_analytics: Contexts param for get_analysables_iterator

18 months agoMerge branch 'MDL-66816' of https://github.com/timhunt/moodle
Jake Dallimore [Mon, 21 Oct 2019 01:36:19 +0000 (09:36 +0800)]
Merge branch 'MDL-66816' of https://github.com/timhunt/moodle

18 months agoMDL-66946 quiz reports: incorrectly show teachers sometimes
Tim Hunt [Thu, 17 Oct 2019 16:36:23 +0000 (17:36 +0100)]
MDL-66946 quiz reports: incorrectly show teachers sometimes

18 months agoMDL-66960 questions: Top align all question bank titles exc "select all"
Luca Bösch [Fri, 18 Oct 2019 14:32:35 +0000 (16:32 +0200)]
MDL-66960 questions: Top align all question bank titles exc "select all"

18 months agoMDL-66816 question bank: replace row of edit icons with an Edit menu
Tim Hunt [Wed, 2 Oct 2019 12:51:48 +0000 (13:51 +0100)]
MDL-66816 question bank: replace row of edit icons with an Edit menu

18 months agoMDL-65774 mod_assign: Update FPDI class to inherit pdf
Sara Arjona [Mon, 15 Jul 2019 00:13:43 +0000 (08:13 +0800)]
MDL-65774 mod_assign: Update FPDI class to inherit pdf

18 months agoMDL-66930 quiz: Question type icon size/alignment in Boost and Classic.
Luca Bösch [Wed, 16 Oct 2019 19:19:30 +0000 (21:19 +0200)]
MDL-66930 quiz: Question type icon size/alignment in Boost and Classic.

18 months agoon-demand release 3.8dev+
Eloy Lafuente (stronk7) [Fri, 18 Oct 2019 08:31:55 +0000 (10:31 +0200)]
on-demand release 3.8dev+

18 months agoMDL-61121 assign: Declare variables in the local scope
Mihail Geshoski [Fri, 18 Oct 2019 05:57:45 +0000 (13:57 +0800)]
MDL-61121 assign: Declare variables in the local scope

18 months agoMDL-61121 assign: Improve accessibility in quick grading page tables
Mihail Geshoski [Fri, 18 Oct 2019 05:57:00 +0000 (13:57 +0800)]
MDL-61121 assign: Improve accessibility in quick grading page tables

18 months agoMDL-61121 assign: Improve accessibility - view full/view summary control
Mihail Geshoski [Fri, 11 Oct 2019 01:45:14 +0000 (09:45 +0800)]
MDL-61121 assign: Improve accessibility - view full/view summary control

18 months agoMerge branch 'MDL-66767' of https://github.com/Chocolate-lightning/moodle_forum-project
Andrew Nicols [Fri, 18 Oct 2019 04:37:50 +0000 (12:37 +0800)]
Merge branch 'MDL-66767' of https://github.com/Chocolate-lightning/moodle_forum-project

18 months agoMDL-66767 forumreport_summary: Improved groups only SQL
Michael Hawkins [Fri, 18 Oct 2019 04:35:53 +0000 (12:35 +0800)]
MDL-66767 forumreport_summary: Improved groups only SQL

18 months agoMDL-66767 forumreport_summary: Control groups filter content
Michael Hawkins [Tue, 1 Oct 2019 07:54:12 +0000 (15:54 +0800)]
MDL-66767 forumreport_summary: Control groups filter content

Control the groups filter options based on forum groups mode and groups
visible to the user viewing the report.

18 months agoMDL-66767 forumreport_summary: Updated groups filter to apply to data
Michael Hawkins [Tue, 1 Oct 2019 04:53:18 +0000 (12:53 +0800)]
MDL-66767 forumreport_summary: Updated groups filter to apply to data

Previously, the groups filter was only filtering by user, it now
filters the data by group, as well as limiting the users displayed
to those with access to the relevant combination.

18 months agoMerge branch 'MDL-66740-master' of git://github.com/marinaglancy/moodle
Adrian Greeve [Fri, 18 Oct 2019 03:06:55 +0000 (11:06 +0800)]
Merge branch 'MDL-66740-master' of git://github.com/marinaglancy/moodle

18 months agoMDL-66631 mod_forum: unit tests for date filters
Simey Lameze [Thu, 3 Oct 2019 02:15:44 +0000 (10:15 +0800)]
MDL-66631 mod_forum: unit tests for date filters

18 months agoMDL-66631 mod_forum: unit tests refactoring
Simey Lameze [Wed, 2 Oct 2019 06:00:22 +0000 (14:00 +0800)]
MDL-66631 mod_forum: unit tests refactoring

18 months agoMDL-66631 mod_forum: make get_from_discussion_ids use new fn
Simey Lameze [Wed, 2 Oct 2019 05:51:22 +0000 (13:51 +0800)]
MDL-66631 mod_forum: make get_from_discussion_ids use new fn

18 months agoMDL-66631 mod_forum: add date filters to export
Simey Lameze [Wed, 25 Sep 2019 04:25:55 +0000 (12:25 +0800)]
MDL-66631 mod_forum: add date filters to export

18 months agoMerge branch 'MDL-66806_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Fri, 18 Oct 2019 01:36:51 +0000 (09:36 +0800)]
Merge branch 'MDL-66806_master' of git://github.com/dmonllao/moodle

18 months agoMerge branch 'MDL-66919' of https://github.com/stronk7/moodle
Andrew Nicols [Fri, 18 Oct 2019 00:26:38 +0000 (08:26 +0800)]
Merge branch 'MDL-66919' of https://github.com/stronk7/moodle

18 months agoMerge branch 'mdl-66173' of https://github.com/Peterburnett/moodle
Eloy Lafuente (stronk7) [Thu, 17 Oct 2019 23:49:31 +0000 (01:49 +0200)]
Merge branch 'mdl-66173' of https://github.com/Peterburnett/moodle

18 months agoMerge branch 'MDL-66625-master' of git://github.com/rezaies/moodle
Jun Pataleta [Thu, 17 Oct 2019 22:39:01 +0000 (06:39 +0800)]
Merge branch 'MDL-66625-master' of git://github.com/rezaies/moodle

18 months agoMerge branch 'MDL-56549-master' of https://github.com/kabalin/moodle
Jun Pataleta [Thu, 17 Oct 2019 22:27:21 +0000 (06:27 +0800)]
Merge branch 'MDL-56549-master' of https://github.com/kabalin/moodle

18 months agoMDL-56549 test: Add tests covering core_media_player_native
Ruslan Kabalin [Sun, 6 Oct 2019 23:09:04 +0000 (00:09 +0100)]
MDL-56549 test: Add tests covering core_media_player_native

18 months agoMDL-56549 medialib_test: Move fixture to dedicated subdir.
Ruslan Kabalin [Sun, 6 Oct 2019 23:05:29 +0000 (00:05 +0100)]
MDL-56549 medialib_test: Move fixture to dedicated subdir.

18 months agoMDL-56549 media_html5video: Add test for native extensions support.
Ruslan Kabalin [Thu, 3 Oct 2019 23:04:25 +0000 (00:04 +0100)]
MDL-56549 media_html5video: Add test for native extensions support.

This is to verify that all files of html_video mime type extensions are
passing list_supported_urls method correctly.

18 months agoMDL-56549 media_html5audio: Add test for native extensions support.
Ruslan Kabalin [Thu, 3 Oct 2019 22:59:59 +0000 (23:59 +0100)]
MDL-56549 media_html5audio: Add test for native extensions support.

This is to verify that all files of html_audio mime type extensions are
passing list_supported_urls method correctly.

18 months agoMDL-56549 lib: Add flac audio extension to html5 support list.
Ruslan Kabalin [Thu, 3 Oct 2019 16:40:40 +0000 (17:40 +0100)]
MDL-56549 lib: Add flac audio extension to html5 support list.

This is now supported by most browsers:
https://en.wikipedia.org/wiki/HTML5_audio
https://caniuse.com/#feat=flac

18 months agoMerge branch 'MDL-64064' of https://github.com/NeillM/moodle
Eloy Lafuente (stronk7) [Thu, 17 Oct 2019 21:08:58 +0000 (23:08 +0200)]
Merge branch 'MDL-64064' of https://github.com/NeillM/moodle

18 months agoMDL-66625 forumreport_summary: Adding behat
Shamim Rezaie [Thu, 17 Oct 2019 18:46:39 +0000 (05:46 +1100)]
MDL-66625 forumreport_summary: Adding behat

18 months agoMDL-66944 course: fixed copy-paste-error in comment
Tim Schroeder [Thu, 17 Oct 2019 16:15:08 +0000 (18:15 +0200)]
MDL-66944 course: fixed copy-paste-error in comment

18 months agoMerge branch 'MDL-66694-master' of git://github.com/junpataleta/moodle
Jun Pataleta [Thu, 17 Oct 2019 14:48:16 +0000 (22:48 +0800)]
Merge branch 'MDL-66694-master' of git://github.com/junpataleta/moodle

18 months agoMDL-66694 mod_forum: Fix unit test
Jun Pataleta [Thu, 17 Oct 2019 14:39:36 +0000 (22:39 +0800)]
MDL-66694 mod_forum: Fix unit test

* Set $forum1's displaywordcount to true in
  test_mod_forum_get_discussion_posts() so that the word and char counts
  will be returned.
* Use count_words() and count_letters() instead of hard coding the
  expected values for the word and char counts.

18 months agoMDL-66694 mod_forum: Refactored post counts scheduled task
Michael Hawkins [Thu, 17 Oct 2019 08:30:33 +0000 (16:30 +0800)]
MDL-66694 mod_forum: Refactored post counts scheduled task

18 months agoMDL-66612 calendar: Fix calendar icons
Pau Ferrer Ocaña [Thu, 5 Sep 2019 13:02:02 +0000 (15:02 +0200)]
MDL-66612 calendar: Fix calendar icons

18 months agoMDL-66694 mod_forum: Word/char count tidy ups & add task config option
Michael Hawkins [Thu, 17 Oct 2019 06:24:16 +0000 (14:24 +0800)]
MDL-66694 mod_forum: Word/char count tidy ups & add task config option

The chunk size used by the existing post word/char count calculation
ad-hoc task can now be set as a $CFG parameter. Also improved the way
the ad-hoc task is re-queued and tidied up some redundant code.

18 months agoMDL-66009 mod_feedback: Nested dependency fails again
Andreas Grabs [Tue, 25 Jun 2019 20:04:14 +0000 (22:04 +0200)]
MDL-66009 mod_feedback: Nested dependency fails again

18 months agoMDL-66694 mod_forum: Updated adhoc task to requeue until completion
Michael Hawkins [Mon, 7 Oct 2019 06:00:22 +0000 (14:00 +0800)]
MDL-66694 mod_forum: Updated adhoc task to requeue until completion

The adhoc task run during upgrade will now be requeued until no more
word/char counts require updating. Previously it was only run once,
so only the first 5000 posts would be updated.

18 months agoMDL-66694 mod_forum: Upgrade forum post word and char counts
David Monllaó [Wed, 2 Oct 2019 03:19:37 +0000 (11:19 +0800)]
MDL-66694 mod_forum: Upgrade forum post word and char counts

18 months agoMDL-66694 mod_forum: Word & char count update consistency fixes
Michael Hawkins [Mon, 7 Oct 2019 05:38:49 +0000 (13:38 +0800)]
MDL-66694 mod_forum: Word & char count update consistency fixes

Charcount logic is now consistent with wordcount in the post exporter.
Counts update now called in forum_udpate_instance since it is updating
the data.

18 months agoMDL-66694 mod_forum: Update word & char counts on db save
David Monllaó [Wed, 2 Oct 2019 02:07:53 +0000 (10:07 +0800)]
MDL-66694 mod_forum: Update word & char counts on db save

18 months agoMDL-66694 forumreport_summary: String update and method tidy up
Michael Hawkins [Mon, 7 Oct 2019 05:25:24 +0000 (13:25 +0800)]
MDL-66694 forumreport_summary: String update and method tidy up

Replaced 'Char' with full word 'Character' in the charcount string.
Also tidied up show_word_char_counts code and set to protected instead
of private.

18 months agoMDL-66694 mod_forum: Word count and char count columns
David Monllaó [Wed, 2 Oct 2019 01:43:45 +0000 (09:43 +0800)]
MDL-66694 mod_forum: Word count and char count columns

18 months agoMDL-66496 mod_data: Fixes during integration
Andrew Nicols [Thu, 17 Oct 2019 04:20:54 +0000 (12:20 +0800)]
MDL-66496 mod_data: Fixes during integration

18 months agoMerge branch 'MDL-66496-master' of git://github.com/tobiasreischmann/moodle
Andrew Nicols [Thu, 17 Oct 2019 03:05:34 +0000 (11:05 +0800)]
Merge branch 'MDL-66496-master' of git://github.com/tobiasreischmann/moodle

18 months agoMDL-66808 mod_forum: set the format col to FORMAT_PLAIN when it is plain
Shamim Rezaie [Thu, 17 Oct 2019 02:21:05 +0000 (13:21 +1100)]
MDL-66808 mod_forum: set the format col to FORMAT_PLAIN when it is plain

18 months agoMDL-66808 mod_forum: Added export options
Shamim Rezaie [Wed, 9 Oct 2019 18:04:38 +0000 (05:04 +1100)]
MDL-66808 mod_forum: Added export options

18 months agoMDL-66173 login: Added form injection, validation and post action hooks
[Peter Burnett] [Fri, 2 Aug 2019 00:34:19 +0000 (10:34 +1000)]
MDL-66173 login: Added form injection, validation and post action hooks

18 months agoMDL-66625 forumreport_summary: Handling private replies
Shamim Rezaie [Wed, 2 Oct 2019 13:02:10 +0000 (23:02 +1000)]
MDL-66625 forumreport_summary: Handling private replies

18 months agoMerge branch 'MDL-66020-master' of git://github.com/marinaglancy/moodle
Jake Dallimore [Wed, 16 Oct 2019 00:37:07 +0000 (08:37 +0800)]
Merge branch 'MDL-66020-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-66790-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 22:55:48 +0000 (00:55 +0200)]
Merge branch 'MDL-66790-master' of git://github.com/junpataleta/moodle

18 months agoMerge branch 'MDL-66705-master' of git://github.com/abgreeve/moodle
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 22:52:52 +0000 (00:52 +0200)]
Merge branch 'MDL-66705-master' of git://github.com/abgreeve/moodle

18 months agoMDL-66919 behat: fix typo in error message
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 18:26:22 +0000 (20:26 +0200)]
MDL-66919 behat: fix typo in error message

Also fix a couple of phpdocs that were incorrect.

18 months agoon-demand release 3.8dev+
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 21:01:00 +0000 (23:01 +0200)]
on-demand release 3.8dev+

18 months agoNOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 21:00:54 +0000 (23:00 +0200)]
NOBUG: Fixed SVG browser compatibility

18 months agoMDL-66915 assign: Notify only if grade was updated in past 24 hours
Martin Gauk [Tue, 15 Oct 2019 15:03:33 +0000 (17:03 +0200)]
MDL-66915 assign: Notify only if grade was updated in past 24 hours

Send notifications only if a grade was updated in the past 24 hours,
whether marking workflow is enabled or not.

18 months agoMerge branch 'MDL-66553-master-fix' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Tue, 15 Oct 2019 14:42:15 +0000 (16:42 +0200)]
Merge branch 'MDL-66553-master-fix' of git://github.com/junpataleta/moodle

18 months agoMDL-66553 question: Behat fixes
Jun Pataleta [Tue, 15 Oct 2019 12:22:12 +0000 (20:22 +0800)]
MDL-66553 question: Behat fixes

1. Fix sortable key for the qname/idnumber/tags column
2. Fix the default sort
3. Fix Behat test for sorting by idnumber. Added ID numbers for both
question A and question C in order for us to get consistent sorting
across DBs.

18 months agoMDL-66790 quizreport: Prevent sorting for checkbox column
Jun Pataleta [Tue, 15 Oct 2019 06:50:06 +0000 (14:50 +0800)]
MDL-66790 quizreport: Prevent sorting for checkbox column

18 months agoMDL-66912 core_message: improve media matching js for content previews
Jake Dallimore [Tue, 15 Oct 2019 06:18:00 +0000 (14:18 +0800)]
MDL-66912 core_message: improve media matching js for content previews

Rather than matching 'src' string, use a dummy node and check for a src
attribute.

18 months agoMerge branch 'MDL-66226-master-2' of https://github.com/snake/moodle
Jun Pataleta [Tue, 15 Oct 2019 03:56:05 +0000 (11:56 +0800)]
Merge branch 'MDL-66226-master-2' of https://github.com/snake/moodle

18 months agoMDL-66705 tool_uploaduser: Add an example csv file.
Adrian Greeve [Tue, 17 Sep 2019 07:05:35 +0000 (15:05 +0800)]
MDL-66705 tool_uploaduser: Add an example csv file.

18 months agoMerge branch 'MDL-66796' of git://github.com/timhunt/moodle
Jake Dallimore [Tue, 15 Oct 2019 02:52:45 +0000 (10:52 +0800)]
Merge branch 'MDL-66796' of git://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-66821' of https://github.com/timhunt/moodle
Jun Pataleta [Mon, 14 Oct 2019 23:35:36 +0000 (07:35 +0800)]
Merge branch 'MDL-66821' of https://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-66335' of https://github.com/stronk7/moodle
Andrew Nicols [Mon, 14 Oct 2019 23:21:52 +0000 (07:21 +0800)]
Merge branch 'MDL-66335' of https://github.com/stronk7/moodle

18 months agoMDL-66335 behat: Avoid double processing the page type
Eloy Lafuente (stronk7) [Mon, 14 Oct 2019 21:52:28 +0000 (23:52 +0200)]
MDL-66335 behat: Avoid double processing the page type

resolve_page_instance_helper() already processes the type, returning
the correct context that should be processing the navigation URL.

With that extra call to parse_page_name() the 2nd call always returns
"core", ultimately leading to tons of behat failures because "core" is
not aware of those (plugin, quiz for now) pages typology.

18 months agoMerge branch 'MDL-66335' of https://github.com/timhunt/moodle
Eloy Lafuente (stronk7) [Mon, 14 Oct 2019 16:53:44 +0000 (18:53 +0200)]
Merge branch 'MDL-66335' of https://github.com/timhunt/moodle

18 months agoMerge branch 'MDL-66559-master' of git://github.com/andrewnicols/moodle
Eloy Lafuente (stronk7) [Mon, 14 Oct 2019 14:33:46 +0000 (16:33 +0200)]
Merge branch 'MDL-66559-master' of git://github.com/andrewnicols/moodle

18 months agoMDL-66796 question bank: fix more bugs with category editing
Tim Hunt [Mon, 14 Oct 2019 14:27:09 +0000 (15:27 +0100)]
MDL-66796 question bank: fix more bugs with category editing

18 months agoMDL-66796 question bank: 0 is a valid question category idnumber
Tim Hunt [Mon, 30 Sep 2019 12:13:06 +0000 (13:13 +0100)]
MDL-66796 question bank: 0 is a valid question category idnumber

18 months agoMerge branch 'MDL-63349-Master' of github.com:tuanngocnguyen/moodle
Sara Arjona [Mon, 14 Oct 2019 11:58:09 +0000 (13:58 +0200)]
Merge branch 'MDL-63349-Master' of github.com:tuanngocnguyen/moodle

18 months agoMDL-66821 question behat: new step for acting on questions in the bank
Tim Hunt [Wed, 2 Oct 2019 14:58:04 +0000 (15:58 +0100)]
MDL-66821 question behat: new step for acting on questions in the bank

There is a proposed change MDL-66816 which will change the question
bank UI. This will break any Behat tests which uses low-level steps
like

    When I click on "Duplicate" "link" in the "Test question" "table_row"

to perform an action on a question in the question bank. This commit
introduces a new step:

    When I choose "Duplicate" action for "Test question" in the question bank

This commit also converts all core Behat tests to use the new step.

18 months agoMerge branch 'MDL-66836-master' of https://github.com/sammarshallou/moodle
Sara Arjona [Mon, 14 Oct 2019 10:26:49 +0000 (12:26 +0200)]
Merge branch 'MDL-66836-master' of https://github.com/sammarshallou/moodle

18 months agoMDL-66740 core_course: change defaults for course request settings
Marina Glancy [Mon, 14 Oct 2019 10:16:31 +0000 (12:16 +0200)]
MDL-66740 core_course: change defaults for course request settings

18 months agoMDL-66335 quiz behat: using the new generic navigation steps
Tim Hunt [Wed, 7 Aug 2019 14:18:45 +0000 (15:18 +0100)]
MDL-66335 quiz behat: using the new generic navigation steps

This converts all the navigation to quiz pages when that is not
the thing under test. Also, I decided that the Quiz settings form
belonged to the course, so did not do that here.

18 months agoMDL-66335 behat: new step to log in and go straight to a particular page
Tim Hunt [Thu, 5 Sep 2019 17:00:39 +0000 (18:00 +0100)]
MDL-66335 behat: new step to log in and go straight to a particular page

I did not think thought through if this new URL parameter would be a
potential security hole. The simple cop-out option is to make it only
work on Behat sites for now.