Petr Skoda [Fri, 3 Sep 2010 19:00:16 +0000 (19:00 +0000)]
MDL-23308 coursefiles is a legacy feature, we should discourage everybody from using it
Petr Skoda [Fri, 3 Sep 2010 18:58:04 +0000 (18:58 +0000)]
adding a TODO highlighting bad api design
Petr Skoda [Fri, 3 Sep 2010 18:14:55 +0000 (18:14 +0000)]
MDL-14679 fixed remaining old style set_field()s
Petr Skoda [Fri, 3 Sep 2010 18:01:25 +0000 (18:01 +0000)]
MDL-14679 fixed remaining old style update_record()s
Petr Skoda [Fri, 3 Sep 2010 17:47:41 +0000 (17:47 +0000)]
MDL-14679 fixed a lot more old style uses of insert_record()
Inaki [Fri, 3 Sep 2010 16:54:03 +0000 (16:54 +0000)]
MDL-23864 auth/cas Coding error: Undefined index REQUEST_URI in auth/cas/CAS/CAS.php
Patch our local copy (and record the change) while upstream fixes it (see
https://issues.jasig.org/browse/PHPCAS-81 )
Petr Skoda [Fri, 3 Sep 2010 16:26:04 +0000 (16:26 +0000)]
MDL-14679 fixed multiple old style insert_record calls, we throw exceptions now from DML
Petr Skoda [Fri, 3 Sep 2010 15:59:25 +0000 (15:59 +0000)]
fixed comment typos
Petr Skoda [Fri, 3 Sep 2010 15:44:11 +0000 (15:44 +0000)]
MDL-24028 cast all bools in DML params to integers 1/0; credit goes to Eloy Lafuente
Petr Skoda [Fri, 3 Sep 2010 12:00:59 +0000 (12:00 +0000)]
MDL-23308 added a feature to allow legacy course files in new courses too
Petr Skoda [Fri, 3 Sep 2010 11:59:28 +0000 (11:59 +0000)]
MDL-23308 all "course files" are legacy feature, we must tell this to all our users, we can not use "Course files" anymore because we really want them to migrate. Sorry, please do not revert this change again. If somebody does not like this they have to tweak their language pack, it is officially "legacy" file area now.
Andrew Davis [Fri, 3 Sep 2010 08:53:32 +0000 (08:53 +0000)]
gradebook MDL-23362 added a fix to deal with the course grade item already existing or not
Andrew Davis [Fri, 3 Sep 2010 08:36:58 +0000 (08:36 +0000)]
gradebook MDL-23362 added a fix to deal with the course grade item already existing or not
Andrew Davis [Fri, 3 Sep 2010 07:53:10 +0000 (07:53 +0000)]
gradebook MDL-23362 added a fix so that grade item sortorder isnt lost when you restore
Sam Hemelryk [Fri, 3 Sep 2010 07:50:33 +0000 (07:50 +0000)]
backup MDL-23904 Fixed regression in backup UI
jerome mouneyrac [Fri, 3 Sep 2010 07:43:29 +0000 (07:43 +0000)]
css rollback clearfix change for IE7 - it breaks IE7 in other cases
jerome mouneyrac [Fri, 3 Sep 2010 06:43:39 +0000 (06:43 +0000)]
CSS quick fix by Sam Hemelryk of 'clearfix' CSS rule: IE7 can handle the styled tag has a layer
Sam Hemelryk [Fri, 3 Sep 2010 05:53:47 +0000 (05:53 +0000)]
NOBUG Additional checking in navigation JavaScript
Dongsheng Cai [Fri, 3 Sep 2010 04:14:29 +0000 (04:14 +0000)]
MDL-23308, coursefiles plugin could return the file link instead of copying it
Andrew Davis [Fri, 3 Sep 2010 02:49:04 +0000 (02:49 +0000)]
gradebook MDL-15457 hide grade item when activity is hidden in the course
Moodle Robot [Fri, 3 Sep 2010 00:50:59 +0000 (00:50 +0000)]
Updated the HEAD build version to
20100903
AMOS bot [Fri, 3 Sep 2010 00:40:08 +0000 (00:40 +0000)]
Automatic installer lang files (
20100903)
Petr Skoda [Thu, 2 Sep 2010 18:49:31 +0000 (18:49 +0000)]
MDL-23184 PARAM_CLEANHTML is work with real html markup only, it does not do our custom FORMAT_MOODLE tweaks anymore, luckily this was not supposed to be used before storage to database in 1.9, that means there should not be any BC issues;ĂŠimproved docs
Petr Skoda [Thu, 2 Sep 2010 18:42:29 +0000 (18:42 +0000)]
MDL-23184 chat supports html only input
Petr Skoda [Thu, 2 Sep 2010 18:41:38 +0000 (18:41 +0000)]
MDL-23184 some TODOs for incorrect text cleaning
Petr Skoda [Thu, 2 Sep 2010 18:39:37 +0000 (18:39 +0000)]
MDL-23184 user confirm improved param cleaning
Petr Skoda [Thu, 2 Sep 2010 18:37:22 +0000 (18:37 +0000)]
MDL-23184 improved docs, do not show deprecated examples
Petr Skoda [Thu, 2 Sep 2010 18:35:44 +0000 (18:35 +0000)]
MDL-23184 no need to clean searches, we use bound params now and we do not print it anywhere
Petr Skoda [Thu, 2 Sep 2010 18:34:39 +0000 (18:34 +0000)]
MDL-23184 activity names are in fact dir names
Petr Skoda [Thu, 2 Sep 2010 18:29:39 +0000 (18:29 +0000)]
MDL-23184 activity names are now either PARAM_TEXT or PARAM_CLEANHTML, this should be more accurate
Petr Skoda [Thu, 2 Sep 2010 18:25:30 +0000 (18:25 +0000)]
MDL-23184 using PARAM_NOTAGS instead of general cleaning for fields that are not supposed to have tags
Petr Skoda [Thu, 2 Sep 2010 18:16:45 +0000 (18:16 +0000)]
MDL-23184 PARAM_CLEANHTML used in messaging for now, adding some hints how to implement support for text formats properly
Petr Skoda [Thu, 2 Sep 2010 18:12:21 +0000 (18:12 +0000)]
MDL-23184 CLEAN_PARAM explanation improved in unittests
Petr Skoda [Thu, 2 Sep 2010 18:09:49 +0000 (18:09 +0000)]
MDL-23184 fixed wrong PARAM_CLEAN
Petr Skoda [Thu, 2 Sep 2010 18:08:04 +0000 (18:08 +0000)]
MDL-24064 disabling bulk enrol for now, it needs to be rewritten a bit; fixing incorrect sue of PARAM_CLEAN
Petr Skoda [Thu, 2 Sep 2010 17:58:03 +0000 (17:58 +0000)]
fixed php docs, PARAM_CLEANHTML does not strip backslashes anymore
Petr Skoda [Thu, 2 Sep 2010 17:55:22 +0000 (17:55 +0000)]
MDL-23184 role description accepts any HTML, we have to trust people that can edit roles anyway
Petr Skoda [Thu, 2 Sep 2010 17:51:59 +0000 (17:51 +0000)]
MDL-24063 finally after so many years developers have to specify parameter types in optional_param() and required_param() - the developers get standard PHP notices and debugging info, hopefully that will be enough to persuade everybody to stop abusing default PARAM_CLEAN; fixing php docs
Petr Skoda [Thu, 2 Sep 2010 17:33:49 +0000 (17:33 +0000)]
MDL-15897 fix strict comparison
Petr Skoda [Thu, 2 Sep 2010 17:30:00 +0000 (17:30 +0000)]
MDL-22959 PARA_TEXT multilang whitelisting cleanup; the text is no longer being processed by kses or htmlpurifier - this should fix some recent regressions, any xhtml strict tweaking should be done in format_string() if necessary; unit tests included
Tim Hunt [Thu, 2 Sep 2010 13:06:17 +0000 (13:06 +0000)]
MDL-24060 Need a way to control whether html_to_text lists all links in the HTML
Petr Skoda [Thu, 2 Sep 2010 12:57:04 +0000 (12:57 +0000)]
MDL-24059 stripslashes TODO notes
Petr Skoda [Thu, 2 Sep 2010 12:56:26 +0000 (12:56 +0000)]
MDL-24058 removing obsolte stripslashes
Petr Skoda [Thu, 2 Sep 2010 12:49:53 +0000 (12:49 +0000)]
MDL-24058 no stripslashes any more, removing
Petr Skoda [Thu, 2 Sep 2010 12:49:29 +0000 (12:49 +0000)]
MDL-24058 no stripslashes any more
Petr Skoda [Thu, 2 Sep 2010 12:47:59 +0000 (12:47 +0000)]
MDL-24058 magic quotes are being delat with in our lib/setup.php, no need to use them again in our heavily hacked quickforms
Petr Skoda [Thu, 2 Sep 2010 12:44:58 +0000 (12:44 +0000)]
MDL-24058 removing forgotten stripslashes from gradebook, no magic quotes used any more
Petr Skoda [Thu, 2 Sep 2010 12:44:27 +0000 (12:44 +0000)]
MDL-24058 removing forgotten stripslashes, no magic quotes used any more
Petr Skoda [Thu, 2 Sep 2010 12:43:26 +0000 (12:43 +0000)]
MDL-24058 fixing wron DML conversion
Petr Skoda [Thu, 2 Sep 2010 12:41:58 +0000 (12:41 +0000)]
MDL-24058 fixing docs
Petr Skoda [Thu, 2 Sep 2010 12:41:30 +0000 (12:41 +0000)]
MDL-24058 removing unnecessary addslashes
Petr Skoda [Thu, 2 Sep 2010 12:40:34 +0000 (12:40 +0000)]
MDL-24058 replacing forbidden addslashes with something that is most probably completely useless
Petr Skoda [Thu, 2 Sep 2010 12:37:00 +0000 (12:37 +0000)]
MDL-24058 just killing addslashes, no idea why we have this horrible code in CVS
Petr Skoda [Thu, 2 Sep 2010 12:35:47 +0000 (12:35 +0000)]
MDL-24058 fixed JS string quoting
Petr Skoda [Thu, 2 Sep 2010 12:34:51 +0000 (12:34 +0000)]
MDL-24058 removed forgotten addslashes from feedback
Petr Skoda [Thu, 2 Sep 2010 12:32:36 +0000 (12:32 +0000)]
MDL-24058 removed forgotted addslashes
Petr Skoda [Thu, 2 Sep 2010 12:29:25 +0000 (12:29 +0000)]
MDL-16780, MDL-24058 removing AJAX from list of used libs too
Petr Skoda [Thu, 2 Sep 2010 12:27:47 +0000 (12:27 +0000)]
MDL-16780, MDL-24058 removing PHP4 JSON implementation and related AJAX pear stuff that is not used any more - it is buggy, so we would have to either fix it (waste of time) or we have to remove it; no core code is using this and contrib can be easily updated to use standard json_encode()
Petr Skoda [Thu, 2 Sep 2010 12:19:08 +0000 (12:19 +0000)]
MDL-24058 fixed potential XSS
Petr Skoda [Thu, 2 Sep 2010 12:17:11 +0000 (12:17 +0000)]
MDL-24058 removed obsolete addslashes
Petr Skoda [Thu, 2 Sep 2010 12:16:24 +0000 (12:16 +0000)]
MDL-24058 fixed sql injection, addslashes must not be used any more
Petr Skoda [Thu, 2 Sep 2010 10:24:40 +0000 (10:24 +0000)]
MDL-23997 using strings instead of integers in binding emulation - this should be compatible both with int and nvarchar sql types
Dan Marsden [Thu, 2 Sep 2010 09:49:04 +0000 (09:49 +0000)]
Assignment MDL-23992 - use fullname instead of username for exported files to improve privacy
Aparup Banerjee [Thu, 2 Sep 2010 06:34:48 +0000 (06:34 +0000)]
lib MDL-23180 put in obviously missed global $CFG.
Aparup Banerjee [Thu, 2 Sep 2010 06:16:45 +0000 (06:16 +0000)]
assignment MDL-23998
clarified 'revert to draft' button in a advanced upload assignment with a help icon.
button 'no more submissions' changed to say 'Prevent submission updates'.
Andrew Davis [Thu, 2 Sep 2010 04:17:56 +0000 (04:17 +0000)]
gradebook MDL-24021 filter out deleted users from the user selector that is used in the user and overview report
Andrew Davis [Thu, 2 Sep 2010 04:09:31 +0000 (04:09 +0000)]
gradebook MDL-24021 re-added all users option to user report
Sam Hemelryk [Thu, 2 Sep 2010 03:22:46 +0000 (03:22 +0000)]
workshop MDL-24046 Fixed SQL error in workshop submission validation
Andrew Davis [Thu, 2 Sep 2010 02:38:29 +0000 (02:38 +0000)]
gradebook MDL-24045 added a guard for when the user report is accessed outside of a course context
Moodle Robot [Thu, 2 Sep 2010 00:49:59 +0000 (00:49 +0000)]
Updated the HEAD build version to
20100902
AMOS bot [Thu, 2 Sep 2010 00:40:09 +0000 (00:40 +0000)]
Automatic installer lang files (
20100902)
Sam Marshall [Wed, 1 Sep 2010 17:36:46 +0000 (17:36 +0000)]
blocks MDL-24040 Creating course fails horribly if you make one of the default blocks invisible
Sam Marshall [Wed, 1 Sep 2010 17:02:56 +0000 (17:02 +0000)]
Completion MDL-23995 Completion, availability data not deleted with modules/course
Petr Skoda [Wed, 1 Sep 2010 16:05:17 +0000 (16:05 +0000)]
MDL-23997 even more unittests detecting failures in sqlsrv driver
Petr Skoda [Wed, 1 Sep 2010 15:54:16 +0000 (15:54 +0000)]
MDL-23997 more unittests detecting failures in sqlsrv driver
Petr Skoda [Wed, 1 Sep 2010 08:37:46 +0000 (08:37 +0000)]
MDL-22657 fixed lost language selection in CLI installer
Petr Skoda [Wed, 1 Sep 2010 07:32:21 +0000 (07:32 +0000)]
MDL-23927 ensure CFG in scope before using, credit goes to Myles Carrick
Dongsheng Cai [Wed, 1 Sep 2010 06:17:01 +0000 (06:17 +0000)]
MDL-23308, change course files link name
Andrew Davis [Wed, 1 Sep 2010 04:46:23 +0000 (04:46 +0000)]
backup MDL-23362 another commit of gradebook restore
Dongsheng Cai [Wed, 1 Sep 2010 03:37:30 +0000 (03:37 +0000)]
MDL-24030, fixed url field type
jerome mouneyrac [Wed, 1 Sep 2010 03:18:15 +0000 (03:18 +0000)]
course publish MDL-24022 cast bool into int (enrollable field)
jerome mouneyrac [Wed, 1 Sep 2010 03:02:06 +0000 (03:02 +0000)]
course publish MDL-24022 cast bool into int (enrollable field)
Martin Dougiamas [Wed, 1 Sep 2010 02:57:09 +0000 (02:57 +0000)]
bulk user editing MDL-24029 Fixed missing CFG global
Moodle Robot [Wed, 1 Sep 2010 00:52:23 +0000 (00:52 +0000)]
Updated the HEAD build version to
20100901
Eloy Lafuente [Tue, 31 Aug 2010 09:17:11 +0000 (09:17 +0000)]
MDL-23362 backup - save grade_item orig category properly, my fault, sorry Andrew
Eloy Lafuente [Tue, 31 Aug 2010 09:15:38 +0000 (09:15 +0000)]
MDL-23362 backup - allow set_mapping() to specify one parentitemid to be saved
Andrew Davis [Tue, 31 Aug 2010 08:19:46 +0000 (08:19 +0000)]
rating MDL-23908 improved rating role tips help item
Andrew Davis [Tue, 31 Aug 2010 07:59:32 +0000 (07:59 +0000)]
rating MDL-23908 improved rating role tips
Aparup Banerjee [Tue, 31 Aug 2010 07:55:12 +0000 (07:55 +0000)]
assignment mdl-24001 fixed toggling the 'revert to draft'/ 'no more submissions' button in a advanced upload assignment grading form loses editing data.
Sam Hemelryk [Tue, 31 Aug 2010 05:40:27 +0000 (05:40 +0000)]
theme MDL-24013 Tiding up CSS and JS for IE compatability
Andrew Davis [Tue, 31 Aug 2010 04:14:01 +0000 (04:14 +0000)]
backup MDL-23362 another intermediate commit for gradebook backup
Sam Hemelryk [Tue, 31 Aug 2010 04:10:50 +0000 (04:10 +0000)]
NOBUG minor CSS adjustments for IE6.... grrrr IE6
Andrew Davis [Tue, 31 Aug 2010 03:51:10 +0000 (03:51 +0000)]
backup MDL-23362 another intermediate commit for gradebook backup
Dongsheng Cai [Tue, 31 Aug 2010 03:39:33 +0000 (03:39 +0000)]
MDL-23308, coursefiles repository plugin added
Sam Hemelryk [Tue, 31 Aug 2010 03:18:13 +0000 (03:18 +0000)]
NOBUG Tidied up the blocks CSS in the base theme, optimisation - no changes
Moodle Robot [Tue, 31 Aug 2010 00:51:35 +0000 (00:51 +0000)]
Updated the HEAD build version to
20100831
AMOS bot [Tue, 31 Aug 2010 00:40:09 +0000 (00:40 +0000)]
Automatic installer lang files (
20100831)
Dan Marsden [Tue, 31 Aug 2010 00:02:10 +0000 (00:02 +0000)]
SCORM MDL-23947 fix tests
Dan Marsden [Mon, 30 Aug 2010 23:45:53 +0000 (23:45 +0000)]
SCORM MDL-23947 change name of function
Eloy Lafuente [Mon, 30 Aug 2010 13:45:26 +0000 (13:45 +0000)]
NOBUG mssql driver, fix some wrong uses recently introduced