moodle.git
13 years agoMDL-19874 updated geoip to 1.80 and fixed iplookup regressions
skodak [Sun, 19 Jul 2009 13:54:11 +0000 (13:54 +0000)]
MDL-19874 updated geoip to 1.80 and fixed iplookup regressions

13 years agoevalmath is BSD, not GPL!
skodak [Sun, 19 Jul 2009 13:18:50 +0000 (13:18 +0000)]
evalmath is BSD, not GPL!

13 years agoMDL-19873 imported new SimplePie 1.2
skodak [Sun, 19 Jul 2009 13:14:44 +0000 (13:14 +0000)]
MDL-19873 imported new SimplePie 1.2

13 years agoMDL-19872 imported new TinyMCE 3.2.5
skodak [Sun, 19 Jul 2009 13:05:21 +0000 (13:05 +0000)]
MDL-19872 imported new TinyMCE 3.2.5

13 years agoMDL-19871 new parameter syntax from htmlpurifier 4.0.0
skodak [Sun, 19 Jul 2009 12:17:48 +0000 (12:17 +0000)]
MDL-19871 new parameter syntax from htmlpurifier 4.0.0

13 years agoMDL-19871 imported htmlpurifier 4.0.0
skodak [Sun, 19 Jul 2009 11:56:56 +0000 (11:56 +0000)]
MDL-19871 imported htmlpurifier 4.0.0

13 years agoMDL-19725 forgotten to update version in lib desc
skodak [Sun, 19 Jul 2009 11:54:35 +0000 (11:54 +0000)]
MDL-19725 forgotten to update version in lib desc

13 years agoMDL-19725 forgotten to update version in readme
skodak [Sun, 19 Jul 2009 10:43:21 +0000 (10:43 +0000)]
MDL-19725 forgotten to update version in readme

13 years agoMDL-14589 added missing require_login()
skodak [Sun, 19 Jul 2009 08:56:45 +0000 (08:56 +0000)]
MDL-14589 added missing require_login()

13 years agoUpdated the HEAD build version to 20090719
moodlerobot [Sun, 19 Jul 2009 00:35:41 +0000 (00:35 +0000)]
Updated the HEAD build version to 20090719

13 years agoImprove comment. Thanks David Mudrak.
tjhunt [Sat, 18 Jul 2009 11:59:17 +0000 (11:59 +0000)]
Improve comment. Thanks David Mudrak.

13 years agoUpdated the HEAD build version to 20090718
moodlerobot [Sat, 18 Jul 2009 00:35:28 +0000 (00:35 +0000)]
Updated the HEAD build version to 20090718

13 years agoMDL-19842 securing algebradebug the same way as text debug - only admins may use...
skodak [Fri, 17 Jul 2009 08:33:23 +0000 (08:33 +0000)]
MDL-19842 securing algebradebug the same way as text debug - only admins may use it now

13 years agoClean up some more todos.
tjhunt [Fri, 17 Jul 2009 08:26:13 +0000 (08:26 +0000)]
Clean up some more todos.

13 years agoblock/search: Eliminate todo that was already done, and clean up whitespace.
tjhunt [Fri, 17 Jul 2009 08:07:50 +0000 (08:07 +0000)]
block/search: Eliminate todo that was already done, and clean up whitespace.

13 years agoadmin block: MDL-16693 fix todo.
tjhunt [Fri, 17 Jul 2009 07:46:04 +0000 (07:46 +0000)]
admin block: MDL-16693 fix todo.

13 years agoadmin bookmarks: remove useless todo.
tjhunt [Fri, 17 Jul 2009 07:42:21 +0000 (07:42 +0000)]
admin bookmarks: remove useless todo.

13 years agotodochecker: don't match variables called $todo or fields called ->todo.
tjhunt [Fri, 17 Jul 2009 07:40:54 +0000 (07:40 +0000)]
todochecker: don't match variables called $todo or fields called ->todo.

13 years agoClarify commenst in backup, to make it clear what is acutally a TODO, and what is...
tjhunt [Fri, 17 Jul 2009 07:40:38 +0000 (07:40 +0000)]
Clarify commenst in backup, to make it clear what is acutally a TODO, and what is a reference to the $todo variable.

I would like to suggest that $todo is not a great variable name!

13 years agotodochecker: Match todo case-insensitively :-( that finds a lot more.
tjhunt [Fri, 17 Jul 2009 07:26:12 +0000 (07:26 +0000)]
todochecker: Match todo case-insensitively :-( that finds a lot more.

13 years agotodochecker: bug summary in tool tip.
tjhunt [Fri, 17 Jul 2009 07:19:43 +0000 (07:19 +0000)]
todochecker: bug summary in tool tip.

13 years agoquiz: add tracker id to TODO.
tjhunt [Fri, 17 Jul 2009 07:06:53 +0000 (07:06 +0000)]
quiz: add tracker id to TODO.

13 years agoquiz: remove incorrect TODO.
tjhunt [Fri, 17 Jul 2009 07:02:13 +0000 (07:02 +0000)]
quiz: remove incorrect TODO.

13 years agoquiz manual grading: Remove todo that was already done!
tjhunt [Fri, 17 Jul 2009 07:00:16 +0000 (07:00 +0000)]
quiz manual grading: Remove todo that was already done!

13 years agoquiz editing: Remove unnecessary TODO.
tjhunt [Fri, 17 Jul 2009 06:56:33 +0000 (06:56 +0000)]
quiz editing: Remove unnecessary TODO.

13 years agoquiz editing: MDL-17730 need better skip links on the quiz editing page.
tjhunt [Fri, 17 Jul 2009 06:54:58 +0000 (06:54 +0000)]
quiz editing: MDL-17730 need better skip links on the quiz editing page.

13 years agothemes: MDL-19077 better handling of top of body code for legacy themes.
tjhunt [Fri, 17 Jul 2009 06:51:25 +0000 (06:51 +0000)]
themes: MDL-19077 better handling of top of body code for legacy themes.

13 years agotodochecker script: skip third party code.
tjhunt [Fri, 17 Jul 2009 05:56:49 +0000 (05:56 +0000)]
todochecker script: skip third party code.

13 years agoadmin: broken icons on question type page.
tjhunt [Fri, 17 Jul 2009 05:51:52 +0000 (05:51 +0000)]
admin: broken icons on question type page.

13 years agoformslib: moodleform_mod needs to be abstract too.
tjhunt [Fri, 17 Jul 2009 03:40:40 +0000 (03:40 +0000)]
formslib: moodleform_mod needs to be abstract too.
(See one of the commits I made yesterday.)

13 years agoUpdated the HEAD build version to 20090717
moodlerobot [Fri, 17 Jul 2009 00:38:06 +0000 (00:38 +0000)]
Updated the HEAD build version to 20090717

13 years agoblocks editing ui: MDL-19398 Can now edit the position of any block.
tjhunt [Thu, 16 Jul 2009 11:05:26 +0000 (11:05 +0000)]
blocks editing ui: MDL-19398 Can now edit the position of any block.
I think this is probaby insecure at the moment. I am still working on it.

13 years agoblocks editing ui: MDL-19398 Can how precisely control block positioning using the...
tjhunt [Thu, 16 Jul 2009 10:50:19 +0000 (10:50 +0000)]
blocks editing ui: MDL-19398 Can how precisely control block positioning using the edit icon
This mostly works now, but ...
* The UI needs further work. In particular we need a non-advanced mode.
* This only works for blocks that use a new edit_form.php to replace config_instance.html.
* .. and so far I have only implemented edit_form.php for the HTML block so far.
* Needs to be enabled (with no block-specific config) for blocks without instance config, so you can control their positioning.

13 years agoformslib: use abstract, rather than a print_error, now we have PHP5.
tjhunt [Thu, 16 Jul 2009 10:38:15 +0000 (10:38 +0000)]
formslib: use abstract, rather than a print_error, now we have PHP5.

13 years agoMDL-19832 new mimeTeX binaries v1.70
skodak [Thu, 16 Jul 2009 09:48:17 +0000 (09:48 +0000)]
MDL-19832 new mimeTeX binaries v1.70

13 years agoMDL-19841 removed sloppy hardcoded debug levels
skodak [Thu, 16 Jul 2009 09:05:15 +0000 (09:05 +0000)]
MDL-19841 removed sloppy hardcoded debug levels

13 years agoMDL-19840 Fixed a bug in regex delimiter quoting
nicolasconnault [Thu, 16 Jul 2009 03:21:19 +0000 (03:21 +0000)]
MDL-19840 Fixed a bug in regex delimiter quoting

13 years agoUpdated the HEAD build version to 20090716
moodlerobot [Thu, 16 Jul 2009 00:38:53 +0000 (00:38 +0000)]
Updated the HEAD build version to 20090716

13 years agoMDL-19827: Completioninfo bugfix
sam_marshall [Wed, 15 Jul 2009 14:19:24 +0000 (14:19 +0000)]
MDL-19827: Completioninfo bugfix

13 years agoFix boilerplate.
tjhunt [Wed, 15 Jul 2009 08:59:51 +0000 (08:59 +0000)]
Fix boilerplate.

13 years agoblocks editing ui: MDL-19398 Remove stupid pass by reference.
tjhunt [Wed, 15 Jul 2009 08:55:52 +0000 (08:55 +0000)]
blocks editing ui: MDL-19398 Remove stupid pass by reference.
Was causing errors when this method was called via block_method_result

13 years agoblocks editing ui: MDL-19398 Make block config_global.html files more strongly deprec...
tjhunt [Wed, 15 Jul 2009 08:52:33 +0000 (08:52 +0000)]
blocks editing ui: MDL-19398 Make block config_global.html files more strongly deprecated.

13 years agoblocks editing ui: MDL-19398 block.multiple column no longer exists, so remove admin...
tjhunt [Wed, 15 Jul 2009 08:24:12 +0000 (08:24 +0000)]
blocks editing ui: MDL-19398 block.multiple column no longer exists, so remove admin for it.

13 years agoMDL-19785 temp fix for undefined completioninfo
skodak [Wed, 15 Jul 2009 08:11:28 +0000 (08:11 +0000)]
MDL-19785 temp fix for undefined completioninfo

13 years agoblocks editing ui: MDL-19398 Make invisible blocks at least partly invisible.
tjhunt [Wed, 15 Jul 2009 07:45:48 +0000 (07:45 +0000)]
blocks editing ui: MDL-19398 Make invisible blocks at least partly invisible.

13 years agoblocks editing ui: MDL-19398 showing and hiding blocks now works.
tjhunt [Wed, 15 Jul 2009 07:41:25 +0000 (07:41 +0000)]
blocks editing ui: MDL-19398 showing and hiding blocks now works.

13 years agoblocks editing ui: MDL-19398 give users a path back after assigning block roles
tjhunt [Wed, 15 Jul 2009 06:33:13 +0000 (06:33 +0000)]
blocks editing ui: MDL-19398 give users a path back after assigning block roles

13 years agomoodlellib: MDL-19828 PARAM_LOCALURL should accept URLs like course/view.php?id=2
tjhunt [Wed, 15 Jul 2009 06:17:39 +0000 (06:17 +0000)]
moodlellib: MDL-19828 PARAM_LOCALURL should accept URLs like course/view.php?id=2

13 years agomoodle_page: MDL-12212 misspelling
jerome [Wed, 15 Jul 2009 06:11:55 +0000 (06:11 +0000)]
moodle_page: MDL-12212  misspelling

13 years agofilters admin: Re-fix heading.
tjhunt [Wed, 15 Jul 2009 05:40:15 +0000 (05:40 +0000)]
filters admin: Re-fix heading.

13 years agooutputlib tables: MDL-19755 fix all cases of deprecated $table->rowclass
tjhunt [Wed, 15 Jul 2009 05:37:31 +0000 (05:37 +0000)]
outputlib tables: MDL-19755 fix all cases of deprecated $table->rowclass

Also fix wrong title on Manage filters admin page.

13 years agoquestion bank: MDL-19826 Merge from MOODLE_19_STABLE.
tjhunt [Wed, 15 Jul 2009 04:06:03 +0000 (04:06 +0000)]
question bank: MDL-19826 Merge from MOODLE_19_STABLE.

13 years agoweblib: Let redirect() take a moodle_url object.
tjhunt [Wed, 15 Jul 2009 04:05:05 +0000 (04:05 +0000)]
weblib: Let redirect() take a moodle_url object.

13 years agoMDL-19808 Upgraded view.php to new pagelib and outputlib APIs
nicolasconnault [Wed, 15 Jul 2009 02:54:40 +0000 (02:54 +0000)]
MDL-19808 Upgraded view.php to new pagelib and outputlib APIs

13 years agoFix CVS drift
Moodle HQ git importer [Wed, 15 Jul 2009 00:37:05 +0000 (00:37 +0000)]
Fix CVS drift

13 years agoUpdated the HEAD build version to 20090715
moodlerobot [Wed, 15 Jul 2009 00:37:05 +0000 (00:37 +0000)]
Updated the HEAD build version to 20090715

13 years agoMDL-19692: Completion tracking help icon enhancements
sam_marshall [Tue, 14 Jul 2009 14:00:34 +0000 (14:00 +0000)]
MDL-19692: Completion tracking help icon enhancements

13 years agoblocks editing ui: MDL-19398 permissions checks when deleting a block.
tjhunt [Tue, 14 Jul 2009 11:16:21 +0000 (11:16 +0000)]
blocks editing ui: MDL-19398 permissions checks when deleting a block.

13 years agoblocks editing ui: MDL-19398 move generating the block edit icons to blocklib.php
tjhunt [Tue, 14 Jul 2009 10:57:06 +0000 (10:57 +0000)]
blocks editing ui: MDL-19398 move generating the block edit icons to blocklib.php
Since that is where the resulting actions are processed.

13 years agoblocks editing ui: MDL-19398 fix adding a block to a page that forgets to call $PAGE...
tjhunt [Tue, 14 Jul 2009 10:41:59 +0000 (10:41 +0000)]
blocks editing ui: MDL-19398 fix adding a block to a page that forgets to call $PAGE->set_url.

13 years agoforum: $PAGE->set_url on forum view page.
tjhunt [Tue, 14 Jul 2009 09:36:02 +0000 (09:36 +0000)]
forum: $PAGE->set_url on forum view page.

13 years agofix typo
tjhunt [Tue, 14 Jul 2009 09:35:33 +0000 (09:35 +0000)]
fix typo

13 years agoblocks editing ui: MDL-19398 fix some bugs with adding a block.
tjhunt [Tue, 14 Jul 2009 09:28:10 +0000 (09:28 +0000)]
blocks editing ui: MDL-19398 fix some bugs with adding a block.

13 years agoblocks editing ui: MDL-19398 add block now secure. Delete block works insecurely.
tjhunt [Tue, 14 Jul 2009 08:37:28 +0000 (08:37 +0000)]
blocks editing ui: MDL-19398 add block now secure. Delete block works insecurely.
Will add security checks in a moment.

13 years agoblocks: MDL-19010 Delete weird line of legacy code.
tjhunt [Tue, 14 Jul 2009 08:36:40 +0000 (08:36 +0000)]
blocks: MDL-19010 Delete weird line of legacy code.

13 years agosetuplib: early errors were not showing debuginfo.
tjhunt [Tue, 14 Jul 2009 08:31:30 +0000 (08:31 +0000)]
setuplib: early errors were not showing debuginfo.

13 years agoMDL-16075 fixed incomplete conversion of glossary comments
skodak [Tue, 14 Jul 2009 08:26:45 +0000 (08:26 +0000)]
MDL-16075 fixed incomplete conversion of glossary comments

13 years agoMDL-14589 fixed incorrect condition testing if files allowed when postprocessing...
skodak [Tue, 14 Jul 2009 08:25:51 +0000 (08:25 +0000)]
MDL-14589 fixed incorrect condition testing if files allowed when postprocessing editor element data, thanks Nicolas for reporting this

13 years agoblocks editing ui: MDL-19398 you can now add new blocks!
tjhunt [Tue, 14 Jul 2009 07:18:57 +0000 (07:18 +0000)]
blocks editing ui: MDL-19398 you can now add new blocks!

13 years agoblocks: MDL-19010 show empty blocks if they have controls.
tjhunt [Tue, 14 Jul 2009 07:06:06 +0000 (07:06 +0000)]
blocks: MDL-19010 show empty blocks if they have controls.

13 years agoMDL-16089 new general page type needed for framed resources, this is not accessible...
skodak [Tue, 14 Jul 2009 06:33:34 +0000 (06:33 +0000)]
MDL-16089 new general page type needed for framed resources, this is not accessible but unfortunately it works much better than object embedding; it will be also used by phpmyadmin integration

13 years agothemes: MDL-19077 Don't need both output_starting_hook and starting_output method...
tjhunt [Tue, 14 Jul 2009 05:14:45 +0000 (05:14 +0000)]
themes: MDL-19077 Don't need both output_starting_hook and starting_output method on page.

13 years agoFix block manager unit tests.
tjhunt [Tue, 14 Jul 2009 04:18:58 +0000 (04:18 +0000)]
Fix block manager unit tests.

13 years agoUpdated the HEAD build version to 20090714
moodlerobot [Tue, 14 Jul 2009 00:38:40 +0000 (00:38 +0000)]
Updated the HEAD build version to 20090714

13 years agoMDL-19755 fixed regression - no class test must be done before adding allign classes ;-)
skodak [Mon, 13 Jul 2009 20:33:56 +0000 (20:33 +0000)]
MDL-19755 fixed regression - no class test must be done before adding allign classes ;-)

13 years agoMDL-19755 print_table replaced with $OUTPUT->table
mudrd8mz [Mon, 13 Jul 2009 11:10:30 +0000 (11:10 +0000)]
MDL-19755 print_table replaced with $OUTPUT->table

rowclass property has been deprecated, rowclasses should be used.
Direct assigning of the class has been deprecated,
moodle_html_elements::set_classes() should be used instead. In both
cases, debugging message is displayed.

13 years agoblock contexts: MDL-19098 every block should have a context
tjhunt [Mon, 13 Jul 2009 08:37:34 +0000 (08:37 +0000)]
block contexts: MDL-19098 every block should have a context
even non-course and sticky blocks.

The parent context is block_instances.parentcontextid.

The block context should be used for checking permissions directly
related to the block, like moodle/block:view or moodle/site:manageblocks.

However, if the block is displaying information about the current page,
for example the participants block showing who 'here', then it may be
better to use the context of the page where the bloack is appearing -
in other words $this->page->context - to check permissions about the
user's ability to see participants here.

Or, if the block is displaying something stronly related to courses,
for example, a course meny block, the block should probably use the
context for $this->page->course to check permissions.

13 years agothemes: MDL-19077 Don't us $OUTPUT in debugging.
tjhunt [Mon, 13 Jul 2009 06:16:48 +0000 (06:16 +0000)]
themes: MDL-19077 Don't us $OUTPUT in debugging.

13 years agothemes: MDL-19077 fix bugs in cli_renderer. Use correct doctype with legacy header...
tjhunt [Mon, 13 Jul 2009 06:10:03 +0000 (06:10 +0000)]
themes: MDL-19077 fix bugs in cli_renderer. Use correct doctype with legacy header.html.

13 years agocron: MDL-19774 temporary hack so cron does not crash.
tjhunt [Mon, 13 Jul 2009 06:08:48 +0000 (06:08 +0000)]
cron: MDL-19774 temporary hack so cron does not crash.

13 years agofeedback MDL-19773 - temporary work-around so cron can run.
tjhunt [Mon, 13 Jul 2009 05:44:35 +0000 (05:44 +0000)]
feedback MDL-19773 - temporary work-around so cron can run.
This still needs to be fixed properly.

13 years agodeveloper tools MDL-19772: Script to list all todos in code
tjhunt [Mon, 13 Jul 2009 04:27:05 +0000 (04:27 +0000)]
developer tools MDL-19772: Script to list all todos in code

And make sure they link to an open tracker issue as per
http://docs.moodle.org/en/Development:Coding_style#TODO_comments_must_link_to_a_tracker_issue

13 years agothemes: MDL-19077 $OUTPUT->header does the main skip destination, layout.php should...
tjhunt [Mon, 13 Jul 2009 04:24:29 +0000 (04:24 +0000)]
themes: MDL-19077 $OUTPUT->header does the main skip destination, layout.php should now.

13 years agoanomaly theme: XHTML strict.
tjhunt [Mon, 13 Jul 2009 04:23:39 +0000 (04:23 +0000)]
anomaly theme: XHTML strict.

13 years agothemes: MDL-19077 - Incorrect initialisation order for user/editadvanced.php
tjhunt [Mon, 13 Jul 2009 04:21:15 +0000 (04:21 +0000)]
themes: MDL-19077 - Incorrect initialisation order for user/editadvanced.php

13 years agoUpdated the HEAD build version to 20090713
moodlerobot [Mon, 13 Jul 2009 00:38:07 +0000 (00:38 +0000)]
Updated the HEAD build version to 20090713

13 years agoAutomatic installer.php lang files by installer_builder (20090713)
moodlerobot [Mon, 13 Jul 2009 00:27:41 +0000 (00:27 +0000)]
installer.php lang files by installer_builder (20090713)

13 years agoUpdated the HEAD build version to 20090712
moodlerobot [Sun, 12 Jul 2009 00:37:38 +0000 (00:37 +0000)]
Updated the HEAD build version to 20090712

13 years agoUpdated the HEAD build version to 20090711
moodlerobot [Sat, 11 Jul 2009 00:37:27 +0000 (00:37 +0000)]
Updated the HEAD build version to 20090711

13 years agoupgrade: MDL-19763 Improve the redirect that forces a DB upgrade when there are major...
tjhunt [Fri, 10 Jul 2009 08:44:01 +0000 (08:44 +0000)]
upgrade: MDL-19763 Improve the redirect that forces a DB upgrade when there are major changes

Also fix redirect, so 303 redirects don't need to fully initialise $OUTPUT.

13 years agoweblib MDL-19750 Fixed regression caused by implementing new PAGE methods
samhemelryk [Fri, 10 Jul 2009 08:08:17 +0000 (08:08 +0000)]
weblib MDL-19750 Fixed regression caused by implementing new PAGE methods

13 years agoMDL-19010 fixed redirect at login page if upgrade required, otherwise it would end...
skodak [Fri, 10 Jul 2009 08:08:00 +0000 (08:08 +0000)]
MDL-19010 fixed redirect at login page if upgrade required, otherwise it would end with exception due to DB structure changes

13 years agoMDL-19010 fixed redirect at main page if upgrade required, otherwise it would end...
skodak [Fri, 10 Jul 2009 08:03:06 +0000 (08:03 +0000)]
MDL-19010 fixed redirect at main page if upgrade required, otherwise it would end with exception due to DB structure changes

13 years agooutput MDL-19077 typo bug on $debugdisableredirect
jerome [Fri, 10 Jul 2009 07:08:12 +0000 (07:08 +0000)]
output MDL-19077  typo bug on $debugdisableredirect

13 years agoblocks MDL-19536: rename block_instances.contextid to parentcontextid to avoid gross...
tjhunt [Fri, 10 Jul 2009 05:58:59 +0000 (05:58 +0000)]
blocks MDL-19536: rename block_instances.contextid to parentcontextid to avoid gross confusion

13 years agoClarify comment.
tjhunt [Fri, 10 Jul 2009 05:42:54 +0000 (05:42 +0000)]
Clarify comment.

13 years agoRemove unnecessary 'none' passed to footer.
tjhunt [Fri, 10 Jul 2009 05:37:36 +0000 (05:37 +0000)]
Remove unnecessary 'none' passed to footer.

13 years agoFix comment.
tjhunt [Fri, 10 Jul 2009 03:39:09 +0000 (03:39 +0000)]
Fix comment.

13 years agosetup: Need memory before setup_DB.
tjhunt [Fri, 10 Jul 2009 03:31:30 +0000 (03:31 +0000)]
setup: Need memory before setup_DB.

!This is the correct version of the previous commit!

I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
  get_string -> string_manager->__construct -> get_plugin_types

That loads lib.php from every module, which runs out of memeory.

13 years agosetup: Need memory before setup_DB.
tjhunt [Fri, 10 Jul 2009 03:30:43 +0000 (03:30 +0000)]
setup: Need memory before setup_DB.

I was getting an interesting failure with $CFG->prefix commented
out in config.php (by mistake!). Abbreviated stack trace
lib/setup.php -> setup_DB -> dml_exception('prefixcannotbeempty') ->
  get_string -> string_manager->__construct -> get_plugin_types

That loads lib.php from every module, which runs out of memeory.