moodle.git
10 years agoMDL-24955 prevent infinite redirect loop when not enrolled and self enrol not available
Petr Skoda [Tue, 9 Nov 2010 01:53:28 +0000 (01:53 +0000)]
MDL-24955 prevent infinite redirect loop when not enrolled and self enrol not available

10 years agoMDL-25072 themes may disable ajax course edit
Petr Skoda [Tue, 9 Nov 2010 01:28:43 +0000 (01:28 +0000)]
MDL-25072 themes may disable ajax course edit

10 years agoUpdated the HEAD build version to 20101109
Moodle Robot [Tue, 9 Nov 2010 00:49:40 +0000 (00:49 +0000)]
Updated the HEAD build version to 20101109

10 years agoAutomatic installer lang files (20101109)
AMOS bot [Tue, 9 Nov 2010 00:40:10 +0000 (00:40 +0000)]
Automatic installer lang files (20101109)

10 years agoMDL-25104 Fixing some other error about $files in $instructions param of numerical
Pierre Pichet [Tue, 9 Nov 2010 00:02:57 +0000 (00:02 +0000)]
MDL-25104 Fixing some other  error about  $files in $instructions param of numerical

10 years agoMDL-25104 Fixing some litle errors about $instructions param of numerical
Pierre Pichet [Mon, 8 Nov 2010 20:58:32 +0000 (20:58 +0000)]
MDL-25104 Fixing some litle errors about  $instructions param of numerical

10 years agoquestion XML import MDL-25104 fix a whole bunch of minor errors.
Tim Hunt [Mon, 8 Nov 2010 17:25:53 +0000 (17:25 +0000)]
question XML import MDL-25104 fix a whole bunch of minor errors.

10 years agoAdmin MDL-23244 Portfolio/repo admin pages use nested forms, which are illegal HTML...
Sam Marshall [Mon, 8 Nov 2010 17:12:03 +0000 (17:12 +0000)]
Admin MDL-23244 Portfolio/repo admin pages use nested forms, which are illegal HTML and cause first dropdown on page to break

10 years agoquestion bank MDL-24312 problem when deleting a course with orphaned categories.
Tim Hunt [Mon, 8 Nov 2010 15:55:45 +0000 (15:55 +0000)]
question bank MDL-24312 problem when deleting a course with orphaned categories.

When there was a question category whose parent had somehow been deleted from the question bank, while the child category was still there, then that gave an error because a DB query was still referring to the question_categories.courese coloumn, that was changed to contextid in moodle 1.9.

Fix thanks to Mahmoud Kassaei.

10 years agoxml import/export MDL-25103 was not working due to out-of-memory errors when calling...
Tim Hunt [Mon, 8 Nov 2010 15:51:10 +0000 (15:51 +0000)]
xml import/export MDL-25103 was not working due to out-of-memory errors when calling xmltidy, which broke XML wellformedness.

The solution is to not tidy the XML. The XML generated is already quite well laid out, and if we want it better, we should fix that, rather than trying to load the whole file into memory to reformat it.

Also, while investigating this, I found that we were not handling the mime-type of the exported file very elegantly, so I added a new mime_type method (defaults to getting the mime type of the file extension).

10 years agocanvas theme MDL-23664 get rid of ugly black borders round questions.
Tim Hunt [Mon, 8 Nov 2010 14:06:28 +0000 (14:06 +0000)]
canvas theme MDL-23664 get rid of ugly black borders round questions.

10 years agoadmin purge caches MDL-24591 (part) make the redirect go somewhere sensible.
Tim Hunt [Mon, 8 Nov 2010 13:42:01 +0000 (13:42 +0000)]
admin purge caches MDL-24591 (part) make the redirect go somewhere sensible.

10 years agoweblib NOBUG Add a comment to clarify that moodle_url deals with $CFG->admin for...
Tim Hunt [Mon, 8 Nov 2010 13:33:08 +0000 (13:33 +0000)]
weblib NOBUG Add a comment to clarify that moodle_url deals with $CFG->admin for you.

10 years agoActivity completion MDL-24746 If you turn on autocompletion for an activity after...
Sam Marshall [Mon, 8 Nov 2010 11:51:19 +0000 (11:51 +0000)]
Activity completion MDL-24746 If you turn on autocompletion for an activity after users have already done things that should complete it, it didn't mark them complete

10 years agoUnit tests MDL-24980 Initial fix (no fully working yet) for portfolioaddbutton test
Sam Marshall [Mon, 8 Nov 2010 11:07:09 +0000 (11:07 +0000)]
Unit tests MDL-24980 Initial fix (no fully working yet) for portfolioaddbutton test

10 years agogradebook MDL-24867 now hiding some items from the gradebook nav box if youre not...
Andrew Davis [Mon, 8 Nov 2010 08:23:24 +0000 (08:23 +0000)]
gradebook MDL-24867 now hiding some items from the gradebook nav box if youre not within a course

10 years agoMDL-23138 WIKI removed standard_head_html, use standard $OUTPUT->header()
Dongsheng Cai [Mon, 8 Nov 2010 08:16:26 +0000 (08:16 +0000)]
MDL-23138 WIKI  removed standard_head_html, use standard $OUTPUT->header()

10 years agoMDL-23134, use foreach to read recordset instead of valid(), next()
Dongsheng Cai [Mon, 8 Nov 2010 08:05:15 +0000 (08:05 +0000)]
MDL-23134, use foreach to read recordset instead of valid(), next()

10 years agoMDL-25097, fixed CSRF in chat_ajax.php
Dongsheng Cai [Mon, 8 Nov 2010 07:59:55 +0000 (07:59 +0000)]
MDL-25097, fixed CSRF in chat_ajax.php

10 years agoMDL-23135, added defined('MOODLE_INTERNAL') || die; to old ewiki code
Dongsheng Cai [Mon, 8 Nov 2010 07:52:54 +0000 (07:52 +0000)]
MDL-23135, added defined('MOODLE_INTERNAL') || die; to old ewiki code

10 years agoMDL-23139, fixed CSRF in wiki editing page
Dongsheng Cai [Mon, 8 Nov 2010 07:43:18 +0000 (07:43 +0000)]
MDL-23139, fixed CSRF in wiki editing page

10 years agomessage MDL-24788 added brackets around the automatically appended part of the jabber...
Andrew Davis [Mon, 8 Nov 2010 06:50:20 +0000 (06:50 +0000)]
message MDL-24788 added brackets around the automatically appended part of the jabber notification

10 years agoMDL-23395, go straight to page editing page when title is not empyt and forceformat...
Dongsheng Cai [Mon, 8 Nov 2010 06:33:00 +0000 (06:33 +0000)]
MDL-23395, go straight to page editing page when title is not empyt and forceformat is set

10 years agoMDL-25069 CHAT added events definition file
Dongsheng Cai [Mon, 8 Nov 2010 06:03:00 +0000 (06:03 +0000)]
MDL-25069 CHAT added events definition file

10 years agogradebook MDL-25083 contents of user idnumber column wasnt being set correctly
Andrew Davis [Mon, 8 Nov 2010 05:45:21 +0000 (05:45 +0000)]
gradebook MDL-25083 contents of user idnumber column wasnt being set correctly

10 years agoblocks MDL-25093 fixed an error that meant that the course limit wasnt being applied...
Andrew Davis [Mon, 8 Nov 2010 05:27:04 +0000 (05:27 +0000)]
blocks MDL-25093 fixed an error that meant that the course limit wasnt being applied in the course overview

10 years agoMDL-25031 ignore invalid block instances
Petr Skoda [Mon, 8 Nov 2010 03:28:54 +0000 (03:28 +0000)]
MDL-25031 ignore invalid block instances
pagetypepattern can not be null, so we ignore these until we find a way to fix them properly, sorry

10 years agomessage MDL-25095 increased the size of the message fragment displayed in the message...
Andrew Davis [Mon, 8 Nov 2010 03:10:30 +0000 (03:10 +0000)]
message MDL-25095 increased the size of the message fragment displayed in the message search

10 years agouser MDL-25094 adding message link to the user course profile page
Andrew Davis [Mon, 8 Nov 2010 02:55:05 +0000 (02:55 +0000)]
user MDL-25094 adding message link to the user course profile page

10 years agoMDL-25069 CHAT added event handler to handler user logout event.
Dongsheng Cai [Mon, 8 Nov 2010 02:54:42 +0000 (02:54 +0000)]
MDL-25069 CHAT added event handler to handler user logout event.

10 years agoMDL-24781, repository, force context-type to text/html
Dongsheng Cai [Mon, 8 Nov 2010 02:42:28 +0000 (02:42 +0000)]
MDL-24781, repository, force context-type to text/html

10 years agoglobal search MDL-25056 fixed some incorrect PARAM types.
Aparup Banerjee [Mon, 8 Nov 2010 02:08:18 +0000 (02:08 +0000)]
global search MDL-25056 fixed some incorrect PARAM types.

10 years agotheme-anomaly MDL-22914 Fixed up minor rounded corner alignment issues in anomaly.
Sam Hemelryk [Mon, 8 Nov 2010 01:44:40 +0000 (01:44 +0000)]
theme-anomaly MDL-22914 Fixed up minor rounded corner alignment issues in anomaly.

10 years agotheme-formal_white MDL-25090 Fixed region width problem. Thanks Daniele for the solution.
Sam Hemelryk [Mon, 8 Nov 2010 01:27:02 +0000 (01:27 +0000)]
theme-formal_white MDL-25090 Fixed region width problem. Thanks Daniele for the solution.

10 years agoUpdated the HEAD build version to 20101108
Moodle Robot [Mon, 8 Nov 2010 00:49:51 +0000 (00:49 +0000)]
Updated the HEAD build version to 20101108

10 years agoMDL-22498 - removed padding from all .content areas
Patrick Malley [Sun, 7 Nov 2010 19:39:10 +0000 (19:39 +0000)]
MDL-22498 - removed padding from all .content areas

10 years agoAdded z-index to helppopupbox
Patrick Malley [Sun, 7 Nov 2010 19:32:27 +0000 (19:32 +0000)]
Added z-index to helppopupbox

10 years agoUpdated the HEAD build version to 20101107
Moodle Robot [Sun, 7 Nov 2010 00:48:58 +0000 (00:48 +0000)]
Updated the HEAD build version to 20101107

10 years agoFixing drift between CVS and git
Moodle HQ git importer [Sat, 6 Nov 2010 15:38:36 +0000 (15:38 +0000)]
Fixing drift between CVS and git

10 years agoMDL-25086 numerical options for numerical questions, calculated and 1,9 import withou...
Pierre Pichet [Sat, 6 Nov 2010 15:38:36 +0000 (15:38 +0000)]
MDL-25086 numerical options for numerical questions, calculated and 1,9 import without images...

10 years agoMDL-25086 first modifications, numerical options for numerical questions
Pierre Pichet [Sat, 6 Nov 2010 02:16:07 +0000 (02:16 +0000)]
MDL-25086 first modifications, numerical options for numerical questions

10 years agoUpdated the HEAD build version to 20101106
Moodle Robot [Sat, 6 Nov 2010 00:48:08 +0000 (00:48 +0000)]
Updated the HEAD build version to 20101106

10 years agoAutomatic installer lang files (20101106)
AMOS bot [Sat, 6 Nov 2010 00:40:10 +0000 (00:40 +0000)]
Automatic installer lang files (20101106)

10 years agoglobal search MDL-25056 fixed refering to $CFG->var when it isn't set yet.
Aparup Banerjee [Fri, 5 Nov 2010 09:55:25 +0000 (09:55 +0000)]
global search MDL-25056 fixed refering to $CFG->var when it isn't set yet.

10 years agotypo fix
Helen Foster [Fri, 5 Nov 2010 09:48:36 +0000 (09:48 +0000)]
typo fix

10 years agoMDL-21559: fixed force password change for internal and external authentication in...
Rossiani Wijaya [Fri, 5 Nov 2010 09:26:05 +0000 (09:26 +0000)]
MDL-21559: fixed force password change for internal and external authentication in user upload.
additional note: initialize user object for required fields (columns)

10 years agoglobal search MDL-25056 added a port of the global_config.html to settings.php. Leavi...
Aparup Banerjee [Fri, 5 Nov 2010 08:53:57 +0000 (08:53 +0000)]
global search MDL-25056 added a port of the global_config.html to settings.php. Leaving the html file behind for regression checks.

10 years agoNOBUG fixed infinite loop when zlib compression enabled revisited
Petr Skoda [Fri, 5 Nov 2010 08:44:51 +0000 (08:44 +0000)]
NOBUG fixed infinite loop when zlib compression enabled revisited

10 years agoMDL-21559: fixed force password change for internal and external authentication in...
Rossiani Wijaya [Fri, 5 Nov 2010 08:41:53 +0000 (08:41 +0000)]
MDL-21559: fixed force password change for internal and external authentication in user upload.

10 years agoNOBUG: Fixed minor navigation issue
Sam Hemelryk [Fri, 5 Nov 2010 08:40:45 +0000 (08:40 +0000)]
NOBUG: Fixed minor navigation issue

10 years agoNOBUG fixed infinite loop when zlib compression enabled
Petr Skoda [Fri, 5 Nov 2010 08:32:36 +0000 (08:32 +0000)]
NOBUG fixed infinite loop when zlib compression enabled

10 years agomessage MDL-24694 removed references to user->emailstop. the column itself will be...
Andrew Davis [Fri, 5 Nov 2010 08:04:40 +0000 (08:04 +0000)]
message MDL-24694 removed references to user->emailstop. the column itself will be removed in a later version

10 years agomod-forum MDL-24895 Fixed up CSS classes in forum posts
Sam Hemelryk [Fri, 5 Nov 2010 07:53:08 +0000 (07:53 +0000)]
mod-forum MDL-24895 Fixed up CSS classes in forum posts

10 years agoMDL-25053 invalid SQL syntax
Petr Skoda [Fri, 5 Nov 2010 07:29:24 +0000 (07:29 +0000)]
MDL-25053 invalid SQL syntax
postgresql requires AS when defining column aliases, credit goes to Alan Peter Carter

10 years agoNOBUG: Turned off zlib compression when serving javascript files.
Sam Hemelryk [Fri, 5 Nov 2010 07:03:05 +0000 (07:03 +0000)]
NOBUG: Turned off zlib compression when serving javascript files.

10 years agowebservice MDL-18655 add new capability moodle/user:viewalldetails allowing to see...
jerome mouneyrac [Fri, 5 Nov 2010 06:55:43 +0000 (06:55 +0000)]
webservice MDL-18655 add new capability moodle/user:viewalldetails allowing to see all user information. This capability is set up copying the current moodle/user:update assignations

10 years agothemes MDL-24895 Fixed phantom scroll bar bug that was occurring on OSX Firefox,...
Sam Hemelryk [Fri, 5 Nov 2010 06:37:06 +0000 (06:37 +0000)]
themes MDL-24895 Fixed phantom scroll bar bug that was occurring on OSX Firefox, Chrome, and Safari

10 years agoMDL-15573, question export rewrite
Dongsheng Cai [Fri, 5 Nov 2010 06:34:00 +0000 (06:34 +0000)]
MDL-15573, question export rewrite

10 years agorss MDL-25076 made forum rss feeds that are displaying discussions instead of posts...
Andrew Davis [Fri, 5 Nov 2010 06:13:31 +0000 (06:13 +0000)]
rss MDL-25076 made forum rss feeds that are displaying discussions instead of posts correctly set the item titles

10 years agooutput MDL-24895 Removed debugging notice when setting an unchangeable pagelayout
Sam Hemelryk [Fri, 5 Nov 2010 04:19:08 +0000 (04:19 +0000)]
output MDL-24895 Removed debugging notice when setting an unchangeable pagelayout

10 years agoblocks MDL-25074 When adding pretend blocks if the requested region doesn't exist...
Sam Hemelryk [Fri, 5 Nov 2010 03:45:32 +0000 (03:45 +0000)]
blocks MDL-25074 When adding pretend blocks if the requested region doesn't exist it now uses the default region.

10 years agothemes lib MDL-24895 Multiple fixes to better handle overflow.
Sam Hemelryk [Fri, 5 Nov 2010 02:53:47 +0000 (02:53 +0000)]
themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.

10 years agoMDL-25069, chat, check if user loggedin
Dongsheng Cai [Fri, 5 Nov 2010 02:41:16 +0000 (02:41 +0000)]
MDL-25069, chat, check if user loggedin

10 years agoblock-blog_recent MDL-22942 Fixed up block config function, blog_recent doesn't have...
Sam Hemelryk [Fri, 5 Nov 2010 01:55:51 +0000 (01:55 +0000)]
block-blog_recent MDL-22942 Fixed up block config function, blog_recent doesn't have global settings

10 years agoUpdated the HEAD build version to 20101105
Moodle Robot [Fri, 5 Nov 2010 00:47:33 +0000 (00:47 +0000)]
Updated the HEAD build version to 20101105

10 years agoMDL-21395 rewording help string
Helen Foster [Thu, 4 Nov 2010 17:48:43 +0000 (17:48 +0000)]
MDL-21395 rewording help string

10 years agoMDL-21395 deleting unused string
Helen Foster [Thu, 4 Nov 2010 17:04:50 +0000 (17:04 +0000)]
MDL-21395 deleting unused string

10 years agocap rewording
Helen Foster [Thu, 4 Nov 2010 15:11:47 +0000 (15:11 +0000)]
cap rewording

10 years agoWorkshop aggregation is not expected to produce any output, just redirects back to...
David Mudrak [Thu, 4 Nov 2010 14:45:03 +0000 (14:45 +0000)]
Workshop aggregation is not expected to produce any output, just redirects back to the workshop main page

10 years agoquestion type upgrade MDL-24863 Fix broken upgrade on MSSQL.
Tim Hunt [Thu, 4 Nov 2010 09:49:00 +0000 (09:49 +0000)]
question type upgrade MDL-24863 Fix broken upgrade on MSSQL.
Thanks to mark williams for the report.

10 years agomessage MDL-24763 altered a debugging() call to have a unique message
Andrew Davis [Thu, 4 Nov 2010 06:36:56 +0000 (06:36 +0000)]
message MDL-24763 altered a debugging() call to have a unique message

10 years agomessage MDL-24763 prevented notifications from appearing in the messages block
Andrew Davis [Thu, 4 Nov 2010 06:04:40 +0000 (06:04 +0000)]
message MDL-24763 prevented notifications from appearing in the messages block

10 years agoNOBUG: Fixed syntax error
Sam Hemelryk [Thu, 4 Nov 2010 05:20:09 +0000 (05:20 +0000)]
NOBUG: Fixed syntax error

10 years agoMDL-22663, fixed webdav type option
Dongsheng Cai [Thu, 4 Nov 2010 03:46:41 +0000 (03:46 +0000)]
MDL-22663, fixed webdav type option

10 years agoUpdated the HEAD build version to 20101104
Moodle Robot [Thu, 4 Nov 2010 00:48:47 +0000 (00:48 +0000)]
Updated the HEAD build version to 20101104

10 years agoMDL-24896 Do not access PHPMailer's private properties but use public API only
David Mudrak [Wed, 3 Nov 2010 20:44:35 +0000 (20:44 +0000)]
MDL-24896 Do not access PHPMailer's private properties but use public API only

There was a problem with properties $to, $ReplyTo and $error_count that
are now private. $error_count is accessible via public IsError() method.
For the other two, we needed them just because of post-processing charset
conversion. So I just made sure that the charset is converted before
the recipent and reply-to names are added to the PHPMailer.

Also, I do not instantiate Typo3 during every email if it is not needed
and I pass the character set to it in lower case now as stated in
textlib documentation.

10 years agoMDL-24896 Removed hmm-note - PHPMailer's LE property is part of public API
David Mudrak [Wed, 3 Nov 2010 20:44:23 +0000 (20:44 +0000)]
MDL-24896 Removed hmm-note - PHPMailer's LE property is part of public API

10 years agoMDL-21276 removed forgotten MNet global variable declaration and unused static cache
David Mudrak [Wed, 3 Nov 2010 20:44:10 +0000 (20:44 +0000)]
MDL-21276 removed forgotten MNet global variable declaration and unused static cache

10 years agoMDL-24896 MDL-12596 RFCDate declared explicitly as public as it is in the parent...
David Mudrak [Wed, 3 Nov 2010 20:43:58 +0000 (20:43 +0000)]
MDL-24896 MDL-12596 RFCDate declared explicitly as public as it is in the parent class

The method used to be set as private in PHPdocs @access property in the
versions for PHP4. But apparenty upstream considers the function public.
Also, if the function did not declare visibility explicitly, it was
considered public anyway.

10 years agoMDL-24896 no more returning explicit reference by get_mailer
David Mudrak [Wed, 3 Nov 2010 20:43:46 +0000 (20:43 +0000)]
MDL-24896 no more returning explicit reference by get_mailer

PHP5 passes and returns reference to objects automatically, no need for
reference operator any more.

10 years agoMDL-24896 MDL-23240 class.phpmailer.php reverted to the vanilla upstream version
David Mudrak [Wed, 3 Nov 2010 20:43:34 +0000 (20:43 +0000)]
MDL-24896 MDL-23240 class.phpmailer.php reverted to the vanilla upstream version

10 years agoNOMDL Typo3 expects charset names in lower case
David Mudrak [Wed, 3 Nov 2010 19:33:08 +0000 (19:33 +0000)]
NOMDL Typo3 expects charset names in lower case

10 years agomessage MDL-24694 made the email message processor report success if the recipient...
Andrew Davis [Wed, 3 Nov 2010 07:57:31 +0000 (07:57 +0000)]
message MDL-24694 made the email message processor report success if the recipient has said they don't want to receive emails so that code sending messages isnt bothered by what looks like a failure.

10 years agomessage MDL-25033 made message search appear by default
Andrew Davis [Wed, 3 Nov 2010 07:33:26 +0000 (07:33 +0000)]
message MDL-25033 made message search appear by default

10 years agomessage MDL-25033 made the contact paging elements clickable even if they spill over...
Andrew Davis [Wed, 3 Nov 2010 06:56:17 +0000 (06:56 +0000)]
message MDL-25033 made the contact paging elements clickable even if they spill over into the right hand pane

10 years agoglobal search MDL-25030 fixed forum url anchor in index
Aparup Banerjee [Wed, 3 Nov 2010 04:09:59 +0000 (04:09 +0000)]
global search MDL-25030 fixed forum url anchor in index

10 years agomessage MDL-24970 removed more no longer used code
Andrew Davis [Wed, 3 Nov 2010 03:58:13 +0000 (03:58 +0000)]
message MDL-24970 removed more no longer used code

10 years agomessage MDL-24970 removed no longer used messaging code
Andrew Davis [Wed, 3 Nov 2010 03:49:30 +0000 (03:49 +0000)]
message MDL-24970 removed no longer used messaging code

10 years agoglobal search MDL-25009 indexing failures in each module are now handled so that...
Aparup Banerjee [Wed, 3 Nov 2010 03:47:52 +0000 (03:47 +0000)]
global search MDL-25009 indexing failures in each module are now handled so that indexing can proceed to the next module.

10 years agoglobal search MDL-25010 indexer now recurses through every forum post.
Aparup Banerjee [Wed, 3 Nov 2010 03:23:07 +0000 (03:23 +0000)]
global search MDL-25010 indexer now recurses through every forum post.
also a temp fix (MDL-24822) for forum groupid.

10 years agopublication MDL-24687 fix pb with screenshots sent during a second course sharing
jerome mouneyrac [Wed, 3 Nov 2010 02:43:40 +0000 (02:43 +0000)]
publication MDL-24687 fix pb with screenshots sent during a second course sharing

10 years agotheme-anomaly MDL-25028 Removed unused function is anomaly's lib.php file.
Sam Hemelryk [Wed, 3 Nov 2010 02:26:16 +0000 (02:26 +0000)]
theme-anomaly MDL-25028 Removed unused function is anomaly's lib.php file.

10 years agoUpdated the HEAD build version to 20101103
Moodle Robot [Wed, 3 Nov 2010 00:48:32 +0000 (00:48 +0000)]
Updated the HEAD build version to 20101103

10 years agoMDL-25018 stop html_to_text from breaking utf-8 multibyte characters.
Tim Hunt [Tue, 2 Nov 2010 20:03:48 +0000 (20:03 +0000)]
MDL-25018 stop html_to_text from breaking utf-8 multibyte characters.

10 years agoquiz 'secure' mode MDL-21085 remove popup-blocker check.
Tim Hunt [Tue, 2 Nov 2010 19:49:09 +0000 (19:49 +0000)]
quiz 'secure' mode MDL-21085 remove popup-blocker check.

It was unnecessary on modern browsers, since they let thought a pop-up if you just clicked on a link, so this check was just causing an annoying and misleading alert.

Since the popupchecker was only used here, and since it was implemented in a way that does not work on all browsers, I just deleted the function. If anyone ever finds that they acutally need this functionality, they can re-implement it in a way that works.

10 years agoquiz MDL-24140 navigating to a question that was not first on the page was broken.
Tim Hunt [Tue, 2 Nov 2010 19:20:58 +0000 (19:20 +0000)]
quiz MDL-24140 navigating to a question that was not first on the page was broken.

10 years agoMDL-24140 Each attempt builds on last setting was being ingored in one place.
Tim Hunt [Tue, 2 Nov 2010 19:12:21 +0000 (19:12 +0000)]
MDL-24140 Each attempt builds on last setting was being ingored in one place.
The code was behaving as if it was always true.

10 years agoMDL-24256 question category editing was messed up.
Tim Hunt [Tue, 2 Nov 2010 18:38:50 +0000 (18:38 +0000)]
MDL-24256 question category editing was messed up.
The unerlying problem seemed to be too many uses of pass-by-reference in listlib, where it was not necessary.
In investigating this code, I ended up doing a fair bit of cleaning up. Apologies that it leads to an unclear changeset.

10 years agoUnit tests MDL-24981 Fixed portfolio unit test so it at least runs (update: glossary...
Sam Marshall [Tue, 2 Nov 2010 16:21:34 +0000 (16:21 +0000)]
Unit tests MDL-24981 Fixed portfolio unit test so it at least runs (update: glossary too)

10 years agoUnit tests MDL-24976 Fixed conditionlib unit test (also added thing to ensure that...
Sam Marshall [Tue, 2 Nov 2010 15:04:21 +0000 (15:04 +0000)]
Unit tests MDL-24976 Fixed conditionlib unit test (also added thing to ensure that debug warning in conditionlib is shown in unit test if applicable)