moodle.git
2 months agoMDL-70781 course: setting for displaying completion conditions
Simey Lameze [Mon, 8 Mar 2021 22:42:09 +0000 (06:42 +0800)]
MDL-70781 course: setting for displaying completion conditions

Part of MDL-70817

2 months agoMDL-70782 course: behat coverage for new setting
Simey Lameze [Sat, 13 Mar 2021 02:34:15 +0000 (10:34 +0800)]
MDL-70782 course: behat coverage for new setting

Part of MDL-70817

2 months agoMDL-70782 course: add setting to show activity dates
Simey Lameze [Mon, 8 Mar 2021 12:46:52 +0000 (20:46 +0800)]
MDL-70782 course: add setting to show activity dates

Part of MDL-70817

2 months agoMDL-70817 mod_choice: Behat tests for the activity completion info
Jun Pataleta [Fri, 12 Mar 2021 06:17:38 +0000 (14:17 +0800)]
MDL-70817 mod_choice: Behat tests for the activity completion info

2 months agoMDL-70817 mod_choice: Show choice activity info
Jun Pataleta [Sun, 7 Feb 2021 05:44:02 +0000 (13:44 +0800)]
MDL-70817 mod_choice: Show choice activity info

2 months agoMDL-70817 core_course: Create an activity information output component
Jun Pataleta [Fri, 5 Feb 2021 17:18:24 +0000 (01:18 +0800)]
MDL-70817 core_course: Create an activity information output component

The activity information output component displays information about
an activity module that can contain:
1. Activity dates
2. Completion information
   a. A manual completion button; or
   b. A list of automatic completion conditions and their statuses.

This patch also includes a new JS module called
core_course/manual_completion_toggle for toggling the
completion state of activities that support manual completion.

2 months agoMDL-70817 core_course: Add manual completion toggle to repository
Jun Pataleta [Fri, 5 Mar 2021 09:40:26 +0000 (17:40 +0800)]
MDL-70817 core_course: Add manual completion toggle to repository

Add the functionality of toggling the completion state of an
activity with manual completion to the core_course/repository
JS module.

2 months agoMDL-70817 core_course: Convert core_course/repository to ES6
Jun Pataleta [Fri, 5 Mar 2021 09:37:58 +0000 (17:37 +0800)]
MDL-70817 core_course: Convert core_course/repository to ES6

2 months agoMDL-70817 core: Allow the manual completion update WS function for AJAX
Jun Pataleta [Wed, 17 Feb 2021 16:07:02 +0000 (00:07 +0800)]
MDL-70817 core: Allow the manual completion update WS function for AJAX

Allow the core_completion_update_activity_completion_status_manually
web service function to be called from AJAX as well. This is needed
by the new manual completion toggle button in the
core_course/completion_manual template.

2 months agoMDL-70817 core_completion: Unit tests for cm_completion_details
Jun Pataleta [Mon, 15 Feb 2021 14:20:23 +0000 (22:20 +0800)]
MDL-70817 core_completion: Unit tests for cm_completion_details

2 months agoMDL-70817 core_completion: Course module completion details
Jun Pataleta [Tue, 16 Feb 2021 02:07:25 +0000 (10:07 +0800)]
MDL-70817 core_completion: Course module completion details

* Class cm_completion_details builds the custom completion details
for an activity module.

2 months agoon-demand release 3.11dev+
Víctor Déniz [Tue, 30 Mar 2021 14:39:41 +0000 (15:39 +0100)]
on-demand release 3.11dev+

2 months agoMerge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install...
Víctor Déniz [Tue, 30 Mar 2021 14:39:34 +0000 (15:39 +0100)]
Merge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70963-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE
Eloy Lafuente (stronk7) [Mon, 29 Mar 2021 10:39:49 +0000 (12:39 +0200)]
Merge branch 'MDL-70963-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE

2 months agoMDL-70963 core_badges: Use expected JSON format for OBv2.1
Sara Arjona [Mon, 22 Feb 2021 15:20:49 +0000 (16:20 +0100)]
MDL-70963 core_badges: Use expected JSON format for OBv2.1

This patch adds some changes to guarantee that OpenBadges 2.1 (OBv2.1)
will return always the same JSON format that OBv2.0 (because the only
difference between both versions it's the BadgeConnect API).

2 months agoMerge branch 'MDL-70962-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Andrew Nicols [Mon, 29 Mar 2021 03:58:54 +0000 (11:58 +0800)]
Merge branch 'MDL-70962-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-71004_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE
Andrew Nicols [Mon, 29 Mar 2021 03:54:13 +0000 (11:54 +0800)]
Merge branch 'MDL-71004_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE

2 months agoAutomatically generated installer lang files
AMOS bot [Mon, 29 Mar 2021 00:07:28 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 months agoMerge branch 'MDL-68496-311' of git://github.com/andrewnicols/moodle into MOODLE_311_...
Eloy Lafuente (stronk7) [Sun, 28 Mar 2021 21:48:26 +0000 (23:48 +0200)]
Merge branch 'MDL-68496-311' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-71131-m311' of https://github.com/sammarshallou/moodle into MOODLE_...
Eloy Lafuente (stronk7) [Sun, 28 Mar 2021 21:21:45 +0000 (23:21 +0200)]
Merge branch 'MDL-71131-m311' of https://github.com/sammarshallou/moodle into MOODLE_311_STABLE

2 months agoAutomatically generated installer lang files
AMOS bot [Sun, 28 Mar 2021 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 months agoMerge branch 'MDL-71099-m311' of https://github.com/sammarshallou/moodle into MOODLE_...
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 09:17:51 +0000 (10:17 +0100)]
Merge branch 'MDL-71099-m311' of https://github.com/sammarshallou/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70537-m311' of https://github.com/sammarshallou/moodle into MOODLE_...
Víctor Déniz [Fri, 26 Mar 2021 20:14:49 +0000 (20:14 +0000)]
Merge branch 'MDL-70537-m311' of https://github.com/sammarshallou/moodle into MOODLE_311_STABLE

2 months agoMDL-70962 forms: catch modal exceptions when getting body content.
Paul Holden [Mon, 22 Feb 2021 11:23:28 +0000 (11:23 +0000)]
MDL-70962 forms: catch modal exceptions when getting body content.

They are thrown in the following circumstances:

 * The dynamic form class doesn't exist;
 * It does exist but it's `check_access` method throws exception

Co-Authored-By: Andrew Nicols <andrew@nicols.co.uk>
2 months agoMerge branch 'MDL-71194-311' of git://github.com/NoelDeMartin/moodle into MOODLE_311_...
Víctor Déniz [Thu, 25 Mar 2021 15:13:50 +0000 (15:13 +0000)]
Merge branch 'MDL-71194-311' of git://github.com/NoelDeMartin/moodle into MOODLE_311_STABLE

2 months agoMDL-71131 Admin: Users page incorrectly showing all name fields
sam marshall [Thu, 18 Mar 2021 13:00:20 +0000 (13:00 +0000)]
MDL-71131 Admin: Users page incorrectly showing all name fields

2 months agoMDL-71099 Lib: Move new user_fields class from core to core_user
sam marshall [Mon, 15 Mar 2021 15:36:32 +0000 (15:36 +0000)]
MDL-71099 Lib: Move new user_fields class from core to core_user

This class would belong more appropriately within the 'user' API
(core_user) instead of within the 'core' API, since it is
directly related to user data.

Since the class has only just been added to Moodle, now is a good
time to move it.

2 months agoMerge branch 'MDL-70842_311_v3' of https://github.com/TomoTsuyuki/moodle into MOODLE_...
Víctor Déniz [Thu, 25 Mar 2021 12:59:09 +0000 (12:59 +0000)]
Merge branch 'MDL-70842_311_v3' of https://github.com/TomoTsuyuki/moodle into MOODLE_311_STABLE

2 months agoMDL-71194 behat: Fix app tests
Noel De Martin [Thu, 25 Mar 2021 12:50:27 +0000 (13:50 +0100)]
MDL-71194 behat: Fix app tests

2 months agoMerge branch 'MDL-70318-311' of https://github.com/ilyatregubov/moodle into MOODLE_31...
Andrew Nicols [Thu, 25 Mar 2021 04:31:44 +0000 (12:31 +0800)]
Merge branch 'MDL-70318-311' of https://github.com/ilyatregubov/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-65776-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE
Andrew Nicols [Thu, 25 Mar 2021 03:07:24 +0000 (11:07 +0800)]
Merge branch 'MDL-65776-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70871-311' of git://github.com/roland04/moodle into MOODLE_311_STABLE
Andrew Nicols [Thu, 25 Mar 2021 00:12:08 +0000 (08:12 +0800)]
Merge branch 'MDL-70871-311' of git://github.com/roland04/moodle into MOODLE_311_STABLE

2 months agoAutomatically generated installer lang files
AMOS bot [Thu, 25 Mar 2021 00:07:31 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 months agoMerge branch 'MDL-70980-311' of git://github.com/ferranrecio/moodle into MOODLE_311_S...
Andrew Nicols [Thu, 25 Mar 2021 00:06:47 +0000 (08:06 +0800)]
Merge branch 'MDL-70980-311' of git://github.com/ferranrecio/moodle into MOODLE_311_STABLE

2 months agoMDL-71004 git: Ignore moodle-plugin-ci.phar in any directory
Eloy Lafuente (stronk7) [Sun, 21 Mar 2021 22:21:28 +0000 (23:21 +0100)]
MDL-71004 git: Ignore moodle-plugin-ci.phar in any directory

2 months agoweekly release 3.11dev
Víctor Déniz [Wed, 24 Mar 2021 14:20:41 +0000 (14:20 +0000)]
weekly release 3.11dev

2 months agoMerge branch 'MDL-71149_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE
Víctor Déniz [Wed, 24 Mar 2021 13:36:32 +0000 (13:36 +0000)]
Merge branch 'MDL-71149_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-71182-311-2' of git://github.com/lameze/moodle into MOODLE_311_STABLE
Eloy Lafuente (stronk7) [Wed, 24 Mar 2021 09:49:32 +0000 (10:49 +0100)]
Merge branch 'MDL-71182-311-2' of git://github.com/lameze/moodle into MOODLE_311_STABLE

2 months agoMDL-71182 calendar: add logic for category events in get_context
Simey Lameze [Mon, 24 Aug 2020 03:08:00 +0000 (11:08 +0800)]
MDL-71182 calendar: add logic for category events in get_context

This commit adds the missing logic for category events in
get_context() method. Without this fix, users will get errors
if they have category events with userid set to 0.

2 months agoMDL-70842 mod_assign: Add more cases to add file to archive
Tomo Tsuyuki [Wed, 24 Mar 2021 05:01:36 +0000 (16:01 +1100)]
MDL-70842 mod_assign: Add more cases to add file to archive

2 months agoMDL-71182 calendar: Revert "Merge branch 'MDL-67494-311' of git://github.com/lameze...
Simey Lameze [Wed, 24 Mar 2021 00:02:16 +0000 (08:02 +0800)]
MDL-71182 calendar: Revert "Merge branch 'MDL-67494-311' of git://github.com/lameze/moodle into MOODLE_311_STABLE"

This reverts commit 9f5794834e986eda22781503119c882720e00dd8, reversing
changes made to d30b045210f27d909a87ade2e1b637c46cdf4c00.

2 months agoMerge branch 'MDL-71022-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Víctor Déniz [Tue, 23 Mar 2021 23:01:00 +0000 (23:01 +0000)]
Merge branch 'MDL-71022-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70727-311' of https://github.com/NashTechOpenUniversity/moodle...
Víctor Déniz [Tue, 23 Mar 2021 18:23:32 +0000 (18:23 +0000)]
Merge branch 'MDL-70727-311' of https://github.com/NashTechOpenUniversity/moodle into MOODLE_311_STABLE

2 months agoMDL-70871 user: Move 'Show all X' functionality to dynamic_table
Mikel Martín [Mon, 15 Feb 2021 11:09:28 +0000 (12:09 +0100)]
MDL-70871 user: Move 'Show all X' functionality to dynamic_table

2 months agoMDL-70871 table: Add 'Show all X' functionality to dynamic_table
Mikel Martín [Mon, 15 Feb 2021 10:36:59 +0000 (11:36 +0100)]
MDL-70871 table: Add 'Show all X' functionality to dynamic_table

2 months agoMerge branch 'MDL-69792-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE
Travis CI [Tue, 23 Mar 2021 05:55:09 +0000 (13:55 +0800)]
Merge branch 'MDL-69792-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-71104-311-2' of git://github.com/mickhawkins/moodle into MOODLE_311...
Travis CI [Tue, 23 Mar 2021 05:47:02 +0000 (13:47 +0800)]
Merge branch 'MDL-71104-311-2' of git://github.com/mickhawkins/moodle into MOODLE_311_STABLE

2 months agoMDL-71104 core_completion: Fix fetching of grade completion status
Michael Hawkins [Thu, 18 Mar 2021 06:27:36 +0000 (14:27 +0800)]
MDL-71104 core_completion: Fix fetching of grade completion status

We should be able to fetch the grade completion status for modules
that do not have custom completion configured. This also improves
unit testing coverage.

2 months agoMDL-71104 completion: Fix completion_info::get_data() unit tests
Jun Pataleta [Mon, 15 Mar 2021 06:39:08 +0000 (14:39 +0800)]
MDL-71104 completion: Fix completion_info::get_data() unit tests

* Fixed inverted $sameuser test data.
* Fixed caching expectation check. Caching only relies on whether the
user accessing the completion data is the same user or not.
* Fixed checking for the caching of other modules. Should have been
checking cm ID and not instance ID.
* Additional test case when whole course parameter is passed as
true, but the requesting user is different from the target user.

2 months agoMerge branch 'MDL-71039-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Andrew Nicols [Tue, 23 Mar 2021 03:18:24 +0000 (11:18 +0800)]
Merge branch 'MDL-71039-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70313-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE
Andrew Nicols [Tue, 23 Mar 2021 02:00:19 +0000 (10:00 +0800)]
Merge branch 'MDL-70313-311' of git://github.com/peterRd/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-69036-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Andrew Nicols [Tue, 23 Mar 2021 01:52:02 +0000 (09:52 +0800)]
Merge branch 'MDL-69036-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-67870-311' of git://github.com/mihailges/moodle into MOODLE_311_STABLE
Andrew Nicols [Tue, 23 Mar 2021 01:24:41 +0000 (09:24 +0800)]
Merge branch 'MDL-67870-311' of git://github.com/mihailges/moodle into MOODLE_311_STABLE

2 months agoMDL-70980 mod_h5pactivity: fix review mode
Ferran Recio [Tue, 23 Feb 2021 14:33:57 +0000 (15:33 +0100)]
MDL-70980 mod_h5pactivity: fix review mode

2 months agoMDL-67870 backup: Skip value change if setting is locked by hierarchy
Mihail Geshoski [Wed, 10 Mar 2021 03:08:48 +0000 (11:08 +0800)]
MDL-67870 backup: Skip value change if setting is locked by hierarchy

The given condition in the if statement did not take into account cases
when the setting is locked by hierarchy. Settings which are locked by
hierarchy should should keep their current values which were inherited
from the parent.

2 months agoMDL-68496 Grunt: Stylelint should only lint relevant component files
Andrew Nicols [Thu, 18 Mar 2021 23:47:02 +0000 (07:47 +0800)]
MDL-68496 Grunt: Stylelint should only lint relevant component files

Prior to this change the Grunt stylelint command was too greedy when
determining which files hsould be linted.

This change modifies the watch command to only watch relevant files and
subdirectories of each component directories. This means that unrelated
CSS and SCSS files are no longer watched for changes, and has the added
benefit of significantly increaseing the startup speed of grunt.

Without this patch applied the watch tasks were checking for matches in
the node_modules, and vendor directories.

2 months agoMerge branch 'MDL-70816-311-4' of git://github.com/rezaies/moodle into MOODLE_311_STABLE
Andrew Nicols [Mon, 22 Mar 2021 05:33:48 +0000 (13:33 +0800)]
Merge branch 'MDL-70816-311-4' of git://github.com/rezaies/moodle into MOODLE_311_STABLE

2 months agoMDL-70816 mod_choice: activity_dates implementation
Shamim Rezaie [Thu, 18 Feb 2021 16:25:57 +0000 (03:25 +1100)]
MDL-70816 mod_choice: activity_dates implementation

2 months agoMDL-70816 core: Activity date details base class
Shamim Rezaie [Thu, 18 Feb 2021 15:43:30 +0000 (02:43 +1100)]
MDL-70816 core: Activity date details base class

* Base class for fetching an activity module's important date for a user

2 months agoMerge branch 'MDL-71139-311-trademark' of git://github.com/mudrd8mz/moodle into MOODL...
Andrew Nicols [Mon, 22 Mar 2021 04:00:08 +0000 (12:00 +0800)]
Merge branch 'MDL-71139-311-trademark' of git://github.com/mudrd8mz/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70919-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Andrew Nicols [Sun, 21 Mar 2021 23:48:42 +0000 (07:48 +0800)]
Merge branch 'MDL-70919-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

2 months agoMDL-71149 install: update the list of stale files for 3.11
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 12:00:27 +0000 (13:00 +0100)]
MDL-71149 install: update the list of stale files for 3.11

2 months agoMDL-65776 libraries: Set moodle files after jsbeautify upgrade
Sara Arjona [Wed, 17 Mar 2021 09:54:10 +0000 (10:54 +0100)]
MDL-65776 libraries: Set moodle files after jsbeautify upgrade

2 months agoMDL-65776 libraries: Upgrade jsbeautify to 1.13
Sara Arjona [Wed, 17 Mar 2021 09:52:47 +0000 (10:52 +0100)]
MDL-65776 libraries: Upgrade jsbeautify to 1.13

2 months agoMDL-69792 core_badges: deprecated backpack.js and BADGE_BACKPACKURL
Sara Arjona [Tue, 23 Feb 2021 11:01:55 +0000 (12:01 +0100)]
MDL-69792 core_badges: deprecated backpack.js and BADGE_BACKPACKURL

Final deprecation for constant BADGE_BACKPACKURL (it has been removed)
and badges/backpack.js file (it has been removed too).
Besides, some methods have started the deprecation process too:
 - badges_check_backpack_accessibility
 - badges_setup_backpack_js()
 - badges_local_backpack_js()

Apart from that, string 'addbackpack' has been deprecated here
because it's not used anywhere.

2 months agoweekly release 3.11dev
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:25 +0000 (14:06 +0100)]
weekly release 3.11dev

2 months agoNOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:25 +0000 (14:06 +0100)]
NOBUG: Fixed file access permissions

2 months agoMerge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install...
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:21 +0000 (14:06 +0100)]
Merge branch 'install_311_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_311_STABLE

2 months agoMDL-70318 core: Moodle customisations.
Ilya Tregubov [Fri, 19 Mar 2021 08:18:30 +0000 (10:18 +0200)]
MDL-70318 core: Moodle customisations.

2 months agoMDL-70318 core: Upgrade CFPropertyList to 2.0.2.
Ilya Tregubov [Mon, 15 Mar 2021 09:27:43 +0000 (11:27 +0200)]
MDL-70318 core: Upgrade CFPropertyList to 2.0.2.

2 months agoMDL-68496 grunt: Restructure grunt tasks into subdirectories
Andrew Nicols [Fri, 19 Mar 2021 00:14:11 +0000 (08:14 +0800)]
MDL-68496 grunt: Restructure grunt tasks into subdirectories

Prior to this change all Grunt features were in a single Gruntfile.js
but this has become difficult to manage and maintain.

This commit moves the existing dependencies for component calculation
and babel moduel definition into a new .grunt directory, and
restructures the existing tasks in Gruntfile.js into separate task
configuration files.

This improves the maintainability of the Grunt build system and allows
for easier future expansion.

2 months agoMDL-70537 Availability: Avoid recursive calls to $cm->name
sam marshall [Tue, 2 Feb 2021 11:51:25 +0000 (11:51 +0000)]
MDL-70537 Availability: Avoid recursive calls to $cm->name

These recursive calls didn't work in PHP 7.3 and below, but in PHP
7.4 they also cause a fatal error which means if you have invalid
availability data, the whole page might die.

2 months agoMDL-70919 core_form: non-static method can not be called statically
Marina Glancy [Thu, 18 Mar 2021 11:15:49 +0000 (12:15 +0100)]
MDL-70919 core_form: non-static method can not be called statically

2 months agoMDL-71139 trademark: Improve the trademark messaging
Chris Brown [Thu, 18 Mar 2021 09:31:56 +0000 (10:31 +0100)]
MDL-71139 trademark: Improve the trademark messaging

2 months agoMerge branch 'MDL-70992-311' of https://github.com/NashTechOpenUniversity/moodle...
Jun Pataleta [Thu, 18 Mar 2021 04:23:39 +0000 (12:23 +0800)]
Merge branch 'MDL-70992-311' of https://github.com/NashTechOpenUniversity/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-70924-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Adrian Greeve [Thu, 18 Mar 2021 03:52:51 +0000 (11:52 +0800)]
Merge branch 'MDL-70924-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

2 months agoMerge branch 'MDL-71048-311' of https://github.com/paulholden/moodle into MOODLE_311_...
Adrian Greeve [Thu, 18 Mar 2021 03:10:59 +0000 (11:10 +0800)]
Merge branch 'MDL-71048-311' of https://github.com/paulholden/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70977-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Adrian Greeve [Thu, 18 Mar 2021 02:28:55 +0000 (10:28 +0800)]
Merge branch 'MDL-70977-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70978-311' of git://github.com/aanabit/moodle into MOODLE_311_STABLE
Jun Pataleta [Thu, 18 Mar 2021 01:55:53 +0000 (09:55 +0800)]
Merge branch 'MDL-70978-311' of git://github.com/aanabit/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-71068-protectusername-confirmed-MOODLE_311_STABLE' of https://githu...
Adrian Greeve [Thu, 18 Mar 2021 01:52:10 +0000 (09:52 +0800)]
Merge branch 'MDL-71068-protectusername-confirmed-MOODLE_311_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_311_STABLE

3 months agoAutomatically generated installer lang files
AMOS bot [Thu, 18 Mar 2021 00:07:28 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 months agoMerge branch 'MDL-70901-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:40:55 +0000 (00:40 +0100)]
Merge branch 'MDL-70901-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70896-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:34:13 +0000 (00:34 +0100)]
Merge branch 'MDL-70896-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70968-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:29:46 +0000 (00:29 +0100)]
Merge branch 'MDL-70968-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70893-311' of git://github.com/marinaglancy/moodle into MOODLE_311_...
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 23:23:36 +0000 (00:23 +0100)]
Merge branch 'MDL-70893-311' of git://github.com/marinaglancy/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-70689-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE
Eloy Lafuente (stronk7) [Wed, 17 Mar 2021 22:20:50 +0000 (23:20 +0100)]
Merge branch 'MDL-70689-311' of git://github.com/sarjona/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-71036_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE
Jun Pataleta [Wed, 17 Mar 2021 12:05:17 +0000 (20:05 +0800)]
Merge branch 'MDL-71036_311' of https://github.com/stronk7/moodle into MOODLE_311_STABLE

3 months agoMDL-71068 login: Fix edge cases with $CFG->protectusernames
Brendan Heywood [Wed, 17 Mar 2021 06:37:29 +0000 (17:37 +1100)]
MDL-71068 login: Fix edge cases with $CFG->protectusernames

3 months agoMDL-70992 Folder: Unnecessary tab stops to the left of files
sangnguyen [Mon, 1 Mar 2021 09:48:14 +0000 (16:48 +0700)]
MDL-70992 Folder: Unnecessary tab stops to the left of files

3 months agoMerge branch 'MDL-70565-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 21:49:05 +0000 (22:49 +0100)]
Merge branch 'MDL-70565-311' of git://github.com/paulholden/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MOODLE_311_MDL-71044_v3' of https://github.com/golenkovm/moodle into...
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 21:39:02 +0000 (22:39 +0100)]
Merge branch 'MOODLE_311_MDL-71044_v3' of https://github.com/golenkovm/moodle into MOODLE_311_STABLE

3 months agoMerge branch 'MDL-67748-311-managewebservices' of git://github.com/mudrd8mz/moodle...
Eloy Lafuente (stronk7) [Tue, 16 Mar 2021 18:29:04 +0000 (19:29 +0100)]
Merge branch 'MDL-67748-311-managewebservices' of git://github.com/mudrd8mz/moodle into MOODLE_311_STABLE

3 months agoMDL-67748 admin: Add Behat tests for tokens filtering features
David Mudrák [Mon, 15 Mar 2021 20:19:33 +0000 (21:19 +0100)]
MDL-67748 admin: Add Behat tests for tokens filtering features

Credit goes to Andrew for Behat data generators for webservices.

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
3 months agoMerge branch 'MDL-44613-integration-311' of git://github.com/mihailges/moodle into...
Sara Arjona [Tue, 16 Mar 2021 07:26:57 +0000 (08:26 +0100)]
Merge branch 'MDL-44613-integration-311' of git://github.com/mihailges/moodle into MOODLE_311_STABLE

3 months agoMDL-69474 accessibility: page->url can be not set, protect against that
Eloy Lafuente (stronk7) [Mon, 15 Mar 2021 19:20:33 +0000 (20:20 +0100)]
MDL-69474 accessibility: page->url can be not set, protect against that

Both in unit tests, but also in other areas (say blocks, for example)
it's possible that page->url has not been set yet.

So, let's change current code to always check if we have something
(page->url) to compare.

Note the use of has_set_url() is needed, because page->url is magic
method and it doesn't work as expected. Hate magics!

3 months agoMDL-44613 mod_assign: Fix behat failure in classic
Mihail Geshoski [Tue, 16 Mar 2021 02:26:09 +0000 (10:26 +0800)]
MDL-44613 mod_assign: Fix behat failure in classic

The link to the calendar page is missing in the navigation block in
classic which causes a behat failure in the 'Set availibility dates
for an assignment' feature. The fix includes adding the calendar block
to the Course page which can be used to navigate to the calendar page.

3 months agoMerge branch 'MDL-70780-311' of git://github.com/andrewnicols/moodle into MOODLE_311_...
Adrian Greeve [Tue, 16 Mar 2021 03:15:12 +0000 (11:15 +0800)]
Merge branch 'MDL-70780-311' of git://github.com/andrewnicols/moodle into MOODLE_311_STABLE

3 months agoMDL-67748 admin: Do not show missing capabilities for mobile app service
David Mudrák [Fri, 24 Apr 2020 17:20:54 +0000 (19:20 +0200)]
MDL-67748 admin: Do not show missing capabilities for mobile app service

We used to display capabilities like "Manage any calendar entries",
"Delete evidence", "Manage competency frameworks", "View hidden courses"
and others as "Missing capabilities" for the mobile app service tokens.

This gave dangerous impression that the app will not work for students
without these capabilities granted. There are known cases of admins who
started to grant all these caps to the Authenticated user role because
they were afraid the app would not work for them.

The problem here is that the official mobile app service includes some
functions that have these capabilities declared as required. But they
are not really required to use the app. Either the app makes its own
clever checks of capabilities before calling the functions, or sometimes
the capabilities are not even correctly declared.

It is safer for everybody to display this information for custom
services only where the risk of the falsely missing caps is lower and
the information is more accurate.

Also, the help text has been improved so it does not suggest that these
capabilities must be always added. We do not know why the service has
them declared. In some cases, a service has capabilities declared just
because it makes use of them in the if-then fashion.

Additionally, the patch also displays the service short name because it
is actually needed to know.

3 months agoMDL-67748 admin: Show user identity fields on the manage tokens page
David Mudrák [Fri, 24 Apr 2020 16:33:36 +0000 (18:33 +0200)]
MDL-67748 admin: Show user identity fields on the manage tokens page

On sites with many users, the fullname itself may not be unique
identifier of users. Display the user identity fields below the token
owner's name.

3 months agoMDL-67748 admin: Add filter to the WS tokens management page
David Mudrák [Wed, 22 Apr 2020 20:22:13 +0000 (22:22 +0200)]
MDL-67748 admin: Add filter to the WS tokens management page

The patch adds ability to filter the list of token by the token value,
the user and the service. Also the button to create a new token is made
more prominent and easier to spot.