moodle.git
11 years agoFixed location of icon.gif
David Mudrak [Wed, 24 Mar 2010 10:56:22 +0000 (10:56 +0000)]
Fixed location of icon.gif

11 years agoadding more upgrade info
Petr Skoda [Wed, 24 Mar 2010 10:07:44 +0000 (10:07 +0000)]
adding more upgrade info

11 years ago"MDL-16639, php 5.2 don't understand ::static_func, use the old syntax"
Dongsheng Cai [Wed, 24 Mar 2010 09:42:32 +0000 (09:42 +0000)]
"MDL-16639, php 5.2 don't understand ::static_func, use the old syntax"

11 years agoadding more upgrade info
Petr Skoda [Wed, 24 Mar 2010 09:25:21 +0000 (09:25 +0000)]
adding more upgrade info

11 years agoadding more upgrade info
Petr Skoda [Wed, 24 Mar 2010 09:24:19 +0000 (09:24 +0000)]
adding more upgrade info

11 years agoadding more upgrade info
Petr Skoda [Wed, 24 Mar 2010 09:20:20 +0000 (09:20 +0000)]
adding more upgrade info

11 years agoadding more upgrade info
Petr Skoda [Wed, 24 Mar 2010 09:10:14 +0000 (09:10 +0000)]
adding more upgrade info

11 years agoMDL-21802 backporting patch for vulnerability in CAS client library
Petr Skoda [Wed, 24 Mar 2010 08:12:30 +0000 (08:12 +0000)]
MDL-21802 backporting patch for vulnerability in CAS client library

11 years ago"MDL-21906, disable filepicker for editor during installation"
Dongsheng Cai [Wed, 24 Mar 2010 06:38:10 +0000 (06:38 +0000)]
"MDL-21906, disable filepicker for editor during installation"

11 years agouser library MDL-21899 fix password not hashed
jerome mouneyrac [Wed, 24 Mar 2010 03:02:17 +0000 (03:02 +0000)]
user library MDL-21899 fix password not hashed

11 years agooutput MDL-20204 Fixed regression incorrect param type
Sam Hemelryk [Wed, 24 Mar 2010 02:35:16 +0000 (02:35 +0000)]
output MDL-20204 Fixed regression incorrect param type

11 years agoUpdated the HEAD build version to 20100324
Moodle Robot [Wed, 24 Mar 2010 00:41:34 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100324

11 years agoNOBUG: Now editorlib is using PEAR (forms) stuff. Move the include
Eloy Lafuente [Tue, 23 Mar 2010 11:14:26 +0000 (11:14 +0000)]
NOBUG: Now editorlib is using PEAR (forms) stuff. Move the include
path definition before including all the Moodle stuff.

11 years ago"MDL-16639, added static function to read editor option names"
Dongsheng Cai [Tue, 23 Mar 2010 08:53:47 +0000 (08:53 +0000)]
"MDL-16639, added static function to read editor option names"

11 years ago"MDL-16639, enable spellchecker plugin, and added config pages"
Dongsheng Cai [Tue, 23 Mar 2010 08:47:05 +0000 (08:47 +0000)]
"MDL-16639, enable spellchecker plugin, and added config pages"

11 years agomod-chat MDL-19804 Converted a couple of require calls to require_once calls
Sam Hemelryk [Tue, 23 Mar 2010 08:44:04 +0000 (08:44 +0000)]
mod-chat MDL-19804 Converted a couple of require calls to require_once calls

11 years ago"MDL-16639, checked new spellchecker plugin for tinymce"
Dongsheng Cai [Tue, 23 Mar 2010 08:28:56 +0000 (08:28 +0000)]
"MDL-16639, checked new spellchecker plugin for tinymce"

11 years agouser-selector MDL-21537 Refactored JS to make use of YUI3
Sam Hemelryk [Tue, 23 Mar 2010 07:38:32 +0000 (07:38 +0000)]
user-selector MDL-21537  Refactored JS to make use of YUI3
 *  YUI3 used instead of YUI2, converted all YUI2 components to YUI3 equivalents.
 * Renamed user/selector/script.js to module.js
 * Converted uses of the the user selector to YUI3 + the new events

11 years agoportfolio MDL-21034 fixed syntax error caused by too long lines and patching
Penny Leach [Tue, 23 Mar 2010 06:26:42 +0000 (06:26 +0000)]
portfolio MDL-21034   fixed syntax error caused by too long lines and patching

11 years ago"MDL-21883, filepicker fixed dynamics loading"
Dongsheng Cai [Tue, 23 Mar 2010 04:08:45 +0000 (04:08 +0000)]
"MDL-21883, filepicker fixed dynamics loading"

11 years agoUpdated the HEAD build version to 20100323
Moodle Robot [Tue, 23 Mar 2010 00:41:28 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100323

11 years agoMDL-19233 restore of roles - prevent role creation, role assignment and
Eloy Lafuente [Mon, 22 Mar 2010 22:33:30 +0000 (22:33 +0000)]
MDL-19233 restore of roles - prevent role creation, role assignment and
permission overrides by observing corresponding caps. Improve role mapping a bit.
Credit goes to Daniel Neis. Merged from 19_STABLE

11 years agoNOBUG: Normalise generated param names so we can safely use sql_xxx() helper function...
Eloy Lafuente [Mon, 22 Mar 2010 18:06:59 +0000 (18:06 +0000)]
NOBUG: Normalise generated param names so we can safely use sql_xxx() helper functions everywhere.

11 years agoNOBUG: comment is a reserved word for oracle. I reserve my comments about it ;-)
Eloy Lafuente [Mon, 22 Mar 2010 17:49:42 +0000 (17:49 +0000)]
NOBUG: comment is a reserved word for oracle. I reserve my comments about it ;-)

11 years agoNOBUG: Handle duplicated NAMED params in set_field() uses
Eloy Lafuente [Mon, 22 Mar 2010 17:00:46 +0000 (17:00 +0000)]
NOBUG: Handle duplicated NAMED params in set_field() uses

11 years agoNOBUG: Adding 3 new tests that reveal 2 different problems with NAMED params
Eloy Lafuente [Mon, 22 Mar 2010 14:41:57 +0000 (14:41 +0000)]
NOBUG: Adding 3 new tests that reveal 2 different problems with NAMED params

11 years agoportfolio MDL-21034 add extra leap2a metadata to forum export
Penny Leach [Mon, 22 Mar 2010 14:34:15 +0000 (14:34 +0000)]
portfolio MDL-21034   add extra leap2a metadata to forum export

11 years agoMDL-21894 "move functionality to create a token into function in externallib.php...
Jamie Pratt [Mon, 22 Mar 2010 14:20:18 +0000 (14:20 +0000)]
MDL-21894 "move functionality to create a token into function in externallib.php so it can be used when creating tokens for embedded applications" also fixed MDL-21893 "Errors in code for checking capability when creating token for service with requiredcapability" which I came across while re

11 years agoMDL-21874 - phisics are physics :-P
Eloy Lafuente [Mon, 22 Mar 2010 09:27:35 +0000 (09:27 +0000)]
MDL-21874 - phisics are physics :-P

11 years agoMDL-21874 - ddl object names cache. Don't use cache keys anymore. Leads to conflicts.
Eloy Lafuente [Mon, 22 Mar 2010 09:24:57 +0000 (09:24 +0000)]
MDL-21874 - ddl object names cache. Don't use cache keys anymore. Leads to conflicts.

11 years agoportfolio MDL-21030 be more selective about the mahara continue url (depending...
Penny Leach [Mon, 22 Mar 2010 09:04:02 +0000 (09:04 +0000)]
portfolio    MDL-21030 be more selective about the mahara continue url (depending on the export format)

11 years agoMDL-21652 removed html_table property 'style'
David Mudrak [Mon, 22 Mar 2010 08:16:30 +0000 (08:16 +0000)]
MDL-21652 removed html_table property 'style'

I copied this initially from the legacy html_component during the refactoring and forgot to check
if it is actually used. Credit goes to Sam H. for spotting it.

11 years agonavigation MDL-21565 Update this xxx is now automatically added to the nav for all...
Sam Hemelryk [Mon, 22 Mar 2010 03:04:00 +0000 (03:04 +0000)]
navigation MDL-21565 Update this xxx is now automatically added to the nav for all modules by default and is renamed to settings as that is what was being used in the tabs system presently anyway.
The following minor changes were also made:
* Added roles links to the navigation automatically
* Handling of block context for settings navigation
* Tidied up init code for settings navigation

11 years agorating MDL-21657 changes based on Petr's feedback
Andrew Davis [Mon, 22 Mar 2010 02:59:06 +0000 (02:59 +0000)]
rating MDL-21657 changes based on Petr's feedback

11 years agoEvents MDL-16203 fire events when a module is added/updated/deleted
Dan Marsden [Mon, 22 Mar 2010 02:56:45 +0000 (02:56 +0000)]
Events MDL-16203 fire events when a module is added/updated/deleted

11 years ago"MDL-13766, fixed typo"
Dongsheng Cai [Mon, 22 Mar 2010 01:55:40 +0000 (01:55 +0000)]
"MDL-13766, fixed typo"

11 years agoUpdated the HEAD build version to 20100322
Moodle Robot [Mon, 22 Mar 2010 00:41:54 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100322

11 years agoUnit test did not preserve session
David Mudrak [Sun, 21 Mar 2010 19:44:57 +0000 (19:44 +0000)]
Unit test did not preserve session

11 years agoMDL-21868 mssql generator - improve integer meta type detection + test
Eloy Lafuente [Sun, 21 Mar 2010 19:36:50 +0000 (19:36 +0000)]
MDL-21868 mssql generator - improve integer meta type detection + test

11 years agoMDL-21400 fixed group sinlge selects
Petr Skoda [Sun, 21 Mar 2010 18:00:34 +0000 (18:00 +0000)]
MDL-21400 fixed group sinlge selects

11 years agoMDL-21887 fixed borked JS, but still the groups ajax needs a major cleanup
Petr Skoda [Sun, 21 Mar 2010 17:36:28 +0000 (17:36 +0000)]
MDL-21887 fixed borked JS, but still the groups ajax needs a major cleanup

11 years agoportfolio/mnet/mahara MDL-15362 perform better mnet session handling
Penny Leach [Sun, 21 Mar 2010 17:20:36 +0000 (17:20 +0000)]
portfolio/mnet/mahara MDL-15362  perform better mnet session handling

11 years agoportfolio/mahara MDL-21030 finally enable leap2a support
Penny Leach [Sun, 21 Mar 2010 17:20:25 +0000 (17:20 +0000)]
portfolio/mahara MDL-21030  finally enable leap2a support

11 years agoportfolio/forunm MDL-21034 add on the discussion title
Penny Leach [Sun, 21 Mar 2010 17:20:16 +0000 (17:20 +0000)]
portfolio/forunm MDL-21034   add on the discussion title

when exporting a full forum thread as leap2a to the selection entry

11 years agoportfolio/assignment MDL-21035 add a leap2a selection entry when exporting multiple...
Penny Leach [Sun, 21 Mar 2010 17:20:06 +0000 (17:20 +0000)]
portfolio/assignment MDL-21035   add a leap2a selection entry when exporting multiple files

11 years agoportfolio MDL-16124 improved the portfolio_formats conflict resolution
Penny Leach [Sun, 21 Mar 2010 17:19:56 +0000 (17:19 +0000)]
portfolio MDL-16124   improved the portfolio_formats conflict resolution

11 years agoportfolio/leap2a MDL-21030 fixed a syntax problem in category schemes
Penny Leach [Sun, 21 Mar 2010 17:19:42 +0000 (17:19 +0000)]
portfolio/leap2a MDL-21030   fixed a syntax problem in category schemes

11 years agomoodlelib MDL-20110 - allow remoteip_in_list to return true for cli access
Dan Poltawski [Sun, 21 Mar 2010 15:03:26 +0000 (15:03 +0000)]
moodlelib MDL-20110 - allow remoteip_in_list to return true for cli access

Previously it always failed and restricted access for users blocking ips and
running cron from cli

11 years agorepository_ajax.php MDL-21882 - dont default to a repo id which may exist
Dan Poltawski [Sun, 21 Mar 2010 14:01:30 +0000 (14:01 +0000)]
repository_ajax.php MDL-21882 - dont default to a repo id which may exist

This seems like a dangerous thing to do as it may cause actions on repoid 1
inadvertantly

11 years agogoogledocs MDL-21881 - restore icons to repo plugin
Dan Poltawski [Sun, 21 Mar 2010 13:32:43 +0000 (13:32 +0000)]
googledocs MDL-21881 - restore icons to repo plugin

11 years agoMDL-21652 Fixed forgotten <th> scope handling
David Mudrak [Sun, 21 Mar 2010 10:28:52 +0000 (10:28 +0000)]
MDL-21652 Fixed forgotten <th> scope handling

11 years agoDL-21021 marking private_files block as standard plugin
Petr Skoda [Sun, 21 Mar 2010 10:25:15 +0000 (10:25 +0000)]
DL-21021 marking private_files block as standard plugin

11 years agoUpdated the HEAD build version to 20100321
Moodle Robot [Sun, 21 Mar 2010 00:41:46 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100321

11 years agoMDL-21652 html_table rendering refactored
David Mudrak [Sat, 20 Mar 2010 22:15:54 +0000 (22:15 +0000)]
MDL-21652 html_table rendering refactored

* class html_component does not exist any more
* class html_table rendered via html_writer::table()
* html_table, html_table_row and html_table_cell have public $attributes property to set their CSS classes
* dropped rotateheaders feature, should be added again after more research of possible ways (<svg> is not nice IMHO)
* dropped possibility to define CSS classes for table heading, body and footer - can be easily done and better done using just table class and context

11 years agonavigationlib: MDL-21209 - fix incorrect parameters
Dan Poltawski [Sat, 20 Mar 2010 15:02:15 +0000 (15:02 +0000)]
navigationlib: MDL-21209 - fix incorrect parameters

thanks to Enrique Robredo for the patch

11 years agocourse/lib.php MDL-21798 - remove the static menu cache for add menu
Dan Poltawski [Sat, 20 Mar 2010 14:44:35 +0000 (14:44 +0000)]
course/lib.php MDL-21798 - remove the static menu cache for add menu

The static menu was causing the add menu to always be adding resources to
section 1

I really tried to keep the static cache there, but I just couldn't find a way
to do it with it becoming really really ugly.

11 years agoMDL-14679 fixed double encoding of html entities in debuginfo coming from the dml...
Petr Skoda [Sat, 20 Mar 2010 13:46:15 +0000 (13:46 +0000)]
MDL-14679 fixed double encoding of html entities in debuginfo coming from the dml and ddl

11 years agoportfolio MDL-21878 fixed image export format conflicts
Penny Leach [Sat, 20 Mar 2010 13:14:02 +0000 (13:14 +0000)]
portfolio MDL-21878 fixed image export format conflicts

11 years agoMDL-21876 fixed incorrect uses of bound parameters - patch by Ashley Holman, thanks!
Petr Skoda [Sat, 20 Mar 2010 11:49:48 +0000 (11:49 +0000)]
MDL-21876 fixed incorrect uses of bound parameters - patch by Ashley Holman, thanks!

11 years agoMDL-21871 adding missing string for session autostart
Petr Skoda [Sat, 20 Mar 2010 11:17:43 +0000 (11:17 +0000)]
MDL-21871 adding missing string for session autostart

11 years agoportfolio MDL-20896 - update documentation to not lie ;-)
Dan Poltawski [Sat, 20 Mar 2010 10:41:07 +0000 (10:41 +0000)]
portfolio MDL-20896 - update documentation to not lie ;-)

11 years agoUpdated the HEAD build version to 20100320
Moodle Robot [Sat, 20 Mar 2010 00:43:28 +0000 (00:43 +0000)]
Updated the HEAD build version to 20100320

11 years agoAutomatic installer.php lang files by installer_builder (20100320)
Moodle Robot [Sat, 20 Mar 2010 00:32:34 +0000 (00:32 +0000)]
installer.php lang files by installer_builder (20100320)

11 years agoMDL-21788 string and setting cleanup of session regen, not needed in head where it...
Petr Skoda [Fri, 19 Mar 2010 17:11:14 +0000 (17:11 +0000)]
MDL-21788 string and setting cleanup of session regen, not needed in head where it is always on

11 years agorating MDL-21657 shifted upgrade_module_ratings()
Andrew Davis [Fri, 19 Mar 2010 08:54:20 +0000 (08:54 +0000)]
rating MDL-21657 shifted upgrade_module_ratings()

11 years agorating MDL-21657 shifted the rating migration code out of the main upgrade script...
Andrew Davis [Fri, 19 Mar 2010 08:26:38 +0000 (08:26 +0000)]
rating MDL-21657 shifted the rating migration code out of the main upgrade script and into the modules

11 years agoMDL-21788 string and setting cleanup of session regen, not needed in head where it...
Petr Skoda [Fri, 19 Mar 2010 08:00:29 +0000 (08:00 +0000)]
MDL-21788 string and setting cleanup of session regen, not needed in head where it is always on

11 years agorating MDL-21657 modified moodle/rating:rate risks
Andrew Davis [Fri, 19 Mar 2010 07:37:51 +0000 (07:37 +0000)]
rating MDL-21657 modified moodle/rating:rate risks

11 years agorating MDL-21657 split the class rating into rating and rating_manager
Andrew Davis [Fri, 19 Mar 2010 07:20:13 +0000 (07:20 +0000)]
rating MDL-21657 split the class rating into rating and rating_manager

11 years agorating MDL-21657 started making ratings API more like comments and split rate.php...
Andrew Davis [Fri, 19 Mar 2010 06:55:47 +0000 (06:55 +0000)]
rating MDL-21657 started making ratings API more like comments and split rate.php into rate.php and rate_ajax.php

11 years agoAssignment Events MDL-21861 - trigger events when files are uploaded in assignment...
Dan Marsden [Fri, 19 Mar 2010 06:20:12 +0000 (06:20 +0000)]
Assignment Events MDL-21861 - trigger events when files are uploaded in assignment to allow further handling - particularly for plagiarism prevention

11 years ago"MDL-15405, fixed filearea parameter in filemanager"
Dongsheng Cai [Fri, 19 Mar 2010 05:00:11 +0000 (05:00 +0000)]
"MDL-15405, fixed filearea parameter in filemanager"

11 years ago"MDL-19118, fixed comments api in format_text function"
Dongsheng Cai [Fri, 19 Mar 2010 04:53:54 +0000 (04:53 +0000)]
"MDL-19118, fixed comments api in format_text function"

11 years agorating MDL-21657 changed ratings rendering to avoid a nonconstant element name
Andrew Davis [Fri, 19 Mar 2010 02:24:44 +0000 (02:24 +0000)]
rating MDL-21657 changed ratings rendering to avoid a nonconstant element name

11 years agorating MDL-21657 changed rating::load_ratings so the default scale constant has a...
Andrew Davis [Fri, 19 Mar 2010 02:08:31 +0000 (02:08 +0000)]
rating MDL-21657 changed rating::load_ratings so the default scale constant has a better name

11 years agoUpdated the HEAD build version to 20100319
Moodle Robot [Fri, 19 Mar 2010 00:42:25 +0000 (00:42 +0000)]
Updated the HEAD build version to 20100319

11 years agoMDL-21859 fixed sesskey protection on email actions
Petr Skoda [Thu, 18 Mar 2010 22:54:17 +0000 (22:54 +0000)]
MDL-21859 fixed sesskey protection on email actions

11 years agoMDL-21830 Prevent users from viewing names of all other site users - only teachers...
Petr Skoda [Thu, 18 Mar 2010 22:15:41 +0000 (22:15 +0000)]
MDL-21830 Prevent users from viewing names of all other site users - only teachers with role assign see the full name of not enrolled users when trying to access the profile

11 years agoMDL-21068 do not show admin usernames in cron logs
Petr Skoda [Thu, 18 Mar 2010 22:00:09 +0000 (22:00 +0000)]
MDL-21068 do not show admin usernames in cron logs

11 years agoMDL-21649 fixed form value quoting
Petr Skoda [Thu, 18 Mar 2010 21:23:15 +0000 (21:23 +0000)]
MDL-21649 fixed form value quoting

11 years agoMDL-21818 fixed globals problems
Petr Skoda [Thu, 18 Mar 2010 20:59:58 +0000 (20:59 +0000)]
MDL-21818 fixed globals problems

11 years agoMDL-20204 fixed calling of undefined method
David Mudrak [Thu, 18 Mar 2010 18:47:39 +0000 (18:47 +0000)]
MDL-20204 fixed calling of undefined method

11 years agoMDL-20204 fixed typo in variable name
David Mudrak [Thu, 18 Mar 2010 18:33:40 +0000 (18:33 +0000)]
MDL-20204 fixed typo in variable name

11 years agoMDL-20204 fixed calling of a dropped html_component method on block_contents
David Mudrak [Thu, 18 Mar 2010 17:11:16 +0000 (17:11 +0000)]
MDL-20204 fixed calling of a dropped html_component method on block_contents

11 years agoMDL-20204 fixed calling of a dropped html_component method on block_contents
David Mudrak [Thu, 18 Mar 2010 16:49:03 +0000 (16:49 +0000)]
MDL-20204 fixed calling of a dropped html_component method on block_contents

11 years ago"MDL-19118, improve comments pagination"
Dongsheng Cai [Thu, 18 Mar 2010 09:57:32 +0000 (09:57 +0000)]
"MDL-19118, improve comments pagination"

11 years ago"MDL-21443, fixed phpdocs"
Dongsheng Cai [Thu, 18 Mar 2010 09:45:25 +0000 (09:45 +0000)]
"MDL-21443, fixed phpdocs"

11 years ago"MDL-19118, improve comments block"
Dongsheng Cai [Thu, 18 Mar 2010 09:42:30 +0000 (09:42 +0000)]
"MDL-19118, improve comments block"

11 years agorating MDL-21657 put default scale in a constant
Andrew Davis [Thu, 18 Mar 2010 09:26:53 +0000 (09:26 +0000)]
rating MDL-21657 put default scale in a constant

11 years agorating MDL-21657 switched from putting permissions in constants to using literal...
Andrew Davis [Thu, 18 Mar 2010 08:59:10 +0000 (08:59 +0000)]
rating MDL-21657 switched from putting permissions in constants to using literal strings

11 years agorating MDL-21657 changed inner joins to just joins
Andrew Davis [Thu, 18 Mar 2010 08:47:50 +0000 (08:47 +0000)]
rating MDL-21657 changed inner joins to just joins

11 years agorating MDL-21657 updated aliasing and unaliasing of the fields returned by user_pictu...
Andrew Davis [Thu, 18 Mar 2010 08:17:21 +0000 (08:17 +0000)]
rating MDL-21657 updated aliasing and unaliasing of the fields returned by user_picture::fields

11 years agorating MDL-21657 added aliasing and unaliasing of the fields returned by user_picture...
Andrew Davis [Thu, 18 Mar 2010 08:12:13 +0000 (08:12 +0000)]
rating MDL-21657 added aliasing and unaliasing of the fields returned by user_picture::fields

11 years agoMDL-21851 adding idalias to user_picture::fields()
Petr Skoda [Thu, 18 Mar 2010 07:41:57 +0000 (07:41 +0000)]
MDL-21851 adding idalias to user_picture::fields()

11 years agorating MDL-21657 improved the default rating permissions
Andrew Davis [Thu, 18 Mar 2010 07:14:49 +0000 (07:14 +0000)]
rating MDL-21657 improved the default rating permissions

11 years agotheme MDL-20204 Fixed regression with theme selector in category edit form
Sam Hemelryk [Thu, 18 Mar 2010 06:02:41 +0000 (06:02 +0000)]
theme MDL-20204 Fixed regression with theme selector in category edit form

11 years agorating MDL-21657 improved the phpdoc comments
Andrew Davis [Thu, 18 Mar 2010 05:54:59 +0000 (05:54 +0000)]
rating MDL-21657 improved the phpdoc comments

11 years agodatalib MDL-14679 Fixed regression in get_logs_userday function, missing argument
Sam Hemelryk [Thu, 18 Mar 2010 05:48:21 +0000 (05:48 +0000)]
datalib MDL-14679 Fixed regression in get_logs_userday function, missing argument

11 years agorating MDL-21657 changed to make use use of user_picture::fields()
Andrew Davis [Thu, 18 Mar 2010 04:08:52 +0000 (04:08 +0000)]
rating MDL-21657 changed to make use use of user_picture::fields()

11 years agorating MDL-21657 more changes based on Petr's feedback
Andrew Davis [Thu, 18 Mar 2010 03:47:12 +0000 (03:47 +0000)]
rating MDL-21657 more changes based on Petr's feedback