moodle.git
12 years agoMDL-21577 fixed regression, thanks James Gheel for the patch
Petr Skoda [Wed, 10 Feb 2010 15:52:34 +0000 (15:52 +0000)]
MDL-21577 fixed regression, thanks James Gheel for the patch

12 years agoMDL-20204 legacy time selects converted, please note we should always use mforms...
Petr Skoda [Wed, 10 Feb 2010 14:27:03 +0000 (14:27 +0000)]
MDL-20204 legacy time selects converted, please note we should always use mforms if possible

12 years agoMDL-20204 converting yes_no selects
Petr Skoda [Wed, 10 Feb 2010 14:05:07 +0000 (14:05 +0000)]
MDL-20204 converting yes_no selects

12 years agoMDL-20204 all popup forms converted
Petr Skoda [Wed, 10 Feb 2010 12:00:18 +0000 (12:00 +0000)]
MDL-20204 all popup forms converted

12 years agoMDL-20204 more single_selects converted
Petr Skoda [Wed, 10 Feb 2010 11:51:49 +0000 (11:51 +0000)]
MDL-20204 more single_selects converted

12 years agoMDL-20204 sorry for the forgotten debug code
Petr Skoda [Wed, 10 Feb 2010 11:38:14 +0000 (11:38 +0000)]
MDL-20204 sorry for the forgotten debug code

12 years agoMDL-20204 fixed regression from button conversion
Petr Skoda [Wed, 10 Feb 2010 11:35:54 +0000 (11:35 +0000)]
MDL-20204 fixed regression from button conversion

12 years agoMDL-20204 init weirdness TODO
Petr Skoda [Wed, 10 Feb 2010 11:34:59 +0000 (11:34 +0000)]
MDL-20204 init weirdness TODO

12 years agoMDL-20204 more steps away from old popup_form
Petr Skoda [Wed, 10 Feb 2010 11:25:17 +0000 (11:25 +0000)]
MDL-20204 more steps away from old popup_form

12 years agoMDL-20204 using url_select
Petr Skoda [Wed, 10 Feb 2010 10:55:51 +0000 (10:55 +0000)]
MDL-20204 using url_select

12 years agoMDL-20204 fixed docs
Petr Skoda [Wed, 10 Feb 2010 10:23:09 +0000 (10:23 +0000)]
MDL-20204 fixed docs

12 years agoMDL-20204 new url_select widget
Petr Skoda [Wed, 10 Feb 2010 10:22:25 +0000 (10:22 +0000)]
MDL-20204 new url_select widget

12 years agoMDL-20204 added forgotten support for disabled in single_select
Petr Skoda [Wed, 10 Feb 2010 09:46:44 +0000 (09:46 +0000)]
MDL-20204 added forgotten support for disabled in single_select

12 years agoMDL-20204 a lot more steps away from html_select
Petr Skoda [Wed, 10 Feb 2010 09:37:50 +0000 (09:37 +0000)]
MDL-20204 a lot more steps away from html_select

12 years agoMDL-20808 Fixes for amf web services and test client - a web service browser.
Jamie Pratt [Wed, 10 Feb 2010 08:44:46 +0000 (08:44 +0000)]
MDL-20808 Fixes for amf web services and test client - a web service browser.

Includes :

MDL-21552 amf web services need to accept params and return values of proper type

MDL-21553 amf web service : In Flash an array has normally a numeri

12 years agonavigation MDL-21564 Fixed regression whereby the last course section was not being...
Sam Hemelryk [Wed, 10 Feb 2010 01:28:17 +0000 (01:28 +0000)]
navigation MDL-21564 Fixed regression whereby the last course section was not being shown on the navigation

12 years agonavigation MDL-21560 Fixed method of finding active admin settings page.
Sam Hemelryk [Wed, 10 Feb 2010 01:12:59 +0000 (01:12 +0000)]
navigation MDL-21560 Fixed method of finding active admin settings page.

12 years agoUpdated the HEAD build version to 20100210
Moodle Robot [Wed, 10 Feb 2010 00:42:39 +0000 (00:42 +0000)]
Updated the HEAD build version to 20100210

12 years agoAutomatic installer.php lang files by installer_builder (20100210)
Moodle Robot [Wed, 10 Feb 2010 00:31:27 +0000 (00:31 +0000)]
installer.php lang files by installer_builder (20100210)

12 years agoMDL-20204 some more steps away from html_select
Petr Skoda [Tue, 9 Feb 2010 19:50:11 +0000 (19:50 +0000)]
MDL-20204 some more steps away from html_select

12 years agoMDL-20204 more steps away from html_select
Petr Skoda [Tue, 9 Feb 2010 19:23:11 +0000 (19:23 +0000)]
MDL-20204 more steps away from html_select

12 years agoMDL-20204 one more step away from html_select
Petr Skoda [Tue, 9 Feb 2010 18:54:03 +0000 (18:54 +0000)]
MDL-20204 one more step away from html_select

12 years agoMDL-16184 - revert earlier work for x.start.time, and apply patch from valerian ...
Piers Harding [Tue, 9 Feb 2010 18:43:15 +0000 (18:43 +0000)]
MDL-16184 - revert earlier work for x.start.time, and apply patch from valerian (incidental fix for user_picture)

12 years agoMDL-20204 converting to new checkboxes
Petr Skoda [Tue, 9 Feb 2010 18:17:21 +0000 (18:17 +0000)]
MDL-20204 converting to new checkboxes

12 years agoMDL-20204 new html_writer::checkbox fixed
Petr Skoda [Tue, 9 Feb 2010 18:16:14 +0000 (18:16 +0000)]
MDL-20204 new html_writer::checkbox fixed

12 years agoMDL-20204 new html_writer::checkbox
Petr Skoda [Tue, 9 Feb 2010 18:04:16 +0000 (18:04 +0000)]
MDL-20204 new html_writer::checkbox

12 years agoMDL-18202 - fix incorrect substitutions of '_'.
Piers Harding [Tue, 9 Feb 2010 18:00:43 +0000 (18:00 +0000)]
MDL-18202 - fix incorrect substitutions of '_'.

12 years agofixed regression
Petr Skoda [Tue, 9 Feb 2010 17:56:26 +0000 (17:56 +0000)]
fixed regression

12 years agoMDL-20204 new single_select + cleanup
Petr Skoda [Tue, 9 Feb 2010 17:39:13 +0000 (17:39 +0000)]
MDL-20204 new single_select + cleanup

12 years agoMDL-21558 fixed php warning in case no local plugins are installed
David Mudrak [Tue, 9 Feb 2010 17:27:39 +0000 (17:27 +0000)]
MDL-21558 fixed php warning in case no local plugins are installed

Thanks Stephen Bourget for a prompt report

12 years agoMDL-21400 yet another IE weirdness fixed
Petr Skoda [Tue, 9 Feb 2010 14:48:29 +0000 (14:48 +0000)]
MDL-21400 yet another IE weirdness fixed

12 years agoMDL-21558 fixed sorting of installed local plugins
David Mudrak [Tue, 9 Feb 2010 14:15:43 +0000 (14:15 +0000)]
MDL-21558 fixed sorting of installed local plugins

A typo caused loosing of array keys that are needed in the later
foreach loop

12 years agofixed sloppy IE regression, sorrrryyyyy
Petr Skoda [Tue, 9 Feb 2010 13:39:37 +0000 (13:39 +0000)]
fixed sloppy IE regression, sorrrryyyyy

12 years agowebservice MDL-16805 fix REST server bug: empty list (<MULTIPLE></MULTIPLE>) without...
jerome mouneyrac [Tue, 9 Feb 2010 09:26:03 +0000 (09:26 +0000)]
webservice MDL-16805 fix REST server bug:  empty list (<MULTIPLE></MULTIPLE>) without php error

12 years agojavascript-modules MDL-21400 Fixed up some recent module regressions
Sam Hemelryk [Tue, 9 Feb 2010 01:38:45 +0000 (01:38 +0000)]
javascript-modules MDL-21400 Fixed up some recent module regressions

12 years agoUpdated the HEAD build version to 20100209
Moodle Robot [Tue, 9 Feb 2010 00:41:03 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100209

12 years agoAutomatic installer.php lang files by installer_builder (20100209)
Moodle Robot [Tue, 9 Feb 2010 00:30:19 +0000 (00:30 +0000)]
installer.php lang files by installer_builder (20100209)

12 years agoMDL-10110 removing common code with calculated/questiontype.php
Pierre Pichet [Mon, 8 Feb 2010 20:27:49 +0000 (20:27 +0000)]
MDL-10110 removing common code with calculated/questiontype.php

12 years agoMDL-10110 removing call to multichoice field from code
Pierre Pichet [Mon, 8 Feb 2010 18:47:16 +0000 (18:47 +0000)]
MDL-10110 removing call to multichoice field from code

12 years agoMDL-10110 dropping multichoice field in question_calculated_options table
Pierre Pichet [Mon, 8 Feb 2010 18:44:53 +0000 (18:44 +0000)]
MDL-10110 dropping multichoice field in question_calculated_options table

12 years agoMDL-21557 potential fix for IE CSS issues in debug mode
Petr Skoda [Mon, 8 Feb 2010 16:50:12 +0000 (16:50 +0000)]
MDL-21557 potential fix for IE CSS issues in debug mode

12 years agoMDL-21392 it is possible to have settings without Save button
Petr Skoda [Mon, 8 Feb 2010 16:26:15 +0000 (16:26 +0000)]
MDL-21392 it is possible to have settings without Save button

12 years agoMDL-21558 adding local plugins management page into the admin tree
David Mudrak [Mon, 8 Feb 2010 16:03:37 +0000 (16:03 +0000)]
MDL-21558 adding local plugins management page into the admin tree

The new admin external page admin/localplugins.php provides a list of
installed local plugins with a possibility to remove it.

12 years agoremoving old amf test client code and swf
Jamie Pratt [Mon, 8 Feb 2010 11:30:55 +0000 (11:30 +0000)]
removing old amf test client code and swf

12 years agoworkshop: fixing minor issues discovered during the preparation of iMoot2010 talk
David Mudrak [Mon, 8 Feb 2010 08:53:43 +0000 (08:53 +0000)]
workshop: fixing minor issues discovered during the preparation of iMoot2010 talk

12 years agogradebook MDL-21218 Improved the hiding/displaying of category and course totals...
Andrew Davis [Mon, 8 Feb 2010 06:27:04 +0000 (06:27 +0000)]
gradebook MDL-21218 Improved the hiding/displaying of category and course totals when they contain hidden items

12 years agonavigation MDL-21529 Added a close icon to docked item panels + show/hide event impro...
Sam Hemelryk [Mon, 8 Feb 2010 04:09:18 +0000 (04:09 +0000)]
navigation MDL-21529 Added a close icon to docked item panels + show/hide event improvements

12 years agowebservice MDL-21510 added two new DEFINE values: NULL_ALLOWED and NULL_NOT_ALLOWED
jerome mouneyrac [Mon, 8 Feb 2010 03:49:52 +0000 (03:49 +0000)]
webservice MDL-21510 added two new DEFINE values: NULL_ALLOWED and NULL_NOT_ALLOWED

12 years agooutputrequirements MDL-21400 Added missing YUI2 module required by dock
Sam Hemelryk [Mon, 8 Feb 2010 03:25:45 +0000 (03:25 +0000)]
outputrequirements MDL-21400 Added missing YUI2 module required by dock

12 years agoUpdated the HEAD build version to 20100208
Moodle Robot [Mon, 8 Feb 2010 00:40:53 +0000 (00:40 +0000)]
Updated the HEAD build version to 20100208

12 years agoMDL-20204 more outputlib changes towards separate html_writer
Petr Skoda [Sun, 7 Feb 2010 20:12:31 +0000 (20:12 +0000)]
MDL-20204 more outputlib changes towards separate html_writer

12 years agoMDL-10110 Modifications related to the creation of the calculatedmulti question type
Pierre Pichet [Sun, 7 Feb 2010 19:52:52 +0000 (19:52 +0000)]
MDL-10110 Modifications related to the creation of the calculatedmulti question type

12 years agoMDL-10110 Creating the calculatedmulti question type
Pierre Pichet [Sun, 7 Feb 2010 19:50:10 +0000 (19:50 +0000)]
MDL-10110 Creating the calculatedmulti question type

12 years agoMDL-21400 apparently tinymce loading is not compatible with our brand new JS caching...
Petr Skoda [Sun, 7 Feb 2010 13:26:28 +0000 (13:26 +0000)]
MDL-21400 apparently tinymce loading is not compatible with our brand new JS caching yet ;-)

12 years agoMDL-21400 main version bump - initialised jsrev counter
Petr Skoda [Sun, 7 Feb 2010 13:18:03 +0000 (13:18 +0000)]
MDL-21400 main version bump - initialised jsrev counter

12 years agoMDL-21400 thems and JS now using the same script naming convention and parameter...
Petr Skoda [Sun, 7 Feb 2010 13:08:46 +0000 (13:08 +0000)]
MDL-21400 thems and JS now using the same script naming convention and parameter style

12 years agoMDL-20601 added missing covnersion of url placeholders
Petr Skoda [Sun, 7 Feb 2010 12:58:25 +0000 (12:58 +0000)]
MDL-20601 added missing covnersion of url placeholders

12 years agoMDL-21400 finally, gzip for JS files and proper caching - without admin UI for now...
Petr Skoda [Sun, 7 Feb 2010 12:50:53 +0000 (12:50 +0000)]
MDL-21400 finally, gzip for JS files and proper caching - without admin UI for now (off by default)

12 years agoMDL-21420 finally moving old global mstr to new M.str.
Petr Skoda [Sun, 7 Feb 2010 09:43:07 +0000 (09:43 +0000)]
MDL-21420 finally moving old global mstr to new M.str.

12 years agoMDL-21400 JS modules now include needed strings in module description + fixed some...
Petr Skoda [Sun, 7 Feb 2010 09:34:19 +0000 (09:34 +0000)]
MDL-21400 JS modules now include needed strings in module description + fixed some string and icon issues in file picker

12 years agoMDL-21400 JS != ajax and page requirements are also CSS - making new special lib...
Petr Skoda [Sun, 7 Feb 2010 08:45:21 +0000 (08:45 +0000)]
MDL-21400 JS != ajax and page requirements are also CSS - making new special lib file for page requirements

12 years agoUpdated the HEAD build version to 20100207
Moodle Robot [Sun, 7 Feb 2010 00:40:22 +0000 (00:40 +0000)]
Updated the HEAD build version to 20100207

12 years agoMDL-21400 imscp module converted to new JS coding style
Petr Skoda [Sat, 6 Feb 2010 19:44:58 +0000 (19:44 +0000)]
MDL-21400 imscp module converted to new JS coding style

12 years agoMDL-21400 fixed filepicker regression
Petr Skoda [Sat, 6 Feb 2010 19:43:35 +0000 (19:43 +0000)]
MDL-21400 fixed filepicker regression

12 years agoMDL-21400 fixed borked yui CSS when image contained "_"
Petr Skoda [Sat, 6 Feb 2010 19:41:20 +0000 (19:41 +0000)]
MDL-21400 fixed borked yui CSS when image contained "_"

12 years agoMDL-21400 fixed yui2 laoding from footer
Petr Skoda [Sat, 6 Feb 2010 19:39:28 +0000 (19:39 +0000)]
MDL-21400 fixed yui2 laoding from footer

12 years agoMDL-21400 fixed my own ugly mess in resizing of embedded stuff + converted to YUI3
Petr Skoda [Sat, 6 Feb 2010 18:47:44 +0000 (18:47 +0000)]
MDL-21400 fixed my own ugly mess in resizing of embedded stuff + converted to YUI3

12 years agoMDL-21400 converted mod/folder to new JS coding style
Petr Skoda [Sat, 6 Feb 2010 17:58:07 +0000 (17:58 +0000)]
MDL-21400 converted mod/folder to new JS coding style

12 years agoMDL-21400 JS confirm dialog converted to YUI3/2
Petr Skoda [Sat, 6 Feb 2010 17:35:11 +0000 (17:35 +0000)]
MDL-21400 JS confirm dialog converted to YUI3/2

12 years agoMDL-21400 removing some YUI2 extras
Petr Skoda [Sat, 6 Feb 2010 15:59:29 +0000 (15:59 +0000)]
MDL-21400 removing some YUI2 extras

12 years agoMDL-21400 load as few YUI2 as possible
Petr Skoda [Sat, 6 Feb 2010 15:26:47 +0000 (15:26 +0000)]
MDL-21400 load as few YUI2 as possible

12 years agoMDL-21400 converting JS set_user_preference to M namespace and YUI3
Petr Skoda [Sat, 6 Feb 2010 15:20:24 +0000 (15:20 +0000)]
MDL-21400 converting JS set_user_preference to M namespace and YUI3

12 years agoMDL-21400 converting help tooltips to YUI3/2
Petr Skoda [Sat, 6 Feb 2010 15:08:12 +0000 (15:08 +0000)]
MDL-21400 converting help tooltips to YUI3/2

12 years agoMDL-21400 finalising JS api - removing ->on_dom_ready (now bool param in js() and...
Petr Skoda [Sat, 6 Feb 2010 14:45:17 +0000 (14:45 +0000)]
MDL-21400 finalising JS api - removing ->on_dom_ready (now bool param in js() and js_init_call()) and after_delay() (again int parameter) - the reason is it was adding unnecessary complexity and it is used in just a few places that will be eventually converted to the new js_init_call() anyway

12 years agoMDL-21532 ->in_head() now really exceptional (after overrlib removal there will be...
Petr Skoda [Sat, 6 Feb 2010 14:09:33 +0000 (14:09 +0000)]
MDL-21532 ->in_head() now really exceptional (after overrlib removal there will be just a few of them)

12 years agoMDL-21400 removed js_object_init, the new js_init_call is a new replacement which...
Petr Skoda [Sat, 6 Feb 2010 13:56:31 +0000 (13:56 +0000)]
MDL-21400 removed js_object_init, the new js_init_call is a new replacement which encourages our new standard coding style

12 years agoMDL-21400 the correct namespace for blcoks is M.block_xxx, not M.blockS_xxx - the...
Petr Skoda [Sat, 6 Feb 2010 13:34:54 +0000 (13:34 +0000)]
MDL-21400 the correct namespace for blcoks is M.block_xxx, not M.blockS_xxx - the /blocks/ directory name is ugly exception, we use singulars everywhere else

12 years agoMDL-21400 ->in_head() from deprecated data_for_js(), this actually also fixes order...
Petr Skoda [Sat, 6 Feb 2010 13:30:15 +0000 (13:30 +0000)]
MDL-21400 ->in_head() from deprecated data_for_js(), this actually also fixes order of loading of libs+init code

12 years agoMDL-21400 removing inhead - not tested
Petr Skoda [Sat, 6 Feb 2010 13:00:51 +0000 (13:00 +0000)]
MDL-21400 removing inhead - not tested

12 years agoMDL-21400 migrated falsh detection to YUI3
Petr Skoda [Sat, 6 Feb 2010 12:58:19 +0000 (12:58 +0000)]
MDL-21400 migrated falsh detection to YUI3

12 years agoMDL-21400 removing unneeded in_head()
Petr Skoda [Sat, 6 Feb 2010 12:43:03 +0000 (12:43 +0000)]
MDL-21400 removing unneeded in_head()

12 years agoMDL-21400 converted ufo embedding to new style
Petr Skoda [Sat, 6 Feb 2010 12:41:09 +0000 (12:41 +0000)]
MDL-21400 converted ufo embedding to new style

12 years agoMDL-21400 converted message JS to new coding style, I was unable to test this because...
Petr Skoda [Sat, 6 Feb 2010 12:38:07 +0000 (12:38 +0000)]
MDL-21400 converted message JS to new coding style, I was unable to test this because th UI is a bit borked now

12 years agoMDL-21400 converted iplookup to YUI3, removed in_head()
Petr Skoda [Sat, 6 Feb 2010 12:12:23 +0000 (12:12 +0000)]
MDL-21400 converted iplookup to YUI3, removed in_head()

12 years agoMDL-21400 fixed & quoting issues
Petr Skoda [Sat, 6 Feb 2010 12:11:34 +0000 (12:11 +0000)]
MDL-21400 fixed & quoting issues

12 years agoUpdated the HEAD build version to 20100206
Moodle Robot [Sat, 6 Feb 2010 00:41:01 +0000 (00:41 +0000)]
Updated the HEAD build version to 20100206

12 years agoAutomatic installer.php lang files by installer_builder (20100206)
Moodle Robot [Sat, 6 Feb 2010 00:30:17 +0000 (00:30 +0000)]
installer.php lang files by installer_builder (20100206)

12 years agoquestion state loading MDL-9327 and MDL-19114 fix loading the state of ungraded essay...
Tim Hunt [Fri, 5 Feb 2010 16:37:01 +0000 (16:37 +0000)]
question state loading MDL-9327 and MDL-19114 fix loading the state of ungraded essay questions

In two situations, the correct state was not being loaded for essay questions that had
not yet been manually graded:
1. When starting a subsequent attempt in each attempt builds on last mode.
2. In the quiz reports.

This commit fixes the problem. It has one other side-effect. When viewing the individual
question grades in the overview report for an attempt that is still in progress, the
information displayed will be slightly different. This only affects adaptive mode quizzes,
and will acutally cause the report to show slighly more up-to-date information.

Interestingly, the reportlib.php change had already been made in HEAD, as part of MDL 16529

12 years agotheme-anomaly MDL-20175 Mega theme changes for anomaly
Sam Hemelryk [Fri, 5 Feb 2010 08:38:02 +0000 (08:38 +0000)]
theme-anomaly MDL-20175 Mega theme changes for anomaly
* Changed layout from tables to the 3 divs (2,1,3)
* Cleaned up the all of the images, remade where required with optimised palettes
* Rewrote CSS, this is ongoing process with changes required in both base and anomaly
* Customised the dock to fit with the theme
* Implemented a custom renderer to achieve rounded corners in IE + Opera (CSS otherwise)

12 years agoMDL-21503 RIP global Y
Petr Skoda [Fri, 5 Feb 2010 08:31:52 +0000 (08:31 +0000)]
MDL-21503 RIP global Y

12 years agoMDL-21503 fixed unintended use of global Y
Petr Skoda [Fri, 5 Feb 2010 08:31:28 +0000 (08:31 +0000)]
MDL-21503 fixed unintended use of global Y

12 years agoMDL-21509 - include timecreate field (user table) to backup and restore.
Rossiani Wijaya [Fri, 5 Feb 2010 08:08:57 +0000 (08:08 +0000)]
MDL-21509 - include timecreate field (user table) to backup and restore.

12 years agowebservice MDL-17135 fix typo bug returning exception when we have good right on...
jerome mouneyrac [Fri, 5 Feb 2010 07:58:29 +0000 (07:58 +0000)]
webservice MDL-17135 fix typo bug returning exception when we have good right on the context

12 years agoMDL-16919 - add validation to upload user data according to the upload type.
Rossiani Wijaya [Fri, 5 Feb 2010 07:30:53 +0000 (07:30 +0000)]
MDL-16919 -  add validation to upload user data according to the upload type.

12 years agogradebook MDL-21218 course and category totals behaviour when they contain hidden...
Andrew Davis [Fri, 5 Feb 2010 06:42:01 +0000 (06:42 +0000)]
gradebook MDL-21218 course and category totals behaviour when they contain hidden items

12 years agojavascript MDL-21503 Removed use of the global Y from dock, navigation and calendar
Sam Hemelryk [Fri, 5 Feb 2010 06:36:09 +0000 (06:36 +0000)]
javascript MDL-21503 Removed use of the global Y from dock, navigation and calendar
Also included in this patch the ability to switch the dock from the left to right side of the screen.
Altered js_object_init to deliver Y like js_init_call does now.
Several minor tweaks made to the dock and navigation as well at the same time.

12 years agowebservice MDL-21511 display debug info when the exception return is invalid paramete...
jerome mouneyrac [Fri, 5 Feb 2010 06:30:47 +0000 (06:30 +0000)]
webservice MDL-21511 display debug info when the exception return is invalid parameter type

12 years agogradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly
Andrew Davis [Fri, 5 Feb 2010 05:45:02 +0000 (05:45 +0000)]
gradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly

12 years agogradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly
Andrew Davis [Fri, 5 Feb 2010 05:33:10 +0000 (05:33 +0000)]
gradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly

12 years agogradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly
Andrew Davis [Fri, 5 Feb 2010 05:20:13 +0000 (05:20 +0000)]
gradebook MDL-21513 navigation dropdown in gradebook wasnt working correctly