moodle.git
8 years agoMerge branch 'MDL-34275-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE
Eloy Lafuente (stronk7) [Tue, 7 May 2013 17:14:19 +0000 (19:14 +0200)]
Merge branch 'MDL-34275-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-36223-23' of git://github.com/damyon/moodle into MOODLE_23_STABLE
Dan Poltawski [Tue, 7 May 2013 14:28:42 +0000 (15:28 +0100)]
Merge branch 'MDL-36223-23' of git://github.com/damyon/moodle into MOODLE_23_STABLE

8 years agoMDL-37245 Blog: Fixed comments.
Rajesh Taneja [Tue, 7 May 2013 09:13:44 +0000 (17:13 +0800)]
MDL-37245 Blog: Fixed comments.

Conflicts:

blog/lib.php

Signed-off-by: Rajesh Taneja <rajesh@moodle.com>
Conflicts:

blog/lib.php

8 years agoMDL-37245 Blog: Added permission check for blog comments
Rajesh Taneja [Tue, 7 May 2013 09:12:50 +0000 (17:12 +0800)]
MDL-37245 Blog: Added permission check for blog comments

Conflicts:

blog/index.php

Signed-off-by: Rajesh Taneja <rajesh@moodle.com>
8 years agoMerge branch 'MDL-38500-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE
Dan Poltawski [Tue, 7 May 2013 10:54:32 +0000 (11:54 +0100)]
Merge branch 'MDL-38500-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE

8 years agoMDL-34275 - Use default copyright license when restoring files
Rex Lorenzo [Wed, 11 Jul 2012 22:15:09 +0000 (15:15 -0700)]
MDL-34275 - Use default copyright license when restoring files

8 years agoMerge branch 'MDL-31713_override_23' of git://github.com/andyjdavis/moodle into MOODL...
Damyon Wiese [Tue, 7 May 2013 07:31:41 +0000 (15:31 +0800)]
Merge branch 'MDL-31713_override_23' of git://github.com/andyjdavis/moodle into MOODLE_23_STABLE

8 years agoMDL-31713 core_grade: added updating of grade min and max to update_final_grade()
Andrew Davis [Sun, 21 Apr 2013 07:30:13 +0000 (15:30 +0800)]
MDL-31713 core_grade: added updating of grade min and max to update_final_grade()

8 years agoMDL-39169: Now the question's tags are added in backup/restore options
Maria Torres [Fri, 26 Apr 2013 00:12:01 +0000 (12:12 +1200)]
MDL-39169: Now the question's tags are added in backup/restore options

8 years agoMerge branch 'MDL-38315-m23' of git://github.com/sammarshallou/moodle into MOODLE_23_...
Damyon Wiese [Mon, 6 May 2013 14:06:01 +0000 (22:06 +0800)]
Merge branch 'MDL-38315-m23' of git://github.com/sammarshallou/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39446_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Dan Poltawski [Mon, 6 May 2013 13:48:23 +0000 (14:48 +0100)]
Merge branch 'MDL-39446_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39491-workshop-media_23' of git://github.com/mudrd8mz/moodle into...
Dan Poltawski [Mon, 6 May 2013 12:12:23 +0000 (13:12 +0100)]
Merge branch 'MDL-39491-workshop-media_23' of git://github.com/mudrd8mz/moodle into MOODLE_23_STABLE

8 years agoMDL-38443 Assignment: Missing permissions check on downloadall submissions
Damyon Wiese [Wed, 13 Mar 2013 03:13:42 +0000 (11:13 +0800)]
MDL-38443 Assignment: Missing permissions check on downloadall submissions

8 years agoMerge branch 'MDL-39445_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Mon, 6 May 2013 07:17:00 +0000 (15:17 +0800)]
Merge branch 'MDL-39445_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'brokencalc_23' of git://github.com/andyjdavis/moodle into MOODLE_23_STABLE
Dan Poltawski [Sun, 5 May 2013 10:30:40 +0000 (11:30 +0100)]
Merge branch 'brokencalc_23' of git://github.com/andyjdavis/moodle into MOODLE_23_STABLE

8 years agoMDL-39491 Fix order of Workshop submission text processing
David Mudrák [Fri, 3 May 2013 09:43:03 +0000 (11:43 +0200)]
MDL-39491 Fix order of Workshop submission text processing

The order of format_text() and file_rewrite_pluginfile_urls() is
important to make filters work correctly.

8 years agoMDL-39446 calculated qtype: make answer formula input bigger
Tim Hunt [Wed, 1 May 2013 18:28:58 +0000 (19:28 +0100)]
MDL-39446 calculated qtype: make answer formula input bigger

This makes it easier for teachers editing questions.

8 years agoMDL-39445 get_plugin_list clean_param use is slow
Tim Hunt [Wed, 1 May 2013 10:35:14 +0000 (11:35 +0100)]
MDL-39445 get_plugin_list clean_param use is slow

get_plugin_list was calling clean_param($pluginname, PARAM_PLUGIN) a
lot (600+ times per page), and that is much slower than you would guess.
A specific function for this case, (which we then also use from
clean_param) is a performance win.

8 years agoweekly release 2.3.6+
Dan Poltawski [Thu, 2 May 2013 13:36:56 +0000 (14:36 +0100)]
weekly release 2.3.6+

8 years agoMerge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23...
Dan Poltawski [Thu, 2 May 2013 13:32:32 +0000 (14:32 +0100)]
Merge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-30775-23' of git://github.com/mouneyrac/moodle into MOODLE_23_STABLE
Damyon Wiese [Thu, 2 May 2013 08:22:48 +0000 (16:22 +0800)]
Merge branch 'MDL-30775-23' of git://github.com/mouneyrac/moodle into MOODLE_23_STABLE

8 years agoMDL-36223 Assign: User outline report grade display
Damyon Wiese [Thu, 2 May 2013 07:41:43 +0000 (15:41 +0800)]
MDL-36223 Assign: User outline report grade display

Use str_long_grade for user outline report because it handles scales and
no grade.

Thanks to Jean-Daniel Descoteaux for suggesting this fix.

8 years agoMDL-32913 core_grade:made it more obvious when the gradebook is broken due to a broke...
Andrew Davis [Mon, 29 Apr 2013 02:15:08 +0000 (10:15 +0800)]
MDL-32913 core_grade:made it more obvious when the gradebook is broken due to a broken calculation

8 years agoAutomatically generated installer lang files
AMOS bot [Thu, 2 May 2013 00:38:16 +0000 (00:38 +0000)]
Automatically generated installer lang files

8 years agoMerge branch 'MDL-39444_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Eloy Lafuente (stronk7) [Wed, 1 May 2013 14:54:06 +0000 (16:54 +0200)]
Merge branch 'MDL-39444_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMDL-39444 get_string: remove unnecessary clean_param
Tim Hunt [Wed, 1 May 2013 08:55:01 +0000 (09:55 +0100)]
MDL-39444 get_string: remove unnecessary clean_param

This clean_param was added as part of MDL-22015. It is a good idea when
developer debug is turned on, but it showed up as a surprisingly
expensive cost in our profiling.

This change:

1. Removes the check during string_extist. This will not change
behaviour, the method returns false if the string does not exist.

2. In get_string, it only does the check if debugging is set to
DEVELOPER level.

8 years agoMDL-38500 repository: Instance names must be unique
Frederic Massart [Wed, 1 May 2013 08:11:44 +0000 (16:11 +0800)]
MDL-38500 repository: Instance names must be unique

8 years agoAutomatically generated installer lang files
AMOS bot [Wed, 1 May 2013 00:39:27 +0000 (00:39 +0000)]
Automatically generated installer lang files

8 years agoMerge branch 'wip-MDL-39432-m23' of git://github.com/samhemelryk/moodle into MOODLE_2...
Eloy Lafuente (stronk7) [Tue, 30 Apr 2013 23:35:24 +0000 (01:35 +0200)]
Merge branch 'wip-MDL-39432-m23' of git://github.com/samhemelryk/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39422-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE
Sam Hemelryk [Tue, 30 Apr 2013 23:14:12 +0000 (11:14 +1200)]
Merge branch 'MDL-39422-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'wip-MDL-39099_M23' of git://github.com/gjb2048/moodle into MOODLE_23_STABLE
Sam Hemelryk [Tue, 30 Apr 2013 23:04:33 +0000 (11:04 +1200)]
Merge branch 'wip-MDL-39099_M23' of git://github.com/gjb2048/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39414-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE
Sam Hemelryk [Tue, 30 Apr 2013 23:01:54 +0000 (11:01 +1200)]
Merge branch 'MDL-39414-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE

8 years agoMDL-39432 course: converted closures to lambda functions
Sam Hemelryk [Tue, 30 Apr 2013 22:40:54 +0000 (10:40 +1200)]
MDL-39432 course: converted closures to lambda functions

8 years agoMerge branch 'MDL-36060-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE
Sam Hemelryk [Tue, 30 Apr 2013 22:13:51 +0000 (10:13 +1200)]
Merge branch 'MDL-36060-23' of git://github.com/danpoltawski/moodle into MOODLE_23_STABLE

8 years agoMDL-36060: Remove anonymous functions in mod/lti
Mark Nielsen [Tue, 12 Mar 2013 22:28:23 +0000 (15:28 -0700)]
MDL-36060: Remove anonymous functions in mod/lti

This was breaking eaccelerator because it doesn't
support anonymous functions.

8 years agoMDL-39422 mod_forms: prevent long coruse module names
Dan Poltawski [Tue, 30 Apr 2013 16:39:56 +0000 (17:39 +0100)]
MDL-39422 mod_forms: prevent long coruse module names

To prevent ugly DB errors.

8 years agoMDL-39422 course: prevent module names longer 255 chars
Dan Poltawski [Tue, 30 Apr 2013 15:48:53 +0000 (16:48 +0100)]
MDL-39422 course: prevent module names longer 255 chars

To prevent ugly DB errors.

8 years agoMDL-39099 course_format: Allow section_summary() to be overridden.
Gareth J Barnard [Fri, 12 Apr 2013 17:52:16 +0000 (18:52 +0100)]
MDL-39099 course_format: Allow section_summary() to be overridden.

8 years agoMerge branch 'MDL-35385_chat_23' of git://github.com/andyjdavis/moodle into MOODLE_23...
Dan Poltawski [Tue, 30 Apr 2013 13:08:32 +0000 (14:08 +0100)]
Merge branch 'MDL-35385_chat_23' of git://github.com/andyjdavis/moodle into MOODLE_23_STABLE

8 years agoMDL-39414 portfolio: don't queue google portfolio exports
Dan Poltawski [Tue, 30 Apr 2013 09:16:01 +0000 (10:16 +0100)]
MDL-39414 portfolio: don't queue google portfolio exports

This is a bit of an ugly way of saying 'I dont support queued exports'.

The google plugins need a valid user session in order to export to the
google services, thereforce we are forcing the export to be interactive
and not queued through cron, as this wont work in the current
implmenetation.

It's possible we could add offline access to the plugins, but I don't
believe it is worth the benefit for the additional complexity.

8 years agoMerge branch 'MDL-39354_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Tue, 30 Apr 2013 08:27:04 +0000 (16:27 +0800)]
Merge branch 'MDL-39354_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMDL-30775 get_course_contents: remove warnings when the section is empty
Jerome Mouneyrac [Tue, 30 Apr 2013 06:13:53 +0000 (14:13 +0800)]
MDL-30775 get_course_contents: remove warnings when the section is empty

8 years agoMDL-31713 core_grade:added a unit test to replicate a raw grade max bug
Andrew Davis [Fri, 19 Apr 2013 13:25:18 +0000 (21:25 +0800)]
MDL-31713 core_grade:added a unit test to replicate a raw grade max bug

8 years agoMDL-35385 mod_chat: made sure no message popups display within the chat window
Andrew Davis [Fri, 12 Apr 2013 03:59:08 +0000 (11:59 +0800)]
MDL-35385 mod_chat: made sure no message popups display within the chat window

8 years agoAutomatically generated installer lang files
AMOS bot [Tue, 30 Apr 2013 00:43:52 +0000 (00:43 +0000)]
Automatically generated installer lang files

8 years agoMerge branch 'w17_MDL-39344_m23_lists' of git://github.com/skodak/moodle into MOODLE_...
Sam Hemelryk [Mon, 29 Apr 2013 22:11:46 +0000 (10:11 +1200)]
Merge branch 'w17_MDL-39344_m23_lists' of git://github.com/skodak/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39303_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE
Sam Hemelryk [Mon, 29 Apr 2013 21:59:32 +0000 (09:59 +1200)]
Merge branch 'MDL-39303_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39365-m23' of git://github.com/ankitagarwal/moodle into MOODLE_23_S...
Sam Hemelryk [Mon, 29 Apr 2013 21:36:25 +0000 (09:36 +1200)]
Merge branch 'MDL-39365-m23' of git://github.com/ankitagarwal/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39398-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE
Sam Hemelryk [Mon, 29 Apr 2013 21:31:31 +0000 (09:31 +1200)]
Merge branch 'MDL-39398-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE

8 years agoMDL-39354 put back a bit of margin on checkboxes.
Tim Hunt [Thu, 25 Apr 2013 15:47:20 +0000 (16:47 +0100)]
MDL-39354 put back a bit of margin on checkboxes.

8 years agoMerge branch 'MDL-39378_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Dan Poltawski [Mon, 29 Apr 2013 16:01:12 +0000 (17:01 +0100)]
Merge branch 'MDL-39378_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMDL-39378 Improve s() performance.
Tim Hunt [Fri, 26 Apr 2013 14:59:53 +0000 (15:59 +0100)]
MDL-39378 Improve s() performance.

These changes give about a 10% speed-up in this function. The significant changes are:
1. Simplify the if logic to remove unnecssary cases.
2. Dont pass default argument values to htmlspecialchars, just using the
   defaults is faster.
3. I can confirm that /i regex is faster than the equivalent regex without the i.

I also added more unit tests to test the edge cases.

8 years agoMDL-39378 s(): fix bad hex regex
Tim Hunt [Fri, 26 Apr 2013 17:38:29 +0000 (18:38 +0100)]
MDL-39378 s(): fix bad hex regex

8 years agoMDL-39398 message: Prevent notice when sending Jabber messages
Frederic Massart [Mon, 29 Apr 2013 06:10:44 +0000 (14:10 +0800)]
MDL-39398 message: Prevent notice when sending Jabber messages

Not tracking the presence prevents a notice to be displayed during disconnect(),
where the the jabber server attempts to subscribe to $CFG->jabberusername presence.
As the server name does not include a resource identifier (stillwit@jabber.org/resource),
an explode('/') fails.

8 years agoMerge branch 'MDL-27071_23' of git://github.com/stronk7/moodle into MOODLE_23_STABLE
Dan Poltawski [Mon, 29 Apr 2013 09:27:52 +0000 (10:27 +0100)]
Merge branch 'MDL-27071_23' of git://github.com/stronk7/moodle into MOODLE_23_STABLE

8 years agoMDL-27071 Add big IN() unit tests
Eloy Lafuente (stronk7) [Sun, 28 Apr 2013 23:11:10 +0000 (01:11 +0200)]
MDL-27071 Add big IN() unit tests

Let's verify how all databases perform with a big
number of parameters (10000) using IN() SQL clauses.
Both using QM and NAMED parameters.

Ideally only Oracle fails, and only it will need fixing.

8 years agoMDL-27071 Allow Oracle IN() to use > 1000 items
Eloy Lafuente (stronk7) [Sun, 28 Apr 2013 23:14:24 +0000 (01:14 +0200)]
MDL-27071 Allow Oracle IN() to use > 1000 items

By using a pivoting strategy, we modify the list
of params (QM and NAMED supported) into a
subquery, so the 1000 limit in Oracle (ORA-01795)
is not thrown anymore.

Conflicts:
lib/dml/oci_native_moodle_database.php

8 years agoMerge branch 'MDL-39342_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Mon, 29 Apr 2013 07:36:30 +0000 (15:36 +0800)]
Merge branch 'MDL-39342_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-30940-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE
Damyon Wiese [Mon, 29 Apr 2013 06:04:26 +0000 (14:04 +0800)]
Merge branch 'MDL-30940-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE

8 years agoMDL-39365 scorm reports: Return correct track count
Ankit Agarwal [Mon, 29 Apr 2013 05:21:43 +0000 (13:21 +0800)]
MDL-39365 scorm reports: Return correct track count

8 years agoMerge branch 'MDL-37845_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Mon, 29 Apr 2013 03:47:02 +0000 (11:47 +0800)]
Merge branch 'MDL-37845_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39192_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE
Sam Hemelryk [Sun, 28 Apr 2013 22:53:33 +0000 (10:53 +1200)]
Merge branch 'MDL-39192_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE

8 years agoMDL-37845 multichoice qtype: Fix some display issues.
Tim Hunt [Thu, 25 Apr 2013 16:07:36 +0000 (17:07 +0100)]
MDL-37845 multichoice qtype: Fix some display issues.

1. Better handling of multi-line choices in the correct answer display.
2. Remove dangerous CSS that is no longer needed.

8 years agoMerge branch 'MDL-34403-MOODLE_23_STABLE' of https://github.com/mpetrowi/moodle into...
Dan Poltawski [Thu, 25 Apr 2013 11:59:31 +0000 (12:59 +0100)]
Merge branch 'MDL-34403-MOODLE_23_STABLE' of https://github.com/mpetrowi/moodle into MOODLE_23_STABLE

8 years agoMDL-39342 stop users entering too long matching answers.
Jason Platts [Tue, 26 Mar 2013 15:11:20 +0000 (15:11 +0000)]
MDL-39342 stop users entering too long matching answers.

Since they lead to an ugly DB error.

8 years agoMerge branch 'MDL-29258_23' of git://github.com/dmonllao/moodle into MOODLE_23_STABLE
Dan Poltawski [Thu, 25 Apr 2013 09:32:28 +0000 (10:32 +0100)]
Merge branch 'MDL-29258_23' of git://github.com/dmonllao/moodle into MOODLE_23_STABLE

8 years agoMDL-39344 revert enabling of broken lists plugin from MDL-38329
Petr Škoda [Wed, 24 Apr 2013 20:31:15 +0000 (22:31 +0200)]
MDL-39344 revert enabling of broken lists plugin from MDL-38329

8 years agoAutomatically generated installer lang files
AMOS bot [Thu, 25 Apr 2013 00:38:10 +0000 (00:38 +0000)]
Automatically generated installer lang files

8 years agoweekly release 2.3.6+
Eloy Lafuente (stronk7) [Wed, 24 Apr 2013 23:09:23 +0000 (01:09 +0200)]
weekly release 2.3.6+

8 years agoMerge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23...
Eloy Lafuente (stronk7) [Wed, 24 Apr 2013 23:03:22 +0000 (01:03 +0200)]
Merge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-35364_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Eloy Lafuente (stronk7) [Wed, 24 Apr 2013 21:37:17 +0000 (23:37 +0200)]
Merge branch 'MDL-35364_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMDL-34403 mod quiz: fix error during enrolment
Matt Petro [Tue, 16 Apr 2013 11:19:23 +0000 (07:19 -0400)]
MDL-34403 mod quiz: fix error during enrolment

8 years agoMerge branch 'MDL-39283_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE
Dan Poltawski [Wed, 24 Apr 2013 13:36:26 +0000 (14:36 +0100)]
Merge branch 'MDL-39283_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE

8 years agoMDL-34939: Fix clamdscan permissions-related issues
Ruslan Kabalin [Mon, 15 Apr 2013 09:30:36 +0000 (10:30 +0100)]
MDL-34939: Fix clamdscan permissions-related issues

Use --fdpass parameter that passes the file descriptor permissions to clamd,
which allows to scan given file irrespective of directory and file
permissions. Changing file permissions is not required.

8 years agoMDL-39303 mod_forum: prevent user from submitting when post threshold reached
Mark Nelson [Tue, 23 Apr 2013 09:09:49 +0000 (17:09 +0800)]
MDL-39303 mod_forum: prevent user from submitting when post threshold reached

8 years agoMDL-39192 mod_forum: do not need to check the posting threshold when editing a post
Mark Nelson [Thu, 18 Apr 2013 08:58:29 +0000 (16:58 +0800)]
MDL-39192 mod_forum: do not need to check the posting threshold when editing a post

8 years agoMDL-39283 GIFT and XML question export broken for unsupported qtypes
Jean-Michel Vedrine [Mon, 22 Apr 2013 14:21:54 +0000 (16:21 +0200)]
MDL-39283 GIFT and XML question export broken for unsupported qtypes
Do no write any data to the export for unsupported qtypes

8 years agoMerge branch 'MDL-34933_23_STABLE' of https://github.com/mchurchward/moodle into...
Damyon Wiese [Tue, 23 Apr 2013 04:02:30 +0000 (12:02 +0800)]
Merge branch 'MDL-34933_23_STABLE' of https://github.com/mchurchward/moodle into MOODLE_23_STABLE

Conflicts:
lib/db/upgrade.php
version.php

8 years agoMDL-29258 core_portfolio: Fixing broken default breadcrumb
David Monllao [Tue, 23 Apr 2013 03:12:51 +0000 (11:12 +0800)]
MDL-29258 core_portfolio: Fixing broken default breadcrumb

8 years agoMDL-35364 shorten text: don't return invalid HTML.
Tim Hunt [Mon, 22 Apr 2013 18:21:40 +0000 (19:21 +0100)]
MDL-35364 shorten text: don't return invalid HTML.

I also broke the unit tests into more, smaller, named tests, so that
when things start failing, more tests are run, and it is clearer what
the problem is.

In a couple of cases, I adjusted the $ideal lenght in the test. A
careful counting of the characters in the test input (added as comments)
suggests that the new values make for better tests.

8 years agoMDL-37514 module.js: fix .js for auto quiz submission in preview mode
Alex Leontiev [Sat, 20 Apr 2013 07:32:27 +0000 (15:32 +0800)]
MDL-37514 module.js: fix .js for auto quiz submission in preview mode

The issue: when we attempt the quiz as teacher/admin and timer is up,
quiz is not submitted, even though "Open attempts are submitted
automatically" is set. I've changed the javascript for a timer,
responsible for submission, removing the special behaviour in case of
preview mode. Note, that when the admin/teacher is taking a quiz, the
"preview" mode is automatically switched on.

It is a bit strange, since in the javascript there was clearly no
expressed intention to really submit quiz in preview, even when timer
hits. It does not really seem like a accidental bug, rather it looks
like some misunderstanding. Worse still, it may happen that I did not
understand the intentions of previous editor and ruined some
functionality. Because of this, and the fact that this is my first bug,
I would like to ask about the peer review! Please, see my comments in
bug discussion for the testing steps.

8 years agoMDL-34933 core_message: Adding index to improve database access on message_working...
Mike Churchward [Wed, 17 Apr 2013 14:18:55 +0000 (10:18 -0400)]
MDL-34933 core_message: Adding index to improve database access on message_working table.

8 years agoMDL-37942 Images with non-alphanumeric chars in file name won't export
Jason Platts [Tue, 2 Apr 2013 08:16:00 +0000 (09:16 +0100)]
MDL-37942 Images with non-alphanumeric chars in file name won't export

8 years agoMDL-39050 quiz access rules: $module->is_enabled() not available for 23
Damyon Wiese [Mon, 22 Apr 2013 02:36:20 +0000 (10:36 +0800)]
MDL-39050 quiz access rules: $module->is_enabled() not available for 23

8 years agoMerge branch 'MDL-39050_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Mon, 22 Apr 2013 02:31:30 +0000 (10:31 +0800)]
Merge branch 'MDL-39050_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoAutomatically generated installer lang files
AMOS bot [Mon, 22 Apr 2013 00:38:30 +0000 (00:38 +0000)]
Automatically generated installer lang files

8 years agoMerge branch 'MDL-39172_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE
Sam Hemelryk [Sun, 21 Apr 2013 23:01:42 +0000 (11:01 +1200)]
Merge branch 'MDL-39172_23' of git://github.com/jmvedrine/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-38361_23' of https://github.com/prateeksachan/moodle into MOODLE_23...
Dan Poltawski [Fri, 19 Apr 2013 14:12:00 +0000 (15:12 +0100)]
Merge branch 'MDL-38361_23' of https://github.com/prateeksachan/moodle into MOODLE_23_STABLE

8 years agoMDL-39050 quiz access rules: settings.php files should work.
Tim Hunt [Wed, 17 Apr 2013 12:15:10 +0000 (13:15 +0100)]
MDL-39050 quiz access rules: settings.php files should work.

8 years agoMerge branch 'MDL-39084-moodle23' of github.com:StudiUM/moodle into MOODLE_23_STABLE
Damyon Wiese [Fri, 19 Apr 2013 06:07:38 +0000 (14:07 +0800)]
Merge branch 'MDL-39084-moodle23' of github.com:StudiUM/moodle into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39167_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE
Damyon Wiese [Fri, 19 Apr 2013 05:29:41 +0000 (13:29 +0800)]
Merge branch 'MDL-39167_23' of git://github.com/timhunt/moodle into MOODLE_23_STABLE

8 years agoMDL-30940 form: Mutiple select work correctly without any selection
Frederic Massart [Fri, 19 Apr 2013 03:04:34 +0000 (11:04 +0800)]
MDL-30940 form: Mutiple select work correctly without any selection

8 years agoMerge branch 'MDL-39185_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE
Sam Hemelryk [Fri, 19 Apr 2013 01:53:19 +0000 (13:53 +1200)]
Merge branch 'MDL-39185_m23' of https://github.com/markn86/moodle into MOODLE_23_STABLE

8 years agoMDL-39172 Import of .dat files is broken in blackboard_six import format
Jean-Michel Vedrine [Tue, 16 Apr 2013 20:04:55 +0000 (22:04 +0200)]
MDL-39172 Import of .dat files is broken in blackboard_six import format

8 years agoweekly release 2.3.6+
Dan Poltawski [Thu, 18 Apr 2013 11:48:44 +0000 (12:48 +0100)]
weekly release 2.3.6+

8 years agoMerge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23...
Dan Poltawski [Thu, 18 Apr 2013 11:43:54 +0000 (12:43 +0100)]
Merge branch 'install_23_STABLE' of git://git.moodle.cz/moodle-install into MOODLE_23_STABLE

8 years agoMerge branch 'MDL-39203-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE
Dan Poltawski [Thu, 18 Apr 2013 07:36:32 +0000 (08:36 +0100)]
Merge branch 'MDL-39203-23' of git://github.com/FMCorz/moodle into MOODLE_23_STABLE

8 years agoMDL-39203 repository: Fixed authentication errors with Dropbox
Frederic Massart [Thu, 18 Apr 2013 06:47:22 +0000 (14:47 +0800)]
MDL-39203 repository: Fixed authentication errors with Dropbox

8 years agoMerge branch 'MDL-38824-m23' of git://github.com/sammarshallou/moodle into MOODLE_23_...
Dan Poltawski [Wed, 17 Apr 2013 13:38:18 +0000 (14:38 +0100)]
Merge branch 'MDL-38824-m23' of git://github.com/sammarshallou/moodle into MOODLE_23_STABLE

8 years agoMDL-39167 quiz access rules: need to validate their settings.
Tim Hunt [Wed, 17 Apr 2013 13:24:38 +0000 (14:24 +0100)]
MDL-39167 quiz access rules: need to validate their settings.

We were missing the hook in the form validation method. We had them
everywhere else they were needed.