moodle.git
18 months agoMDL-67451 badges: use the site OB version as default
Sara Arjona [Wed, 4 Dec 2019 13:50:13 +0000 (14:50 +0100)]
MDL-67451 badges: use the site OB version as default

18 months agoweekly release 3.9dev
Eloy Lafuente (stronk7) [Thu, 28 Nov 2019 23:45:41 +0000 (00:45 +0100)]
weekly release 3.9dev

18 months agoMerge branch 'MDL-67348-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Wed, 27 Nov 2019 02:35:30 +0000 (10:35 +0800)]
Merge branch 'MDL-67348-master' of git://github.com/andrewnicols/moodle

18 months agoMerge branch 'MDL-67300-master' of https://github.com/sammarshallou/moodle
Eloy Lafuente (stronk7) [Tue, 26 Nov 2019 21:16:38 +0000 (22:16 +0100)]
Merge branch 'MDL-67300-master' of https://github.com/sammarshallou/moodle

(fix trailing whitespace case)

18 months agoMerge branch 'master_MDL-56886' of https://github.com/golenkovm/moodle
Jun Pataleta [Tue, 26 Nov 2019 14:32:48 +0000 (22:32 +0800)]
Merge branch 'master_MDL-56886' of https://github.com/golenkovm/moodle

18 months agoMerge branch 'MDL-67210-master' of git://github.com/lucaboesch/moodle
Sara Arjona [Tue, 26 Nov 2019 07:29:45 +0000 (08:29 +0100)]
Merge branch 'MDL-67210-master' of git://github.com/lucaboesch/moodle

18 months agoMerge branch 'MDL-67307' of https://github.com/stronk7/moodle
Jake Dallimore [Tue, 26 Nov 2019 06:14:50 +0000 (14:14 +0800)]
Merge branch 'MDL-67307' of https://github.com/stronk7/moodle

18 months agoMerge branch 'MDL-67042-master' of git://github.com/sarjona/moodle
Jake Dallimore [Tue, 26 Nov 2019 03:59:08 +0000 (11:59 +0800)]
Merge branch 'MDL-67042-master' of git://github.com/sarjona/moodle

18 months agoMerge branch 'MDL-66966' of https://github.com/stronk7/moodle
Jun Pataleta [Tue, 26 Nov 2019 03:42:25 +0000 (11:42 +0800)]
Merge branch 'MDL-66966' of https://github.com/stronk7/moodle

18 months agoMerge branch 'MDL-67222-master' of git://github.com/bmbrands/moodle
Jake Dallimore [Tue, 26 Nov 2019 02:12:29 +0000 (10:12 +0800)]
Merge branch 'MDL-67222-master' of git://github.com/bmbrands/moodle

18 months agoMDL-56886 navigation: Allow local plugins to modify navigation via AJAX.
Mikhail Golenkov [Tue, 26 Nov 2019 01:11:00 +0000 (12:11 +1100)]
MDL-56886 navigation: Allow local plugins to modify navigation via AJAX.

18 months agoMDL-67348 theme: Return CSS from localcache if available
Andrew Nicols [Mon, 25 Nov 2019 01:55:09 +0000 (09:55 +0800)]
MDL-67348 theme: Return CSS from localcache if available

18 months agoMerge branch 'MDL-67342-master' of git://github.com/marinaglancy/moodle
Sara Arjona [Mon, 25 Nov 2019 14:58:54 +0000 (15:58 +0100)]
Merge branch 'MDL-67342-master' of git://github.com/marinaglancy/moodle

18 months agoMerge branch 'MDL-66627-master' of git://github.com/mickhawkins/moodle
Sara Arjona [Mon, 25 Nov 2019 14:41:47 +0000 (15:41 +0100)]
Merge branch 'MDL-66627-master' of git://github.com/mickhawkins/moodle

18 months agoMDL-67222 tool_lp: update css classes for Bootstrap 4.3
Bas Brands [Wed, 13 Nov 2019 11:12:52 +0000 (12:12 +0100)]
MDL-67222 tool_lp: update css classes for Bootstrap 4.3

18 months agoMerge branch 'MDL-67217_master' of git://github.com/dmonllao/moodle
Jun Pataleta [Mon, 25 Nov 2019 08:13:01 +0000 (16:13 +0800)]
Merge branch 'MDL-67217_master' of git://github.com/dmonllao/moodle

18 months agoMerge branch 'MDL-67168-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Mon, 25 Nov 2019 07:54:51 +0000 (08:54 +0100)]
Merge branch 'MDL-67168-master' of git://github.com/andrewnicols/moodle

18 months agoMerge branch 'MDL-65956-master-1' of git://github.com/mihailges/moodle
Jun Pataleta [Mon, 25 Nov 2019 06:23:18 +0000 (14:23 +0800)]
Merge branch 'MDL-65956-master-1' of git://github.com/mihailges/moodle

18 months agoMDL-65956 mod_assign: Add behat tests
Mihail Geshoski [Mon, 25 Nov 2019 02:49:36 +0000 (10:49 +0800)]
MDL-65956 mod_assign: Add behat tests

18 months agoMDL-65956 mod_assign: Add proper capability checks and error handling
Mihail Geshoski [Mon, 25 Nov 2019 02:49:21 +0000 (10:49 +0800)]
MDL-65956 mod_assign: Add proper capability checks and error handling

18 months agoMerge branch 'MDL-67285-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Mon, 25 Nov 2019 02:28:56 +0000 (10:28 +0800)]
Merge branch 'MDL-67285-master' of git://github.com/andrewnicols/moodle

18 months agoMerge branch 'MDL-67049' of https://github.com/stronk7/moodle
Jake Dallimore [Mon, 25 Nov 2019 01:33:42 +0000 (09:33 +0800)]
Merge branch 'MDL-67049' of https://github.com/stronk7/moodle

18 months agoMDL-67210 tool_uploadcourse: Allow only 0 and 1 for visible value.
Luca Bösch [Mon, 11 Nov 2019 17:06:03 +0000 (18:06 +0100)]
MDL-67210 tool_uploadcourse: Allow only 0 and 1 for visible value.

18 months agoMDL-67342 theme_boost: Do not hardcode tooltip container
Marina Glancy [Sun, 24 Nov 2019 12:42:48 +0000 (13:42 +0100)]
MDL-67342 theme_boost: Do not hardcode tooltip container

19 months agoMDL-67042 customfield: Add behat tests to check hidden fields
Sara Arjona [Mon, 11 Nov 2019 12:43:17 +0000 (13:43 +0100)]
MDL-67042 customfield: Add behat tests to check hidden fields

Fields with the visibility different to Everyone should
be never displayed in the available filters custom field.

19 months agoMDL-67042 customfield: Display only fields visible to everybody
Sara Arjona [Mon, 11 Nov 2019 12:42:12 +0000 (13:42 +0100)]
MDL-67042 customfield: Display only fields visible to everybody

When defining the available filters for the Dashboard, only the
fields visible to everyone should be displayed in the Custom field
filter.

19 months agoMDL-67307 core: Fix onject creation from empty value cases
Eloy Lafuente (stronk7) [Tue, 19 Nov 2019 17:54:46 +0000 (18:54 +0100)]
MDL-67307 core: Fix onject creation from empty value cases

The "creating default object from empty value" warning is now consistently
thrown if a falsy value is promoted into an stdClass object. Previously some
cases like `$null->prop[0] = $val` missed this warning.

19 months agoMDL-67049 grading: options are array, ensure json_decode() knows it
Eloy Lafuente (stronk7) [Mon, 28 Oct 2019 01:50:24 +0000 (02:50 +0100)]
MDL-67049 grading: options are array, ensure json_decode() knows it

By default json_decode() returns object for associative arrays. That
was not a problem till now becuause array_key_exists() worked with
objects too. But in php74 that emits a warning.

So we need to ensure that the information arriving to it is
an array, allowing everything to continue working ok.

19 months agoMDL-66966 tcpdf: Update readme to point to manual commits to review
Eloy Lafuente (stronk7) [Sun, 20 Oct 2019 00:16:18 +0000 (02:16 +0200)]
MDL-66966 tcpdf: Update readme to point to manual commits to review

Apart from the main import of the library, there are a couple of
commits (with corresponding PRs upstream) that have been added to
provide php74 compatibility.

This commit addes them to the instructions, to ensure that they
will be reviewed on next import.

19 months agoMDL-66966 tcpdf: Silence non-existing K_PATH_CACHE
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 23:06:13 +0000 (00:06 +0100)]
MDL-66966 tcpdf: Silence non-existing K_PATH_CACHE

I was fixing this adding a extra dir_exists() check that
is better than the silence operator but that was that already
there was a PR using @. So went to it.

This is https://git.io/JeKft

19 months agoMDL-66966 tcpdf: Some more curly braces to fix
Eloy Lafuente (stronk7) [Sun, 20 Oct 2019 00:14:51 +0000 (02:14 +0200)]
MDL-66966 tcpdf: Some more curly braces to fix

This is https://git.io/JeKfT

19 months agoMDL-66966 tcpdf: PHP 7.4 - cannot use array offset on integers
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 23:54:10 +0000 (01:54 +0200)]
MDL-66966 tcpdf: PHP 7.4 - cannot use array offset on integers

This is https://git.io/JeKfU

19 months agoMDL-66966 tcpdf: Bump to tcpdf 6.3.2
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 22:46:53 +0000 (00:46 +0200)]
MDL-66966 tcpdf: Bump to tcpdf 6.3.2

Bug fixes and php74 support.

19 months agoMDL-67217 unittest: usleep and windows don't get along well
David Monllaó [Tue, 12 Nov 2019 00:28:14 +0000 (08:28 +0800)]
MDL-67217 unittest: usleep and windows don't get along well

19 months agoweekly on-sync release 3.9dev
Eloy Lafuente (stronk7) [Thu, 21 Nov 2019 23:17:41 +0000 (00:17 +0100)]
weekly on-sync release 3.9dev

19 months agoMDL-67300 Calendar: Inconsistent behaviour of managegroupentries
sam marshall [Tue, 19 Nov 2019 11:46:40 +0000 (11:46 +0000)]
MDL-67300 Calendar: Inconsistent behaviour of managegroupentries

When calling the calendar_get_allowed_event_types function with
no course id, it is supposed to return true if you have the
relevant permissions in any course.

For users who have the managegroupentries permission, this was not
the case - even though it works correctly if you call the function
with a supplied course id.

This change makes behaviour with and without a supplied course id
consistent.

19 months agoMDL-67168 forum: Correct behaviour of viewfullnames
Andrew Nicols [Thu, 21 Nov 2019 07:08:33 +0000 (15:08 +0800)]
MDL-67168 forum: Correct behaviour of viewfullnames

19 months agoMerge branch 'MDL-67035' of https://github.com/stronk7/moodle
Jake Dallimore [Thu, 21 Nov 2019 03:55:07 +0000 (11:55 +0800)]
Merge branch 'MDL-67035' of https://github.com/stronk7/moodle

19 months agoMerge branch 'MDL-66964' of https://github.com/stronk7/moodle
Jun Pataleta [Thu, 21 Nov 2019 03:36:33 +0000 (11:36 +0800)]
Merge branch 'MDL-66964' of https://github.com/stronk7/moodle

19 months agoMDL-48024 behat: allow plugins to have data generators
Tim Hunt [Thu, 25 Apr 2019 19:57:44 +0000 (20:57 +0100)]
MDL-48024 behat: allow plugins to have data generators

This extends the step
Given the following "users" exist:
to also support things like
Given the following "mod_quiz > user overrides" exist:

Instructions are on the behat_data_generators and
behat_generator_base classes.

19 months agoMerge branch 'MDL-67030' of https://github.com/stronk7/moodle
Jake Dallimore [Thu, 21 Nov 2019 00:18:46 +0000 (08:18 +0800)]
Merge branch 'MDL-67030' of https://github.com/stronk7/moodle

19 months agoMDL-66964 markdown: add details to readme
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 08:51:25 +0000 (10:51 +0200)]
MDL-66964 markdown: add details to readme

The commit to apply, from upstream repo, is:

https://github.com/michelf/php-markdown/commit/a35858f0409e5f01474f5cd562d17289fe8e5435

But it doesn't apply clean to our current 1.8.0 version.

So we have ended a slightly different version in core reproducing the same changes.

19 months agoMerge branch 'MDL-67031' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 20 Nov 2019 08:21:47 +0000 (16:21 +0800)]
Merge branch 'MDL-67031' of https://github.com/stronk7/moodle

19 months agoMerge branch 'MDL-67077' of https://github.com/stronk7/moodle
Jun Pataleta [Wed, 20 Nov 2019 08:08:30 +0000 (16:08 +0800)]
Merge branch 'MDL-67077' of https://github.com/stronk7/moodle

19 months agoMDL-66627 forumreport_summary: Added content access behat tests
Michael Hawkins [Wed, 20 Nov 2019 06:41:44 +0000 (14:41 +0800)]
MDL-66627 forumreport_summary: Added content access behat tests

19 months agoMerge branch 'MDL-67034' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 20 Nov 2019 05:16:28 +0000 (13:16 +0800)]
Merge branch 'MDL-67034' of https://github.com/stronk7/moodle

19 months agoMerge branch 'MDL-67029' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 20 Nov 2019 03:45:10 +0000 (11:45 +0800)]
Merge branch 'MDL-67029' of https://github.com/stronk7/moodle

19 months agoMerge branch 'MDL-67017' of https://github.com/stronk7/moodle
Adrian Greeve [Wed, 20 Nov 2019 01:57:50 +0000 (09:57 +0800)]
Merge branch 'MDL-67017' of https://github.com/stronk7/moodle

19 months agoMDL-67034 lti_provider: php74 fix (curly braces) for LTI Provider lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:25:54 +0000 (00:25 +0200)]
MDL-67034 lti_provider: php74 fix (curly braces) for LTI Provider lib

19 months agoMerge branch 'MDL-67274-master' of https://github.com/sammarshallou/moodle
Jake Dallimore [Tue, 19 Nov 2019 02:51:05 +0000 (10:51 +0800)]
Merge branch 'MDL-67274-master' of https://github.com/sammarshallou/moodle

19 months agoMDL-67285 core: YUI dialogues must use focuslock
Andrew Nicols [Mon, 18 Nov 2019 00:27:13 +0000 (08:27 +0800)]
MDL-67285 core: YUI dialogues must use focuslock

YUI Dialogues were using an older method for locking focus to modals,
but this way conflicts with the way in which we lock focus for AMD
modules.

As a result, when an AMD dialogue launches a YUI dialogue the focus is
not correctly locked and it is not possible to focus on anything in the
YUI dialogue.

This includes a minor changes to the focuslock AMD module to ensure that
it is possible to loop the focus in both directions. Many of our older
YUI dialogues are themselves focusable. As a result we need to include
the lock region in the calculation when calculating the possible
descendants.
If we do not do so then the reverse looping does not work.

19 months agoMerge branch 'MDL-67148-master' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 18 Nov 2019 17:42:37 +0000 (18:42 +0100)]
Merge branch 'MDL-67148-master' of git://github.com/junpataleta/moodle

19 months agoMDL-67274 Tasks: Log display fails with memory errors
sam marshall [Fri, 15 Nov 2019 13:55:43 +0000 (13:55 +0000)]
MDL-67274 Tasks: Log display fails with memory errors

19 months agoMerge branch 'MDL-67073-master' of git://github.com/marinaglancy/moodle
Jun Pataleta [Mon, 18 Nov 2019 08:02:05 +0000 (16:02 +0800)]
Merge branch 'MDL-67073-master' of git://github.com/marinaglancy/moodle

19 months agoMerge branch 'MDL-67284' of https://github.com/stronk7/moodle
Jake Dallimore [Mon, 18 Nov 2019 03:27:00 +0000 (11:27 +0800)]
Merge branch 'MDL-67284' of https://github.com/stronk7/moodle

19 months agoMerge branch 'MDL-67283' of https://github.com/stronk7/moodle
Jake Dallimore [Mon, 18 Nov 2019 03:20:28 +0000 (11:20 +0800)]
Merge branch 'MDL-67283' of https://github.com/stronk7/moodle

19 months agoMDL-67284 mod_feedback: Add missing file phpdoc block
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 11:27:17 +0000 (12:27 +0100)]
MDL-67284 mod_feedback: Add missing file phpdoc block

19 months agoMDL-67283 backup: Bump release to 3.9
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 10:25:40 +0000 (11:25 +0100)]
MDL-67283 backup: Bump release to 3.9

19 months agoMDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sun, 17 Nov 2019 10:40:19 +0000 (11:40 +0100)]
MDL-67284 upgrade: add 3.8.0 separation line to all upgrade scripts

19 months agoMDL-67077 h5p: php74 fix (curly braces) for the H5P lib
Eloy Lafuente (stronk7) [Wed, 30 Oct 2019 10:24:34 +0000 (11:24 +0100)]
MDL-67077 h5p: php74 fix (curly braces) for the H5P lib

This has been sent also upstream @ https://github.com/h5p/h5p-php-library/pull/69

19 months agoMDL-67035 tags: fix nested ternary operators to be php74 compliant
Eloy Lafuente (stronk7) [Sun, 27 Oct 2019 23:26:17 +0000 (00:26 +0100)]
MDL-67035 tags: fix nested ternary operators to be php74 compliant

Nesting ternary operators without explicit parentheses is deprecated:

    // Code like
    $a ? $b : $c ? $d : $e
    // should be replaced by (current interpretation)
    ($a ? $b : $c) ? $d : $e
    // or (likely intended interpretation)
    $a ? $b : ($c ? $d : $e)

19 months agoMDL-67034 google: php74 fix (curly braces) for the Google-Client lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:21:56 +0000 (00:21 +0200)]
MDL-67034 google: php74 fix (curly braces) for the Google-Client lib

19 months agoMDL-67034 adodb: php74 fix (curly braces) for the AdoDB lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:18:05 +0000 (00:18 +0200)]
MDL-67034 adodb: php74 fix (curly braces) for the AdoDB lib

19 months agoMDL-67034 horde: php74 fix (curly braces) for the Horde lib
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 22:15:48 +0000 (00:15 +0200)]
MDL-67034 horde: php74 fix (curly braces) for the Horde lib

19 months agoMDL-67031 s3: php74 fixup for class S3 v0.5.1
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 15:05:29 +0000 (17:05 +0200)]
MDL-67031 s3: php74 fixup for class S3 v0.5.1

19 months agoMDL-67030 htmlpurifier: add details to readme
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 09:37:37 +0000 (11:37 +0200)]
MDL-67030 htmlpurifier: add details to readme

19 months agoMDL-67030 htmlpurifier: php74 fixup for htmlpurifier v4.10.0
Eloy Lafuente (stronk7) [Sat, 26 Oct 2019 09:34:03 +0000 (11:34 +0200)]
MDL-67030 htmlpurifier: php74 fixup for htmlpurifier v4.10.0

This simply applies this pull request:

https://github.com/ezyang/htmlpurifier/pull/224

straight to our library. Once there is some new htmlpurifier
release available (>v4.11.0) we'll be back upstream because
the fix will be included.

19 months agoMDL-67029 bennu: add details to readme
Eloy Lafuente (stronk7) [Fri, 25 Oct 2019 20:00:57 +0000 (22:00 +0200)]
MDL-67029 bennu: add details to readme

19 months agoMDL-67029 bennu: php74 fixup for bennu lib 0.1-custom
Eloy Lafuente (stronk7) [Fri, 25 Oct 2019 19:50:13 +0000 (21:50 +0200)]
MDL-67029 bennu: php74 fixup for bennu lib 0.1-custom

19 months agoMDL-67017 typo3: add details to readme
Eloy Lafuente (stronk7) [Thu, 24 Oct 2019 16:48:30 +0000 (18:48 +0200)]
MDL-67017 typo3: add details to readme

19 months agoMDL-67017 typo3: php74 fixup for typo3 lib 4.7.19
Eloy Lafuente (stronk7) [Thu, 24 Oct 2019 16:41:52 +0000 (18:41 +0200)]
MDL-67017 typo3: php74 fixup for typo3 lib 4.7.19

We are using a really outdated Typo3 library (2014) already patched
for php73 support. Plus, probably, we'll be soon removing it from core.

So we have decided to, instead of upgrade, apply the needed php74 fixes.

19 months agoMDL-66964 markdown: php74 fixup for markdown lib 1.8.0
Eloy Lafuente (stronk7) [Sat, 19 Oct 2019 08:48:00 +0000 (10:48 +0200)]
MDL-66964 markdown: php74 fixup for markdown lib 1.8.0

Note this is different from the upstream commit:

https://github.com/michelf/php-markdown/commit/a35858f0409e5f01474f5cd562d17289fe8e5435

because it was conflicting so only the cases corresponding
to our current 1.8.0 version have been modified.

This commit is trivial, just a pure curly to square replacement.

19 months agoweekly back-to-dev release 3.9dev
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 17:03:02 +0000 (18:03 +0100)]
weekly back-to-dev release 3.9dev

19 months agoNOBUG: Change travis.yml back to master
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml back to master

19 months agoMoodle release 3.8 v3.8.0
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:07 +0000 (17:54 +0100)]
Moodle release 3.8

19 months agoNOBUG: Change travis.yml to MOODLE_38_STABLE
Eloy Lafuente (stronk7) [Sat, 16 Nov 2019 16:54:08 +0000 (17:54 +0100)]
NOBUG: Change travis.yml to MOODLE_38_STABLE

19 months agoMerge branch 'MDL-67281' of https://github.com/stronk7/moodle
Jun Pataleta [Sat, 16 Nov 2019 09:44:05 +0000 (17:44 +0800)]
Merge branch 'MDL-67281' of https://github.com/stronk7/moodle

19 months agoMDL-67281 forum: don't show discussion creation time twice
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 18:11:34 +0000 (19:11 +0100)]
MDL-67281 forum: don't show discussion creation time twice

The discussion creation time (or first post) is being shown
both in the "started by" and "last post" columns in forum
discussions list.

Just let's change the former to show the discussion modification
time (or last post) instead.

19 months agoMoodle release 3.8rc1 v3.8.0-rc1
Eloy Lafuente (stronk7) [Fri, 15 Nov 2019 11:30:52 +0000 (12:30 +0100)]
Moodle release 3.8rc1

19 months agoMerge branch 'MDL-67269-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Fri, 15 Nov 2019 04:38:54 +0000 (12:38 +0800)]
Merge branch 'MDL-67269-master' of git://github.com/andrewnicols/moodle

19 months agoMerge branch 'MDL-67268-master' of git://github.com/mihailges/moodle
Andrew Nicols [Fri, 15 Nov 2019 04:08:33 +0000 (12:08 +0800)]
Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle

19 months agoMDL-67268 mod_forum: Group and label radio buttons in forum grader
Mihail Geshoski [Fri, 15 Nov 2019 04:05:59 +0000 (12:05 +0800)]
MDL-67268 mod_forum: Group and label radio buttons in forum grader

19 months agoMDL-67269 mod_forum: Capture form submission in grading panel
Andrew Nicols [Fri, 15 Nov 2019 03:45:17 +0000 (11:45 +0800)]
MDL-67269 mod_forum: Capture form submission in grading panel

19 months agoMerge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project
Andrew Nicols [Fri, 15 Nov 2019 02:35:00 +0000 (10:35 +0800)]
Merge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project

19 months agoMDL-67265 core: Set max-height on toast wrapper
Mathew May [Fri, 15 Nov 2019 01:21:06 +0000 (09:21 +0800)]
MDL-67265 core: Set max-height on toast wrapper

19 months agoMerge branch 'MDL-67241-master' of git://github.com/lameze/moodle
Jake Dallimore [Thu, 14 Nov 2019 08:34:28 +0000 (16:34 +0800)]
Merge branch 'MDL-67241-master' of git://github.com/lameze/moodle

19 months agoMerge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_f...
Jake Dallimore [Thu, 14 Nov 2019 07:17:24 +0000 (15:17 +0800)]
Merge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_forum-project

19 months agoMDL-67144 mod_forum: If no users exist do not show the grading interface
Mathew May [Thu, 14 Nov 2019 03:49:25 +0000 (11:49 +0800)]
MDL-67144 mod_forum: If no users exist do not show the grading interface

19 months agoMerge branch 'MDL-67246-master' of git://github.com/jleyva/moodle
Jun Pataleta [Thu, 14 Nov 2019 06:34:17 +0000 (14:34 +0800)]
Merge branch 'MDL-67246-master' of git://github.com/jleyva/moodle

19 months agoMerge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle
Jake Dallimore [Thu, 14 Nov 2019 06:27:42 +0000 (14:27 +0800)]
Merge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle

19 months agoMerge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Jun Pataleta [Thu, 14 Nov 2019 04:37:22 +0000 (12:37 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle

19 months agoMDL-67116 course: Restore removed line
Andrew Nicols [Thu, 14 Nov 2019 03:42:56 +0000 (11:42 +0800)]
MDL-67116 course: Restore removed line

This line was inadvertently removed in a previous commit.

19 months agoMerge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle
Andrew Nicols [Thu, 14 Nov 2019 02:54:14 +0000 (10:54 +0800)]
Merge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle

19 months agoMDL-67241 mod_forum: raise memory limit when exporting
Simey Lameze [Thu, 14 Nov 2019 02:10:29 +0000 (10:10 +0800)]
MDL-67241 mod_forum: raise memory limit when exporting

19 months agoMerge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle
Adrian Greeve [Thu, 14 Nov 2019 01:03:31 +0000 (09:03 +0800)]
Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle

19 months agoMDL-67116 course: Strict empty string check required
Andrew Nicols [Thu, 14 Nov 2019 00:38:19 +0000 (08:38 +0800)]
MDL-67116 course: Strict empty string check required

In PHP the following are true:

    assert('' == '');
    assert(0 == '');
    assert(null == '');

The options in the course completion settings are now:

    ''    => none selected
    [int] => itemnumber of activity course completion item.

In the case where the itemnumber was 0  this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:

    (int) '' === 0

As a result, the non-strict comparison means that the following are
identical:

    assert(0 == '');
    assert(0 == (int) '');
    assert(0 == '0');

Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.

19 months agoMerge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle
Eloy Lafuente (stronk7) [Thu, 14 Nov 2019 00:12:01 +0000 (01:12 +0100)]
Merge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle

19 months agoMDL-67250 setup: Revert removal of the httpswwwroot setting
David Mudrák [Wed, 13 Nov 2019 18:58:10 +0000 (19:58 +0100)]
MDL-67250 setup: Revert removal of the httpswwwroot setting

It is still used widely in the plugins that would stop working suddenly
without being warned via a debugging message. We must keep it forever as
an alias for the wwwroot.

19 months agoMDL-67248 filter_displayh5p: Add new description on filter
cescobedo [Wed, 13 Nov 2019 17:36:09 +0000 (18:36 +0100)]
MDL-67248 filter_displayh5p: Add new description on filter

19 months agoMDL-67246 admin: Return course color settings for external clients
Juan Leyva [Wed, 13 Nov 2019 14:33:20 +0000 (15:33 +0100)]
MDL-67246 admin: Return course color settings for external clients