moodle.git
6 months agoMDL-70320 behat: User full path to page admin node
Andrew Nicols [Wed, 9 Dec 2020 23:53:56 +0000 (07:53 +0800)]
MDL-70320 behat: User full path to page admin node

6 months agoMDL-70320 permission overrides: role names were double-escaped
Tim Hunt [Tue, 24 Nov 2020 17:20:12 +0000 (17:20 +0000)]
MDL-70320 permission overrides: role names were double-escaped

6 months agoweekly release 3.10+
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 22:17:06 +0000 (23:17 +0100)]
weekly release 3.10+

7 months agoMerge branch 'MOODLE_310_STABLE-MDL-67636' of https://github.com/yao9394/moodle into...
Adrian Greeve [Thu, 19 Nov 2020 03:57:33 +0000 (11:57 +0800)]
Merge branch 'MOODLE_310_STABLE-MDL-67636' of https://github.com/yao9394/moodle into MOODLE_310_STABLE

7 months agoMDL-67636 gradebook: Prevent exposing hidden grade in locked category
John Yao [Thu, 19 Nov 2020 01:36:32 +0000 (12:36 +1100)]
MDL-67636 gradebook: Prevent exposing hidden grade in locked category

7 months agoMerge branch 'MDL-56653-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE
Adrian Greeve [Thu, 19 Nov 2020 03:10:48 +0000 (11:10 +0800)]
Merge branch 'MDL-56653-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69809-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Andrew Nicols [Thu, 19 Nov 2020 02:47:46 +0000 (10:47 +0800)]
Merge branch 'MDL-69809-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70094-310' of https://github.com/SangNguyen2601/moodle into MOODLE_...
Jun Pataleta [Thu, 19 Nov 2020 01:36:53 +0000 (09:36 +0800)]
Merge branch 'MDL-70094-310' of https://github.com/SangNguyen2601/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69201-310' of https://github.com/paulholden/moodle into MOODLE_310_...
Eloy Lafuente (stronk7) [Wed, 18 Nov 2020 22:00:18 +0000 (23:00 +0100)]
Merge branch 'MDL-69201-310' of https://github.com/paulholden/moodle into MOODLE_310_STABLE

7 months agoMDL-70094 Question: Technical info section expands if click help icon
sangnguyen2601 [Mon, 9 Nov 2020 08:47:14 +0000 (15:47 +0700)]
MDL-70094 Question: Technical info section expands if click help icon

7 months agoMDL-56653 enrol_meta: a single DB query in edit_instance_validation
Vitaly [Fri, 18 Sep 2020 18:45:26 +0000 (21:45 +0300)]
MDL-56653 enrol_meta: a single DB query in edit_instance_validation

The 'edit_instance_validation()' method checks for existing meta enrolment instances.
The fix replaces DB queries in a loop for each course with a single query for all courses.
Also, a new testing method 'test_edit_instance_validation_with_existing_courses()'
was added to /enrol/meta/tests/plugin_test.php to test if the new implementation
returns an error in case of trying to save the already linked courses in the 'customint1' field.

7 months agoMerge branch '310_MDL-68896' of git://github.com/danmarsden/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 18 Nov 2020 01:33:06 +0000 (09:33 +0800)]
Merge branch '310_MDL-68896' of git://github.com/danmarsden/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70148-310' of git://github.com/andrewnicols/moodle into MOODLE_310_...
Eloy Lafuente (stronk7) [Tue, 17 Nov 2020 22:13:17 +0000 (23:13 +0100)]
Merge branch 'MDL-70148-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

7 months agoMDL-70148 gradereport_grader: Improve reliability of keyboard usage
Andrew Nicols [Mon, 9 Nov 2020 07:35:54 +0000 (15:35 +0800)]
MDL-70148 gradereport_grader: Improve reliability of keyboard usage

In some browsers the ajax grade select does not properly update the
grade after setting values. The previous solution was to press the
[enter] key, but doing this with the new key type step opens the select
box again. This is what happens when a real user presses enter on the
select.

This is the last possible field in the report, so pressing the tab key
to move to the next gradable element does not work.

The solution uses a shift-tab to move the focus away to the previous
gradale element. In this case it must also be moved to an earlier step
because the previously selected value must be checked in the Then
section of the test and if it is selected then its value cannot be
checked.

7 months agoMDL-70148 qtype: Update qtype steps to new key interaction
Andrew Nicols [Tue, 23 Jun 2020 03:09:58 +0000 (11:09 +0800)]
MDL-70148 qtype: Update qtype steps to new key interaction

Note: The ddmarker question type was previously getting the number of
keypresses wrong. This was because it was using both keyDown/keyUp, and
also keyPress. As a result each keypress was essentially happening two
times.

7 months agoMDL-70148 behat: Update steps for keyboard
Andrew Nicols [Mon, 22 Jun 2020 02:39:57 +0000 (10:39 +0800)]
MDL-70148 behat: Update steps for keyboard

7 months agoMDL-70148 behat: Add steps to send keys without an element
Andrew Nicols [Wed, 17 Jun 2020 06:50:04 +0000 (14:50 +0800)]
MDL-70148 behat: Add steps to send keys without an element

7 months agoMerge branch 'MDL-69526-310' of git://github.com/lucaboesch/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 17 Nov 2020 06:55:10 +0000 (14:55 +0800)]
Merge branch 'MDL-69526-310' of git://github.com/lucaboesch/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-50955-310' of git://github.com/peterRd/moodle into MOODLE_310_STABLE
Adrian Greeve [Tue, 17 Nov 2020 05:08:48 +0000 (13:08 +0800)]
Merge branch 'MDL-50955-310' of git://github.com/peterRd/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69964-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE
Andrew Nicols [Tue, 17 Nov 2020 02:22:38 +0000 (10:22 +0800)]
Merge branch 'MDL-69964-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE

7 months agoMDL-69964 course: toggle participant checkboxes in root element.
Paul Holden [Wed, 21 Oct 2020 09:22:55 +0000 (10:22 +0100)]
MDL-69964 course: toggle participant checkboxes in root element.

For a given toggleGroup, the relevant action elements are not
necessarily descendants of the same tableRoot element, on the
course participants page.

7 months agoMDL-67513 core: Only move modal to body if currently attached
Andrew Nicols [Mon, 16 Nov 2020 07:19:28 +0000 (15:19 +0800)]
MDL-67513 core: Only move modal to body if currently attached

A previous change as part of this commitset was intended to move the
modal to the document.body, but where the modal had been destroyed it
was instead added back to the body.

7 months agoMDL-50955 core: Reset lessons completion criteria if grade type is none
Peter Dias [Wed, 7 Oct 2020 02:55:25 +0000 (10:55 +0800)]
MDL-50955 core: Reset lessons completion criteria if grade type is none

7 months agoMerge branch 'MDL-67513-m310' of https://github.com/NeillM/moodle into MOODLE_310_STABLE
Andrew Nicols [Mon, 16 Nov 2020 00:27:35 +0000 (08:27 +0800)]
Merge branch 'MDL-67513-m310' of https://github.com/NeillM/moodle into MOODLE_310_STABLE

7 months agoMDL-69526 block_myoverview: custom course fields natural sorting
Luca Bösch [Fri, 21 Aug 2020 14:03:18 +0000 (16:03 +0200)]
MDL-69526 block_myoverview: custom course fields natural sorting

7 months agoweekly release 3.10+
Eloy Lafuente (stronk7) [Thu, 12 Nov 2020 21:11:40 +0000 (22:11 +0100)]
weekly release 3.10+

7 months agoMDL-67513 forum: View conversations while fullscreen grading
Neill Magill [Tue, 25 Aug 2020 06:47:15 +0000 (07:47 +0100)]
MDL-67513 forum: View conversations while fullscreen grading

Before this change when a modal was shown and an element on the page
was fullscreen the modal would be created behind it.

This change ensures that the modal will be inside an element that is
fullscreen so that it will be correctly displayed.

7 months agoMerge branch 'MDL-69453-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE
Adrian Greeve [Thu, 12 Nov 2020 03:56:29 +0000 (11:56 +0800)]
Merge branch 'MDL-69453-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70067-310_theme_classic' of https://github.com/alexmorrisnz/moodle...
Andrew Nicols [Thu, 12 Nov 2020 02:27:27 +0000 (10:27 +0800)]
Merge branch 'MDL-70067-310_theme_classic' of https://github.com/alexmorrisnz/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MOODLE_310_MDL-70117' of https://github.com/golenkovm/moodle into MOODL...
Adrian Greeve [Thu, 12 Nov 2020 01:27:08 +0000 (09:27 +0800)]
Merge branch 'MOODLE_310_MDL-70117' of https://github.com/golenkovm/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-65941-310' of https://github.com/snake/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Wed, 11 Nov 2020 23:18:39 +0000 (00:18 +0100)]
Merge branch 'MDL-65941-310' of https://github.com/snake/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70023-310' of git://github.com/marinaglancy/moodle into MOODLE_310_...
Eloy Lafuente (stronk7) [Wed, 11 Nov 2020 22:57:25 +0000 (23:57 +0100)]
Merge branch 'MDL-70023-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE

7 months agoMDL-70067 report_insights: Replace BS3 column naming
Alex Morris [Wed, 11 Nov 2020 19:56:19 +0000 (08:56 +1300)]
MDL-70067 report_insights: Replace BS3 column naming

Bootstrap 4 removed col-xs- and replaced it with col-

7 months agoMerge branch 'MDL-70063-310-1' of git://github.com/mihailges/moodle into MOODLE_310_S...
Sara Arjona [Wed, 11 Nov 2020 15:30:21 +0000 (16:30 +0100)]
Merge branch 'MDL-70063-310-1' of git://github.com/mihailges/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70072-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE
Jun Pataleta [Wed, 11 Nov 2020 14:09:07 +0000 (22:09 +0800)]
Merge branch 'MDL-70072-310' of git://github.com/rezaies/moodle into MOODLE_310_STABLE

7 months agoMDL-70063 block_tag_youtube: Add behat tests
Mihail Geshoski [Wed, 11 Nov 2020 13:02:42 +0000 (21:02 +0800)]
MDL-70063 block_tag_youtube: Add behat tests

7 months agoMDL-70063 block_tag_youtube: Fix category config in existing instances
Mihail Geshoski [Sat, 31 Oct 2020 14:59:52 +0000 (22:59 +0800)]
MDL-70063 block_tag_youtube: Fix category config in existing instances

Upgrade step that fixes the category configuration of existing
tag_youtube block instances.

7 months agoMDL-70063 block_tag_youtube: Update category config to use category ID
Mihail Geshoski [Sat, 31 Oct 2020 14:52:06 +0000 (22:52 +0800)]
MDL-70063 block_tag_youtube: Update category config to use category ID

In YouTube Data API v3, the API call to fetch the videos related to a
certain category expects the category ID to be passed to the
videoCategoryId parameter, instead of the category name. Therefore, the
category config should store the category ID.

7 months agoMDL-69453 core_form: improve form UI icons and alignment
Bas Brands [Tue, 27 Oct 2020 12:44:02 +0000 (13:44 +0100)]
MDL-69453 core_form: improve form UI icons and alignment

7 months agoMerge branch 'MDL-70141-m310' of https://github.com/sammarshallou/moodle into MOODLE_...
Sara Arjona [Wed, 11 Nov 2020 07:39:23 +0000 (08:39 +0100)]
Merge branch 'MDL-70141-m310' of https://github.com/sammarshallou/moodle into MOODLE_310_STABLE

7 months agoMDL-65941 cache: Prevent cache config failure on redis problems.
Michael Aherne [Mon, 17 Jun 2019 11:24:39 +0000 (12:24 +0100)]
MDL-65941 cache: Prevent cache config failure on redis problems.

7 months agoMerge branch 'MDL-69823-310' of git://github.com/jleyva/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 11 Nov 2020 06:41:31 +0000 (07:41 +0100)]
Merge branch 'MDL-69823-310' of git://github.com/jleyva/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70126-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 11 Nov 2020 02:25:04 +0000 (10:25 +0800)]
Merge branch 'MDL-70126-310' of git://github.com/paulholden/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70065_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Andrew Nicols [Wed, 11 Nov 2020 02:10:24 +0000 (10:10 +0800)]
Merge branch 'MDL-70065_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

7 months agoMDL-70117 dataformat_pdf: Fix content overflow when headers are involved
Mikhail Golenkov [Tue, 10 Nov 2020 23:49:58 +0000 (10:49 +1100)]
MDL-70117 dataformat_pdf: Fix content overflow when headers are involved

7 months agoMDL-69823 qtype: Support core question types
Juan Leyva [Wed, 30 Sep 2020 09:27:29 +0000 (11:27 +0200)]
MDL-69823 qtype: Support core question types

7 months agoMDL-69823 mod_quiz: Return question options via WS
Juan Leyva [Wed, 30 Sep 2020 09:27:05 +0000 (11:27 +0200)]
MDL-69823 mod_quiz: Return question options via WS

7 months agoMerge branch 'MDL-70106-icon-cache-310' of https://github.com/Peterburnett/moodle...
Sara Arjona [Tue, 10 Nov 2020 15:53:37 +0000 (16:53 +0100)]
Merge branch 'MDL-70106-icon-cache-310' of https://github.com/Peterburnett/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69930-310' of https://github.com/HuongNV13/moodle into MOODLE_310_S...
Jun Pataleta [Tue, 10 Nov 2020 06:08:57 +0000 (14:08 +0800)]
Merge branch 'MDL-69930-310' of https://github.com/HuongNV13/moodle into MOODLE_310_STABLE

# Conflicts:
# question/type/ddimageortext/amd/build/question.min.js
# question/type/ddimageortext/amd/build/question.min.js.map
# question/type/ddimageortext/amd/src/question.js

7 months agoMerge branch 'MDL-68349-310' of git://github.com/marinaglancy/moodle into MOODLE_310_...
Jun Pataleta [Tue, 10 Nov 2020 02:14:37 +0000 (10:14 +0800)]
Merge branch 'MDL-68349-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69841-310' of https://github.com/HuongNV13/moodle into MOODLE_310_S...
Jake Dallimore [Tue, 10 Nov 2020 01:33:06 +0000 (09:33 +0800)]
Merge branch 'MDL-69841-310' of https://github.com/HuongNV13/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-69955-310' of https://github.com/HuongNV13/moodle into MOODLE_310_S...
Víctor Déniz [Mon, 9 Nov 2020 21:47:22 +0000 (21:47 +0000)]
Merge branch 'MDL-69955-310' of https://github.com/HuongNV13/moodle into MOODLE_310_STABLE

7 months agoMDL-69201 core: consistent table primary sort column/order.
Paul Holden [Tue, 20 Oct 2020 23:22:23 +0000 (00:22 +0100)]
MDL-69201 core: consistent table primary sort column/order.

7 months agoMDL-70126 tag: correct thrown exception class name.
Paul Holden [Thu, 5 Nov 2020 19:48:29 +0000 (19:48 +0000)]
MDL-70126 tag: correct thrown exception class name.

7 months agoMDL-67513 forum: Test that discussions can be viewed while grading
Neill Magill [Mon, 9 Nov 2020 14:23:25 +0000 (14:23 +0000)]
MDL-67513 forum: Test that discussions can be viewed while grading

7 months agoMerge branch 'MDL-70146_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Andrew Nicols [Mon, 9 Nov 2020 02:01:19 +0000 (10:01 +0800)]
Merge branch 'MDL-70146_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE

7 months agoMDL-70146 upgrade: add 3.10.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sat, 7 Nov 2020 22:26:09 +0000 (23:26 +0100)]
MDL-70146 upgrade: add 3.10.0 separation line to all upgrade scripts

7 months agoMoodle release 3.10 v3.10.0
Eloy Lafuente (stronk7) [Sat, 7 Nov 2020 16:24:12 +0000 (17:24 +0100)]
Moodle release 3.10

7 months agoMoodle release 3.10rc2 v3.10.0-rc2
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 21:56:08 +0000 (22:56 +0100)]
Moodle release 3.10rc2

7 months agoMerge branch 'MDL-70137-310-2' of git://github.com/andrewnicols/moodle into MOODLE_31...
Víctor Déniz [Fri, 6 Nov 2020 19:16:15 +0000 (19:16 +0000)]
Merge branch 'MDL-70137-310-2' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

7 months agoMDL-70137 cache: Write config to temp file and move into place
Andrew Nicols [Fri, 6 Nov 2020 07:07:57 +0000 (15:07 +0800)]
MDL-70137 cache: Write config to temp file and move into place

7 months agoMDL-70137 cache: Use sensible default when reading MUC config
Andrew Nicols [Fri, 6 Nov 2020 07:27:46 +0000 (15:27 +0800)]
MDL-70137 cache: Use sensible default when reading MUC config

When we read the MUC configuration, a file which exists but is empty
will not error, but will cause all configuration to be empty.

We already perform an {{is_array()}} check on the {{$configuration}}
variable, but the default value for {{$configuration}} is an empty
array. In the case where the file exists, but is empty, no errors occur
when the file is loaded, and the initial {{$configuration}} value is
not overwritten, leading to the file being replaced with an empty copy.

7 months agoMerge branch 'MDL-70143-310' of git://github.com/marinaglancy/moodle into MOODLE_310_...
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 18:51:54 +0000 (19:51 +0100)]
Merge branch 'MDL-70143-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70139-310' of git://github.com/sarjona/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 17:56:00 +0000 (18:56 +0100)]
Merge branch 'MDL-70139-310' of git://github.com/sarjona/moodle into MOODLE_310_STABLE

7 months agoMDL-70141 core_block: Web service set $PAGE url to avoid warnings
sam marshall [Fri, 6 Nov 2020 17:37:06 +0000 (17:37 +0000)]
MDL-70141 core_block: Web service set $PAGE url to avoid warnings

7 months agoMDL-70143 tool_uploaduser: fix wrong cache reference
Marina Glancy [Fri, 6 Nov 2020 17:07:24 +0000 (18:07 +0100)]
MDL-70143 tool_uploaduser: fix wrong cache reference

7 months agoMDL-70139 core_badges: fix invalid request when sending to backpack
Sara Arjona [Fri, 6 Nov 2020 14:15:45 +0000 (15:15 +0100)]
MDL-70139 core_badges: fix invalid request when sending to backpack

Having mixed $data in badge exporters is causing some issues.
As all these exporters are using $data as an object, $data can be
converted to object in the constructor, to avoid errors and get
the expected behaviour always.

7 months agoMDL-70072 core: Fix always displaying date in Gregorian
Shamim Rezaie [Fri, 6 Nov 2020 08:21:17 +0000 (19:21 +1100)]
MDL-70072 core: Fix always displaying date in Gregorian

7 months agoMerge branch 'MDL-70130-310' of git://github.com/andrewnicols/moodle into MOODLE_310_...
Jun Pataleta [Fri, 6 Nov 2020 03:27:54 +0000 (11:27 +0800)]
Merge branch 'MDL-70130-310' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

7 months agoMDL-70130 core: Compare realpaths for file attachment checks
Andrew Nicols [Fri, 6 Nov 2020 02:46:02 +0000 (10:46 +0800)]
MDL-70130 core: Compare realpaths for file attachment checks

Rather than using the provided path, the `realpath` must be used to
ensure that the use of symlinks in paths is normalised.

7 months agoMDL-70130 core: Simplify attachment handling in email_to_suer
Andrew Nicols [Fri, 6 Nov 2020 02:50:56 +0000 (10:50 +0800)]
MDL-70130 core: Simplify attachment handling in email_to_suer

7 months agoMDL-70130 core: allow to attach files from localrequestdir to emails
Marina Glancy [Thu, 5 Nov 2020 16:01:54 +0000 (17:01 +0100)]
MDL-70130 core: allow to attach files from localrequestdir to emails

Co-authored-by: Paul Holden <paulh@moodle.com>
7 months agoMerge branch 'MDL-70131-310' of git://github.com/marinaglancy/moodle into MOODLE_310_...
Andrew Nicols [Fri, 6 Nov 2020 01:27:33 +0000 (09:27 +0800)]
Merge branch 'MDL-70131-310' of git://github.com/marinaglancy/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70120-assign-stamp-expires-MOODLE_310_STABLE' of https://github...
Andrew Nicols [Fri, 6 Nov 2020 01:26:01 +0000 (09:26 +0800)]
Merge branch 'MDL-70120-assign-stamp-expires-MOODLE_310_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_310_STABLE

7 months agoMDL-70131 cli: only allow to negate existing keys
Marina Glancy [Thu, 5 Nov 2020 17:10:13 +0000 (18:10 +0100)]
MDL-70131 cli: only allow to negate existing keys

7 months agoMoodle release 3.10rc1 v3.10.0-rc1
Eloy Lafuente (stronk7) [Thu, 5 Nov 2020 11:16:53 +0000 (12:16 +0100)]
Moodle release 3.10rc1

7 months agoMDL-70023 core_course: improve performance of recently accessed courses
Marina Glancy [Mon, 26 Oct 2020 11:23:23 +0000 (12:23 +0100)]
MDL-70023 core_course: improve performance of recently accessed courses

7 months agoMerge branch 'MDL-70075-310-2' of git://github.com/andrewnicols/moodle into MOODLE_31...
Jun Pataleta [Thu, 5 Nov 2020 04:51:23 +0000 (12:51 +0800)]
Merge branch 'MDL-70075-310-2' of git://github.com/andrewnicols/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70066-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE
Andrew Nicols [Thu, 5 Nov 2020 02:01:18 +0000 (10:01 +0800)]
Merge branch 'MDL-70066-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE

7 months agoMDL-70075 core: Autocomplete selection should always have an active item
Andrew Nicols [Wed, 4 Nov 2020 03:24:04 +0000 (11:24 +0800)]
MDL-70075 core: Autocomplete selection should always have an active item

Ensure that there is always one active element in the list of selected
autocomplete elements.

Without this we have issues beacuse clicking on the link makes the first
one active if one is not already active, and this turns a click event
into a drag event, which means that it is not deleted.

7 months agoMDL-70075 core: Do not return a value in an event handler
Andrew Nicols [Mon, 2 Nov 2020 07:42:38 +0000 (15:42 +0800)]
MDL-70075 core: Do not return a value in an event handler

Returning a value of `false` in an event handler has the effect of
calling event.preventDefault() and event.stopPropagation().

This is neither obvious, nor desirable in this situation.

7 months agoMDL-70075 core: jQuery.attr() does not accept a bool value
Andrew Nicols [Mon, 2 Nov 2020 07:42:13 +0000 (15:42 +0800)]
MDL-70075 core: jQuery.attr() does not accept a bool value

The documented values that jQuery.attr() accepts are String, Number, or
null. For some reason, when we pass a Boolean value, the subsequent
click handler does not work in some situations.

Changing this to take a Number, and unsetting it when empty, resolves
this issue.

7 months agoMDL-70075 core: Listen for `change` in accessibleChange event
Andrew Nicols [Mon, 2 Nov 2020 01:33:05 +0000 (09:33 +0800)]
MDL-70075 core: Listen for `change` in  accessibleChange event

The accessibleChange custom interaction event was only listening for
blur and focus, however some OS/browser combinations do not emit these
events until the element is explicitly blurred. This is notably
different on Firefox on some Operating Systems.

Recent changes in MDL-68167 explicitly moved the user participants page
filter module to use the accessibleChange event, which means that the
selections are now only triggered on an explicit blur when using
Firefox. This highlight a bug whereby, when the mouse is used to make a
selection, the event is not triggered until the element is blurred.

This change modifies the accessibleChange event to ignore the `change`
event where it was triggered by the keyboard and where that keybaord
event was not a [return] or [escape] keypress, but to otherwise respect
the native change event.

7 months agoMDL-70075 core: Listen for the `focus` and `blur` events again
Andrew Nicols [Mon, 2 Nov 2020 00:12:22 +0000 (08:12 +0800)]
MDL-70075 core: Listen for the `focus` and `blur` events again

The `blur` event does not bubble, but the `focusout` events are not
available in all supported versions of Firefox.

Rather than switching event, this patch using event capture to
effectively achieve the same result and bubble the event up through the
DOM to the delegated listener.

There should be no functional change with this patch, except to support
Firefox fully.

7 months agoMerge branch 'MDL-70100-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE
Eloy Lafuente (stronk7) [Wed, 4 Nov 2020 21:40:54 +0000 (22:40 +0100)]
Merge branch 'MDL-70100-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70112_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE
Víctor Déniz [Wed, 4 Nov 2020 19:17:34 +0000 (19:17 +0000)]
Merge branch 'MDL-70112_310' of https://github.com/timhunt/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70114-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE
Sara Arjona [Wed, 4 Nov 2020 19:15:04 +0000 (20:15 +0100)]
Merge branch 'MDL-70114-310' of git://github.com/bmbrands/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-68749-310-2' of git://github.com/mickhawkins/moodle into MOODLE_310...
Víctor Déniz [Wed, 4 Nov 2020 15:24:08 +0000 (15:24 +0000)]
Merge branch 'MDL-68749-310-2' of git://github.com/mickhawkins/moodle into MOODLE_310_STABLE

7 months agoMerge branch 'MDL-70119-310' of git://github.com/ferranrecio/moodle into MOODLE_310_S...
Sara Arjona [Wed, 4 Nov 2020 14:19:44 +0000 (15:19 +0100)]
Merge branch 'MDL-70119-310' of git://github.com/ferranrecio/moodle into MOODLE_310_STABLE

7 months agoMDL-70114 mod_data: add border for to textarea
Bas Brands [Wed, 4 Nov 2020 13:21:57 +0000 (13:21 +0000)]
MDL-70114 mod_data: add border for to textarea

7 months agoMDL-70120 assignfeedback_editpdf: Stamp files should be cached
Brendan Heywood [Wed, 4 Nov 2020 11:42:21 +0000 (22:42 +1100)]
MDL-70120 assignfeedback_editpdf: Stamp files should be cached

7 months agoMDL-70119 core_badges: fix tab names
Ferran Recio [Wed, 4 Nov 2020 11:48:09 +0000 (12:48 +0100)]
MDL-70119 core_badges: fix tab names

7 months agoMDL-70066 badges: change usages of array_key_exists to isset
Simey Lameze [Thu, 29 Oct 2020 23:17:43 +0000 (07:17 +0800)]
MDL-70066 badges: change usages of array_key_exists to isset

7 months agoMerge branch 'MDL-70089_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE
Jun Pataleta [Wed, 4 Nov 2020 05:05:47 +0000 (13:05 +0800)]
Merge branch 'MDL-70089_310' of https://github.com/stronk7/moodle into MOODLE_310_STABLE

7 months agoMDL-70106 cache: Set icon localstorage cache to use theme localisation
Peter Burnett [Tue, 3 Nov 2020 00:59:21 +0000 (10:59 +1000)]
MDL-70106 cache: Set icon localstorage cache to use theme localisation

7 months agoMDL-69955 qtype_ddimageortext: drop zone disappear in special case
Huong Nguyen [Mon, 2 Nov 2020 02:54:22 +0000 (09:54 +0700)]
MDL-69955 qtype_ddimageortext: drop zone disappear in special case

7 months agoMerge branch 'MOODLE_310_MDL-70093' of https://github.com/golenkovm/moodle into MOODL...
Jake Dallimore [Wed, 4 Nov 2020 01:00:26 +0000 (09:00 +0800)]
Merge branch 'MOODLE_310_MDL-70093' of https://github.com/golenkovm/moodle into MOODLE_310_STABLE

7 months agoMDL-70112 drag-drop qtypes: fix form preview
Tim Hunt [Tue, 3 Nov 2020 21:25:51 +0000 (21:25 +0000)]
MDL-70112 drag-drop qtypes: fix form preview

7 months agoMDL-70089 versions: main version bump
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 18:38:27 +0000 (19:38 +0100)]
MDL-70089 versions: main version bump

7 months agoMDL-70089 versions: bump all versions and requires near release
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 18:34:52 +0000 (19:34 +0100)]
MDL-70089 versions: bump all versions and requires near release

version = 2020110900 release version
requires= 2020110300 current beta+ (week6roll1) version

Note that, because we are under parallel development period,
this is being done in the branch that is going to be released
(MOODLE_310_STABLE already existing) for Moodle 3.10.0 and
not in master, that is the one getting the bump under normal
(non-parallel) periods.