Sara Arjona [Thu, 15 Apr 2021 06:30:08 +0000 (08:30 +0200)]
Merge branch 'MDL-71337-master' of git://github.com/junpataleta/moodle
Jake Dallimore [Thu, 15 Apr 2021 06:16:04 +0000 (14:16 +0800)]
Merge branch 'MDL-61768-master-3' of git://github.com/mihailges/moodle
abgreeve [Thu, 15 Apr 2021 05:48:39 +0000 (13:48 +0800)]
Merge branch 'MDL-71007-courseidnumer-grade-ws' of https://github.com/brendanheywood/moodle
Jun Pataleta [Thu, 15 Apr 2021 04:43:27 +0000 (12:43 +0800)]
MDL-71337 mod_h5pactivity: Increase window size during test
The addition of the activity information moves the h5p content down
out of the window view on Firefox which causes the Check button to be
unclickable. This patch increases the window size to ensure that the
check button is visible and clickable.
Credits to Eloy <stronk7@moodle.org> for the thorough investigation
of the root cause of this issue :)
Mihail Geshoski [Thu, 18 Mar 2021 06:03:20 +0000 (14:03 +0800)]
MDL-61768 repository_googledocs: Deprecate unused methods
Deprecates methods from the repository_googledocs class which are
no longer used.
Mihail Geshoski [Thu, 18 Mar 2021 01:39:30 +0000 (09:39 +0800)]
MDL-61768 repository_googledocs: Add unit tests
Adds unit tests for the newly introduced methods related to the content
browsing and searching functionallity across drives.
Mihail Geshoski [Thu, 18 Mar 2021 01:38:43 +0000 (09:38 +0800)]
MDL-61768 repository_googledocs: Support shared drives
Enables the Google Drive repository to support browsing and searching
for content from the existing shared drives.
Mihail Geshoski [Wed, 3 Mar 2021 08:49:24 +0000 (16:49 +0800)]
MDL-61768 repository_googledocs: Rest API function to list shared drives
Adds a new rest API function in the googledocs repository which would
return the existing shared drives.
Jake Dallimore [Thu, 15 Apr 2021 02:35:33 +0000 (10:35 +0800)]
Merge branch 'MDL-70142' of git://github.com/paulholden/moodle
Andrew Nicols [Thu, 15 Apr 2021 01:19:24 +0000 (09:19 +0800)]
Merge branch 'MDL-70311-master' of git://github.com/ilyatregubov/moodle
Jake Dallimore [Thu, 15 Apr 2021 00:38:48 +0000 (08:38 +0800)]
Merge branch 'MDL-70649-alternative-security-helper' of https://github.com/xuangui2018/moodle
Jake Dallimore [Thu, 15 Apr 2021 00:31:47 +0000 (08:31 +0800)]
Merge branch 'MDL-71119-master' of git://github.com/sarjona/moodle
Eloy Lafuente (stronk7) [Wed, 14 Apr 2021 17:17:19 +0000 (19:17 +0200)]
Merge branch 'MDL-67999-master' of git://github.com/sarjona/moodle
Sara Arjona [Thu, 18 Mar 2021 15:30:02 +0000 (16:30 +0100)]
MDL-67999 contentbank: Remove contentbank/upload.php
As the form to upload files to the content bank has been moved to
modal, this file is not required any more, so it has been removed.
Sara Arjona [Thu, 18 Mar 2021 11:51:03 +0000 (12:51 +0100)]
MDL-67999 contentbank: Make upload/replace files modal form
Once MDL-64554 landed, content bank can implement the original
proposal, using a modal form when uploading files.
Sara Arjona [Thu, 18 Mar 2021 11:40:32 +0000 (12:40 +0100)]
MDL-67999 core_contentbank: Add namespace to upload form
The form to upload/replace files has been moved to classes/form
(it's where it should have been added when it was created).
Besides, this class has been renamed because now, with the
namespace, contentbank and form don't need to be in the name ;-)
Xuan Gui [Tue, 2 Feb 2021 23:54:54 +0000 (09:54 +1000)]
MDL-70649 files: Alternative security helper
Augument all installed plugin's security helper if there is any.
Plugins function has to be defined as plugintype_pluginname_security_helper in pluginname/lib.php file.
Eloy Lafuente (stronk7) [Wed, 14 Apr 2021 10:45:00 +0000 (12:45 +0200)]
Merge branch 'MDL-70616-master' of https://github.com/izendegi/moodle
Iñigo Zendegi [Wed, 14 Apr 2021 09:04:54 +0000 (11:04 +0200)]
MDL-70616 gradingform_rubric: Filters not applied to rubric name
Sara Arjona [Wed, 14 Apr 2021 08:52:34 +0000 (10:52 +0200)]
MDL-71119 core_badges: Add more information to errors
Some errors raised when calling external services were ignored.
Displaying this information helps to debug and find the real reasons
why some action, like connecting to an external backpack, can't be
done.
Jun Pataleta [Wed, 14 Apr 2021 08:50:42 +0000 (16:50 +0800)]
Merge branch 'MDL-71315-master' of git://github.com/sarjona/moodle
Sara Arjona [Tue, 16 Mar 2021 11:43:39 +0000 (12:43 +0100)]
MDL-71119 core_badges: Use basicauth and remove urlencode
Basic authorization header is required to get token. Besides, client
id and secret shouldn't call urlencode.
Sara Arjona [Tue, 16 Mar 2021 11:32:20 +0000 (12:32 +0100)]
MDL-71119 core_badges: Initialise scopes param in backpack-connect.php
The scopes parameter should be passed when creating the OAuth2 badges
client. As it is an optional parameter, when it's empty, it will
be initilised with the supported scopes for the backpack issuer.
It will happen, for instance, when a call is done to oauth2callback.php
because, as defined in RFC6749, OAuth2 authorization response only
supports code and state.
Sara Arjona [Tue, 13 Apr 2021 07:06:55 +0000 (09:06 +0200)]
MDL-71315 core_badges: Fix warning when rendering badges
Andrew Nicols [Wed, 14 Apr 2021 04:09:01 +0000 (12:09 +0800)]
Merge branch 'MDL-71154' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 14 Apr 2021 01:07:21 +0000 (09:07 +0800)]
Merge branch 'MDL-70207-master' of git://github.com/peterRd/moodle
Andrew Nicols [Wed, 14 Apr 2021 00:35:07 +0000 (08:35 +0800)]
Merge branch 'MDL-71169-master-execute' of git://github.com/mudrd8mz/moodle
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 21:08:45 +0000 (23:08 +0200)]
Merge branch 'MDL-69874-master' of git://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 20:39:27 +0000 (22:39 +0200)]
Merge branch 'MDL-70722-master' of git://github.com/sarjona/moodle
Víctor Déniz [Tue, 13 Apr 2021 18:45:03 +0000 (19:45 +0100)]
Merge branch 'MDL-71089-master' of git://github.com/roland04/moodle
Eloy Lafuente (stronk7) [Sun, 21 Mar 2021 18:05:22 +0000 (19:05 +0100)]
MDL-71154 ci: Prevent upstream branches and tags to be built
Both for travis and GHA:
- master and MOODLE_XXX_STABLE branches
- any vX.Y.Z tag
won't lead to a build anymore.
Mikel Martín [Tue, 16 Mar 2021 11:45:35 +0000 (12:45 +0100)]
MDL-71089 core: Add different Toast notification styling 'types'
Mikel Martín [Thu, 11 Mar 2021 15:07:17 +0000 (16:07 +0100)]
MDL-71089 theme_boost: Add styles for different toast types
Sara Arjona [Tue, 13 Apr 2021 10:26:57 +0000 (12:26 +0200)]
Merge branch 'MDL-71011' of https://github.com/stronk7/moodle
Sara Arjona [Tue, 13 Apr 2021 10:19:25 +0000 (12:19 +0200)]
Merge branch 'MDL-65983-master' of git://github.com/jleyva/moodle
Luca Bösch [Tue, 6 Oct 2020 16:12:10 +0000 (18:12 +0200)]
MDL-69874 workshop: Title mentions received assessments in close phase.
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 08:26:25 +0000 (10:26 +0200)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 08:26:20 +0000 (10:26 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Adrian Greeve [Tue, 13 Apr 2021 03:42:30 +0000 (11:42 +0800)]
Merge branch 'MDL-71161-master-4' of git://github.com/junpataleta/moodle
Adrian Greeve [Tue, 13 Apr 2021 02:59:02 +0000 (10:59 +0800)]
Merge branch 'MDL-70821-master-5' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 12 Apr 2021 22:46:55 +0000 (00:46 +0200)]
Merge branch 'mdl_71172' of https://github.com/AnupamaSarjoshi/moodle
Michael Hawkins [Fri, 12 Mar 2021 11:20:39 +0000 (19:20 +0800)]
MDL-71161 mod_workshop: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 08:16:45 +0000 (16:16 +0800)]
MDL-71161 mod_wiki: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 06:28:57 +0000 (14:28 +0800)]
MDL-71161 mod_url: Display activity completion information
Simey Lameze [Thu, 11 Mar 2021 11:06:09 +0000 (19:06 +0800)]
MDL-71161 mod_survey: show survey activity info
Michael Hawkins [Mon, 22 Mar 2021 09:45:50 +0000 (17:45 +0800)]
MDL-71161 mod_scorm: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 10:44:34 +0000 (18:44 +0800)]
MDL-71161 mod_resource: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 10:58:00 +0000 (18:58 +0800)]
MDL-71161 mod_quiz: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 03:52:34 +0000 (11:52 +0800)]
MDL-71161 mod_page: Display activity completion information
Michael Hawkins [Wed, 10 Mar 2021 11:18:54 +0000 (19:18 +0800)]
MDL-71161 mod_lti: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 11:05:17 +0000 (19:05 +0800)]
MDL-71161 mod_lesson: Display activity completion information
Jun Pataleta [Thu, 25 Mar 2021 08:36:00 +0000 (16:36 +0800)]
MDL-71161 mod_imscp: Display activity information output component
Jun Pataleta [Thu, 25 Mar 2021 08:35:46 +0000 (16:35 +0800)]
MDL-71161 mod_h5pactivity: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 08:37:24 +0000 (16:37 +0800)]
MDL-71161 mod_glossary: show glossary activity info
Simey Lameze [Thu, 11 Mar 2021 08:09:32 +0000 (16:09 +0800)]
MDL-71161 mod_forum: show forum activity info
Jun Pataleta [Thu, 25 Mar 2021 08:34:41 +0000 (16:34 +0800)]
MDL-71161 mod_folder: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 08:45:04 +0000 (16:45 +0800)]
MDL-71161 mod_feedback: show feedback activity info
Simey Lameze [Mon, 29 Mar 2021 02:37:01 +0000 (10:37 +0800)]
MDL-71161 mod_data: show database activity info
Jun Pataleta [Thu, 25 Mar 2021 08:34:23 +0000 (16:34 +0800)]
MDL-71161 mod_chat: Display activity information output component
Jun Pataleta [Thu, 25 Mar 2021 08:34:11 +0000 (16:34 +0800)]
MDL-71161 mod_book: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 11:05:23 +0000 (19:05 +0800)]
MDL-71161 mod_assign: show assign activity info
Jun Pataleta [Mon, 12 Apr 2021 16:33:54 +0000 (00:33 +0800)]
MDL-70821 core_completion: Fix completion settings Behat tests
Jun Pataleta [Mon, 12 Apr 2021 13:15:46 +0000 (21:15 +0800)]
MDL-70821 course: Render activity information only when necessary
Render the activity information output component in the course homepage
only if either completion details or activity dates are to be displayed.
This can help reduce the number of files being included when loading the
course homepage (e.g. the activity information template for each
activity in the course homepage).
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 17:20:38 +0000 (18:20 +0100)]
MDL-71011 adodb: Update readme and thirdpartylibs
Small changes in readme and document the bump in xml
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 17:16:07 +0000 (18:16 +0100)]
MDL-71011 php80: final private makes no sense, throwing warning
Ref: https://php.watch/versions/8.0/final-private-function#final-private
This applies #712 from upstream libraries.
Unrelated: I've also changed a occurrence of "private final"
by the correct (PSR-12) "final private" in the constructor
(the final&private combination is allowed in constructors)
in lib/classes/event/base.php, because it's the unique case
in core and phpcs was really insisting.
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 16:56:57 +0000 (17:56 +0100)]
MDL-71011 adodb: Bump to v5.21.0
Following the instructions @ readme_moodle.txt
Eloy Lafuente (stronk7) [Mon, 12 Apr 2021 15:32:24 +0000 (17:32 +0200)]
Merge branch 'MDL-71064' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 12 Apr 2021 15:24:33 +0000 (17:24 +0200)]
Merge branch 'MDL-68716' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 12 Apr 2021 14:40:04 +0000 (16:40 +0200)]
Merge branch 'MDL-71264' of https://github.com/stronk7/moodle
Sara Arjona [Mon, 12 Apr 2021 14:01:29 +0000 (16:01 +0200)]
Merge branch 'MDL-70595-master' of git://github.com/mickhawkins/moodle
Sara Arjona [Mon, 12 Apr 2021 10:41:03 +0000 (12:41 +0200)]
Merge branch 'MDL-71107-master' of git://github.com/aanabit/moodle
Anupama Sarjoshi [Mon, 22 Mar 2021 16:07:33 +0000 (16:07 +0000)]
MDL-71172 quiz: Improve quiz Behat tests
Juan Leyva [Mon, 16 Nov 2020 15:01:40 +0000 (16:01 +0100)]
MDL-65983 airnotifier: Configuration check report
Jake Dallimore [Mon, 12 Apr 2021 06:48:28 +0000 (14:48 +0800)]
Merge branch 'MDL-71251-master' of git://github.com/jleyva/moodle
Adrian Greeve [Mon, 12 Apr 2021 06:45:59 +0000 (14:45 +0800)]
Merge branch 'MDL-70821-master-5' of git://github.com/junpataleta/moodle
Jun Pataleta [Sat, 27 Mar 2021 05:21:53 +0000 (13:21 +0800)]
MDL-70821 course: Activity information fixes
* Make sure the activity is visible to the user (cm_info::uservisible)
before showing the activity completion information.
* Add to-do status for overridden automatic completion
Jun Pataleta [Sat, 27 Mar 2021 04:42:51 +0000 (12:42 +0800)]
MDL-70821 course: Check activity dates on course homepage
* Check the activity dates on the course homepage depending on
the value of the showactivitydates course setting
* Plus use the new Behat steps for checking activity dates
Jun Pataleta [Sat, 27 Mar 2021 04:41:37 +0000 (12:41 +0800)]
MDL-70821 course: New Behat steps for activity dates
* activity_date_in_activity_should_contain_text()
- Checks the presence of the given text in the activity's date info.
* activity_dates_information_in_activity_should_exist()
- Checks the presence of activity dates information in the activity
information output component.
* activity_dates_information_in_activity_should_not_exist()
- Checks the absence of activity dates information in the activity
information output component.
Jun Pataleta [Fri, 26 Mar 2021 09:50:41 +0000 (17:50 +0800)]
MDL-70821 behat: Use new activity completion steps for Behat tests
Replace usages of completion Behat steps that check for the completion
checkboxes with the new activity completion Behat steps.
Jun Pataleta [Fri, 26 Mar 2021 09:49:34 +0000 (17:49 +0800)]
MDL-70821 completion: New Behat steps for activity completion
* activity_completion_condition_displayed_as()
- Shows the status of an automatic completion condition for a given
activity
* activity_should_have_the_completion_condition()
- Checks that the activity displays the given completion condition
* manual_completion_button_displayed_as()
- Shows the status of the manual completion button for a given
activity
* the_manual_completion_button_for_activity_should_be_disabled()
- Checks that the manual completion button for the given activity is
disabled.
* there_should_be_no_completion_for_activity()
- Checks that the activity does not show completion information
* toggle_the_manual_completion_state()
- Toggles the manual completion button's state for a given activity
* overridden_manual_completion_button_displayed_as()
- Checks the manual completion state of an activity.
* overridden_activity_completion_condition_displayed_as()
- Checks if the activity with specified name is maked as complete.
Jun Pataleta [Wed, 24 Mar 2021 15:05:38 +0000 (23:05 +0800)]
MDL-70821 course: activity_information template changes
* Add activity name for completion conditions labels. This would give
better information to screen reader users the activity that the list
of automatic completion conditions belong to. This would be useful
especially when the completion conditions are displayed on the course
homepage.
* Add data-region attributes to activity dates and completion
information divs.
* Reorganise activity dates and completion information divs so they
are only rendered when they have data to show.
Jun Pataleta [Wed, 24 Mar 2021 05:10:27 +0000 (13:10 +0800)]
MDL-70821 course: Remove old manual completion toggling
Remove the old ways of toggling manual completion via completion.js
and the ajax part of togglecompletion.php.
Jun Pataleta [Wed, 24 Mar 2021 03:24:02 +0000 (11:24 +0800)]
MDL-70821 course: Deprecate course_section_cm_completion()
Deprecate \core_course_renderer::course_section_cm_completion(). It is
not being used anymore and is being replaced by
\core_renderer::activity_information().
Jun Pataleta [Tue, 23 Mar 2021 12:18:38 +0000 (20:18 +0800)]
MDL-70821 course: Cover availability conditions for manual completion
When an activity has manual completion tracking, pressing the manual
completion checkbox reloads the page after toggling the completion
state when the activity is linked to availability conditions.
The "Mark as done" button needs to mimic this behaviour as well.
The approach being taken here is to add a core_course/view JS module
for the course homepage which listens for the manualCompletionToggled
event and reloads the page when the activity module has availability
conditions tied to it.
Perhaps for future development, instead of reloading the page, the
container of the restricted course sections/activities can reloaded via
AJAX as well.
Jun Pataleta [Tue, 23 Mar 2021 12:13:22 +0000 (20:13 +0800)]
MDL-70821 course: Create manualCompletionToggled event
Add a new "manualCompletionToggled" course event and dispatch this
when the manual completion state for an activity is toggled.
Jun Pataleta [Mon, 22 Mar 2021 15:13:10 +0000 (23:13 +0800)]
MDL-70821 course: Remove unused completion info from cm_format
With the activity information output component dealing with the
completion information of the activity, there's no need to pass
completion info to the cm_format renderable.
Jun Pataleta [Fri, 12 Mar 2021 09:59:18 +0000 (17:59 +0800)]
MDL-70821 course: Render activity information output component in course
Use the activity information output component to render activity
completion details and activity dates for activities on the course
homepage.
Includes fixup from Shamim Rezaie <shamim@moodle.com>
Eloy Lafuente (stronk7) [Sun, 11 Apr 2021 21:52:41 +0000 (23:52 +0200)]
Merge branch 'MDL-69102-master' of https://github.com/martygilbert/moodle
Eloy Lafuente (stronk7) [Thu, 8 Apr 2021 17:19:09 +0000 (19:19 +0200)]
MDL-69102 phpunit: Add test to cover ALL cohort criteria
That way we can check that the expectations are
working ok for every database. Previously only the
ANY case was being tested.
Also, convert them to course badges and check, via
review_all_criteria() that the SQL structures returned
by award_criteria_cohort->get_completed_criteria_sql()
doesn't fail and return the expected counters.
Marty Gilbert [Tue, 23 Jun 2020 12:27:40 +0000 (08:27 -0400)]
MDL-69102 badge: Fixes broken WHERE clause
When buildilng the 'WHERE' clause, the SQL generated
a query that selected any user who was a member of the
**last** group, not all of the groups.
I believe the query has to be re-worked so that it only
returns users who are in ALL of the groups. This can
be done by a GROUP BY and HAVING.
Juan Leyva [Fri, 9 Apr 2021 13:30:32 +0000 (15:30 +0200)]
MDL-71251 qtype_essay: Return new min/max word limit settings via WS
Those settings are required by external clients such as the Moodle App
Dan Marsden [Fri, 9 Apr 2021 09:43:27 +0000 (21:43 +1200)]
MDL-32226 plagiarism: add span around links.
Make it easier for Mobile app to parse.
AMOS bot [Fri, 9 Apr 2021 00:07:57 +0000 (00:07 +0000)]
Automatically generated installer lang files
Víctor Déniz [Thu, 8 Apr 2021 23:54:18 +0000 (00:54 +0100)]
Merge branch 'MDL-70769-master' of https://github.com/sharidas/moodle
Eloy Lafuente (stronk7) [Thu, 8 Apr 2021 16:30:13 +0000 (18:30 +0200)]
Merge branch 'MDL-70802-master' of git://github.com/andrewnicols/moodle
Sara Arjona [Thu, 8 Apr 2021 15:45:41 +0000 (17:45 +0200)]
Merge branch 'MDL-65616' of git://github.com/paulholden/moodle
Eloy Lafuente (stronk7) [Thu, 8 Apr 2021 15:30:12 +0000 (17:30 +0200)]
Merge branch 'master_MDL-32226' of https://github.com/danmarsden/moodle
Víctor Déniz [Thu, 8 Apr 2021 00:01:15 +0000 (01:01 +0100)]
Merge branch 'MDL-71116-master' of git://github.com/sarjona/moodle
Víctor Déniz [Wed, 7 Apr 2021 15:09:15 +0000 (16:09 +0100)]
Merge branch 'MDL-71178-master' of git://github.com/junpataleta/moodle
Amaia Anabitarte [Tue, 16 Mar 2021 12:18:10 +0000 (13:18 +0100)]
MDL-71107 core_contentbank: Behat test. Authoring when copying a course