Sara Arjona [Wed, 28 Apr 2021 11:06:07 +0000 (13:06 +0200)]
Merge branch 'MDL-70979' of git://github.com/paulholden/moodle
Sara Arjona [Wed, 28 Apr 2021 10:58:15 +0000 (12:58 +0200)]
Merge branch 'MDL-71127' of git://github.com/paulholden/moodle
Sara Arjona [Wed, 28 Apr 2021 10:36:23 +0000 (12:36 +0200)]
Merge branch 'MDL-70763' of git://github.com/paulholden/moodle
Sara Arjona [Wed, 28 Apr 2021 07:17:28 +0000 (09:17 +0200)]
Merge branch 'MDL-71244-master' of git://github.com/lucaboesch/moodle
Jun Pataleta [Wed, 28 Apr 2021 05:41:57 +0000 (13:41 +0800)]
Merge branch 'MDL-71330-master' of https://github.com/dcai/moodle
Dongsheng Cai [Tue, 20 Apr 2021 04:29:22 +0000 (14:29 +1000)]
MDL-71330 mod_chat: Implement the activity dates functionality
Andrew Nicols [Wed, 28 Apr 2021 02:48:02 +0000 (10:48 +0800)]
Merge branch 'MDL-71168' of git://github.com/paulholden/moodle
Andrew Nicols [Wed, 28 Apr 2021 02:45:08 +0000 (10:45 +0800)]
Merge branch 'MDL-70372-master-oldstrings' of git://github.com/mudrd8mz/moodle
Andrew Nicols [Wed, 28 Apr 2021 02:25:36 +0000 (10:25 +0800)]
MDL-70909 mod_h5pactivity: Whitespace fix
Andrew Nicols [Wed, 28 Apr 2021 02:20:03 +0000 (10:20 +0800)]
Merge branch 'MDL-70909-master' of git://github.com/ferranrecio/moodle
Andrew Nicols [Wed, 28 Apr 2021 02:05:28 +0000 (10:05 +0800)]
Merge branch 'MDL-71386-master' of git://github.com/NoelDeMartin/moodle
Andrew Nicols [Wed, 28 Apr 2021 01:14:48 +0000 (09:14 +0800)]
Merge branch 'MDL-71389-master' of git://github.com/marinaglancy/moodle
Luca Bösch [Tue, 30 Mar 2021 14:49:17 +0000 (16:49 +0200)]
MDL-71244 enrol_manual: Add bootstrap classes to buttons
Sara Arjona [Tue, 27 Apr 2021 14:01:55 +0000 (16:01 +0200)]
Merge branch 'MDL-71403' of git://github.com/paulholden/moodle
Ferran Recio [Tue, 16 Feb 2021 16:09:31 +0000 (17:09 +0100)]
MDL-70909 mod_h5pactivity: fix reports on freeze context
Sara Arjona [Tue, 27 Apr 2021 13:14:50 +0000 (15:14 +0200)]
weekly release 4.0dev
Sara Arjona [Tue, 27 Apr 2021 13:14:48 +0000 (15:14 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Jun Pataleta [Tue, 27 Apr 2021 04:36:24 +0000 (12:36 +0800)]
Merge branch 'MDL-71410-master' of git://github.com/rezaies/moodle
Shamim Rezaie [Sun, 18 Apr 2021 21:19:10 +0000 (07:19 +1000)]
MDL-71410 core: Prevent recursively calling getters
Shamim Rezaie [Sun, 7 Mar 2021 15:52:04 +0000 (02:52 +1100)]
MDL-71410 mod_quiz: implement activity_dates for the quiz module
Shamim Rezaie [Wed, 14 Apr 2021 22:08:36 +0000 (08:08 +1000)]
MDL-71410 mod_quiz: Cache quiz times in modinfo for performance
We update the dates with user/group overrides. The calculation of
the override in the quiz module is different from the assignment
module as the quiz_overrides table des not have a sortorder column.
See quiz_update_effective_access().
Shamim Rezaie [Sun, 25 Apr 2021 16:44:25 +0000 (02:44 +1000)]
MDL-71410 mod_quiz: Cache user and group overrides
Shamim Rezaie [Fri, 5 Mar 2021 12:37:23 +0000 (23:37 +1100)]
MDL-71410 mod_lesson: implement activity_dates for the lesson module
Shamim Rezaie [Fri, 5 Mar 2021 11:29:12 +0000 (22:29 +1100)]
MDL-71410 mod_lesson: Cache lesson times in modinfo for performance
We update the dates with user/group overrides. The calculation of
the override in the lesson module is different from the assignment
module as the lesson_overrides table des not have a sortorder column.
See lesson::update_effective_access().
Shamim Rezaie [Sat, 24 Apr 2021 18:19:24 +0000 (04:19 +1000)]
MDL-71410 mod_lesson: Cache user and group overrides
Shamim Rezaie [Thu, 25 Feb 2021 07:56:58 +0000 (18:56 +1100)]
MDL-71410 mod_assign: implement activity_dates for the assignment module
Shamim Rezaie [Wed, 14 Apr 2021 19:55:09 +0000 (05:55 +1000)]
MDL-71410 mod_assign: Cache assign times in modinfo for performance
We update the dates with user/group overrides
Shamim Rezaie [Fri, 23 Apr 2021 11:07:39 +0000 (21:07 +1000)]
MDL-71410 mod_assign: Cache user and group overrides
Jun Pataleta [Tue, 27 Apr 2021 02:41:03 +0000 (10:41 +0800)]
Merge branch 'MDL-71252-master' of git://github.com/HuongNV13/moodle
Huong Nguyen [Tue, 27 Apr 2021 01:42:37 +0000 (08:42 +0700)]
MDL-71252 completion: PHPUnit failure
Adrian Greeve [Tue, 27 Apr 2021 01:36:56 +0000 (09:36 +0800)]
Merge branch 'MDL-71329' of https://github.com/Chocolate-lightning/moodle
Víctor Déniz [Mon, 26 Apr 2021 23:51:43 +0000 (00:51 +0100)]
Merge branch 'MDL-65687' of git://github.com/paulholden/moodle
Víctor Déniz [Mon, 26 Apr 2021 23:38:11 +0000 (00:38 +0100)]
Merge branch 'MDL-71003' of git://github.com/paulholden/moodle
Víctor Déniz [Mon, 26 Apr 2021 22:50:22 +0000 (23:50 +0100)]
Merge branch 'MDL-71441-master' of git://github.com/bmbrands/moodle
Sara Arjona [Mon, 26 Apr 2021 13:17:59 +0000 (15:17 +0200)]
Merge branch 'MDL-70917' of git://github.com/paulholden/moodle
Bas Brands [Mon, 26 Apr 2021 09:59:55 +0000 (11:59 +0200)]
MDL-71441 core_user: add profilefield social to standard plugins list
Jun Pataleta [Mon, 26 Apr 2021 11:51:11 +0000 (19:51 +0800)]
MDL-71252 completion: Fix Behat test for manual completion display
Adjusting the test since the manual completion button is now being
hidden from the course homepage when completion is disabled.
Sara Arjona [Mon, 26 Apr 2021 10:35:34 +0000 (12:35 +0200)]
Merge branch 'MDL-71416' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 26 Apr 2021 09:52:46 +0000 (11:52 +0200)]
Merge branch 'MDL-71392' of git://github.com/paulholden/moodle
Jun Pataleta [Mon, 26 Apr 2021 09:02:46 +0000 (17:02 +0800)]
Merge branch 'MDL-71252-master' of git://github.com/HuongNV13/moodle
Huong Nguyen [Mon, 26 Apr 2021 08:48:17 +0000 (15:48 +0700)]
MDL-71252 completion: Behat failure
Eloy Lafuente (stronk7) [Mon, 26 Apr 2021 08:44:59 +0000 (10:44 +0200)]
Merge branch 'MDL-70446-master' of https://github.com/sammarshallou/moodle
Jun Pataleta [Mon, 26 Apr 2021 07:55:11 +0000 (15:55 +0800)]
Merge branch 'MDL-71252-master' of git://github.com/HuongNV13/moodle
Sara Arjona [Mon, 26 Apr 2021 07:50:40 +0000 (09:50 +0200)]
Merge branch 'MDL-71370-master-test' of git://github.com/junpataleta/moodle
Huong Nguyen [Wed, 21 Apr 2021 07:32:40 +0000 (14:32 +0700)]
MDL-71252 completion: Avoid showing the 'Mark as done' button
The following activites will be applied:
- Label
- File (Force download/Open/In pop-up)
- URL (Open/In pop-up)
Shamim Rezaie [Wed, 14 Apr 2021 19:27:00 +0000 (05:27 +1000)]
MDL-71410 core: Introduce override_customdata()
The get_custom_data() method now calls obtain_dynamic_data() because
$this->customdata can be dynamic now.
Paul Holden [Fri, 23 Apr 2021 20:43:11 +0000 (21:43 +0100)]
MDL-71403 message: Bootstrap controls for message preferences.
Replicates changes made to notification preferences in
e41b3485.
The templates for each are similar enough than one can be used
from the other. Remove redundant styles for previous controls.
Jun Pataleta [Thu, 22 Apr 2021 14:41:03 +0000 (22:41 +0800)]
MDL-71370 course: Make showcompletionconditions nullable
* When completion tracking is not enabled for the course, it does not
make sense for the course's showcompletionconditions setting to
be set according to the default value indicated by the
"moodlecourse | showcompletionconditions" admin setting. Setting
showcompletionconditions as enabled when completion tracking is disabled
makes even less sense. So in such a case, we should not be setting a
default value for showcompletionconditions and allow it to be null.
* When the course is edited and completion tracking is enabled, this
also would set the "Show completion conditions" field to default to the
value set in the "moodlecourse | showcompletionconditions" admin
setting.
AMOS bot [Sat, 24 Apr 2021 00:07:56 +0000 (00:07 +0000)]
Automatically generated installer lang files
Paul Holden [Fri, 23 Apr 2021 11:47:55 +0000 (12:47 +0100)]
MDL-71416 report_log: user context header should show users name.
Co-Authored-By: Luca Bösch <luca.boesch@bfh.ch>
Sara Arjona [Fri, 23 Apr 2021 11:16:01 +0000 (13:16 +0200)]
Merge branch 'MDL-71144-master' of git://github.com/rezaies/moodle
Sara Arjona [Fri, 23 Apr 2021 08:46:53 +0000 (10:46 +0200)]
weekly release 4.0dev
Sara Arjona [Fri, 23 Apr 2021 08:46:51 +0000 (10:46 +0200)]
NOBUG: Fixed SVG browser compatibility
Mathew May [Tue, 20 Apr 2021 07:47:41 +0000 (15:47 +0800)]
MDL-71329 tool_moodlenet: Check to see if we get errors before curl
Jun Pataleta [Fri, 23 Apr 2021 04:41:15 +0000 (12:41 +0800)]
Merge branch 'MDL-71171_master' of git://github.com/mdjnelson/moodle
Mark Nelson [Mon, 22 Mar 2021 14:55:20 +0000 (22:55 +0800)]
MDL-71171 customfield_text: ensure we set defaults properly
abgreeve [Fri, 23 Apr 2021 04:19:51 +0000 (12:19 +0800)]
Merge branch 'MDL-70818-master-4' of git://github.com/rezaies/moodle
Andrew Nicols [Fri, 23 Apr 2021 03:56:47 +0000 (11:56 +0800)]
Merge branch 'MDL-70903-master' of git://github.com/roland04/moodle
Andrew Nicols [Fri, 23 Apr 2021 03:52:21 +0000 (11:52 +0800)]
Merge branch 'master-MDL-71376' of https://github.com/rjnl/moodle
Shamim Rezaie [Mon, 8 Mar 2021 04:32:31 +0000 (15:32 +1100)]
MDL-70818 mod_workshop: implement activity_dates for the workshop module
Shamim Rezaie [Mon, 8 Mar 2021 04:15:24 +0000 (15:15 +1100)]
MDL-70818 mod_workshop: cache workshop times in modinfo for performance
Shamim Rezaie [Sun, 7 Mar 2021 16:33:13 +0000 (03:33 +1100)]
MDL-70818 mod_scorm: implement activity_dates for the scorm module
Shamim Rezaie [Fri, 26 Feb 2021 10:36:36 +0000 (21:36 +1100)]
MDL-70818 mod_forum: implement activity_dates for the forum module
Shamim Rezaie [Fri, 26 Feb 2021 09:53:44 +0000 (20:53 +1100)]
MDL-70818 mod_forum: cache forum times in modinfo for performance
Shamim Rezaie [Fri, 26 Feb 2021 05:06:58 +0000 (16:06 +1100)]
MDL-70818 mod_feedback: implement activity_dates for the feedback module
Shamim Rezaie [Thu, 25 Feb 2021 15:51:46 +0000 (02:51 +1100)]
MDL-70818 mod_data: implement activity_dates for the database module
Andrew Nicols [Fri, 23 Apr 2021 03:42:00 +0000 (11:42 +0800)]
Merge branch 'MDL-71394-master' of git://github.com/marinaglancy/moodle
Andrew Nicols [Fri, 23 Apr 2021 03:26:53 +0000 (11:26 +0800)]
Merge branch 'MDL-70970' of git://github.com/paulholden/moodle
Andrew Nicols [Fri, 23 Apr 2021 03:12:15 +0000 (11:12 +0800)]
Merge branch 'MDL-70902-master' of git://github.com/dravek/moodle
Sara Arjona [Thu, 22 Apr 2021 16:13:04 +0000 (18:13 +0200)]
Merge branch 'MDL-57831' of git://github.com/paulholden/moodle
Paul Holden [Thu, 22 Apr 2021 15:11:02 +0000 (16:11 +0100)]
MDL-57831 tool_monitor: update Behat tests for message preferences.
Ferran Recio [Mon, 19 Apr 2021 10:01:36 +0000 (12:01 +0200)]
MDL-70909 behat: context freeze and not freeze steps
Sara Arjona [Thu, 22 Apr 2021 11:56:37 +0000 (13:56 +0200)]
Merge branch 'MDL-71136_master' of https://github.com/TomoTsuyuki/moodle
Ferran Recio [Tue, 16 Feb 2021 16:08:51 +0000 (17:08 +0100)]
MDL-70909 core: add cannotmatchanyrows to capabilities join
Sara Arjona [Thu, 22 Apr 2021 11:16:23 +0000 (13:16 +0200)]
Merge branch 'MDL-71400-master' of git://github.com/mihailges/moodle
Shamim Rezaie [Tue, 30 Mar 2021 16:28:49 +0000 (03:28 +1100)]
MDL-71144 mod_scorm: Deprecate scorm_get_completion_state()
Shamim Rezaie [Tue, 30 Mar 2021 16:02:50 +0000 (03:02 +1100)]
MDL-71144 mod_quiz: custom_completion should not use deprecated function
This commit also removes an unnecessary DB query.
Shamim Rezaie [Tue, 30 Mar 2021 14:06:11 +0000 (01:06 +1100)]
MDL-71144 mod_quiz: Deprecate quiz_get_completion_state()
Jun Pataleta [Thu, 22 Apr 2021 10:55:28 +0000 (18:55 +0800)]
Merge branch 'MDL-71170_master' of git://github.com/mdjnelson/moodle
Noel De Martin [Tue, 20 Apr 2021 15:26:27 +0000 (17:26 +0200)]
MDL-71386 behat: Support for 3.9.5+ mobile app
Paul Holden [Mon, 22 Feb 2021 20:02:40 +0000 (20:02 +0000)]
MDL-70979 search: validate external user search parameters.
Clean return value in unit test for same.
Paul Holden [Wed, 21 Apr 2021 21:17:48 +0000 (22:17 +0100)]
MDL-71392 mod_quiz: don't display grade to pass if not set.
Mihail Geshoski [Thu, 22 Apr 2021 04:21:04 +0000 (12:21 +0800)]
MDL-71400 assignfeedback_offline: Fix message after worksheet upload
Jun Pataleta [Thu, 22 Apr 2021 03:51:59 +0000 (11:51 +0800)]
Merge branch 'MDL-71156-master' of git://github.com/lameze/moodle
Andrew Nicols [Thu, 22 Apr 2021 03:11:40 +0000 (11:11 +0800)]
Merge branch 'MDL-69460' of https://github.com/paulholden/moodle
Jun Pataleta [Thu, 22 Apr 2021 02:29:25 +0000 (10:29 +0800)]
Merge branch 'MDL-71288-master' of git://github.com/lameze/moodle
Simey Lameze [Fri, 16 Apr 2021 03:42:33 +0000 (11:42 +0800)]
MDL-71156 core: machinery to recover orphaned calendar events
The machinery to fix orphaned calendar events that were broken by MDL-67494.
The solution consists of:
1) Upgrade step that checks if this site has executed the problematic upgrade steps and
if positive, it will schedule a new run for calendar_fix_orphaned_events adhoc task.
2) Adhoc task that will self-spawn calling the recovery machinery, running until
all the orphaned calendar events are fixed. It also sets the maximum runtime of
60 seconds. It is also possible to override that number by specifing the desired
number setting the ->calendareventsmaxseconds in your config.php
3) CLI script that will look for all the calendar events which userids
where broken by a wrong upgrade step, affecting to Moodle 3.9.5
and up.
It performs checks to both:
a) Detect if the site was affected (ran the wrong upgrade step).
b) Look for orphaned calendar events, categorising them as:
- standard: site / category / course / group / user events
- subscription: events created via subscriptions.
- action: normal action events, created to show common important dates.
- override: user and group override events, particular, that some activities support.
- custom: other events, not being any of the above, common or particular.
By specifying it (--fix) try to recover as many broken events (missing userid) as
possible. Standard, subscription, action, override events in core are fully supported but
override or custom events should be fixed by each plugin as far as there isn't any standard
API (plugin-wise) to launch a rebuild of the calendar events.
4) Unit tests and helper functions to generate calendar events. We have decided to
keep the tests simple, testing only true and false and not using data generators because
the code is purely to recover the calendar events and won't turn into an API or something
and also due to the urgency of this issue.
The helpers have been created in calendar/tests/helpers.php since there are no data generators
for calendar.
Andrew Nicols [Thu, 22 Apr 2021 02:10:38 +0000 (10:10 +0800)]
Merge branch 'MDL-70412-master' of git://github.com/aanabit/moodle
Simey Lameze [Mon, 19 Apr 2021 09:11:02 +0000 (17:11 +0800)]
MDL-71288 completion: add fallback for plugins
This commits adds a fallback for plugins which does not have
custom_completion implementation.
For those cases, it will search for {modulename}_get_completion_state
callback in the plugin and call get_overall_completion() method in
cm_completion_details class to get the overall completion state for
a course module and user.
abgreeve [Thu, 22 Apr 2021 01:38:50 +0000 (09:38 +0800)]
Merge branch 'MDL-28452-master' of git://github.com/bmbrands/moodle
Shamim Rezaie [Tue, 30 Mar 2021 13:41:55 +0000 (00:41 +1100)]
MDL-71144 mod_lesson: Deprecate lesson_get_completion_state()
Shamim Rezaie [Tue, 30 Mar 2021 13:33:22 +0000 (00:33 +1100)]
MDL-71144 mod_survey: Deprecate survey_get_completion_state()
Shamim Rezaie [Tue, 30 Mar 2021 13:02:46 +0000 (00:02 +1100)]
MDL-71144 mod_glossary: Deprecate glossary_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:56:10 +0000 (09:56 +0800)]
MDL-71144 mod_forum: Deprecate forum_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:55:48 +0000 (09:55 +0800)]
MDL-71144 mod_feedback: Deprecate feedback_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:53:19 +0000 (09:53 +0800)]
MDL-71144 mod_data: Deprecate data_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:52:59 +0000 (09:52 +0800)]
MDL-71144 mod_choice: Deprecate choice_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:52:26 +0000 (09:52 +0800)]
MDL-71144 mod_assign: Deprecate assign_get_completion_state()
Jun Pataleta [Tue, 30 Mar 2021 01:51:31 +0000 (09:51 +0800)]
MDL-71144 completion: Deprecate get_completion_state callbacks
* *_get_completion_state() callback functions have been deprecated and
should no longer be used. Plugins that define custom completion rules
must implement the mod_[modname]\completion\custom_completion class that
extends the \core_completion\activity_custom_completion base class.
Paul Holden [Wed, 21 Apr 2021 20:46:29 +0000 (21:46 +0100)]
MDL-57831 theme_boost: accessibility update for message preferences.
The preferences table did not meet accessibility guidelines regarding
colour contrast between hovered rows and the disabled switch
elements.
Ensure white background is used for all table cells, and replace the
highlighted columns used to differentiate processors with borders.