Eloy Lafuente (stronk7) [Sun, 18 Apr 2021 21:43:13 +0000 (23:43 +0200)]
MDL-71367 unit tests: Add missing ->destroy() call to test backups
As part of the tests preparations, some backups are created, but
the tests aren't calling to their ->destroy() method at the end.
The destroy() method is needed to go cleaning and unsetting various
objects that, only then, will free resources, like memory, open files...
This isn't critical under Unix OSs... but Windows is really sensible
and keeps all open files locked, so any write operation on them fails.
Sara Arjona [Fri, 16 Apr 2021 15:03:25 +0000 (17:03 +0200)]
weekly release 4.0dev
Sara Arjona [Fri, 16 Apr 2021 15:03:22 +0000 (17:03 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Eloy Lafuente (stronk7) [Fri, 16 Apr 2021 11:04:51 +0000 (13:04 +0200)]
Merge branch 'MDL-69331-fix' of github.com:sarjona/moodle
Sara Arjona [Fri, 16 Apr 2021 08:52:13 +0000 (10:52 +0200)]
MDL-69331 core_h5p: fix behat errors
Andrew Nicols [Fri, 16 Apr 2021 04:08:29 +0000 (12:08 +0800)]
Merge branch 'master_MDL-71233' of https://github.com/golenkovm/moodle
Jun Pataleta [Fri, 16 Apr 2021 04:02:13 +0000 (12:02 +0800)]
Merge branch 'MDL-48594-master' of https://github.com/nguyenphuctien/moodle
Andrew Nicols [Fri, 16 Apr 2021 03:53:15 +0000 (11:53 +0800)]
Merge branch 'MDL-60490-missing_close_div' of https://github.com/leonstr/moodle
Andrew Nicols [Fri, 16 Apr 2021 03:25:55 +0000 (11:25 +0800)]
Merge branch 'MDL-69415-master' of git://github.com/sarjona/moodle
Jake Dallimore [Fri, 16 Apr 2021 02:16:16 +0000 (10:16 +0800)]
Merge branch 'master' of git://github.com/paulphillip5/moodle
Jake Dallimore [Fri, 16 Apr 2021 01:19:57 +0000 (09:19 +0800)]
Merge branch 'MDL-71342-master-2' of git://github.com/junpataleta/moodle
Andrew Nicols [Fri, 16 Apr 2021 00:18:39 +0000 (08:18 +0800)]
Merge branch 'master_MDL-71254' of https://github.com/golenkovm/moodle
Andrew Nicols [Thu, 15 Apr 2021 23:52:35 +0000 (07:52 +0800)]
Merge branch 'MDL-71186-master' of https://github.com/clransom/moodle
Víctor Déniz [Thu, 15 Apr 2021 14:15:38 +0000 (15:15 +0100)]
Merge branch 'MDL-69331-master' of git://github.com/sarjona/moodle
Sara Arjona [Thu, 15 Apr 2021 13:36:31 +0000 (15:36 +0200)]
Merge branch 'MDL-70269' of https://github.com/timhunt/moodle
Tien Nguyen [Fri, 2 Apr 2021 05:06:18 +0000 (12:06 +0700)]
MDL-48594 Report: More filtering options on Activity Completion Report
Jun Pataleta [Thu, 15 Apr 2021 15:10:03 +0000 (23:10 +0800)]
MDL-71342 mod: Conditionally display activity info
* The activity information output component is still being displayed
even in the case when the activity does not have dates to show and
completion tracking is not enabled.
This also causes a horizontal line to be rendered in activity view pages
below the activity heading which does not serve much purpose when
there's no activity information to be shown.
The activity information output component should only be displayed
if there's completion information to show or if there are activty dates
to show. Otherwise, there's no need to render it.
Katie Ransom [Mon, 29 Mar 2021 08:38:50 +0000 (09:38 +0100)]
MDL-71186 core_user: show custom user fields in group management screens
Sara Arjona [Thu, 15 Apr 2021 09:56:40 +0000 (11:56 +0200)]
Merge branch 'MDL-71090' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 1 Mar 2021 10:41:26 +0000 (11:41 +0100)]
MDL-69331 core_h5p: Add missing @core_h5p tag
Sara Arjona [Mon, 1 Mar 2021 10:48:55 +0000 (11:48 +0100)]
MDL-69331 core_h5p: Add missing library files to behat tests
Some of the pre-existing behat tests were creating content into the
content bank using the generator but the H5P content-type libraries
weren't uploaded.
Since MDL-69331, libraries need to be deployed previously (so fake
H5P content-type won't be displayed if these libraries don't exist).
Sara Arjona [Thu, 25 Feb 2021 16:21:32 +0000 (17:21 +0100)]
MDL-69331 core_contentbank: Hide disabled H5P content-types
If a H5P content-type is disabled:
- The content bank won't display existing contents having it as a
main library.
- The content bank won't allow to create new contents using it.
Sara Arjona [Thu, 25 Feb 2021 15:21:51 +0000 (16:21 +0100)]
MDL-69331 core_h5p: Only upgrade enabled libraries
The core\task\h5p_get_content_types_task task will only download
content-type for enabled libraries.
Sara Arjona [Thu, 25 Feb 2021 14:02:23 +0000 (15:02 +0100)]
MDL-69331 core_h5p: Display error when main library is disabled
H5P contents with the main library disabled won't be deployed; a
message error will be displayed instead of.
Sara Arjona [Wed, 24 Feb 2021 15:11:12 +0000 (16:11 +0100)]
MDL-69331 core_h5p: Add enabled field to libraries
The "enabled" field has been added to the H5P libraries to let
admins decide whether a library should be used or not in the site.
Jake Dallimore [Thu, 15 Apr 2021 06:42:10 +0000 (14:42 +0800)]
Merge branch 'MDL-71338' of git://github.com/paulholden/moodle
Sara Arjona [Thu, 15 Apr 2021 06:30:08 +0000 (08:30 +0200)]
Merge branch 'MDL-71337-master' of git://github.com/junpataleta/moodle
Jake Dallimore [Thu, 15 Apr 2021 06:16:04 +0000 (14:16 +0800)]
Merge branch 'MDL-61768-master-3' of git://github.com/mihailges/moodle
abgreeve [Thu, 15 Apr 2021 05:48:39 +0000 (13:48 +0800)]
Merge branch 'MDL-71007-courseidnumer-grade-ws' of https://github.com/brendanheywood/moodle
Jun Pataleta [Thu, 15 Apr 2021 04:43:27 +0000 (12:43 +0800)]
MDL-71337 mod_h5pactivity: Increase window size during test
The addition of the activity information moves the h5p content down
out of the window view on Firefox which causes the Check button to be
unclickable. This patch increases the window size to ensure that the
check button is visible and clickable.
Credits to Eloy <stronk7@moodle.org> for the thorough investigation
of the root cause of this issue :)
Mihail Geshoski [Thu, 18 Mar 2021 06:03:20 +0000 (14:03 +0800)]
MDL-61768 repository_googledocs: Deprecate unused methods
Deprecates methods from the repository_googledocs class which are
no longer used.
Mihail Geshoski [Thu, 18 Mar 2021 01:39:30 +0000 (09:39 +0800)]
MDL-61768 repository_googledocs: Add unit tests
Adds unit tests for the newly introduced methods related to the content
browsing and searching functionallity across drives.
Mihail Geshoski [Thu, 18 Mar 2021 01:38:43 +0000 (09:38 +0800)]
MDL-61768 repository_googledocs: Support shared drives
Enables the Google Drive repository to support browsing and searching
for content from the existing shared drives.
Mihail Geshoski [Wed, 3 Mar 2021 08:49:24 +0000 (16:49 +0800)]
MDL-61768 repository_googledocs: Rest API function to list shared drives
Adds a new rest API function in the googledocs repository which would
return the existing shared drives.
Jake Dallimore [Thu, 15 Apr 2021 02:35:33 +0000 (10:35 +0800)]
Merge branch 'MDL-70142' of git://github.com/paulholden/moodle
Andrew Nicols [Thu, 15 Apr 2021 01:19:24 +0000 (09:19 +0800)]
Merge branch 'MDL-70311-master' of git://github.com/ilyatregubov/moodle
Jake Dallimore [Thu, 15 Apr 2021 00:38:48 +0000 (08:38 +0800)]
Merge branch 'MDL-70649-alternative-security-helper' of https://github.com/xuangui2018/moodle
Jake Dallimore [Thu, 15 Apr 2021 00:31:47 +0000 (08:31 +0800)]
Merge branch 'MDL-71119-master' of git://github.com/sarjona/moodle
AMOS bot [Thu, 15 Apr 2021 00:08:03 +0000 (00:08 +0000)]
Automatically generated installer lang files
Paul Holden [Wed, 14 Apr 2021 20:07:43 +0000 (21:07 +0100)]
MDL-71338 tool_usertours: correct Content-Type on tour export.
Replace existing code with standard file serving mechanism, in
turn correcting the previously incorrect Content-Type header.
Eloy Lafuente (stronk7) [Wed, 14 Apr 2021 17:17:19 +0000 (19:17 +0200)]
Merge branch 'MDL-67999-master' of git://github.com/sarjona/moodle
Sara Arjona [Thu, 18 Mar 2021 15:30:02 +0000 (16:30 +0100)]
MDL-67999 contentbank: Remove contentbank/upload.php
As the form to upload files to the content bank has been moved to
modal, this file is not required any more, so it has been removed.
Sara Arjona [Thu, 18 Mar 2021 11:51:03 +0000 (12:51 +0100)]
MDL-67999 contentbank: Make upload/replace files modal form
Once MDL-64554 landed, content bank can implement the original
proposal, using a modal form when uploading files.
Sara Arjona [Thu, 18 Mar 2021 11:40:32 +0000 (12:40 +0100)]
MDL-67999 core_contentbank: Add namespace to upload form
The form to upload/replace files has been moved to classes/form
(it's where it should have been added when it was created).
Besides, this class has been renamed because now, with the
namespace, contentbank and form don't need to be in the name ;-)
Xuan Gui [Tue, 2 Feb 2021 23:54:54 +0000 (09:54 +1000)]
MDL-70649 files: Alternative security helper
Augument all installed plugin's security helper if there is any.
Plugins function has to be defined as plugintype_pluginname_security_helper in pluginname/lib.php file.
Eloy Lafuente (stronk7) [Wed, 14 Apr 2021 10:45:00 +0000 (12:45 +0200)]
Merge branch 'MDL-70616-master' of https://github.com/izendegi/moodle
Iñigo Zendegi [Wed, 14 Apr 2021 09:04:54 +0000 (11:04 +0200)]
MDL-70616 gradingform_rubric: Filters not applied to rubric name
Sara Arjona [Wed, 14 Apr 2021 08:52:34 +0000 (10:52 +0200)]
MDL-71119 core_badges: Add more information to errors
Some errors raised when calling external services were ignored.
Displaying this information helps to debug and find the real reasons
why some action, like connecting to an external backpack, can't be
done.
Jun Pataleta [Wed, 14 Apr 2021 08:50:42 +0000 (16:50 +0800)]
Merge branch 'MDL-71315-master' of git://github.com/sarjona/moodle
Sara Arjona [Tue, 16 Mar 2021 11:43:39 +0000 (12:43 +0100)]
MDL-71119 core_badges: Use basicauth and remove urlencode
Basic authorization header is required to get token. Besides, client
id and secret shouldn't call urlencode.
Sara Arjona [Tue, 16 Mar 2021 11:32:20 +0000 (12:32 +0100)]
MDL-71119 core_badges: Initialise scopes param in backpack-connect.php
The scopes parameter should be passed when creating the OAuth2 badges
client. As it is an optional parameter, when it's empty, it will
be initilised with the supported scopes for the backpack issuer.
It will happen, for instance, when a call is done to oauth2callback.php
because, as defined in RFC6749, OAuth2 authorization response only
supports code and state.
Sara Arjona [Tue, 13 Apr 2021 07:06:55 +0000 (09:06 +0200)]
MDL-71315 core_badges: Fix warning when rendering badges
Andrew Nicols [Wed, 14 Apr 2021 04:09:01 +0000 (12:09 +0800)]
Merge branch 'MDL-71154' of https://github.com/stronk7/moodle
Jake Dallimore [Wed, 14 Apr 2021 01:07:21 +0000 (09:07 +0800)]
Merge branch 'MDL-70207-master' of git://github.com/peterRd/moodle
Andrew Nicols [Wed, 14 Apr 2021 00:35:07 +0000 (08:35 +0800)]
Merge branch 'MDL-71169-master-execute' of git://github.com/mudrd8mz/moodle
AMOS bot [Wed, 14 Apr 2021 00:07:59 +0000 (00:07 +0000)]
Automatically generated installer lang files
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 21:08:45 +0000 (23:08 +0200)]
Merge branch 'MDL-69874-master' of git://github.com/lucaboesch/moodle
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 20:39:27 +0000 (22:39 +0200)]
Merge branch 'MDL-70722-master' of git://github.com/sarjona/moodle
Víctor Déniz [Tue, 13 Apr 2021 18:45:03 +0000 (19:45 +0100)]
Merge branch 'MDL-71089-master' of git://github.com/roland04/moodle
Eloy Lafuente (stronk7) [Sun, 21 Mar 2021 18:05:22 +0000 (19:05 +0100)]
MDL-71154 ci: Prevent upstream branches and tags to be built
Both for travis and GHA:
- master and MOODLE_XXX_STABLE branches
- any vX.Y.Z tag
won't lead to a build anymore.
Mikel Martín [Tue, 16 Mar 2021 11:45:35 +0000 (12:45 +0100)]
MDL-71089 core: Add different Toast notification styling 'types'
Mikel Martín [Thu, 11 Mar 2021 15:07:17 +0000 (16:07 +0100)]
MDL-71089 theme_boost: Add styles for different toast types
Sara Arjona [Tue, 13 Apr 2021 10:26:57 +0000 (12:26 +0200)]
Merge branch 'MDL-71011' of https://github.com/stronk7/moodle
Sara Arjona [Tue, 13 Apr 2021 10:19:25 +0000 (12:19 +0200)]
Merge branch 'MDL-65983-master' of git://github.com/jleyva/moodle
Luca Bösch [Tue, 6 Oct 2020 16:12:10 +0000 (18:12 +0200)]
MDL-69874 workshop: Title mentions received assessments in close phase.
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 08:26:25 +0000 (10:26 +0200)]
weekly release 4.0dev
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 08:26:20 +0000 (10:26 +0200)]
Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install
Adrian Greeve [Tue, 13 Apr 2021 03:42:30 +0000 (11:42 +0800)]
Merge branch 'MDL-71161-master-4' of git://github.com/junpataleta/moodle
Adrian Greeve [Tue, 13 Apr 2021 02:59:02 +0000 (10:59 +0800)]
Merge branch 'MDL-70821-master-5' of git://github.com/junpataleta/moodle
Eloy Lafuente (stronk7) [Mon, 12 Apr 2021 22:46:55 +0000 (00:46 +0200)]
Merge branch 'mdl_71172' of https://github.com/AnupamaSarjoshi/moodle
Michael Hawkins [Fri, 12 Mar 2021 11:20:39 +0000 (19:20 +0800)]
MDL-71161 mod_workshop: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 08:16:45 +0000 (16:16 +0800)]
MDL-71161 mod_wiki: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 06:28:57 +0000 (14:28 +0800)]
MDL-71161 mod_url: Display activity completion information
Simey Lameze [Thu, 11 Mar 2021 11:06:09 +0000 (19:06 +0800)]
MDL-71161 mod_survey: show survey activity info
Michael Hawkins [Mon, 22 Mar 2021 09:45:50 +0000 (17:45 +0800)]
MDL-71161 mod_scorm: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 10:44:34 +0000 (18:44 +0800)]
MDL-71161 mod_resource: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 10:58:00 +0000 (18:58 +0800)]
MDL-71161 mod_quiz: Display activity completion information
Michael Hawkins [Thu, 11 Mar 2021 03:52:34 +0000 (11:52 +0800)]
MDL-71161 mod_page: Display activity completion information
Michael Hawkins [Wed, 10 Mar 2021 11:18:54 +0000 (19:18 +0800)]
MDL-71161 mod_lti: Display activity completion information
Michael Hawkins [Mon, 22 Mar 2021 11:05:17 +0000 (19:05 +0800)]
MDL-71161 mod_lesson: Display activity completion information
Jun Pataleta [Thu, 25 Mar 2021 08:36:00 +0000 (16:36 +0800)]
MDL-71161 mod_imscp: Display activity information output component
Jun Pataleta [Thu, 25 Mar 2021 08:35:46 +0000 (16:35 +0800)]
MDL-71161 mod_h5pactivity: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 08:37:24 +0000 (16:37 +0800)]
MDL-71161 mod_glossary: show glossary activity info
Simey Lameze [Thu, 11 Mar 2021 08:09:32 +0000 (16:09 +0800)]
MDL-71161 mod_forum: show forum activity info
Jun Pataleta [Thu, 25 Mar 2021 08:34:41 +0000 (16:34 +0800)]
MDL-71161 mod_folder: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 08:45:04 +0000 (16:45 +0800)]
MDL-71161 mod_feedback: show feedback activity info
Simey Lameze [Mon, 29 Mar 2021 02:37:01 +0000 (10:37 +0800)]
MDL-71161 mod_data: show database activity info
Jun Pataleta [Thu, 25 Mar 2021 08:34:23 +0000 (16:34 +0800)]
MDL-71161 mod_chat: Display activity information output component
Jun Pataleta [Thu, 25 Mar 2021 08:34:11 +0000 (16:34 +0800)]
MDL-71161 mod_book: Display activity information output component
Simey Lameze [Thu, 11 Mar 2021 11:05:23 +0000 (19:05 +0800)]
MDL-71161 mod_assign: show assign activity info
Jun Pataleta [Mon, 12 Apr 2021 16:33:54 +0000 (00:33 +0800)]
MDL-70821 core_completion: Fix completion settings Behat tests
Jun Pataleta [Mon, 12 Apr 2021 13:15:46 +0000 (21:15 +0800)]
MDL-70821 course: Render activity information only when necessary
Render the activity information output component in the course homepage
only if either completion details or activity dates are to be displayed.
This can help reduce the number of files being included when loading the
course homepage (e.g. the activity information template for each
activity in the course homepage).
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 17:20:38 +0000 (18:20 +0100)]
MDL-71011 adodb: Update readme and thirdpartylibs
Small changes in readme and document the bump in xml
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 17:16:07 +0000 (18:16 +0100)]
MDL-71011 php80: final private makes no sense, throwing warning
Ref: https://php.watch/versions/8.0/final-private-function#final-private
This applies #712 from upstream libraries.
Unrelated: I've also changed a occurrence of "private final"
by the correct (PSR-12) "final private" in the constructor
(the final&private combination is allowed in constructors)
in lib/classes/event/base.php, because it's the unique case
in core and phpcs was really insisting.
Eloy Lafuente (stronk7) [Sat, 27 Mar 2021 16:56:57 +0000 (17:56 +0100)]
MDL-71011 adodb: Bump to v5.21.0
Following the instructions @ readme_moodle.txt
Eloy Lafuente (stronk7) [Mon, 12 Apr 2021 15:32:24 +0000 (17:32 +0200)]
Merge branch 'MDL-71064' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 12 Apr 2021 15:24:33 +0000 (17:24 +0200)]
Merge branch 'MDL-68716' of git://github.com/paulholden/moodle
Sara Arjona [Mon, 12 Apr 2021 14:40:04 +0000 (16:40 +0200)]
Merge branch 'MDL-71264' of https://github.com/stronk7/moodle
Sara Arjona [Mon, 12 Apr 2021 14:01:29 +0000 (16:01 +0200)]
Merge branch 'MDL-70595-master' of git://github.com/mickhawkins/moodle
Sara Arjona [Mon, 12 Apr 2021 10:41:03 +0000 (12:41 +0200)]
Merge branch 'MDL-71107-master' of git://github.com/aanabit/moodle