moodle.git
10 hours agoweekly release 3.10.3+ MOODLE_310_STABLE
Sara Arjona [Tue, 20 Apr 2021 13:51:19 +0000 (15:51 +0200)]
weekly release 3.10.3+

24 hours agoAutomatically generated installer lang files
AMOS bot [Tue, 20 Apr 2021 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 days agoAutomatically generated installer lang files
AMOS bot [Sun, 18 Apr 2021 00:07:25 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 days agoMDL-71365 grunt: fix ignores missing LF @ EOF
Eloy Lafuente (stronk7) [Sat, 17 Apr 2021 22:16:39 +0000 (00:16 +0200)]
MDL-71365 grunt: fix ignores missing LF @ EOF

3 days agoMDL-71364 behat: fix randomness causes by "now" advancing
Eloy Lafuente (stronk7) [Fri, 16 Apr 2021 22:45:55 +0000 (00:45 +0200)]
MDL-71364 behat: fix randomness causes by "now" advancing

Some recent tests do set a date time element
to ##now## or tomorrow and, immediately after that
the look if, effectively, ##now## and #tomorrow#
have been set (with minutes resolution).

Problem is that, between the field is set and the field
is verified, it can happen that the time advances to
next minute (from H:M:59 to H:M+1:00) and then the
assertion fails.

To avoid this, we could have lowered the resolution to be
hours... but that doesn't solve the problem just makes it
to happen less often.

So, instead of that... we are setting the 2 now and tomorrow
cases to be "today noon" and "tomorrow noon" (12:00:00) so
we ensure they won't be ever in the risk of jumping of minute.

4 days agoweekly release 3.10.3+
Sara Arjona [Fri, 16 Apr 2021 15:03:33 +0000 (17:03 +0200)]
weekly release 3.10.3+

5 days agoMDL-65553 core_analytics: Don't allow to flag predictions several times
Amaia Anabitarte [Tue, 16 Feb 2021 12:17:51 +0000 (13:17 +0100)]
MDL-65553 core_analytics: Don't allow to flag predictions several times

Even if a prediction is hidden from the report once is flagged,
it can be flagged several times if the user visits detailed view via URL.
We remove the checkbox to select a prediction and flag it
once it has already been flagged.

6 days agoAutomatically generated installer lang files
AMOS bot [Thu, 15 Apr 2021 00:07:34 +0000 (00:07 +0000)]
Automatically generated installer lang files

6 days agoMDL-71338 tool_usertours: correct Content-Type on tour export.
Paul Holden [Wed, 14 Apr 2021 20:07:43 +0000 (21:07 +0100)]
MDL-71338 tool_usertours: correct Content-Type on tour export.

Replace existing code with standard file serving mechanism, in
turn correcting the previously incorrect Content-Type header.

6 days agoMDL-70616 gradingform_rubric: Filters not applied to rubric name
Iñigo Zendegi [Wed, 14 Apr 2021 09:13:38 +0000 (11:13 +0200)]
MDL-70616 gradingform_rubric: Filters not applied to rubric name

6 days agoMDL-71119 core_badges: Add more information to errors
Sara Arjona [Wed, 14 Apr 2021 08:52:34 +0000 (10:52 +0200)]
MDL-71119 core_badges: Add more information to errors

Some errors raised when calling external services were ignored.
Displaying this information helps to debug and find the real reasons
why some action, like connecting to an external backpack, can't be
done.

6 days agoMDL-71119 core_badges: Use basicauth and remove urlencode
Sara Arjona [Tue, 16 Mar 2021 11:43:39 +0000 (12:43 +0100)]
MDL-71119 core_badges: Use basicauth and remove urlencode

Basic authorization header is required to get token. Besides, client
id and secret shouldn't call urlencode.

6 days agoMDL-71119 core_badges: Initialise scopes param in backpack-connect.php
Sara Arjona [Tue, 16 Mar 2021 11:32:20 +0000 (12:32 +0100)]
MDL-71119 core_badges: Initialise scopes param in backpack-connect.php

The scopes parameter should be passed when creating the OAuth2 badges
client. As it is an optional parameter, when it's empty, it will
be initilised with the supported scopes for the backpack issuer.

It will happen, for instance, when a call is done to oauth2callback.php
because, as defined in RFC6749, OAuth2 authorization response only
supports code and state.

7 days agoAutomatically generated installer lang files
AMOS bot [Wed, 14 Apr 2021 00:07:28 +0000 (00:07 +0000)]
Automatically generated installer lang files

7 days agoMDL-71154 ci: Prevent upstream branches and tags to be built
Eloy Lafuente (stronk7) [Sun, 21 Mar 2021 18:05:22 +0000 (19:05 +0100)]
MDL-71154 ci: Prevent upstream branches and tags to be built

Both for travis and GHA:

- master and MOODLE_XXX_STABLE branches
- any vX.Y.Z tag

won't lead to a build anymore.

7 days agoweekly release 3.10.3+
Eloy Lafuente (stronk7) [Tue, 13 Apr 2021 08:26:39 +0000 (10:26 +0200)]
weekly release 3.10.3+

10 days agoMDL-69102 phpunit: Add test to cover ALL cohort criteria
Eloy Lafuente (stronk7) [Thu, 8 Apr 2021 17:19:09 +0000 (19:19 +0200)]
MDL-69102 phpunit: Add test to cover ALL cohort criteria

That way we can check that the expectations are
working ok for every database. Previously only the
ANY case was being tested.

Also, convert them to course badges and check, via
review_all_criteria() that the SQL structures returned
by award_criteria_cohort->get_completed_criteria_sql()
doesn't fail and return the expected counters.

12 days agoAutomatically generated installer lang files
AMOS bot [Fri, 9 Apr 2021 00:07:31 +0000 (00:07 +0000)]
Automatically generated installer lang files

13 days agoMDL-71107 core_contentbank: Behat test. Authoring when copying a course
Amaia Anabitarte [Tue, 16 Mar 2021 12:18:10 +0000 (13:18 +0100)]
MDL-71107 core_contentbank: Behat test. Authoring when copying a course

13 days agoMDL-71107 core_contentbank: Fill content author when copying a course
Amaia Anabitarte [Mon, 15 Mar 2021 12:45:42 +0000 (13:45 +0100)]
MDL-71107 core_contentbank: Fill content author when copying a course

'usercreated' and 'usermodified' fields can not be always mapped.
We are filling those fields with 'old' users when working on the same
site, or with current user when working on a different instance.

2 weeks agoMDL-70595 core: Updated security.txt expiry
Michael Hawkins [Tue, 6 Apr 2021 05:01:19 +0000 (13:01 +0800)]
MDL-70595 core: Updated security.txt expiry

2 weeks agoAutomatically generated installer lang files
AMOS bot [Tue, 6 Apr 2021 00:07:37 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 weeks agoMDL-70099 enrol: increase accuracy of current enrolments by date.
Paul Holden [Tue, 3 Nov 2020 08:16:07 +0000 (08:16 +0000)]
MDL-70099 enrol: increase accuracy of current enrolments by date.

By rounding the current time it was possible that the most recently
created user enrolments (e.g. self enrolments) were being excluded.

This would manifest itself in a user being enrolled on a course,
but it not appearing under "My courses" navigation or on their own
Dashboard until the rounded time had caught up with the current
time.

2 weeks agoMDL-66475 task: fix random timing failures in logger cleanup test.
Paul Holden [Fri, 18 Dec 2020 15:18:43 +0000 (15:18 +0000)]
MDL-66475 task: fix random timing failures in logger cleanup test.

2 weeks agoAutomatically generated installer lang files
AMOS bot [Sun, 4 Apr 2021 00:07:33 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 weeks agoMDL-71264 behat: Change date(time) element update order
Eloy Lafuente (stronk7) [Sat, 3 Apr 2021 08:33:57 +0000 (10:33 +0200)]
MDL-71264 behat: Change date(time) element update order

This includes 2 change to the order date(time) elements are filled,
each one addressing one type of problem, where current order is
problematic and can lead to unexpected dates.

1) Changing date, when current month only has X days and target
   month has more than X days. Example, being 1 April, change
   the date to 31 May.
     This is solved by changing the order of introduction
     from current D => M => Y to Y => M => D.
2) Changing date, when target month only has X days and current
   month has more that X days. Example, being 31 March, change
   the date to 28 Feb.
     This is solved by always setting the D to 1, before the
     Y => M => D sequence commented @ 1) begins.

2 weeks agoMDL-71264 behat: New feature covering all day/month/year date changes
Eloy Lafuente (stronk7) [Fri, 2 Apr 2021 23:22:15 +0000 (01:22 +0200)]
MDL-71264 behat: New feature covering all day/month/year date changes

Because of the order that dates and datetimes are filled by behat
sometimes there are some intermediate results that are impossible
and then the form (javascript) automatically reacts and fixes the
date, ultimate leading to a different date that the one we wanted
to set with Behat.

This is noticeable when switching between months (with some day
being the last day of the month) and the 2 months have a different
number of days. For example April date => March date (or the opposite).

This test covers all the critical changes (day, month and year),
back and forth. All times are Perth/Australia.

2 weeks agoAutomatically generated installer lang files
AMOS bot [Fri, 2 Apr 2021 00:07:25 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 weeks agoMDL-69102 badge: Fixes broken WHERE clause
Marty Gilbert [Fri, 19 Jun 2020 18:57:31 +0000 (14:57 -0400)]
MDL-69102 badge: Fixes broken WHERE clause

When buildilng the 'WHERE' clause, the SQL generated
a query that selected any user who was a member of the
**last** group, not all of the groups.

I believe the query has to be re-worked so that it only
returns users who are in ALL of the groups. This can
be done by a GROUP BY and HAVING.

2 weeks agoMDL-60490 tool_lp: Missing div close
Leon Stringer [Thu, 1 Apr 2021 11:18:13 +0000 (12:18 +0100)]
MDL-60490 tool_lp: Missing div close

Mustache template had opening <div> with missing </div>.

2 weeks agoAutomatically generated installer lang files
AMOS bot [Thu, 1 Apr 2021 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoweekly release 3.10.3+
Víctor Déniz [Tue, 30 Mar 2021 14:37:42 +0000 (15:37 +0100)]
weekly release 3.10.3+

3 weeks agoMDL-71233 backup: Fix Moodle version for MDL-69418
Mikhail Golenkov [Mon, 29 Mar 2021 23:41:59 +0000 (10:41 +1100)]
MDL-71233 backup: Fix Moodle version for MDL-69418

3 weeks agoMDL-68635 tool_cohortroles: observe user initial table filter.
Paul Holden [Thu, 7 May 2020 21:07:04 +0000 (22:07 +0100)]
MDL-68635 tool_cohortroles: observe user initial table filter.

3 weeks agoMDL-68716 mod_forum: extra column sorting options in privacy export.
Paul Holden [Mon, 1 Feb 2021 18:46:03 +0000 (18:46 +0000)]
MDL-68716 mod_forum: extra column sorting options in privacy export.

Accounts for extra sort options that were added in bc23cbaf.

3 weeks agoAutomatically generated installer lang files
AMOS bot [Mon, 29 Mar 2021 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoAutomatically generated installer lang files
AMOS bot [Sun, 28 Mar 2021 00:07:23 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoMDL-70963 core_badges: Use expected JSON format for OBv2.1
Sara Arjona [Mon, 22 Feb 2021 15:20:49 +0000 (16:20 +0100)]
MDL-70963 core_badges: Use expected JSON format for OBv2.1

This patch adds some changes to guarantee that OpenBadges 2.1 (OBv2.1)
will return always the same JSON format that OBv2.0 (because the only
difference between both versions it's the BadgeConnect API).

3 weeks agoMDL-69304 gradeimport_csv: Validate if the user id is numerical.
Shintaro Fujiwara [Fri, 26 Mar 2021 01:31:40 +0000 (10:31 +0900)]
MDL-69304 gradeimport_csv: Validate if the user id is numerical.

3 weeks agoMDL-71194 behat: Fix app tests
Noel De Martin [Thu, 25 Mar 2021 12:50:27 +0000 (13:50 +0100)]
MDL-71194 behat: Fix app tests

3 weeks agoAutomatically generated installer lang files
AMOS bot [Thu, 25 Mar 2021 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoMoodle release 3.10.3 v3.10.3
Eloy Lafuente (stronk7) [Wed, 24 Mar 2021 19:13:09 +0000 (20:13 +0100)]
Moodle release 3.10.3

3 weeks agoMDL-71004 git: Ignore moodle-plugin-ci.phar in any directory
Eloy Lafuente (stronk7) [Sun, 21 Mar 2021 22:21:28 +0000 (23:21 +0100)]
MDL-71004 git: Ignore moodle-plugin-ci.phar in any directory

3 weeks agoweekly release 3.10.2+
Víctor Déniz [Wed, 24 Mar 2021 14:21:00 +0000 (14:21 +0000)]
weekly release 3.10.2+

3 weeks agoMDL-71182 calendar: add logic for category events in get_context
Simey Lameze [Mon, 24 Aug 2020 03:08:00 +0000 (11:08 +0800)]
MDL-71182 calendar: add logic for category events in get_context

This commit adds the missing logic for category events in
get_context() method. Without this fix, users will get errors
if they have category events with userid set to 0.

3 weeks agoMDL-70802 javascript: Normalise component consistently in templates
Andrew Nicols [Fri, 5 Feb 2021 07:51:18 +0000 (15:51 +0800)]
MDL-70802 javascript: Normalise component consistently in templates

3 weeks agoMDL-71182 calendar: Revert "Merge branch 'MDL-67494-310' of git://github.com/lameze...
Simey Lameze [Wed, 24 Mar 2021 00:34:06 +0000 (08:34 +0800)]
MDL-71182 calendar: Revert "Merge branch 'MDL-67494-310' of git://github.com/lameze/moodle into MOODLE_310_STABLE"

This reverts commit 5a407772c7e55392faa3f6245b32d665649f144d, reversing
changes made to 82f2fe02e603c4abb6e5875ca59ea030ab53195d.

4 weeks agoMDL-69256 tests: Fix random slow test failures in completion cron
Andrew Nicols [Tue, 23 Mar 2021 00:03:36 +0000 (08:03 +0800)]
MDL-69256 tests: Fix random slow test failures in completion cron

4 weeks agoMDL-69415 core_h5p: prepend H5P libraries in autoloader
Sara Arjona [Mon, 22 Mar 2021 11:36:41 +0000 (12:36 +0100)]
MDL-69415 core_h5p: prepend H5P libraries in autoloader

Core and mod_hvp are using the same namespace for some H5P
libraries. This is causing some random errors.
In order to get the expected behaviour in Moodle core, this patch
prepends H5P libraries in order to guarantee they are loaded first.
Plugins using same libraries will need to use a different namespace
if they overlap and a different version of these libraries should
be used.

4 weeks agoMDL-70980 mod_h5pactivity: fix review mode
Ferran Recio [Tue, 23 Feb 2021 14:33:57 +0000 (15:33 +0100)]
MDL-70980 mod_h5pactivity: fix review mode

4 weeks agoMDL-67870 backup: Skip value change if setting is locked by hierarchy
Mihail Geshoski [Wed, 10 Mar 2021 03:08:48 +0000 (11:08 +0800)]
MDL-67870 backup: Skip value change if setting is locked by hierarchy

The given condition in the if statement did not take into account cases
when the setting is locked by hierarchy. Settings which are locked by
hierarchy should should keep their current values which were inherited
from the parent.

4 weeks agoMDL-71087 File picker: Focus lost after 'Create folder'
Thinh Pham [Fri, 19 Mar 2021 09:33:37 +0000 (16:33 +0700)]
MDL-71087 File picker: Focus lost after 'Create folder'

4 weeks agoMDL-71139 trademark: Improve the trademark messaging
Chris Brown [Thu, 18 Mar 2021 09:31:56 +0000 (10:31 +0100)]
MDL-71139 trademark: Improve the trademark messaging

4 weeks agoMDL-71116 core_badges: Backpack URLs with more than 50 chars
Sara Arjona [Tue, 16 Mar 2021 16:43:35 +0000 (17:43 +0100)]
MDL-71116 core_badges: Backpack URLs with more than 50 chars

Backpack URLs (web and API) can have up to 255. However, the form
for creating/editing them, doesn't allow URLs with more than 50
characters. This patch align limitation to DB value (255).

4 weeks agoweekly release 3.10.2+
Eloy Lafuente (stronk7) [Fri, 19 Mar 2021 13:06:33 +0000 (14:06 +0100)]
weekly release 3.10.2+

4 weeks agoMDL-70959 completion: Fix completion_info::get_data() unit tests
Jun Pataleta [Mon, 15 Mar 2021 06:39:08 +0000 (14:39 +0800)]
MDL-70959 completion: Fix completion_info::get_data() unit tests

* Fixed inverted $sameuser test data.
* Fixed caching expectation check. Caching only relies on whether the
user accessing the completion data is the same user or not.
* Fixed checking for the caching of other modules. Should have been
checking cm ID and not instance ID.
* Additional test case when whole course parameter is passed as
true, but the requesting user is different from the target user.

4 weeks agoMDL-70537 Availability: Avoid recursive calls to $cm->name
sam marshall [Tue, 2 Feb 2021 11:51:25 +0000 (11:51 +0000)]
MDL-70537 Availability: Avoid recursive calls to $cm->name

These recursive calls didn't work in PHP 7.3 and below, but in PHP
7.4 they also cause a fatal error which means if you have invalid
availability data, the whole page might die.

4 weeks agoAutomatically generated installer lang files
AMOS bot [Thu, 18 Mar 2021 00:07:25 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 weeks agoMDL-71068 login: Fix edge cases with $CFG->protectusernames
Brendan Heywood [Wed, 17 Mar 2021 06:37:29 +0000 (17:37 +1100)]
MDL-71068 login: Fix edge cases with $CFG->protectusernames

4 weeks agoMDL-70992 Folder: Unnecessary tab stops to the left of files
sangnguyen [Mon, 1 Mar 2021 09:48:14 +0000 (16:48 +0700)]
MDL-70992 Folder: Unnecessary tab stops to the left of files

5 weeks agoMDL-71128 mod_quiz: escape question idnumber on display.
Paul Holden [Tue, 16 Mar 2021 20:18:38 +0000 (20:18 +0000)]
MDL-71128 mod_quiz: escape question idnumber on display.

5 weeks agoMDL-44613 mod_assign: Fix behat failure in classic
Mihail Geshoski [Tue, 16 Mar 2021 02:26:09 +0000 (10:26 +0800)]
MDL-44613 mod_assign: Fix behat failure in classic

The link to the calendar page is missing in the navigation block in
classic which causes a behat failure in the 'Set availibility dates
for an assignment' feature. The fix includes adding the calendar block
to the Course page which can be used to navigate to the calendar page.

5 weeks agoMDL-70977 mod_forum: fix empty equality check updating post content.
Paul Holden [Mon, 22 Feb 2021 23:19:46 +0000 (23:19 +0000)]
MDL-70977 mod_forum: fix empty equality check updating post content.

Using the external method for updating posts, the check for empty
subject/message content wasn't correct (disallowed the string '0'),
in addition to being impossible to set a posts message format
property to FORMAT_MOODLE (integer 0).

5 weeks agoMDL-70924 course: ensure required fields present when getting courses.
Paul Holden [Wed, 17 Feb 2021 09:54:24 +0000 (09:54 +0000)]
MDL-70924 course: ensure required fields present when getting courses.

5 weeks agoMDL-44613 mod_assign: Automate testing of the assignment availability
Mihail Geshoski [Tue, 9 Feb 2021 03:26:05 +0000 (11:26 +0800)]
MDL-44613 mod_assign: Automate testing of the assignment availability

5 weeks agoMDL-44613 tool_behat: Update datetime format usages to strftime
Mihail Geshoski [Fri, 19 Feb 2021 06:47:44 +0000 (14:47 +0800)]
MDL-44613 tool_behat: Update datetime format usages to strftime

Updates all existing datetime format usages to strftime in the
'time to timestamp' transformation in tool_behat behat tests.

5 weeks agoMDL-44613 core_message: Update datetime format usages to strftime
Mihail Geshoski [Fri, 19 Feb 2021 06:35:24 +0000 (14:35 +0800)]
MDL-44613 core_message: Update datetime format usages to strftime

Updates all existing datetime format usages to strftime in the
'time to timestamp' transformation in core_message behat tests.

5 weeks agoMDL-44613 behat: strftime format in time to timestamp transformation
Mihail Geshoski [Fri, 19 Feb 2021 06:02:10 +0000 (14:02 +0800)]
MDL-44613 behat: strftime format in time to timestamp transformation

Modifies the 'string time to timestamp' behat trasformation to use
userdate() instead of date(). The userdate() method is generally used
throught Moodle for constructing formatted date strings and this change
will provide more consistency and prevent any potential behat failures.
Therefore, if the date format is defined in the given trasformation, it
has to be strftime compatible. Example:
'I should see "##tomorrow noon##%A, %d %B %Y, %I:%M %p##"'

5 weeks agoMDL-70306 auth: Update the thirdpartylib.xml
Peter Dias [Wed, 10 Mar 2021 00:24:02 +0000 (08:24 +0800)]
MDL-70306 auth: Update the thirdpartylib.xml

5 weeks agoAutomatically generated installer lang files
AMOS bot [Sat, 13 Mar 2021 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

5 weeks agoMDL-70959 completion: Fix unit tests for get_data()
Jun Pataleta [Mon, 22 Feb 2021 09:41:56 +0000 (17:41 +0800)]
MDL-70959 completion: Fix unit tests for get_data()

The unit tests for completion_info::get_data() does not make a lot of
sense with mocking being incorrectly used and the actual functionality
is not being properly tested. I have rewritten the test to use actual
cm_info instances and data providers for better coverage.

5 weeks agoMDL-70959 completion: Documentation improvements
Jun Pataleta [Mon, 22 Feb 2021 09:32:41 +0000 (17:32 +0800)]
MDL-70959 completion: Documentation improvements

* Fix typo in $cm parameter's type in PHPDoc
* Improve the comment to better explain the logic why fetching the
completion data for the whole course can only be done when caching is
used.
Even if $wholecourse is set to true, there's no point in fetching the
completion data for all the course modules unless we're caching the
results.

5 weeks agoweekly release 3.10.2+
Sara Arjona [Thu, 11 Mar 2021 16:18:50 +0000 (17:18 +0100)]
weekly release 3.10.2+

6 weeks agoAutomatically generated installer lang files
AMOS bot [Wed, 10 Mar 2021 00:07:21 +0000 (00:07 +0000)]
Automatically generated installer lang files

6 weeks agoMDL-69036 theme_boost: consistent table row hovering for links.
Paul Holden [Mon, 23 Nov 2020 12:05:47 +0000 (12:05 +0000)]
MDL-69036 theme_boost: consistent table row hovering for links.

When hovering over table rows with the `dimmed_text` class we
should consistently set the text/link colour.

Co-Authored-By: Mikel Martín <mikel@moodle.com>
6 weeks agoMDL-70780 customfield: Address random behat fails
Andrew Nicols [Fri, 5 Feb 2021 01:44:06 +0000 (09:44 +0800)]
MDL-70780 customfield: Address random behat fails

A number of behat fails have been creeping in with the customfield code
as behat is moving onto the next step before the current step finishes.

This change introduces some additional pending JS tracking to prevent
this.

6 weeks agoAutomatically generated installer lang files
AMOS bot [Sun, 7 Mar 2021 00:07:20 +0000 (00:07 +0000)]
Automatically generated installer lang files

6 weeks agoMoodle release 3.10.2 v3.10.2
Eloy Lafuente (stronk7) [Sat, 6 Mar 2021 17:03:57 +0000 (18:03 +0100)]
Moodle release 3.10.2

6 weeks agoAutomatically generated installer lang files
AMOS bot [Sat, 6 Mar 2021 00:07:19 +0000 (00:07 +0000)]
Automatically generated installer lang files

6 weeks agoweekly release 3.10.1+
Sara Arjona [Fri, 5 Mar 2021 15:01:41 +0000 (16:01 +0100)]
weekly release 3.10.1+

6 weeks agoMDL-71059 repository_contentbank: set default returntype
Alexander Bias [Fri, 5 Mar 2021 10:34:38 +0000 (11:34 +0100)]
MDL-71059 repository_contentbank: set default returntype

The content bank was designed for making easier to reuse content.
So "Link to the file" should be the default option when using the
contentbank repository, in order to let teachers modify their
content in the content bank and update automatically it everywhere
is used.

6 weeks agoMDL-70726 behat: Fixing existing fail tests
Amaia Anabitarte [Fri, 5 Feb 2021 16:36:24 +0000 (17:36 +0100)]
MDL-70726 behat: Fixing existing fail tests

Some of the current behat tests were wrong but not failing because of the bug in 'should not exist' step.
Once the bug is fixed, we must fix also wrong behats.

6 weeks agoMDL-69680 lib: Fix behat test backup_and_restore.feature
Ilya Tregubov [Thu, 4 Mar 2021 10:45:06 +0000 (12:45 +0200)]
MDL-69680 lib: Fix behat test backup_and_restore.feature

6 weeks agoMDL-71048 lang: fix null equality check of lang string args.
Paul Holden [Thu, 4 Mar 2021 17:37:08 +0000 (17:37 +0000)]
MDL-71048 lang: fix null equality check of lang string args.

6 weeks agoMDL-71039 core_form: support valuehtmlcallback in autocomplete inline
Marina Glancy [Thu, 4 Mar 2021 11:02:07 +0000 (12:02 +0100)]
MDL-71039 core_form: support valuehtmlcallback in autocomplete inline

6 weeks agoMDL-70727 Behat: function scrollIntoView not working in the app
Thinh Pham [Thu, 4 Mar 2021 04:44:57 +0000 (11:44 +0700)]
MDL-70727 Behat: function scrollIntoView not working in the app

6 weeks agoMDL-69680 lib: Replace deprecated jQuery functions
Ilya Tregubov [Tue, 16 Feb 2021 07:31:41 +0000 (09:31 +0200)]
MDL-69680 lib: Replace deprecated jQuery functions

6 weeks agoMDL-69680 lib: Update jQuery version in Moodle files
Ilya Tregubov [Fri, 12 Feb 2021 07:39:18 +0000 (09:39 +0200)]
MDL-69680 lib: Update jQuery version in Moodle files

6 weeks agoMDL-69680 lib: Upgrade jQuery lib to 3.5.1
Ilya Tregubov [Fri, 12 Feb 2021 07:29:08 +0000 (09:29 +0200)]
MDL-69680 lib: Upgrade jQuery lib to 3.5.1

6 weeks agoMDL-70424 auth: Avoid random changes to $CFG->auth
Brendan Heywood [Mon, 22 Feb 2021 03:43:14 +0000 (14:43 +1100)]
MDL-70424 auth: Avoid random changes to $CFG->auth

6 weeks agoMDL-70767 feedback: Prevent xss in feedback answer text.
Ilya Tregubov [Tue, 2 Mar 2021 13:59:43 +0000 (15:59 +0200)]
MDL-70767 feedback: Prevent xss in feedback answer text.

6 weeks agoMDL-68721 mod_h5pactivity: report acceptance tests
Ferran Recio [Thu, 14 Jan 2021 15:03:33 +0000 (16:03 +0100)]
MDL-68721 mod_h5pactivity: report acceptance tests

6 weeks agoMDL-65552 block_activity_results: correct Behat tests for idnumbers.
Paul Holden [Wed, 3 Mar 2021 13:36:11 +0000 (13:36 +0000)]
MDL-65552 block_activity_results: correct Behat tests for idnumbers.

Teachers can see user idnumber fields only when they are configured
identity fields. Students cannot.

6 weeks agoMDL-65552 user: escape idnumber and email in table_sql
Marina Glancy [Mon, 1 Mar 2021 18:14:35 +0000 (19:14 +0100)]
MDL-65552 user: escape idnumber and email in table_sql

6 weeks agoMDL-65552 user: escape idnumber field on output.
Paul Holden [Mon, 1 Mar 2021 14:20:02 +0000 (14:20 +0000)]
MDL-65552 user: escape idnumber field on output.

This commit also corrects parameter definition of the field to
match core_user.

6 weeks agoMDL-71026 user: Fix incorrect get_string call.
Ilya Tregubov [Wed, 3 Mar 2021 09:11:23 +0000 (11:11 +0200)]
MDL-71026 user: Fix incorrect get_string call.

6 weeks agoMDL-67494 calendar: user_delete_user should delete all user events
Simey Lameze [Mon, 7 Sep 2020 09:31:16 +0000 (17:31 +0800)]
MDL-67494 calendar: user_delete_user should delete all user events

6 weeks agoMDL-67494 calendar: privacy provider should not delete shared events
Simey Lameze [Mon, 7 Sep 2020 04:03:44 +0000 (12:03 +0800)]
MDL-67494 calendar: privacy provider should not delete shared events

6 weeks agoMDL-67494 calendar: shared subscriptions should not set userid to 0
Simey Lameze [Mon, 7 Sep 2020 08:56:23 +0000 (16:56 +0800)]
MDL-67494 calendar: shared subscriptions should not set userid to 0

6 weeks agoMDL-67494 calendar: only user overrides should retain userid
Simey Lameze [Fri, 5 Feb 2021 08:09:52 +0000 (16:09 +0800)]
MDL-67494 calendar: only user overrides should retain userid