moodle.git
6 days agoweekly release 3.10+ MOODLE_310_STABLE
Sara Arjona [Fri, 27 Nov 2020 06:50:48 +0000 (07:50 +0100)]
weekly release 3.10+

6 days agoAutomatically generated installer lang files
AMOS bot [Fri, 27 Nov 2020 06:21:03 +0000 (06:21 +0000)]
Automatically generated installer lang files

6 days agoMDL-70153 qtype_essay: Whitespace/behat fixes
Andrew Nicols [Thu, 26 Nov 2020 03:26:15 +0000 (11:26 +0800)]
MDL-70153 qtype_essay: Whitespace/behat fixes

7 days agoMDL-70276 github actions: First cut, phpunit and grunt checks
Eloy Lafuente (stronk7) [Sat, 21 Nov 2020 12:05:22 +0000 (13:05 +0100)]
MDL-70276 github actions: First cut, phpunit and grunt checks

First working version, supports phpunit (using build matrix):

- php72 (lowest), running mysql.
- php74 (highest), running postgres.

Also verifies that the branch has been "gruntified" and there
isn't any missing change (build js/css files).

TODO: Verify the remaining checks currently in .travis.yml, namely:
 - CITEST
 - Add caching
 - Better health-check for DB images.
 - Support from the tracker (satus badges and enable check).
 - Support from CiBoT (status and enable check).
 - Consider moving both the common setup (git, composer...)
   and the database (mysql, postgres) to own actions for
   easier tweaking.

8 days agoMDL-65852 user: Fix permission check to download course participants.
Ilya Tregubov [Fri, 13 Nov 2020 09:02:52 +0000 (11:02 +0200)]
MDL-65852 user: Fix permission check to download course participants.

9 days agoMDL-70265 travis: Completely remove the UPGRADE check
Eloy Lafuente (stronk7) [Mon, 23 Nov 2020 12:40:52 +0000 (13:40 +0100)]
MDL-70265 travis: Completely remove the UPGRADE check

It was broken since ages ago, see MDL-64874, so no sense
to keep it eating minutes for nothing.

10 days agoMDL-67668 behat: Update tests for inplace editable field type
Andrew Nicols [Wed, 17 Jun 2020 05:45:37 +0000 (13:45 +0800)]
MDL-67668 behat: Update tests for inplace editable field type

10 days agoMDL-67668 behat: Add inplace editable field type
Andrew Nicols [Wed, 17 Jun 2020 05:45:15 +0000 (13:45 +0800)]
MDL-67668 behat: Add inplace editable field type

This commit promotes the Inplace Editable field to a first-class form
element by introducing a new partial selector for inplace editable
fields, and teaching the field manager how to recognise these, then
introducing a new field type which can handle setting values for this
field.

10 days agoMDL-67668 behat: Share behat_behat functionality with forms
Andrew Nicols [Tue, 10 Nov 2020 07:10:30 +0000 (15:10 +0800)]
MDL-67668 behat: Share behat_behat functionality with forms

Behat form fields are implemented in a way completely isolated from the
rest of the Behat Context system. Whereas regular step definitions have
access to execute steps, to call `find`, check for JS running, and other
related functionality, the Moodle implementation of a field type does
not have any access to this.

By moving the core functionality of behat_base to a new trait, and the
constants to a new interface, the functionality can also be used in
behat form fields in the same way as elsewhere.

10 days agoMDL-67668 behat: Correct js pending check
Andrew Nicols [Thu, 12 Nov 2020 00:17:34 +0000 (08:17 +0800)]
MDL-67668 behat: Correct js pending check

Pending checks should only run when JS is running, but some uses were
not apply this check.

10 days agoMDL-67668 behat: Support NodeElement when fetching node in container
Andrew Nicols [Thu, 12 Nov 2020 00:15:55 +0000 (08:15 +0800)]
MDL-67668 behat: Support NodeElement when fetching node in container

This is similar to change made in MDL-69136 to allow an already-fetched
NodeElement to be provided to the get_node_in_container() function and
makes it easier to be deterministic when writing steps.

12 days agoMDL-70265 travis: Only run highest phpunit if configured via env
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 15:20:18 +0000 (16:20 +0100)]
MDL-70265 travis: Only run highest phpunit if configured via env

By default only lowest php version will be executed, and only pgsql.

This default behavior can be changed with a new variable:

MOODLE_PHP = [all]
MOODLE_DATABASE = [pgsql | mysqli | all]

12 days agoweekly release 3.10+
Eloy Lafuente (stronk7) [Fri, 20 Nov 2020 22:17:06 +0000 (23:17 +0100)]
weekly release 3.10+

2 weeks agoMDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form
Huong Nguyen [Wed, 18 Nov 2020 09:09:05 +0000 (16:09 +0700)]
MDL-70248 qtype_ddimageortext: Drop zones have UI issue in Editing form

2 weeks agoMDL-67636 gradebook: Prevent exposing hidden grade in locked category
John Yao [Thu, 19 Nov 2020 01:36:32 +0000 (12:36 +1100)]
MDL-67636 gradebook: Prevent exposing hidden grade in locked category

2 weeks agoMDL-70237 payment: Allow html tags in gateway description
Shamim Rezaie [Mon, 16 Nov 2020 10:37:45 +0000 (21:37 +1100)]
MDL-70237 payment: Allow html tags in gateway description

2 weeks agoMDL-70094 Question: Technical info section expands if click help icon
sangnguyen2601 [Mon, 9 Nov 2020 08:47:14 +0000 (15:47 +0700)]
MDL-70094 Question: Technical info section expands if click help icon

2 weeks agoMDL-70153 qtype_essay: Add behat test for attachments max size
Dani Palou [Tue, 17 Nov 2020 09:31:32 +0000 (10:31 +0100)]
MDL-70153 qtype_essay: Add behat test for attachments max size

2 weeks agoMDL-70153 qtype_essay: Fix max size displayed for attachments
Dani Palou [Mon, 16 Nov 2020 14:20:34 +0000 (15:20 +0100)]
MDL-70153 qtype_essay: Fix max size displayed for attachments

2 weeks agoMDL-56653 enrol_meta: a single DB query in edit_instance_validation
Vitaly [Fri, 18 Sep 2020 18:45:26 +0000 (21:45 +0300)]
MDL-56653 enrol_meta: a single DB query in edit_instance_validation

The 'edit_instance_validation()' method checks for existing meta enrolment instances.
The fix replaces DB queries in a loop for each course with a single query for all courses.
Also, a new testing method 'test_edit_instance_validation_with_existing_courses()'
was added to /enrol/meta/tests/plugin_test.php to test if the new implementation
returns an error in case of trying to save the already linked courses in the 'customint1' field.

2 weeks agoMDL-70242 auth_oauth2: set page context and url
Marina Glancy [Tue, 17 Nov 2020 15:47:12 +0000 (16:47 +0100)]
MDL-70242 auth_oauth2: set page context and url

2 weeks agoMDL-70148 gradereport_grader: Improve reliability of keyboard usage
Andrew Nicols [Mon, 9 Nov 2020 07:35:54 +0000 (15:35 +0800)]
MDL-70148 gradereport_grader: Improve reliability of keyboard usage

In some browsers the ajax grade select does not properly update the
grade after setting values. The previous solution was to press the
[enter] key, but doing this with the new key type step opens the select
box again. This is what happens when a real user presses enter on the
select.

This is the last possible field in the report, so pressing the tab key
to move to the next gradable element does not work.

The solution uses a shift-tab to move the focus away to the previous
gradale element. In this case it must also be moved to an earlier step
because the previously selected value must be checked in the Then
section of the test and if it is selected then its value cannot be
checked.

2 weeks agoMDL-70148 qtype: Update qtype steps to new key interaction
Andrew Nicols [Tue, 23 Jun 2020 03:09:58 +0000 (11:09 +0800)]
MDL-70148 qtype: Update qtype steps to new key interaction

Note: The ddmarker question type was previously getting the number of
keypresses wrong. This was because it was using both keyDown/keyUp, and
also keyPress. As a result each keypress was essentially happening two
times.

2 weeks agoMDL-70148 behat: Update steps for keyboard
Andrew Nicols [Mon, 22 Jun 2020 02:39:57 +0000 (10:39 +0800)]
MDL-70148 behat: Update steps for keyboard

2 weeks agoMDL-70148 behat: Add steps to send keys without an element
Andrew Nicols [Wed, 17 Jun 2020 06:50:04 +0000 (14:50 +0800)]
MDL-70148 behat: Add steps to send keys without an element

2 weeks agoMDL-69964 course: toggle participant checkboxes in root element.
Paul Holden [Wed, 21 Oct 2020 09:22:55 +0000 (10:22 +0100)]
MDL-69964 course: toggle participant checkboxes in root element.

For a given toggleGroup, the relevant action elements are not
necessarily descendants of the same tableRoot element, on the
course participants page.

2 weeks agoMDL-67513 core: Only move modal to body if currently attached
Andrew Nicols [Mon, 16 Nov 2020 07:19:28 +0000 (15:19 +0800)]
MDL-67513 core: Only move modal to body if currently attached

A previous change as part of this commitset was intended to move the
modal to the document.body, but where the modal had been destroyed it
was instead added back to the body.

2 weeks agoMDL-50955 core: Reset lessons completion criteria if grade type is none
Peter Dias [Wed, 7 Oct 2020 02:55:25 +0000 (10:55 +0800)]
MDL-50955 core: Reset lessons completion criteria if grade type is none

2 weeks agoMDL-69526 block_myoverview: custom course fields natural sorting
Luca Bösch [Fri, 21 Aug 2020 14:03:18 +0000 (16:03 +0200)]
MDL-69526 block_myoverview: custom course fields natural sorting

2 weeks agoweekly release 3.10+
Eloy Lafuente (stronk7) [Thu, 12 Nov 2020 21:11:40 +0000 (22:11 +0100)]
weekly release 3.10+

3 weeks agoMDL-67513 forum: View conversations while fullscreen grading
Neill Magill [Tue, 25 Aug 2020 06:47:15 +0000 (07:47 +0100)]
MDL-67513 forum: View conversations while fullscreen grading

Before this change when a modal was shown and an element on the page
was fullscreen the modal would be created behind it.

This change ensures that the modal will be inside an element that is
fullscreen so that it will be correctly displayed.

3 weeks agoMDL-70067 report_insights: Replace BS3 column naming
Alex Morris [Wed, 11 Nov 2020 19:56:19 +0000 (08:56 +1300)]
MDL-70067 report_insights: Replace BS3 column naming

Bootstrap 4 removed col-xs- and replaced it with col-

3 weeks agoMDL-70063 block_tag_youtube: Add behat tests
Mihail Geshoski [Wed, 11 Nov 2020 13:02:42 +0000 (21:02 +0800)]
MDL-70063 block_tag_youtube: Add behat tests

3 weeks agoMDL-70063 block_tag_youtube: Fix category config in existing instances
Mihail Geshoski [Sat, 31 Oct 2020 14:59:52 +0000 (22:59 +0800)]
MDL-70063 block_tag_youtube: Fix category config in existing instances

Upgrade step that fixes the category configuration of existing
tag_youtube block instances.

3 weeks agoMDL-70063 block_tag_youtube: Update category config to use category ID
Mihail Geshoski [Sat, 31 Oct 2020 14:52:06 +0000 (22:52 +0800)]
MDL-70063 block_tag_youtube: Update category config to use category ID

In YouTube Data API v3, the API call to fetch the videos related to a
certain category expects the category ID to be passed to the
videoCategoryId parameter, instead of the category name. Therefore, the
category config should store the category ID.

3 weeks agoMDL-69453 core_form: improve form UI icons and alignment
Bas Brands [Tue, 27 Oct 2020 12:44:02 +0000 (13:44 +0100)]
MDL-69453 core_form: improve form UI icons and alignment

3 weeks agoMDL-65941 cache: Prevent cache config failure on redis problems.
Michael Aherne [Mon, 17 Jun 2019 11:24:39 +0000 (12:24 +0100)]
MDL-65941 cache: Prevent cache config failure on redis problems.

3 weeks agoMDL-70117 dataformat_pdf: Fix content overflow when headers are involved
Mikhail Golenkov [Tue, 10 Nov 2020 23:49:58 +0000 (10:49 +1100)]
MDL-70117 dataformat_pdf: Fix content overflow when headers are involved

3 weeks agoMDL-69823 qtype: Support core question types
Juan Leyva [Wed, 30 Sep 2020 09:27:29 +0000 (11:27 +0200)]
MDL-69823 qtype: Support core question types

3 weeks agoMDL-69823 mod_quiz: Return question options via WS
Juan Leyva [Wed, 30 Sep 2020 09:27:05 +0000 (11:27 +0200)]
MDL-69823 mod_quiz: Return question options via WS

3 weeks agoMDL-70160 cache: plugin_functions checks for function_exists()
Peter Burnett [Tue, 10 Nov 2020 01:06:17 +0000 (11:06 +1000)]
MDL-70160 cache: plugin_functions checks for function_exists()

3 weeks agoMDL-69201 core: consistent table primary sort column/order.
Paul Holden [Tue, 20 Oct 2020 23:22:23 +0000 (00:22 +0100)]
MDL-69201 core: consistent table primary sort column/order.

3 weeks agoMDL-70126 tag: correct thrown exception class name.
Paul Holden [Thu, 5 Nov 2020 19:48:29 +0000 (19:48 +0000)]
MDL-70126 tag: correct thrown exception class name.

3 weeks agoMDL-67513 forum: Test that discussions can be viewed while grading
Neill Magill [Mon, 9 Nov 2020 14:23:25 +0000 (14:23 +0000)]
MDL-67513 forum: Test that discussions can be viewed while grading

3 weeks agoMDL-70146 upgrade: add 3.10.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sat, 7 Nov 2020 22:26:09 +0000 (23:26 +0100)]
MDL-70146 upgrade: add 3.10.0 separation line to all upgrade scripts

3 weeks agoMoodle release 3.10 v3.10.0
Eloy Lafuente (stronk7) [Sat, 7 Nov 2020 16:24:12 +0000 (17:24 +0100)]
Moodle release 3.10

3 weeks agoMoodle release 3.10rc2 v3.10.0-rc2
Eloy Lafuente (stronk7) [Fri, 6 Nov 2020 21:56:08 +0000 (22:56 +0100)]
Moodle release 3.10rc2

3 weeks agoMDL-70137 cache: Write config to temp file and move into place
Andrew Nicols [Fri, 6 Nov 2020 07:07:57 +0000 (15:07 +0800)]
MDL-70137 cache: Write config to temp file and move into place

3 weeks agoMDL-70137 cache: Use sensible default when reading MUC config
Andrew Nicols [Fri, 6 Nov 2020 07:27:46 +0000 (15:27 +0800)]
MDL-70137 cache: Use sensible default when reading MUC config

When we read the MUC configuration, a file which exists but is empty
will not error, but will cause all configuration to be empty.

We already perform an {{is_array()}} check on the {{$configuration}}
variable, but the default value for {{$configuration}} is an empty
array. In the case where the file exists, but is empty, no errors occur
when the file is loaded, and the initial {{$configuration}} value is
not overwritten, leading to the file being replaced with an empty copy.

3 weeks agoMDL-70141 core_block: Web service set $PAGE url to avoid warnings
sam marshall [Fri, 6 Nov 2020 17:37:06 +0000 (17:37 +0000)]
MDL-70141 core_block: Web service set $PAGE url to avoid warnings

3 weeks agoMDL-70143 tool_uploaduser: fix wrong cache reference
Marina Glancy [Fri, 6 Nov 2020 17:07:24 +0000 (18:07 +0100)]
MDL-70143 tool_uploaduser: fix wrong cache reference

3 weeks agoMDL-70139 core_badges: fix invalid request when sending to backpack
Sara Arjona [Fri, 6 Nov 2020 14:15:45 +0000 (15:15 +0100)]
MDL-70139 core_badges: fix invalid request when sending to backpack

Having mixed $data in badge exporters is causing some issues.
As all these exporters are using $data as an object, $data can be
converted to object in the constructor, to avoid errors and get
the expected behaviour always.

3 weeks agoMDL-70072 core: Fix always displaying date in Gregorian
Shamim Rezaie [Fri, 6 Nov 2020 08:21:17 +0000 (19:21 +1100)]
MDL-70072 core: Fix always displaying date in Gregorian

3 weeks agoMDL-70130 core: Compare realpaths for file attachment checks
Andrew Nicols [Fri, 6 Nov 2020 02:46:02 +0000 (10:46 +0800)]
MDL-70130 core: Compare realpaths for file attachment checks

Rather than using the provided path, the `realpath` must be used to
ensure that the use of symlinks in paths is normalised.

3 weeks agoMDL-70130 core: Simplify attachment handling in email_to_suer
Andrew Nicols [Fri, 6 Nov 2020 02:50:56 +0000 (10:50 +0800)]
MDL-70130 core: Simplify attachment handling in email_to_suer

3 weeks agoMDL-70130 core: allow to attach files from localrequestdir to emails
Marina Glancy [Thu, 5 Nov 2020 16:01:54 +0000 (17:01 +0100)]
MDL-70130 core: allow to attach files from localrequestdir to emails

Co-authored-by: Paul Holden <paulh@moodle.com>
3 weeks agoMDL-70131 cli: only allow to negate existing keys
Marina Glancy [Thu, 5 Nov 2020 17:10:13 +0000 (18:10 +0100)]
MDL-70131 cli: only allow to negate existing keys

4 weeks agoMoodle release 3.10rc1 v3.10.0-rc1
Eloy Lafuente (stronk7) [Thu, 5 Nov 2020 11:16:53 +0000 (12:16 +0100)]
Moodle release 3.10rc1

4 weeks agoMDL-70023 core_course: improve performance of recently accessed courses
Marina Glancy [Mon, 26 Oct 2020 11:23:23 +0000 (12:23 +0100)]
MDL-70023 core_course: improve performance of recently accessed courses

4 weeks agoMDL-70075 core: Autocomplete selection should always have an active item
Andrew Nicols [Wed, 4 Nov 2020 03:24:04 +0000 (11:24 +0800)]
MDL-70075 core: Autocomplete selection should always have an active item

Ensure that there is always one active element in the list of selected
autocomplete elements.

Without this we have issues beacuse clicking on the link makes the first
one active if one is not already active, and this turns a click event
into a drag event, which means that it is not deleted.

4 weeks agoMDL-70075 core: Do not return a value in an event handler
Andrew Nicols [Mon, 2 Nov 2020 07:42:38 +0000 (15:42 +0800)]
MDL-70075 core: Do not return a value in an event handler

Returning a value of `false` in an event handler has the effect of
calling event.preventDefault() and event.stopPropagation().

This is neither obvious, nor desirable in this situation.

4 weeks agoMDL-70075 core: jQuery.attr() does not accept a bool value
Andrew Nicols [Mon, 2 Nov 2020 07:42:13 +0000 (15:42 +0800)]
MDL-70075 core: jQuery.attr() does not accept a bool value

The documented values that jQuery.attr() accepts are String, Number, or
null. For some reason, when we pass a Boolean value, the subsequent
click handler does not work in some situations.

Changing this to take a Number, and unsetting it when empty, resolves
this issue.

4 weeks agoMDL-70075 core: Listen for `change` in accessibleChange event
Andrew Nicols [Mon, 2 Nov 2020 01:33:05 +0000 (09:33 +0800)]
MDL-70075 core: Listen for `change` in  accessibleChange event

The accessibleChange custom interaction event was only listening for
blur and focus, however some OS/browser combinations do not emit these
events until the element is explicitly blurred. This is notably
different on Firefox on some Operating Systems.

Recent changes in MDL-68167 explicitly moved the user participants page
filter module to use the accessibleChange event, which means that the
selections are now only triggered on an explicit blur when using
Firefox. This highlight a bug whereby, when the mouse is used to make a
selection, the event is not triggered until the element is blurred.

This change modifies the accessibleChange event to ignore the `change`
event where it was triggered by the keyboard and where that keybaord
event was not a [return] or [escape] keypress, but to otherwise respect
the native change event.

4 weeks agoMDL-70075 core: Listen for the `focus` and `blur` events again
Andrew Nicols [Mon, 2 Nov 2020 00:12:22 +0000 (08:12 +0800)]
MDL-70075 core: Listen for the `focus` and `blur` events again

The `blur` event does not bubble, but the `focusout` events are not
available in all supported versions of Firefox.

Rather than switching event, this patch using event capture to
effectively achieve the same result and bubble the event up through the
DOM to the delegated listener.

There should be no functional change with this patch, except to support
Firefox fully.

4 weeks agoMDL-70114 mod_data: add border for to textarea
Bas Brands [Wed, 4 Nov 2020 13:21:57 +0000 (13:21 +0000)]
MDL-70114 mod_data: add border for to textarea

4 weeks agoMDL-70120 assignfeedback_editpdf: Stamp files should be cached
Brendan Heywood [Wed, 4 Nov 2020 11:42:21 +0000 (22:42 +1100)]
MDL-70120 assignfeedback_editpdf: Stamp files should be cached

4 weeks agoMDL-70119 core_badges: fix tab names
Ferran Recio [Wed, 4 Nov 2020 11:48:09 +0000 (12:48 +0100)]
MDL-70119 core_badges: fix tab names

4 weeks agoMDL-70066 badges: change usages of array_key_exists to isset
Simey Lameze [Thu, 29 Oct 2020 23:17:43 +0000 (07:17 +0800)]
MDL-70066 badges: change usages of array_key_exists to isset

4 weeks agoMDL-70106 cache: Set icon localstorage cache to use theme localisation
Peter Burnett [Tue, 3 Nov 2020 00:59:21 +0000 (10:59 +1000)]
MDL-70106 cache: Set icon localstorage cache to use theme localisation

4 weeks agoMDL-69955 qtype_ddimageortext: drop zone disappear in special case
Huong Nguyen [Mon, 2 Nov 2020 02:54:22 +0000 (09:54 +0700)]
MDL-69955 qtype_ddimageortext: drop zone disappear in special case

4 weeks agoMDL-70112 drag-drop qtypes: fix form preview
Tim Hunt [Tue, 3 Nov 2020 21:25:51 +0000 (21:25 +0000)]
MDL-70112 drag-drop qtypes: fix form preview

4 weeks agoMDL-70089 versions: main version bump
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 18:38:27 +0000 (19:38 +0100)]
MDL-70089 versions: main version bump

4 weeks agoMDL-70089 versions: bump all versions and requires near release
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 18:34:52 +0000 (19:34 +0100)]
MDL-70089 versions: bump all versions and requires near release

version = 2020110900 release version
requires= 2020110300 current beta+ (week6roll1) version

Note that, because we are under parallel development period,
this is being done in the branch that is going to be released
(MOODLE_310_STABLE already existing) for Moodle 3.10.0 and
not in master, that is the one getting the bump under normal
(non-parallel) periods.

4 weeks agoMDL-67837 backup: Add unit tests
Mihail Geshoski [Tue, 22 Sep 2020 08:09:59 +0000 (16:09 +0800)]
MDL-67837 backup: Add unit tests

4 weeks agoMDL-67837 backup: Verify caps before unenrolling users on course restore
Mihail Geshoski [Tue, 22 Sep 2020 08:09:35 +0000 (16:09 +0800)]
MDL-67837 backup: Verify caps before unenrolling users on course restore

4 weeks agoMDL-69844 user: Fix no email in download_participants_table
andreasschenkel [Mon, 12 Oct 2020 09:06:12 +0000 (11:06 +0200)]
MDL-69844 user: Fix no email in download_participants_table

Only include eMail in download_participants_table
if selected in showuseridentity
($identityfieldsselect)

4 weeks agoMDL-67015 mod_data: Prevent users adding entries to other groups
Juan Leyva [Mon, 28 Sep 2020 16:55:25 +0000 (18:55 +0200)]
MDL-67015 mod_data: Prevent users adding entries to other groups

4 weeks agoMDL-69046 core_contentbank: Escape quotes when showing name
Amaia Anabitarte [Tue, 15 Sep 2020 13:55:37 +0000 (15:55 +0200)]
MDL-69046 core_contentbank: Escape quotes when showing name

4 weeks agoMDL-69378 tool_uploadcourse: fix enrolment methods uploads
Ferran Recio [Wed, 19 Aug 2020 16:16:46 +0000 (18:16 +0200)]
MDL-69378 tool_uploadcourse: fix enrolment methods uploads

4 weeks agoMDL-56310 restore: Confirm user has permission to change capabilities
Peter Dias [Wed, 9 Sep 2020 05:50:21 +0000 (13:50 +0800)]
MDL-56310 restore: Confirm user has permission to change capabilities

4 weeks agoon-demand release 3.10beta+
Eloy Lafuente (stronk7) [Tue, 3 Nov 2020 11:23:48 +0000 (12:23 +0100)]
on-demand release 3.10beta+

4 weeks agoMDL-70100 theme_boost: quiztimer zindex fix
Bas Brands [Mon, 2 Nov 2020 11:29:23 +0000 (11:29 +0000)]
MDL-70100 theme_boost: quiztimer zindex fix

4 weeks agoMDL-68749 theme: Fix bootstrap toggle switches in RTL layout
Michael Hawkins [Tue, 3 Nov 2020 06:47:58 +0000 (14:47 +0800)]
MDL-68749 theme: Fix bootstrap toggle switches in RTL layout

Co-authored-by: Bas Brands <bas@moodle.com>
4 weeks agoMDL-70033 course: Update download content event handling for Classic
Michael Hawkins [Tue, 27 Oct 2020 10:51:28 +0000 (18:51 +0800)]
MDL-70033 course: Update download content event handling for Classic

4 weeks agoMDL-70033 core: Update tree.js event handlers to replace stopPropagation
Michael Hawkins [Tue, 27 Oct 2020 10:47:01 +0000 (18:47 +0800)]
MDL-70033 core: Update tree.js event handlers to replace stopPropagation

Also added support to allow links to override action keys (enter/space)

Co-authored-by: Andrew Nicols <andrew@nicols.co.uk>
4 weeks agoMDL-70081 airnotifier: Add missing device type in token registration
Juan Leyva [Sat, 31 Oct 2020 12:07:30 +0000 (13:07 +0100)]
MDL-70081 airnotifier: Add missing device type in token registration

4 weeks agoMDL-70093 dataformat_pdf: Fix row height calculation with high cells
Mikhail Golenkov [Mon, 2 Nov 2020 03:46:17 +0000 (14:46 +1100)]
MDL-70093 dataformat_pdf: Fix row height calculation with high cells

4 weeks agoMDL-70059 core_badges: avoid duplicate key error
Sara Arjona [Thu, 29 Oct 2020 17:25:16 +0000 (18:25 +0100)]
MDL-70059 core_badges: avoid duplicate key error

When 2 or more backpack were created without credentials,
a "Duplicate key value violates unique constraint" error
was raised because externalbackpackid was not taking the
correct value.
Other improvements have been done to the code too in order
to make it more readable.

4 weeks agoMDL-70067 theme_classic: Use col-12 as col-xs-12 was removed in BS4
Alexander [Sun, 1 Nov 2020 20:02:44 +0000 (09:02 +1300)]
MDL-70067 theme_classic: Use col-12 as col-xs-12 was removed in BS4

4 weeks agoMDL-70073 badges: Fix the backpack-add to match current master
Peter Dias [Sun, 1 Nov 2020 14:33:28 +0000 (22:33 +0800)]
MDL-70073 badges: Fix the backpack-add to match current master

4 weeks agoMDL-69975 core: Fix paths longer than 260 chars on windows
Brendan Heywood [Wed, 28 Oct 2020 05:08:11 +0000 (16:08 +1100)]
MDL-69975 core: Fix paths longer than 260 chars on windows

Also, ensure that remove_dir() only processes directories,
because sometimes it was being called by shutdown managers
with files, leading to PHP warnings.

Co-authored-by: Eloy Lafuente (stronk7) <stronk7@moodle.org>
Co-authored-by: Jun Pataleta <jun@moodle.com>
4 weeks agoMDL-70074 mod_lti: add authorization_endpoint
Claude Vervoort [Fri, 30 Oct 2020 19:57:15 +0000 (15:57 -0400)]
MDL-70074 mod_lti: add authorization_endpoint

4 weeks agoMDL-69973 xmldb: Ensure all reports use fresh metadata (not cached)
Eloy Lafuente (stronk7) [Sun, 18 Oct 2020 09:59:59 +0000 (11:59 +0200)]
MDL-69973 xmldb: Ensure all reports use fresh metadata (not cached)

4 weeks agoMDL-69973 xmldb: Fix problem with MariaDB >= 10.2.7 metadata defaults
Eloy Lafuente (stronk7) [Sun, 18 Oct 2020 09:53:37 +0000 (11:53 +0200)]
MDL-69973 xmldb: Fix problem with MariaDB >= 10.2.7 metadata defaults

With MariaDB 10.2.7 the driver was incorrectly returning '' (empty
string) as default for all the columns having null (meaning, no
default).

Also, cover the case in unit tests, it seems that we were already
testing other defaults but not the null case.

4 weeks agoMDL-68349 auth_db: user_created event should be triggered later
Marina Glancy [Mon, 6 Apr 2020 10:36:09 +0000 (12:36 +0200)]
MDL-68349 auth_db: user_created event should be triggered later

4 weeks agoon-demand release 3.10beta+
Eloy Lafuente (stronk7) [Fri, 30 Oct 2020 12:49:20 +0000 (13:49 +0100)]
on-demand release 3.10beta+

4 weeks agoMDL-68167 lib: autocomplete focos should not be removed on blur
Shamim Rezaie [Thu, 29 Oct 2020 15:54:38 +0000 (02:54 +1100)]
MDL-68167 lib: autocomplete focos should not be removed on blur

See https://www.w3.org/TR/wai-aria-practices-1.1/examples/listbox/listbox-rearrangeable.html

4 weeks agoMDL-68167 lib: Do not set aria-expanded if it should not be set
Shamim Rezaie [Thu, 29 Oct 2020 17:59:40 +0000 (04:59 +1100)]
MDL-68167 lib: Do not set aria-expanded if it should not be set

4 weeks agoMDL-68167 user: Fix missing label for participants filter input fields
Shamim Rezaie [Thu, 29 Oct 2020 17:51:08 +0000 (04:51 +1100)]
MDL-68167 user: Fix missing label for participants filter input fields

4 weeks agoMDL-68167 lib: Clear single-select autocomplete elements with keyboard
Shamim Rezaie [Thu, 29 Oct 2020 13:39:05 +0000 (00:39 +1100)]
MDL-68167 lib: Clear single-select autocomplete elements with keyboard

Following MDL-57680, it should be possible to clear the selected option
using keyboard as well.