Shamim Rezaie [Fri, 12 Aug 2022 01:52:57 +0000 (11:52 +1000)]
weekly release 3.11.8+
Brendan Heywood [Thu, 4 Aug 2022 11:16:18 +0000 (21:16 +1000)]
MDL-75375 cache: Fix file store path cleaning
Ilya Tregubov [Fri, 5 Aug 2022 04:29:20 +0000 (08:29 +0400)]
weekly release 3.11.8+
Simey Lameze [Fri, 29 Jul 2022 03:24:00 +0000 (11:24 +0800)]
MDL-74211 behat: convert few more steps to use new data generators
Andrew Nicols [Thu, 4 Aug 2022 02:04:12 +0000 (10:04 +0800)]
MDL-74492 editor_atto: Comment the regex change
Noel De Martin [Wed, 4 May 2022 15:09:29 +0000 (17:09 +0200)]
MDL-74655 competency: Implement behat generators
Amaia Anabitarte [Mon, 4 Jul 2022 10:49:21 +0000 (12:49 +0200)]
MDL-74475 core_badges: Behat test using new step
Amaia Anabitarte [Mon, 11 Apr 2022 10:36:38 +0000 (12:36 +0200)]
MDL-74475 behat: Option to jump to course edit page
Tim Hunt [Tue, 3 May 2022 19:40:08 +0000 (20:40 +0100)]
MDL-74636 behat: step to skip this scenario if a plugin isn't installed
Philipp Imhof [Fri, 29 Jul 2022 06:36:38 +0000 (08:36 +0200)]
MDL-74492 editor_atto: <line> tags should not be confused with <li> tags
Simey Lameze [Fri, 29 Jul 2022 02:33:59 +0000 (10:33 +0800)]
MDL-74211 behat: replace steps to use new categories page type
Simey Lameze [Fri, 29 Jul 2022 01:18:15 +0000 (09:18 +0800)]
MDL-74211 behat: add course question categories page type
Simey Lameze [Mon, 18 Jul 2022 23:03:03 +0000 (07:03 +0800)]
MDL-74211 quiz: make use of question data generators
Jun Pataleta [Fri, 29 Jul 2022 02:56:47 +0000 (10:56 +0800)]
weekly release 3.11.8+
Angelia Dela Cruz [Tue, 28 Jun 2022 07:52:43 +0000 (15:52 +0800)]
MDL-75080 behat: Chat behat generators use UI
Replace steps that manually add Chat instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
Andrew Nicols [Tue, 19 Jul 2022 04:37:49 +0000 (12:37 +0800)]
MDL-75244 form: Change checker should check existence of tinyMCE API
The window.tinyMCE.editors API was present in version 3 of TinyMCE, but
is not present in later versions. As a result, this check tries to loop
over a variable which does not exist and throws an error in the process.
We should check that window.tinyMCE *and* window.tinyMCE.editors both
exist before attempting to loop over them.
Simey Lameze [Tue, 24 Jul 2018 02:35:30 +0000 (10:35 +0800)]
MDL-62959 calendar: add behat to test event type changing
Simey Lameze [Tue, 24 Jul 2018 01:28:49 +0000 (09:28 +0800)]
MDL-62959 calendar: fix event data mapping for group id
Huong Nguyen [Tue, 26 Jul 2022 04:21:36 +0000 (11:21 +0700)]
MDL-72430 Calendar: Fix admin cannot edit course event
Paul Holden [Mon, 25 Jul 2022 19:02:14 +0000 (20:02 +0100)]
MDL-74895 h5p: more resilient error handling during content fetching.
On new installs, the task for downloading new H5P content types would
throw exceptions and exit when encountering unexpected and/or missing
data.
Angelia Dela Cruz [Mon, 7 Mar 2022 06:36:06 +0000 (14:36 +0800)]
MDL-74057 behat: SCORM behat generators use UI
Replace steps that manually add SCORM instances via the UI and use
Behat generators. This improves the speed of Behat test runs.
Philipp Imhof [Tue, 14 Jun 2022 12:49:12 +0000 (14:49 +0200)]
MDL-74974 quiz override mark: do not hide_all_feedback
(backport of MDL-74495)
Thong Bui [Wed, 29 Jun 2022 07:28:14 +0000 (14:28 +0700)]
MDL-74766 html_editor: Fix form is submitted as an empty string
Ilya Tregubov [Thu, 21 Jul 2022 17:29:58 +0000 (21:29 +0400)]
weekly release 3.11.8+
Ilya Tregubov [Thu, 21 Jul 2022 17:29:56 +0000 (21:29 +0400)]
NOBUG: Fixed SVG browser compatibility
Christina Thee Roperto [Mon, 18 Jul 2022 12:46:01 +0000 (22:46 +1000)]
MDL-72349 filelib: update strip_double_headers function
Eloy Lafuente (stronk7) [Wed, 13 Jul 2022 21:44:16 +0000 (23:44 +0200)]
MDL-75208 oracle: Amend a couple of queries to make Oracle happy
The changes introduced here are completely safe, just we stop
binding SITEID and, instead, embed it in the SQL.
Why? Because Oracle 21 has started to return non-sense results
when SITEID is bound.
After lots of tests, attempts, debugging... we have been unable
to find any logic to the need of this change and also, have been
unable to reproduce the problem with a standalone script that
pretty much runs the same queries that the ones changed here.
I'm sure that there is something, somewhere, but have failed
to find it, grrr.
Please read MDL-75208 and linked issues to find more information
about this problem, that is one of the biggest mysteries I've
seen recently. Maybe at the end there is a tiny detail that
explains it all, but it's really well hidden.
Angelia Dela Cruz [Mon, 17 Jan 2022 09:47:48 +0000 (17:47 +0800)]
MDL-73788 behat: URL behat generators use UI
Replace steps that manually add URL instances via the UI and use
Behat generators. This improves the speed of Behat test runs.
Jake Dallimore [Tue, 14 Jun 2022 02:55:52 +0000 (10:55 +0800)]
MDL-68843 enrol_lti: auto disable orphaned enrolment instances
- pre_course_module_deletion hook to disable on mod delete
- upgrade step dealing with legacy orphaned records
Jake Dallimore [Fri, 27 May 2022 05:51:38 +0000 (13:51 +0800)]
MDL-68843 enrol_lti: add deleted activity warning to published tools
Adds a warning to the 'name' column of the tables, letting teachers know
that the activity exposed by the method has been deleted and what their
options are.
AMOS bot [Sat, 16 Jul 2022 00:08:03 +0000 (00:08 +0000)]
Automatically generated installer lang files
Denis Brat [Tue, 15 Dec 2020 18:00:14 +0000 (15:00 -0300)]
MDL-69251 enrol_lti: fix sync_members task inconsistent internal state
Marty [Thu, 9 Dec 2021 21:34:54 +0000 (16:34 -0500)]
MDL-73332 mustache: Fix shortentext helper
In the docs, it claims you can provide length to
the shortentext template helper as a context variable.
In reality, that is not the case.
Víctor Déniz [Thu, 14 Jul 2022 11:06:12 +0000 (12:06 +0100)]
weekly release 3.11.8+
Srdjan [Mon, 30 May 2022 07:52:17 +0000 (17:52 +1000)]
MDL-74681 lib/dml: moodle_read_slave_trait: written table timestamping
Moved written table timestamping from query_start() to query_end():
We are adjusting table last written times at the end of transaction.
That does not apply to immediate database writes that are not performed
within transaction. This change is to set last written time after the query
has finished for such writes, rather than before it started. That way
long write operations cannot spill over the latency parameter.
AMOS bot [Tue, 12 Jul 2022 00:07:59 +0000 (00:07 +0000)]
Automatically generated installer lang files
Jake Dallimore [Mon, 11 Jul 2022 05:25:40 +0000 (13:25 +0800)]
MDL-74947 mod_lti: remove text validation from password field
This is a password field so should not be cleaned.
Johannes Burk [Wed, 29 Jun 2022 08:26:40 +0000 (10:26 +0200)]
MDL-75083 login: prevent double submission
Apply core_form/submit JavaScript code to prevent double submission of login form and guest login button.
Add ID to guest login button to make it addressable.
Paul Holden [Mon, 21 Mar 2022 17:43:20 +0000 (17:43 +0000)]
MDL-74282 grade: omit outcomes report if outcomes aren't enabled.
Jake Dallimore [Fri, 8 Jul 2022 03:28:39 +0000 (11:28 +0800)]
Moodle release 3.11.8
Eloy Lafuente (stronk7) [Thu, 7 Jul 2022 18:46:59 +0000 (20:46 +0200)]
MDL-71747 environment: Ensure that check_xmlrpc_usage is in >=39
This is a partial backport of MDL-73270 to ensure that the
check_xmlrpc_usage custom check is present in all the supported
branches and it's applied to all branches able to run php80:
- MOODLE_311_STABLE
- MOODLE_400_STABLE
- master (aka, 4.1 and up)
Note that the whole patch has not been backported, only the
environmental check (xml file and check implementation).
Eloy Lafuente (stronk7) [Thu, 2 Jun 2022 23:52:52 +0000 (01:52 +0200)]
MDL-71747 environment: Apply agreed changes
- PHP 7.4 required.
- Moodle 3.9 required.
- MariaDB 10.4 required.
- PostgreSQL 12 required.
- Oracle 19c required.
Eloy Lafuente (stronk7) [Thu, 2 Jun 2022 23:48:25 +0000 (01:48 +0200)]
MDL-71747 environment: 4.1 base information
This is a direct copy of the 4.0 information, to
have the changes under control in the next commit.
Jun Pataleta [Thu, 7 Jul 2022 13:33:10 +0000 (21:33 +0800)]
weekly release 3.11.7+
Shamim Rezaie [Thu, 7 Jul 2022 06:01:18 +0000 (16:01 +1000)]
MDL-56923 gradingform_guide: Fix icon positioning in RTL
stevando [Fri, 1 Jul 2022 05:15:56 +0000 (13:15 +0800)]
MDL-72171 tool_mobile: Ensure auto login URL is always local
Adrian Greeve [Mon, 4 Jul 2022 06:59:40 +0000 (14:59 +0800)]
MDL-69400 mod_forum: Added calender event refreshing.
Mihail Geshoski [Fri, 24 Jun 2022 05:52:36 +0000 (13:52 +0800)]
MDL-71921 scorm: Sanitize element names before outputting track details
Alex Morris [Wed, 22 Jun 2022 07:31:05 +0000 (19:31 +1200)]
MDL-75044 assignfeedback_editpdf: Add SAFER option to GS command
Adds the SAFER option to the Ghostscript command to limit interaction
with IO and OS commands
Huong Nguyen [Fri, 6 May 2022 05:21:39 +0000 (12:21 +0700)]
MDL-72029 Lesson: Prevent arbitrary file read when importing lesson questions in blackboard format
Huong Nguyen [Fri, 6 May 2022 04:30:15 +0000 (11:30 +0700)]
MDL-72029 lib: Prevent path traversal for clean_param with PARAM_SAFEPATH
Laurent David [Mon, 16 May 2022 05:35:21 +0000 (07:35 +0200)]
MDL-74473 core_analytics: Upgrade ML Backend to 2.6.6
Jake Dallimore [Thu, 12 May 2022 03:36:33 +0000 (11:36 +0800)]
MDL-72299 mod_lti: fix html escaping when reposting cross site posts
Mihail Geshoski [Wed, 6 Jul 2022 02:17:04 +0000 (10:17 +0800)]
MDL-74813 filepicker: Replace the dnd gif animation with a static icon
Laurent David [Tue, 14 Jun 2022 06:53:56 +0000 (08:53 +0200)]
MDL-74821 mod_feedback: Fix HTML validator error
* Remove align attribute on table elements
* Fix dangling tr/td on multichoice rated
* Remove colspan as it is not used
AMOS bot [Tue, 5 Jul 2022 00:08:20 +0000 (00:08 +0000)]
Automatically generated installer lang files
Adam Olley [Mon, 4 Jul 2022 11:18:29 +0000 (20:48 +0930)]
MDL-75116 mod_feedback: Check array values exist before using them
Without this, the @list will emit a PHP warning under php8.0+ when the array
doesn't have a second element to assign.
Jun Pataleta [Mon, 4 Jul 2022 03:36:02 +0000 (11:36 +0800)]
MDL-74815 pix: Convert PNG version of darkened SVG icons
* Conversion was done using rsvg-convert from librsvg
Jun Pataleta [Mon, 4 Jul 2022 03:09:50 +0000 (11:09 +0800)]
MDL-74815 pix: Darken colour of grey icons
* Change the fill colour of grey icons from #999 to #888.
Eloy Lafuente (stronk7) [Tue, 21 Jun 2022 17:28:29 +0000 (19:28 +0200)]
MDL-74516 activities: Better handling of floats for gradepass fields
Note that in 311_STABLE the patch is different from the 400 and master
fixes. The API for grade_floatval() was only changed for 4.0 and up.
Hence, for this branch we are just:
- Changing the form definition to use proper "float" element (instead
of text + raw.
- Backporting the behat tests to verify that everything continues
working ok.
Also, in 311_STABLE, the workshop module did not have the grade
to pass completion condition, so we aren't modifying anything
in that activity for that branch.
Víctor Déniz [Fri, 1 Jul 2022 10:28:48 +0000 (11:28 +0100)]
weekly release 3.11.7+
Marina Glancy [Thu, 14 Apr 2022 09:45:43 +0000 (11:45 +0200)]
MDL-74502 behat: when setting a field value it may not be visible
for example in case of editor field, the textarea element is hidden by wysiwyg widget but we still need to be able to set it
David Mudrák [Thu, 30 Jun 2022 20:10:57 +0000 (22:10 +0200)]
MDL-75008 lang: Use the fixed strings in Behat scenario files
Helen Foster [Thu, 30 Jun 2022 20:05:42 +0000 (22:05 +0200)]
MDL-75008 lang: Import fixed English strings (en_fix)
Noel De Martin [Thu, 30 Jun 2022 09:26:27 +0000 (11:26 +0200)]
MDL-74613 grade: Fix undefined behat step
Andrew Nicols [Thu, 30 Jun 2022 01:49:32 +0000 (09:49 +0800)]
MDL-74379 core: Update date_format_string to use x-os functions
Jun Pataleta [Thu, 23 Jun 2022 06:36:11 +0000 (14:36 +0800)]
MDL-75055 templates: Apply .alert-dismissible class
- Apply the .alert-dismissible class for notification alerts with
close button to fix its positioning. As an added bonus, the
.alert-dismissible class also enlarges the clickable area of the
close button which is great for accessibility.
- Improve example context for the notification alerts templates.
Jun Pataleta [Thu, 23 Jun 2022 06:32:36 +0000 (14:32 +0800)]
MDL-75055 theme_boost: Darken close button colour in notification alerts
This is in order for the close button to have a good contrast against
the alert background and meet the minimum Level AA contrast ratio of 3:1
Anastasios Bithas [Tue, 7 Dec 2021 18:32:53 +0000 (20:32 +0200)]
MDL-73305 mod_folder: Download Folder in a mlang formated folder
Alfonso Salces [Tue, 12 Apr 2022 10:26:59 +0000 (12:26 +0200)]
MDL-74674 core: create notification generators
Noel De Martin [Tue, 28 Jun 2022 16:01:33 +0000 (18:01 +0200)]
MDL-75084 blog: Implement behat generators
Cameron Ball [Wed, 11 May 2022 07:50:25 +0000 (15:50 +0800)]
MDL-74548 backup: Deprecate get/set copy from base controller
Cameron Ball [Wed, 11 May 2022 07:21:04 +0000 (15:21 +0800)]
MDL-74548 backup: Deprecate core_backup\copy\copy
Cameron Ball [Thu, 12 May 2022 01:53:53 +0000 (09:53 +0800)]
MDL-74548 backup: Unit tests for course copy refactor
Cameron Ball [Wed, 11 May 2022 07:10:14 +0000 (15:10 +0800)]
MDL-74548 backup: Refactor course copies
This patch modifies the way copy data is shared in order to mitigate potential race conditions
and ensure that the serialised controller stored in the DB is always in a valid state.
The restore controller is now considered the "source of truth" for all information about the
copy operation. Backup controllers can no longer contain information about course copies.
As copy creation is not atomic, it is still possible for copy controllers to become orphaned or
exist in an invalid state. To mitigate this the backup cleanup task has been modified to call
a new helper method copy_helper::cleanup_orphaned_copy_controllers.
Summary of changes in this patch:
- Copy data must now be passed through the restore controller's constructor
- base_controller::get_copy has been deprecated in favour of restore_controller::get_copy
- base_controller::set_copy has been deprecated without replacement
- core_backup\copy\copy has been deprecated, use copy_helper.class.php's copy_helper instead
- backup_cleanup_task will now clean up orphaned controllers from copy operations that went awry
Thanks to Peter Burnett for assiting with testing this patch.
Dani Palou [Fri, 27 May 2022 10:06:05 +0000 (12:06 +0200)]
MDL-74864 forum: Allow specifying group in discussions generator
Aya Saad [Sun, 29 May 2022 08:43:55 +0000 (10:43 +0200)]
MDL-74781 search: Fix heading repetition in global search page
Aya Saad [Sun, 29 May 2022 10:04:48 +0000 (12:04 +0200)]
MDL-74379 language: injecting am/pm in date string
patching the date_format_string() function in moodlelib to add am/pm for languages that don't suuport it.
Shamim Rezaie [Fri, 24 Jun 2022 04:21:51 +0000 (14:21 +1000)]
MDL-74741 javascript: Set the role of d&d links to button
Shamim Rezaie [Fri, 24 Jun 2022 04:15:45 +0000 (14:15 +1000)]
MDL-74741 javascript: A11y fix for dialogues visible from beginning
Jun Pataleta [Fri, 24 Jun 2022 03:59:10 +0000 (11:59 +0800)]
weekly release 3.11.7+
Simey Lameze [Tue, 14 Jun 2022 02:51:30 +0000 (10:51 +0800)]
MDL-68867 calendar: remove dependency on USER->groupmember hack
Eloy Lafuente (stronk7) [Fri, 10 Jun 2022 13:15:37 +0000 (15:15 +0200)]
MDL-73212 gha: Allow parameters to be passed via secret
We are disabling the -v (verbose) option, used by default. Still,
now we support a secret (that can be added to everyone's repository)
to accept any PHPUnit's command line options and run the tests with
them.
Some examples:
phpunit_options = -v (to keep the verbose option enabled)
phpunit_options = --testdox (to print information about every test...)
... (basically anything supported by the CLI)
Also, we are raising here the environment from Ubuntu 18.04 to 20.04
(self tested by GHA, heh)
Jun Pataleta [Tue, 21 Jun 2022 04:24:42 +0000 (12:24 +0800)]
MDL-74812 gradingform_rubric: Add radiogroup role properly
Do not add the radiogroup role to the rubric criterion when the rubric
table is being displayed on edit or preview modes.
Jun Pataleta [Mon, 20 Jun 2022 10:46:54 +0000 (18:46 +0800)]
MDL-74812 gradingform_rubric: Fix text overlap in rubric levels
Jun Pataleta [Mon, 20 Jun 2022 10:10:14 +0000 (18:10 +0800)]
MDL-74812 gradingform_rubric: Do not use deprecated width attribute
Use inline CSS style to define level width instead.
Jun Pataleta [Fri, 17 Jun 2022 16:56:44 +0000 (00:56 +0800)]
MDL-74812 gradingform_rubric: Fix contrast issues in rubric table
* Darken the score value using the green theme colour
* Use a light green theme colour for selection backgrounds
* Unify rubric styles related to background and text colour within the
criteria.
AMOS bot [Tue, 21 Jun 2022 00:09:39 +0000 (00:09 +0000)]
Automatically generated installer lang files
Daniil Fajnberg [Tue, 4 Jan 2022 15:40:01 +0000 (15:40 +0000)]
MDL-73498 mod_lti: iframe allowed domain fixed
Paul Holden [Tue, 3 May 2022 09:07:15 +0000 (10:07 +0100)]
MDL-69939 webservice: correct AJAX bool value in services definition.
Eloy Lafuente (stronk7) [Mon, 13 Jun 2022 10:27:57 +0000 (12:27 +0200)]
MDL-74358 availability: Avoid php8 problem with array_values(null)
Jun Pataleta [Fri, 17 Jun 2022 07:30:35 +0000 (15:30 +0800)]
weekly release 3.11.7+
Jun Pataleta [Thu, 16 Jun 2022 09:44:04 +0000 (17:44 +0800)]
MDL-72324 core: Add upgrade.txt note about $plugin->incompatible
Simey Lameze [Fri, 17 Jun 2022 01:50:38 +0000 (09:50 +0800)]
MDL-72292 core: add param type and polishing
Alexander Bias [Mon, 31 Jan 2022 12:02:04 +0000 (13:02 +0100)]
MDL-72292 core: Check if fulldir is set when loading renamed classes
Marina Glancy [Tue, 14 Jun 2022 11:27:01 +0000 (13:27 +0200)]
MDL-74972 core_form: frozen autocomplete element does not display values
Paul Holden [Tue, 5 Apr 2022 22:49:01 +0000 (23:49 +0100)]
MDL-74287 forms: request changesmade string as required.
Unconditionally requesting the string was triggering exceptions
during installation, before the required external functions had
been populated.
Paul Holden [Tue, 5 Apr 2022 23:01:11 +0000 (00:01 +0100)]
MDL-74287 media_videojs: skip dynamic loader during install/upgrade.
Michael Milette [Wed, 24 Nov 2021 15:19:43 +0000 (10:19 -0500)]
MDL-73156 user: Custom user profile field names now filtered.
Paul Holden [Tue, 10 May 2022 07:26:47 +0000 (08:26 +0100)]
MDL-74713 admin: format custom profile fields in identify config.