moodle.git
5 days agoweekly release 3.11+ MOODLE_311_STABLE
abgreeve [Fri, 11 Jun 2021 05:52:12 +0000 (13:52 +0800)]
weekly release 3.11+

6 days agoMDL-68915 core_form: Fix the behat test failure
Sujith Haridasan [Thu, 10 Jun 2021 06:23:10 +0000 (11:53 +0530)]
MDL-68915 core_form: Fix the behat test failure

Fix the behat test failure for the forums when
grades exist.

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
6 days agoMDL-68915 lesson: Do not allow maxgrade change
Sujith Haridasan [Fri, 21 May 2021 06:03:45 +0000 (11:33 +0530)]
MDL-68915 lesson: Do not allow maxgrade change

Do not allow maxgrade change when some of the
users are already graded. As of now this is applicable
to the following activities:
1. Forum
2. Database
3. Lesson
4. Glossary

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
6 days agoAutomatically generated installer lang files
AMOS bot [Thu, 10 Jun 2021 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

7 days agoMDL-67975 nextcloud: Add support for Link to file
Sujith Haridasan [Mon, 5 Apr 2021 04:54:24 +0000 (10:24 +0530)]
MDL-67975 nextcloud: Add support for Link to file

This change set would bring the following new additions
to the nextcloud repo:
1. Create a new radio button in filepicker: "Link to file"
2. When user clicks this radio button a warning message
   would be created, saying this file would become public.
   Meaning a public link is created in the nextcloud server.
3. Created a sync_reference method to sync the files downloaded
   from nextcloud server. The sync/refresh time given is 1 day/24 hours.
4. Made sure that when the file is downloaded, we use the file
   from moodledata file pool.

Signed-off-by: Sujith Haridasan <sujith@moodle.com>
12 days agoMDL-71471 assign: Remove submission from queue when converted in web
Mikhail Golenkov [Fri, 4 Jun 2021 05:21:51 +0000 (15:21 +1000)]
MDL-71471 assign: Remove submission from queue when converted in web

12 days agoweekly release 3.11+
Eloy Lafuente (stronk7) [Thu, 3 Jun 2021 21:56:11 +0000 (23:56 +0200)]
weekly release 3.11+

13 days agoMDL-71559 core_user: Fields support for PROFILE_VISIBLE_TEACHERS
sam marshall [Wed, 12 May 2021 09:58:43 +0000 (10:58 +0100)]
MDL-71559 core_user: Fields support for PROFILE_VISIBLE_TEACHERS

13 days agoMDL-71741 portfolio: Reset header information between requests
Huong Nguyen [Fri, 28 May 2021 01:55:43 +0000 (08:55 +0700)]
MDL-71741 portfolio: Reset header information between requests

The reset process also removes the CURLFile option in the HTTP object,
which will avoid the serialisation issue on PHP7.4 and upward

13 days agoMDL-71741 portfolio: Use the correct configurations
Huong Nguyen [Fri, 28 May 2021 01:52:05 +0000 (08:52 +0700)]
MDL-71741 portfolio: Use the correct configurations

13 days agoMDL-71682 course: remove deprecated non-AJAX activity chooser call.
Paul Holden [Wed, 2 Jun 2021 19:55:20 +0000 (20:55 +0100)]
MDL-71682 course: remove deprecated non-AJAX activity chooser call.

The deprecated method to render the dropdown based activity chooser
from 430746d3 was still being called, which produced debugging on
the site when doing so.

2 weeks agoMDL-71838 quiz reports: average rows calc can run out of memory
Tim Hunt [Wed, 2 Jun 2021 15:06:32 +0000 (16:06 +0100)]
MDL-71838 quiz reports: average rows calc can run out of memory

Should not use get_records when you mean record_exists.

2 weeks agoMDL-71836 core_enrol: Cannot search for users by username
sam marshall [Wed, 2 Jun 2021 13:51:38 +0000 (14:51 +0100)]
MDL-71836 core_enrol: Cannot search for users by username

2 weeks agoMDL-71438 blocks: Add index on mdl_user_preferences.name
Mikhail Golenkov [Wed, 2 Jun 2021 12:12:40 +0000 (22:12 +1000)]
MDL-71438 blocks: Add index on mdl_user_preferences.name

2 weeks agoMDL-71832 core_admin: Browse users page, sort by custom field fails
sam marshall [Wed, 2 Jun 2021 11:03:35 +0000 (12:03 +0100)]
MDL-71832 core_admin: Browse users page, sort by custom field fails

The failure was because the sort parameter in URL is like
profile_field_xx, but PARAM_ALPHANUM strips the _ symbols.

2 weeks agoMDL-71668 editor_atto: Accissibility focus styling for Atto buttons
Shamim Rezaie [Mon, 31 May 2021 09:20:49 +0000 (19:20 +1000)]
MDL-71668 editor_atto: Accissibility focus styling for Atto buttons

Make all Atto buttons consistent in the way they show the focus outline

2 weeks agoMDL-65637 core_oauth2: Introduce a new custom linkedin oauth2 client
Peter Dias [Wed, 26 May 2021 01:58:21 +0000 (09:58 +0800)]
MDL-65637 core_oauth2: Introduce a new custom linkedin oauth2 client

2 weeks agoMDL-65637 core_oauth2: Create new oauth2 mapping function
Peter Dias [Thu, 27 May 2021 07:07:23 +0000 (15:07 +0800)]
MDL-65637 core_oauth2: Create new oauth2 mapping function

Separated userinfo mapping into a function and new unit test

2 weeks agoAutomatically generated installer lang files
AMOS bot [Sat, 29 May 2021 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

2 weeks agoMDL-71737 portfolio: Make is_valid_image become internal function
Huong Nguyen [Fri, 28 May 2021 08:03:41 +0000 (15:03 +0700)]
MDL-71737 portfolio: Make is_valid_image become internal function

2 weeks agoMDL-70846 accessibility: update color to increase contrast
Dongsheng Cai [Fri, 28 May 2021 02:34:12 +0000 (12:34 +1000)]
MDL-70846 accessibility: update color to increase contrast

2 weeks agoMDL-70846 accessibility: update tree attributes to pass a11y check
Dongsheng Cai [Tue, 25 May 2021 10:38:51 +0000 (20:38 +1000)]
MDL-70846 accessibility: update tree attributes to pass a11y check

- Move aria-* atrributes from <p> to <li>
- Move "role" attribute from <p> to <li>
- Update behat tests

Based on reference implementation from:
- https://www.w3.org/TR/wai-aria-practices-1.1/examples/treeview/treeview-2/treeview-2a.html
- https://www.w3.org/WAI/GL/wiki/Using_ARIA_trees

2 weeks agoMDL-71284 assign: prevent double escaping assignment name.
Luca Bösch [Wed, 31 Mar 2021 13:33:57 +0000 (15:33 +0200)]
MDL-71284 assign: prevent double escaping assignment name.

2 weeks agoMDL-71731 phpunit: isolate tests requiring lots of peak mem
Eloy Lafuente (stronk7) [Mon, 24 May 2021 18:41:22 +0000 (20:41 +0200)]
MDL-71731 phpunit: isolate tests requiring lots of peak mem

It's mostly addDocuments(), used by test_add_document_batch_large()
with 100 big documents what requires a lot of ram
although apparently, it's freed (partially) once ended.
Just the peak usage remains high. In any case, isolating that
test to avoid the non-freed side of it to consume too
much memory for the rest. (We allow "only" 2GB).

Still, I think that there is a good work about to detect which
tests are leaking / consuming too much, I'd bet there are
a bunch running completely out of control.

2 weeks agoMDL-71622 behat: use own fork of friends-of-behat/mink-extension
Eloy Lafuente (stronk7) [Thu, 13 May 2021 21:57:09 +0000 (23:57 +0200)]
MDL-71622 behat: use own fork of friends-of-behat/mink-extension

Upstream behat/mink-extension isn't updated since 2018.

So we switch to friends-of-behat/mink-extension until
upstream situation is clarified.

But friends-of-behat/mink-extension has some PHP8 issues
that, at the time of writting this, have not been solved:

- https://github.com/FriendsOfBehat/MinkExtension/pull/9

So we are temporarily changing to one fork:

https://github.com/moodlehq/MinkExtension

Whenever those issues are solved by friends-of-beha or behat
we will change back to them and remove our fork.

Generated with composer 2.x and PHP 7.3

2 weeks agoweekly release 3.11+
Sara Arjona [Thu, 27 May 2021 15:45:09 +0000 (17:45 +0200)]
weekly release 3.11+

2 weeks agoMDL-69703 theme_boost: ensure multi-select options take all space.
Paul Holden [Thu, 27 May 2021 09:44:10 +0000 (10:44 +0100)]
MDL-69703 theme_boost: ensure multi-select options take all space.

2 weeks agoMDL-71145 qtype_ddmarker: Fix Behat failure
Huong Nguyen [Thu, 27 May 2021 08:29:07 +0000 (15:29 +0700)]
MDL-71145 qtype_ddmarker: Fix Behat failure

2 weeks agoAutomatically generated installer lang files
AMOS bot [Thu, 27 May 2021 00:07:27 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoMDL-71637 core: Set default for mb_substitute_character
Peter Dias [Wed, 26 May 2021 05:51:46 +0000 (13:51 +0800)]
MDL-71637 core: Set default for mb_substitute_character

3 weeks agoMDL-64236 gradereport_grader: Add padding to content in grader report
Mihail Geshoski [Wed, 26 May 2021 05:33:07 +0000 (13:33 +0800)]
MDL-64236 gradereport_grader: Add padding to content in grader report

In certain operative systems the browser's scrollbar may partly cover
the content in the student header and user cells when horizontally
scrolling through the table contents. This is most noticeable when in
RTL mode. Adding slight padding on the left (or right in RTL mode) to
the content in these cells would fix this UI issue.

3 weeks agoMDL-71628 quiz: Quiz review: names not shown on Manual grading screens
Tien Nguyen [Fri, 14 May 2021 07:51:40 +0000 (14:51 +0700)]
MDL-71628 quiz: Quiz review: names not shown on Manual grading screens

3 weeks agoMDL-69703 theme_boost: remove right padding for multi-selects.
Paul Holden [Mon, 23 Nov 2020 23:19:42 +0000 (23:19 +0000)]
MDL-69703 theme_boost: remove right padding for multi-selects.

This removes the whitespace obscuring longer option elements when
selected, particularly on narrow screens.

3 weeks agoMDL-71462 core: Add phpstorm metadata file to gitignore
avi [Tue, 27 Apr 2021 12:08:59 +0000 (15:08 +0300)]
MDL-71462 core: Add phpstorm metadata file to gitignore

3 weeks agoAutomatically generated installer lang files
AMOS bot [Mon, 24 May 2021 00:07:26 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoAutomatically generated installer lang files
AMOS bot [Sun, 23 May 2021 00:07:23 +0000 (00:07 +0000)]
Automatically generated installer lang files

3 weeks agoMDL-71369 admin: Apply form change checker to admin/category view
Andrew Nicols [Mon, 19 Apr 2021 01:56:31 +0000 (09:56 +0800)]
MDL-71369 admin: Apply form change checker to admin/category view

3 weeks agoMDL-71145 qtype_ddmarker: Incorrect marker positions in responsive mode
Huong Nguyen [Mon, 12 Apr 2021 08:59:00 +0000 (15:59 +0700)]
MDL-71145 qtype_ddmarker: Incorrect marker positions in responsive mode

3 weeks agoMDL-60431 qtype_calculated: handle NAN and INF calculation outcomes
Jonathon Fowler [Wed, 5 May 2021 06:35:52 +0000 (16:35 +1000)]
MDL-60431 qtype_calculated: handle NAN and INF calculation outcomes

With significant-digits presentation mode, NAN would be formatted as
'NAN' followed by zeroes, which looks silly, and +INF would cause an
execution timeout as Moodle tries to divide +∞ by 10 until it becomes
less than 1, which can happen in a divide-by-zero situation.

Note that the user can't answer NAN or INF to any question, but at this
at least now looks consistent and also doesn't break Moodle in the case
of +INF.

3 weeks agoMDL-71693 admin: set default for debugdisplay to off.
Paul Holden [Thu, 20 May 2021 19:39:38 +0000 (20:39 +0100)]
MDL-71693 admin: set default for debugdisplay to off.

The previous default value for this config was based on the
PHP ini file `display_error` property (6349a3ba). However we
override this propertly during page setup (25338300) according
to the value of the configuration itself.

This had the effect of always setting the default value for
this config to it's current value.

3 weeks agoweekly release 3.11+
Sara Arjona [Thu, 20 May 2021 09:09:04 +0000 (11:09 +0200)]
weekly release 3.11+

3 weeks agoMDL-67771 theme: Add side-post to incourse views
Peter Dias [Thu, 20 May 2021 07:13:51 +0000 (15:13 +0800)]
MDL-67771 theme: Add side-post to incourse views

3 weeks agoMDL-68925 assignfeedback_editpdf: avoid hiding comments with a menu open
Mark Nelson [Mon, 12 Oct 2020 05:12:08 +0000 (15:12 +1000)]
MDL-68925 assignfeedback_editpdf: avoid hiding comments with a menu open

Co-authored by: Jonathon Fowler <fowlerj@usq.edu.au>

3 weeks agoMDL-71644 Quiz: The issues outstanding from MDL-70947.
Thong Bui [Tue, 18 May 2021 11:15:25 +0000 (18:15 +0700)]
MDL-71644 Quiz: The issues outstanding from MDL-70947.

Issue 1: While essay question's uploading progress, we need to disable submit
buttons to prevent submit form event.

Issue 2: Enable buttons after pressing cancel button on the popup
confirming overwrite file existed.

4 weeks agoMDL-71157 block_myoverview: remove wait from behat
Sara Arjona [Fri, 14 May 2021 13:57:54 +0000 (15:57 +0200)]
MDL-71157 block_myoverview: remove wait from behat

The step "And I wait until ".block_myoverview
[data-control='next']" "css_element" exists" is not correct
because this [data-control='next'] element exists before and
after the step so, in some cases, it might cause the following
step will start earlier than expected.
As pending JS has been added, this wait steps are not required
any more.

4 weeks agoMDL-71157 core: Pending JS in paged content bars
Andrew Nicols [Tue, 18 May 2021 00:56:23 +0000 (08:56 +0800)]
MDL-71157 core: Pending JS in paged content bars

4 weeks agoMDL-71373 tool_usertours: localize "previous"/"next" in user tours.
Luca Bösch [Wed, 19 May 2021 07:28:11 +0000 (09:28 +0200)]
MDL-71373 tool_usertours: localize "previous"/"next" in user tours.

       AMOS BEGIN
        CPY [previous,core],[previousstep,tool_usertours]
        CPY [next,core],[nextstep,tool_usertours]
       AMOS END

4 weeks agoMDL-71373 core_enrol: localize "close" in role manager.
Luca Bösch [Tue, 20 Apr 2021 05:56:59 +0000 (07:56 +0200)]
MDL-71373 core_enrol: localize "close" in role manager.

4 weeks agoMDL-71373 tool_usertours: localize "previous"/"next" in user tours.
Luca Bösch [Tue, 20 Apr 2021 05:53:18 +0000 (07:53 +0200)]
MDL-71373 tool_usertours: localize "previous"/"next" in user tours.

4 weeks agoMDL-71373 core_table: localize "previous"/"next" in pagination.
Luca Bösch [Mon, 19 Apr 2021 11:24:07 +0000 (13:24 +0200)]
MDL-71373 core_table: localize "previous"/"next" in pagination.

4 weeks agoMDL-71659 completion: Consider modules without grade_item incomplete
David Mudrák [Tue, 18 May 2021 16:58:53 +0000 (18:58 +0200)]
MDL-71659 completion: Consider modules without grade_item incomplete

Activity modules may not have the associated grade_item created yet. It
used to throw fatal error in that case - even when trying to view the
course or edit the activity. So there was no easy way to recover from
this situation.

The patch is based on reasoning that an activity without grade item is
same as activity without any grades. And as such it is considered
incomplete.

A new unit test is added to cover this specific scenario. The existing
unit test is modified and it does not expect the exception any more.
There does not seem to be any good reason why this situation should be
exceptional.

4 weeks agoMDL-65203 template: tab should be quoted to produce valid json
Dongsheng Cai [Tue, 18 May 2021 10:36:49 +0000 (20:36 +1000)]
MDL-65203 template: tab should be quoted to produce valid json

4 weeks agoAutomatically generated installer lang files
AMOS bot [Tue, 18 May 2021 00:07:36 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 weeks agoMDL-71647 user: allow searching user selector by identity fields.
Paul Holden [Mon, 17 May 2021 15:01:07 +0000 (16:01 +0100)]
MDL-71647 user: allow searching user selector by identity fields.

Fixes regression from d916cd77, which passed empty extra fields when
not including custom fields.

4 weeks agoMDL-71047 HTML Editor (Atto): Cursor position is not correct when paste
Nhan Vo [Wed, 10 Mar 2021 11:20:06 +0000 (18:20 +0700)]
MDL-71047 HTML Editor (Atto): Cursor position is not correct when paste

4 weeks agoMDL-71638 upgrade: add 3.10.0 separation line to all upgrade scripts
Eloy Lafuente (stronk7) [Sat, 15 May 2021 22:00:43 +0000 (00:00 +0200)]
MDL-71638 upgrade: add 3.10.0 separation line to all upgrade scripts

4 weeks agoMoodle release 3.11 v3.11.0
Eloy Lafuente (stronk7) [Sat, 15 May 2021 16:10:59 +0000 (18:10 +0200)]
Moodle release 3.11

4 weeks agoMDL-71373 core_enrol: localize "close" in role manager.
Luca Bösch [Tue, 20 Apr 2021 05:56:59 +0000 (07:56 +0200)]
MDL-71373 core_enrol: localize "close" in role manager.

4 weeks agoMDL-71373 tool_usertours: localize "previous"/"next" in user tours.
Luca Bösch [Tue, 20 Apr 2021 05:53:18 +0000 (07:53 +0200)]
MDL-71373 tool_usertours: localize "previous"/"next" in user tours.

4 weeks agoMDL-71373 core_table: localize "previous"/"next" in pagination.
Luca Bösch [Mon, 19 Apr 2021 11:24:07 +0000 (13:24 +0200)]
MDL-71373 core_table: localize "previous"/"next" in pagination.

4 weeks agoMDL-71126 Quiz: Manual grading page size preference can get stuck at 0
Huong Nguyen [Tue, 11 May 2021 08:12:58 +0000 (15:12 +0700)]
MDL-71126 Quiz: Manual grading page size preference can get stuck at 0

Including in this change:
 - New positiveint regex rule to check if the value is a positive integer

4 weeks agoMoodle release 3.11rc2 v3.11.0-rc2
Sara Arjona [Fri, 14 May 2021 09:09:10 +0000 (11:09 +0200)]
Moodle release 3.11rc2

4 weeks agoMDL-67935 tool_lp: fix random errors with login/logout
Sara Arjona [Fri, 14 May 2021 08:11:12 +0000 (10:11 +0200)]
MDL-67935 tool_lp: fix random errors with login/logout

4 weeks agoAutomatically generated installer lang files
AMOS bot [Fri, 14 May 2021 00:07:33 +0000 (00:07 +0000)]
Automatically generated installer lang files

4 weeks agoMDL-71626 admin: filter site fullname in CLI maintenance script.
Paul Holden [Mon, 10 May 2021 07:07:13 +0000 (08:07 +0100)]
MDL-71626 admin: filter site fullname in CLI maintenance script.

4 weeks agoMDL-71619 privacy: extend correct class in provider testcases.
Paul Holden [Thu, 13 May 2021 09:54:04 +0000 (10:54 +0100)]
MDL-71619 privacy: extend correct class in provider testcases.

Extending the privacy provider testcase means that it's tearDown
method will reset the request writer.

4 weeks agoMDL-71612 tool_oauth2: remove erroneous hideIf rules for form fields
Jake Dallimore [Thu, 13 May 2021 04:47:58 +0000 (12:47 +0800)]
MDL-71612 tool_oauth2: remove erroneous hideIf rules for form fields

Some fields were being hidden based on whether the service was set up
for internal service use or was a service shown on the login page.
These fields refer to OAuth 2 logins and must be configurable for both
kinds of services.

4 weeks agoMDL-71611 block_accessreview: Return formats if feature disabled.
Mike Churchward [Wed, 12 May 2021 20:27:55 +0000 (16:27 -0400)]
MDL-71611 block_accessreview: Return formats if feature disabled.

5 weeks agoMDL-71580 lang: Fix reworded strings in tests
David Mudrák [Wed, 12 May 2021 06:48:00 +0000 (08:48 +0200)]
MDL-71580 lang: Fix reworded strings in tests

5 weeks agoMDL-71580 lang: Import fixed English strings (en_fix)
Helen Foster [Wed, 12 May 2021 06:34:29 +0000 (08:34 +0200)]
MDL-71580 lang: Import fixed English strings (en_fix)

5 weeks agoMDL-71584 tool_brickfield: Fixed up language string issues.
Mike Churchward [Tue, 11 May 2021 00:08:40 +0000 (20:08 -0400)]
MDL-71584 tool_brickfield: Fixed up language string issues.

5 weeks agoMDL-71590 usertours: Create language string for activity information
Huong Nguyen [Tue, 11 May 2021 08:52:17 +0000 (15:52 +0700)]
MDL-71590 usertours: Create language string for activity information

5 weeks agoMDL-71569 Accessibility toolkit: Fix Summary data task failure
Karen Holland [Fri, 7 May 2021 18:44:14 +0000 (19:44 +0100)]
MDL-71569 Accessibility toolkit: Fix Summary data task failure

5 weeks agoMDL-71583 versions: Add all the missing full-stops to version/requires
Eloy Lafuente (stronk7) [Tue, 11 May 2021 18:00:11 +0000 (20:00 +0200)]
MDL-71583 versions: Add all the missing full-stops to version/requires

It seems that the new phpcs3 checker is now controlling those
line comments that previously were ignored.

This commit just looks for all the cases and bulk-add
them when needed. The bash script (mac) used to add all them is:

while read -r line; do
    arr=(${line//:/ })
    if [[ -n ${arr[0]} ]] && [[ -n ${arr[1]} ]]; then
        echo "  file ${arr[0]}, line ${arr[1]}"
        sed -i "${arr[1]}s/\$/\./" ${arr[0]}
    fi
done < <(find . -name version.php | xargs ag --nomultiline '>(version|requires) *=.*//.*[^;\.]$')

5 weeks agoMDL-71583 versions: main version bump
Eloy Lafuente (stronk7) [Tue, 11 May 2021 15:39:52 +0000 (17:39 +0200)]
MDL-71583 versions: main version bump

5 weeks agoMDL-71583 versions: bump all versions and requires near release
Eloy Lafuente (stronk7) [Tue, 11 May 2021 15:36:47 +0000 (17:36 +0200)]
MDL-71583 versions: bump all versions and requires near release

version = 2021051700 release version
requires= 2021051100 current rc1 (week7roll1) version

Note that, because we are under parallel development period,
this is being done in the branch that is going to be released
(MOODLE_311_STABLE already existing) for Moodle 3.11.0 and
not in master, that is the one getting the bump under normal
(non-parallel) periods.

5 weeks agoMoodle release 3.11rc1 v3.11.0-rc1
Sara Arjona [Tue, 11 May 2021 10:43:50 +0000 (12:43 +0200)]
Moodle release 3.11rc1

5 weeks agoAutomatically generated installer lang files
AMOS bot [Tue, 11 May 2021 00:07:34 +0000 (00:07 +0000)]
Automatically generated installer lang files

5 weeks agoMDL-71060 Questions: Duplicates 'Current category' text.
Thong Bui [Sun, 9 May 2021 17:22:22 +0000 (00:22 +0700)]
MDL-71060 Questions: Duplicates 'Current category' text.

5 weeks agoMDL-71570 mod_forum: Avoid using deprecated string in forum templates
Mihail Geshoski [Mon, 10 May 2021 04:21:31 +0000 (12:21 +0800)]
MDL-71570 mod_forum: Avoid using deprecated string in forum templates

5 weeks agoMDL-71570 core_grades: Avoid using deprecated string in grade templates
Mihail Geshoski [Mon, 10 May 2021 04:17:15 +0000 (12:17 +0800)]
MDL-71570 core_grades: Avoid using deprecated string in grade templates

5 weeks agoMDL-70900 ci: Move highest PHP to 8.0 (from current 7.4)
Eloy Lafuente (stronk7) [Fri, 12 Feb 2021 11:04:31 +0000 (12:04 +0100)]
MDL-70900 ci: Move highest PHP to 8.0 (from current 7.4)

Also adds xmlrpc-beta from PECL (PHP8 moved the extension there)
and setups max_input_vars=5000 as initial value (see MDL-71390).

Note that this also includes a tiny modification when configuring
redis sessions, because there was some outdated code from old issue,
now fixed (MDL-60978), so that info has been removed.

5 weeks agoMoodle release 3.11beta v3.11.0-beta
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:55:23 +0000 (16:55 +0200)]
Moodle release 3.11beta

5 weeks agoNOBUG: Fixed file access permissions
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:55:23 +0000 (16:55 +0200)]
NOBUG: Fixed file access permissions

5 weeks agoNOBUG: Fixed SVG browser compatibility
Eloy Lafuente (stronk7) [Fri, 7 May 2021 14:55:20 +0000 (16:55 +0200)]
NOBUG: Fixed SVG browser compatibility

5 weeks agoMDL-71234 usertours: Create tours for the activity completion output
Huong Nguyen [Tue, 4 May 2021 08:18:27 +0000 (15:18 +0700)]
MDL-71234 usertours: Create tours for the activity completion output

5 weeks agoMDL-70622 mod_lti: Tighten redirect param typing
Mathew May [Thu, 22 Apr 2021 05:26:10 +0000 (13:26 +0800)]
MDL-70622 mod_lti: Tighten redirect param typing

5 weeks agoMDL-70622 mod_lti: Prevent xss on lti 1.3 authentication script
Adam Olley [Fri, 16 Apr 2021 04:28:28 +0000 (13:58 +0930)]
MDL-70622 mod_lti: Prevent xss on lti 1.3 authentication script

Without this, people can craft URLs that other users might use not realising
what they do - and as a XSS vulnerability, it could do any number of things the
clicking-user has access to do on the site.

Change-Id: I82adc71e8706d8929011b4b24523d5b62b8ccea1

5 weeks agoMDL-71533 lib: Remove libraries that already exist in core.
Dan Marsden [Tue, 4 May 2021 22:43:25 +0000 (10:43 +1200)]
MDL-71533 lib: Remove libraries that already exist in core.

5 weeks agoMDL-71543 block_accessreview: Toggling the heatmap icon image.
Mike Churchward [Thu, 6 May 2021 21:28:26 +0000 (17:28 -0400)]
MDL-71543 block_accessreview: Toggling the heatmap icon image.

5 weeks agoMDL-71552 block_accessreview: Removed 'alert' class when toggling off.
Mike Churchward [Thu, 6 May 2021 19:23:15 +0000 (15:23 -0400)]
MDL-71552 block_accessreview: Removed 'alert' class when toggling off.

5 weeks agoMDL-70926 core: getuserdate() shoud show debugging if null was passed
Marina Glancy [Wed, 17 Feb 2021 11:41:12 +0000 (12:41 +0100)]
MDL-70926 core: getuserdate() shoud show debugging if null was passed

passing null to getdate() has different results in PHP7 and PHP8

5 weeks agoMDL-70110 mod_assign: make phpunit test DB order agnostic
Sara Arjona [Thu, 6 May 2021 17:05:25 +0000 (19:05 +0200)]
MDL-70110 mod_assign: make phpunit test DB order agnostic

5 weeks agoMDL-71544 tool_brickfield: Allowing text to break in table.
Mike Churchward [Thu, 6 May 2021 17:10:47 +0000 (13:10 -0400)]
MDL-71544 tool_brickfield: Allowing text to break in table.

5 weeks agoMDL-71491 repository_flickr: return more file data.
Paul Holden [Tue, 4 May 2021 19:08:56 +0000 (20:08 +0100)]
MDL-71491 repository_flickr: return more file data.

See also 643b0cca.

5 weeks agoMDL-71395 core: fix bug in google lib wrapper
Marina Glancy [Thu, 6 May 2021 11:44:30 +0000 (13:44 +0200)]
MDL-71395 core: fix bug in google lib wrapper

because of changes in PHP8 the '' == 0 is no longer true and the error in the google api wrapper was discovered

5 weeks agoMDL-71395 block_tag_youtube: sometimes exception may have empty message
Marina Glancy [Wed, 21 Apr 2021 14:19:21 +0000 (16:19 +0200)]
MDL-71395 block_tag_youtube: sometimes exception may have empty message

5 weeks agoMDL-71402 availability: fix group restriction button in mod form.
Paul Holden [Wed, 21 Apr 2021 22:58:32 +0000 (23:58 +0100)]
MDL-71402 availability: fix group restriction button in mod form.

 * The button to "Add group/grouping access restriction" under
   common module settings should only be present if corresponding
   availability plugins are enabled; and
 * Prevent the same button behaving as a submit button, which
   intercepted the user hitting return in the form and added a
   restriction without deliberate action taken by the user.

5 weeks agoMDL-71420 environment: Add some strategic comments and todos.
Eloy Lafuente (stronk7) [Thu, 6 May 2021 12:29:33 +0000 (14:29 +0200)]
MDL-71420 environment: Add some strategic comments and todos.

This isn't really a deprecations where something is replaced
by another and all uses must adapt to. Instead it's just a
fallback functionality that will stop working in Moodle 4.2.

Because of that, I've tried to add TODO/@todo comments to
the places that will need to modified, always pointing to
MDL-71421 that is where the removal will happen.

Also, haven't added any debugging() output, after thinking
a lot about it, because this isn't anything that developers
can be using but a internal implementation detail (a fallback)
that we want to remove in some versions.

5 weeks agoMDL-71518 behat: Remove %P and AM/PM
Shamim Rezaie [Thu, 6 May 2021 02:31:42 +0000 (12:31 +1000)]
MDL-71518 behat: Remove %P and AM/PM

The %P modifier is not supported in the macOS (MDL-71549)