27 hours agoweekly release 4.1.1+ MOODLE_401_STABLE
Sara Arjona [Thu, 26 Jan 2023 08:59:12 +0000 (09:59 +0100)]
weekly release 4.1.1+

2 days agoMDL-77036 core_iplookup: update test_ipv4 test expectations
Simey Lameze [Wed, 25 Jan 2023 07:11:52 +0000 (15:11 +0800)]
MDL-77036 core_iplookup: update test_ipv4 test expectations

3 days agoMDL-76655 behat: Coverage for workshop grading strategies
Angelia Dela Cruz [Mon, 16 Jan 2023 09:42:47 +0000 (17:42 +0800)]
MDL-76655 behat: Coverage for workshop grading strategies

4 days agoMDL-76362 workshop: check for empty (null included) feedbackreviewer
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 17:18:21 +0000 (18:18 +0100)]
MDL-76362 workshop: check for empty (null included) feedbackreviewer

As far as feedbackreviewer can be null, we cannot, since PHP 8.1
apply any string operation (trim, strlen...) on it, hence, checking
before applying.

4 days agoMDL-76362 enrol_lti: Prevent calling to DataConnector with null keys
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 15:01:33 +0000 (16:01 +0100)]
MDL-76362 enrol_lti: Prevent calling to DataConnector with null keys

While it could have been fixed in DataConnector (3rd part lib), better
prevent in our code to call to it with null keys.

Covered by unit tests.

4 days agoMDL-76362 output: Preserve original behaviour for PHP 8.1
Eloy Lafuente (stronk7) [Sat, 21 Jan 2023 12:24:00 +0000 (13:24 +0100)]
MDL-76362 output: Preserve original behaviour for PHP 8.1

Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.

It's covered by an explicit test:

test_js_fix_url_coding_exception with data set "Provide a null argument"

4 days agoMDL-76362 core: Coding style fixes
Andrew Nicols [Mon, 9 Jan 2023 03:43:30 +0000 (11:43 +0800)]
MDL-76362 core: Coding style fixes

4 days agoMDL-76362 core_privacy: Shortcircuit URL rewriting on empty content
Andrew Nicols [Fri, 6 Jan 2023 14:37:59 +0000 (22:37 +0800)]
MDL-76362 core_privacy: Shortcircuit URL rewriting on empty content

4 days agoMDL-76362 core: Short circuit s() on empty values
Andrew Nicols [Fri, 6 Jan 2023 14:37:07 +0000 (22:37 +0800)]
MDL-76362 core: Short circuit s() on empty values

4 days agoMDL-76362 core: Short-circuit strip_querystring on empty values
Andrew Nicols [Fri, 6 Jan 2023 14:36:54 +0000 (22:36 +0800)]
MDL-76362 core: Short-circuit strip_querystring on empty values

4 days agoMDL-76362 core_file: Check prefix exists before checking length
Andrew Nicols [Fri, 6 Jan 2023 14:31:42 +0000 (22:31 +0800)]
MDL-76362 core_file: Check prefix exists before checking length

4 days agoMDL-76362 core: plugin names must be strings to be valid
Andrew Nicols [Fri, 6 Jan 2023 14:30:16 +0000 (22:30 +0800)]
MDL-76362 core: plugin names must be strings to be valid

4 days agoMDL-76362 core: Update core_component plugin name tests
Andrew Nicols [Fri, 6 Jan 2023 14:34:26 +0000 (22:34 +0800)]
MDL-76362 core: Update core_component plugin name tests

4 days agoMDL-76362 core: Test coursealias before using
Andrew Nicols [Fri, 6 Jan 2023 14:29:49 +0000 (22:29 +0800)]
MDL-76362 core: Test coursealias before using

4 days agoMDL-76362 h5p: Use string as default lang param
Andrew Nicols [Fri, 6 Jan 2023 14:29:25 +0000 (22:29 +0800)]
MDL-76362 h5p: Use string as default lang param

4 days agoMDL-76362 qtype_numerical: Fix bug in phpdoc
Andrew Nicols [Fri, 6 Jan 2023 14:29:02 +0000 (22:29 +0800)]
MDL-76362 qtype_numerical: Fix bug in phpdoc

4 days agoMDL-76362 qtype_calculated*: Address issues with null strings
Andrew Nicols [Fri, 6 Jan 2023 14:26:45 +0000 (22:26 +0800)]
MDL-76362 qtype_calculated*: Address issues with null strings

4 days agoMDL-76362 qtype: Update formatting of qtype_calculated* upgradelib
Andrew Nicols [Fri, 6 Jan 2023 14:17:22 +0000 (22:17 +0800)]
MDL-76362 qtype: Update formatting of qtype_calculated* upgradelib

4 days agoMDL-76362 qtype_numerical: Support empty units for apply_units
Andrew Nicols [Fri, 6 Jan 2023 14:11:22 +0000 (22:11 +0800)]
MDL-76362 qtype_numerical: Support empty units for apply_units

4 days agoMDL-76362 qtype_numeric: Refactor answer tests
Andrew Nicols [Fri, 6 Jan 2023 14:09:56 +0000 (22:09 +0800)]
MDL-76362 qtype_numeric: Refactor answer tests

4 days agoMDL-76362 question: Add test for number(null)
Andrew Nicols [Fri, 6 Jan 2023 13:21:09 +0000 (21:21 +0800)]
MDL-76362 question: Add test for number(null)

4 days agoMDL-76362 question: Refactor question number unit tests
Andrew Nicols [Fri, 6 Jan 2023 13:20:20 +0000 (21:20 +0800)]
MDL-76362 question: Refactor question number unit tests

4 days agoMDL-76362 core: Use empty default string when getting prefs
Andrew Nicols [Fri, 6 Jan 2023 13:10:51 +0000 (21:10 +0800)]
MDL-76362 core: Use empty default string when getting prefs

The json_decode function does not accept a null, which is the
traditional default for get_user_preferences. By passing a default of
am empty string we avoid issues in PHP 8.1.

4 days agoMDL-76362 various: Avoid passing nulls to functions that don't allow nulls
Marina Glancy [Thu, 17 Nov 2022 15:04:24 +0000 (16:04 +0100)]
MDL-76362 various: Avoid passing nulls to functions that don't allow nulls

PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument

4 days agoMDL-76362 mustache: Override parent method to avoid PHP notices
Marina Glancy [Thu, 17 Nov 2022 15:00:44 +0000 (16:00 +0100)]
MDL-76362 mustache: Override parent method to avoid PHP notices

Parent method checks baseDir that is null in this case. This shows notices under PHP 8.1

6 days agoMDL-76977 phpunit: ensure unique data provider keys in mustache test.
Paul Holden [Fri, 20 Jan 2023 17:19:16 +0000 (17:19 +0000)]
MDL-76977 phpunit: ensure unique data provider keys in mustache test.

7 days agoMDL-76967 questions: Questions last used line height
Luca Bösch [Fri, 20 Jan 2023 08:56:55 +0000 (09:56 +0100)]
MDL-76967 questions: Questions last used line height

7 days agoweekly release 4.1.1+
Ilya Tregubov [Fri, 20 Jan 2023 01:41:41 +0000 (09:41 +0800)]
weekly release 4.1.1+

9 days agoMDL-76525 mod_data: Add param validation for data fields
Philipp Memmel [Wed, 28 Dec 2022 18:29:26 +0000 (19:29 +0100)]
MDL-76525 mod_data: Add param validation for data fields

10 days agoMDL-74756 availability_completion: Prev activity (completion n/enabled)
Stefan Hanauska [Wed, 18 May 2022 04:24:53 +0000 (06:24 +0200)]
MDL-74756 availability_completion: Prev activity (completion n/enabled)

11 days agoMDL-76841 tool_mobile: improve potential config issues test.
Paul Holden [Tue, 10 Jan 2023 14:50:46 +0000 (14:50 +0000)]
MDL-76841 tool_mobile: improve potential config issues test.

Avoid certificate checking of the default test site (``),
and update the assertion so we get clearer failures in the future.

11 days agoMDL-70070 phpunit: correct data provider method names.
Paul Holden [Tue, 13 Dec 2022 11:22:33 +0000 (11:22 +0000)]
MDL-70070 phpunit: correct data provider method names.

They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.

13 days agoMDL-76537 behat: Month and day names are lang-dependent correct utf-8
Eloy Lafuente (stronk7) [Fri, 23 Dec 2022 17:18:16 +0000 (18:18 +0100)]
MDL-76537 behat: Month and day names are lang-dependent correct utf-8

Just verify that calendars are always displayed with correct UTF-8
and in the language the user is currently using.

13 days agoMDL-76537 core: Fix date_format_string() to work with php-intl
Eloy Lafuente (stronk7) [Thu, 22 Dec 2022 23:01:26 +0000 (00:01 +0100)]
MDL-76537 core: Fix date_format_string() to work with php-intl

With Moodle 4.1 and up, we have stopped to work with strftime(),
because it's deprecated for PHP 8.1 and up and, instead we are
using core_date::strftime() that performs the conversions using
the php-intl extension.

The original strftime() had a lot of OS-specific dependencies,
both about locale names and charsets used to provide the information.

Instead, the php-intl gets rid of all those OS-specific nightmares
and only uses ICU/Unicode locales and UTF-8.

Because of that, the old utf-8 => windows charset => utf-8
conversions aren't needed anymore. Hence, removing them.

13 days agoMoodle release 4.1.1 v4.1.1
Jun Pataleta [Sat, 14 Jan 2023 06:17:03 +0000 (14:17 +0800)]
Moodle release 4.1.1

2 weeks agoMDL-66221 tool_recyclebin: Fix recycle bin with activity settings
raortegar [Wed, 30 Nov 2022 13:41:12 +0000 (14:41 +0100)]
MDL-66221 tool_recyclebin: Fix recycle bin with activity settings

If backup_auto_activities setting from Automated backup is disabled
the activities will not be stored for the recycle bin

2 weeks agoMDL-76870 question: change assertion to assertEqualsCanonicalizing
Simey Lameze [Thu, 12 Jan 2023 09:12:18 +0000 (17:12 +0800)]
MDL-76870 question: change assertion to assertEqualsCanonicalizing

By using that assertion the arrays will be sorted before comparison
preventing any Oracle sorting related failures.

Credits for the solution go to Tim Hunt!

2 weeks agoMDL-76639 behat: Add Behat test coverage for quiz with limited attempts
Angelia Dela Cruz [Fri, 6 Jan 2023 06:38:38 +0000 (14:38 +0800)]
MDL-76639 behat: Add Behat test coverage for quiz with limited attempts

2 weeks agoweekly release 4.1+
Jun Pataleta [Fri, 13 Jan 2023 02:52:14 +0000 (10:52 +0800)]
weekly release 4.1+

2 weeks agoMDL-76474 tiny_h5p: Prevent H5P Formatter placeholder to be assessed
Huong Nguyen [Wed, 4 Jan 2023 05:01:11 +0000 (12:01 +0700)]
MDL-76474 tiny_h5p: Prevent H5P Formatter placeholder to be assessed

2 weeks agoMDL-76474 tiny_accessibilitychecker: Prevent placeholders to be assessed
Huong Nguyen [Wed, 4 Jan 2023 04:52:43 +0000 (11:52 +0700)]
MDL-76474 tiny_accessibilitychecker: Prevent placeholders to be assessed

2 weeks agoMDL-76474 editor_tiny: Implement placeholder selector list
Huong Nguyen [Wed, 4 Jan 2023 03:54:04 +0000 (10:54 +0700)]
MDL-76474 editor_tiny: Implement placeholder selector list

We created a list of placeholder selectors in placeholderSelectors option.
The purpose of this list is to indicate the contents that are only shown
in the editor and not to the users, by that way, we can decide to apply or
not to apply rules, styles, etc... to these contents

2 weeks agoMDL-76861 blog: Ensure correct escaping applied to search string
Michael Hawkins [Wed, 11 Jan 2023 17:59:42 +0000 (01:59 +0800)]
MDL-76861 blog: Ensure correct escaping applied to search string

2 weeks agoMDL-76862 user: Unit test for setting user home page preferences
Jake Dallimore [Thu, 12 Jan 2023 03:28:37 +0000 (11:28 +0800)]
MDL-76862 user: Unit test for setting user home page preferences

2 weeks agoMDL-76862 user: ensure user can only update own preferred start page.
Paul Holden [Wed, 11 Jan 2023 22:40:49 +0000 (22:40 +0000)]
MDL-76862 user: ensure user can only update own preferred start page.

2 weeks agoMDL-76820 core_search: Reset manager::$coursedeleting between tests
Cameron Ball [Thu, 12 Jan 2023 02:41:39 +0000 (10:41 +0800)]
MDL-76820 core_search: Reset manager::$coursedeleting between tests

2 weeks agoMDL-76739 behat: Replace occurrences of "surname" in Behat tests
Jun Pataleta [Thu, 12 Jan 2023 01:52:48 +0000 (09:52 +0800)]
MDL-76739 behat: Replace occurrences of "surname" in Behat tests

Replace occurrences of "surname" in Behat tests with "last name"

2 weeks agoMDL-76766 mod_quiz: Allow shuffling quizes with no questions
Amaia Anabitarte [Wed, 4 Jan 2023 15:58:04 +0000 (16:58 +0100)]
MDL-76766 mod_quiz: Allow shuffling quizes with no questions

2 weeks agoMDL-76810 redirect handling: ensure return URLs are properly sanitised
Tim Hunt [Fri, 6 Jan 2023 12:55:40 +0000 (12:55 +0000)]
MDL-76810 redirect handling: ensure return URLs are properly sanitised

2 weeks agoMDL-76739 lang: Use the fixed strings in the tests, too
David Mudrák [Mon, 9 Jan 2023 17:24:23 +0000 (18:24 +0100)]
MDL-76739 lang: Use the fixed strings in the tests, too

2 weeks agoMDL-76739 lang: Import fixed English strings (en_fix)
Helen Foster [Tue, 10 Jan 2023 20:13:14 +0000 (21:13 +0100)]
MDL-76739 lang: Import fixed English strings (en_fix)

2 weeks agoMDL-76356 various: avoid implicit conversion to int
Marina Glancy [Thu, 17 Nov 2022 14:49:48 +0000 (15:49 +0100)]
MDL-76356 various: avoid implicit conversion to int

PHP before version 8.1 automatically converted to int if the function
parameter (or array key) is expected to be int. PHP 8.1 shows notice in
this case

2 weeks agoMDL-76356 various: avoid implicit conversion to arrays
Marina Glancy [Thu, 17 Nov 2022 14:44:35 +0000 (15:44 +0100)]
MDL-76356 various: avoid implicit conversion to arrays

PHP before version 8.1 automatically converted stdClass or 'false' to arrays if
function parameter expects array (for example, "reset").
PHP 8.1 shows notices in these situations

2 weeks agoMDL-76839 mod_data: correct external test class coverage notation.
Paul Holden [Tue, 10 Jan 2023 12:59:06 +0000 (12:59 +0000)]
MDL-76839 mod_data: correct external test class coverage notation.

2 weeks agoMDL-76803 lang: Update usages of reworded email display options
Jun Pataleta [Fri, 6 Jan 2023 03:02:33 +0000 (11:02 +0800)]
MDL-76803 lang: Update usages of reworded email display options

2 weeks agoMDL-76803 lang: Make email display options more concise
Jun Pataleta [Thu, 5 Jan 2023 15:55:54 +0000 (23:55 +0800)]
MDL-76803 lang: Make email display options more concise

2 weeks agoMDL-76833 core: Bump phpunit/php-code-coverage version
Andrew Nicols [Tue, 10 Jan 2023 04:09:00 +0000 (12:09 +0800)]
MDL-76833 core: Bump phpunit/php-code-coverage version

This includes a bug fix for a display issue with code coverage reporting
in phpunit's HTML output report.

2 weeks agoMDL-76811 mod_data: Remove duplicate tests
Andrew Nicols [Tue, 10 Jan 2023 03:19:02 +0000 (11:19 +0800)]
MDL-76811 mod_data: Remove duplicate tests

2 weeks agoMDL-76811 mod_data: Stop testing template creation on field creation
Andrew Nicols [Fri, 6 Jan 2023 04:51:21 +0000 (12:51 +0800)]
MDL-76811 mod_data: Stop testing template creation on field creation

The default template is no longer created when creating the fields with
the generator, so we should stop testing that it is.

2 weeks agoMDL-76811 mod_data: Generator test cleanup
Andrew Nicols [Tue, 10 Jan 2023 03:18:36 +0000 (11:18 +0800)]
MDL-76811 mod_data: Generator test cleanup

2 weeks agoMDL-76653 behat: add coverage for SCORM availability
Simey Lameze [Tue, 20 Dec 2022 08:34:02 +0000 (16:34 +0800)]
MDL-76653 behat: add coverage for SCORM availability

2 weeks agoMDL-76061 core_calendar: Fix changing event type from 'user'
Philipp Memmel [Thu, 15 Dec 2022 19:11:12 +0000 (20:11 +0100)]
MDL-76061 core_calendar: Fix changing event type from 'user'

2 weeks agoMDL-66924 mod_forum: Allow users to see their own private messages
Julien Boulen [Mon, 9 Jan 2023 13:41:01 +0000 (14:41 +0100)]
MDL-66924 mod_forum: Allow users to see their own private messages

Allow users to see their own private messages even if they don't have
mod/forum:readprivatereplies capability

Add behat test to avoid MDL-67109 issue.

Co-authored-by: Martin Putzlocher <>
2 weeks agoMDL-76649 quiz statistics task: output more useful trace info
Tim Hunt [Mon, 12 Dec 2022 18:11:38 +0000 (18:11 +0000)]
MDL-76649 quiz statistics task: output more useful trace info

At the moment, quiz_statistics\task\recalculate gives no useful
information about what it is doing, which makes it hard to investigate
if the task fails. This commit makes it more usefully verbose.

Also, following this change, one instance of this task will not
run for more than one hour at a time.

As part of this commit, I have added a new helper mtrace_exception.
to consistently log exceptions in scheduled tasks. It is sad to
add a new function to moodlelib.php, but that seemed the logical place.
Looking at other tasks, this method is badly needed. Many are just
logging the ->getMessage() which is normaly insufficient for proper
debugging. However, swiching all existing tasks to use the new function
will need to wait for a future MDL.

2 weeks agoMDL-76785 tiny_media: define video width/height language strings.
Paul Holden [Tue, 3 Jan 2023 21:08:18 +0000 (21:08 +0000)]
MDL-76785 tiny_media: define video width/height language strings.

 CPY [videoheight,atto_media],[videoheight,tiny_media]
 CPY [videowidth,atto_media],[videowidth,tiny_media]

2 weeks agoMDL-76597 mod_quiz: Add a default heading name for Behat tests
Jun Pataleta [Mon, 9 Jan 2023 07:41:27 +0000 (15:41 +0800)]
MDL-76597 mod_quiz: Add a default heading name for Behat tests

2 weeks agoMDL-76597 mod_quiz: Set presentation role for the question list
Jun Pataleta [Fri, 6 Jan 2023 12:45:12 +0000 (20:45 +0800)]
MDL-76597 mod_quiz: Set presentation role for the question list

Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.
The aria-label for the <li> element is inappropriate and can also cause
confusion to screen reader users. Better to remove this. Though this is
being used in the confirmation modal so better to just change it to a
data attribute.

2 weeks agoMDL-76597 mod_quiz: Set presentation role for the question list
Jun Pataleta [Fri, 6 Jan 2023 05:09:22 +0000 (13:09 +0800)]
MDL-76597 mod_quiz: Set presentation role for the question list

Since the <ul> and <li> elements for listing the quiz questions and
elements are mainly used for layout purposes, it is better to set the
role of these elements to presentation only.

2 weeks agoMDL-76597 mod_quiz: Add label for question checkboxes
Jun Pataleta [Thu, 5 Jan 2023 04:27:14 +0000 (12:27 +0800)]
MDL-76597 mod_quiz: Add label for question checkboxes

2 weeks agoMDL-76597 mod_quiz: Darken section heading on quiz questions page
Jun Pataleta [Wed, 4 Jan 2023 15:29:52 +0000 (23:29 +0800)]
MDL-76597 mod_quiz: Darken section heading on quiz questions page

2 weeks agoMDL-76597 mod_quiz: Add label for version selector
Jun Pataleta [Wed, 4 Jan 2023 15:27:49 +0000 (23:27 +0800)]
MDL-76597 mod_quiz: Add label for version selector

2 weeks agoMDL-76597 mod_quiz: Add a default sr-only section heading
Jun Pataleta [Wed, 4 Jan 2023 12:30:48 +0000 (20:30 +0800)]
MDL-76597 mod_quiz: Add a default sr-only section heading

Add a default sr-only section heading in order to prevent having an
empty heading for the quiz section which is not good for accessibility.

- There's also an existing issue where filters are never applied to
section headings on load. This has been fixed in this commit as well.
- Button role added for the edit section button which enables it to
take advantage of the theme highlighting when it receives focus.

2 weeks agoMDL-75532 enrol_lti: fix optional lineitemsurl in grade sync task
Jake Dallimore [Fri, 19 Aug 2022 04:24:40 +0000 (12:24 +0800)]
MDL-75532 enrol_lti: fix optional lineitemsurl in grade sync task

As in MDL-74691, we need either or both of these fields, meaning either
one could be omitted. This just supports that as per the fix made in

2 weeks agoMDL-75532 enrol_lti: add tests for coupled and decoupled line items
Jake Dallimore [Fri, 19 Aug 2022 04:21:52 +0000 (12:21 +0800)]
MDL-75532 enrol_lti: add tests for coupled and decoupled line items

This covers the following cases:
1. Where only the 'lineitem' service endpoint is provided
2. Where only the 'lineitems' service endpoint is provided.
Existing tests already cover the case where both are provided.

2 weeks agoMDL-76652 behat: use data generator and remove duplicated steps
Simey Lameze [Tue, 20 Dec 2022 07:31:06 +0000 (15:31 +0800)]
MDL-76652 behat: use data generator and remove duplicated steps

2 weeks agoMDL-76652 behat: add coverage for postwithoutthrottling logic
Simey Lameze [Tue, 20 Dec 2022 07:18:14 +0000 (15:18 +0800)]
MDL-76652 behat: add coverage for postwithoutthrottling logic

3 weeks agoMDL-76812 reportbuilder: ensure audience key is incremented correctly.
Paul Holden [Fri, 6 Jan 2023 09:57:14 +0000 (09:57 +0000)]
MDL-76812 reportbuilder: ensure audience key is incremented correctly.

3 weeks agoMDL-76251 mod_forum: Fix illegal whitespace. Another try.
Ilya Tregubov [Fri, 6 Jan 2023 09:41:25 +0000 (16:41 +0700)]
MDL-76251 mod_forum: Fix illegal whitespace. Another try.

3 weeks agoMDL-76251 mod_forum: Fix illegal whitespace.
Ilya Tregubov [Fri, 6 Jan 2023 09:11:51 +0000 (16:11 +0700)]
MDL-76251 mod_forum: Fix illegal whitespace.

3 weeks agoMDL-32114 form: markdown must be preserved on saving post
Stephan Robotta [Wed, 4 Jan 2023 15:52:43 +0000 (16:52 +0100)]
MDL-32114 form: markdown must be preserved on saving post

- Markdown is saved to the DB, no conversion to HTML to keep
  ability to reedit the content without beaking it.
- Blockquote element is styled that it's distingishable from
  normal text.

3 weeks agoMDL-76781 gradebook: support multilingual group names.
Luca Bösch [Tue, 3 Jan 2023 16:05:16 +0000 (17:05 +0100)]
MDL-76781 gradebook: support multilingual group names.

3 weeks agoweekly release 4.1+
Paul Holden [Thu, 5 Jan 2023 10:53:10 +0000 (10:53 +0000)]
weekly release 4.1+

3 weeks agoMDL-76251 mod_forum: fix responsive issues in discussion
Aya Saad [Thu, 5 Jan 2023 09:41:19 +0000 (11:41 +0200)]
MDL-76251 mod_forum: fix responsive issues in discussion

3 weeks agoMDL-76607 timeline: Reordered message to account for long course name
David Woloszyn [Thu, 5 Jan 2023 01:11:42 +0000 (12:11 +1100)]
MDL-76607 timeline: Reordered message to account for long course name

3 weeks agoMDL-76607 css: Fixed various classes where long strings break layout
David Woloszyn [Thu, 5 Jan 2023 01:10:58 +0000 (12:10 +1100)]
MDL-76607 css: Fixed various classes where long strings break layout

3 weeks agoMDL-76787 tiny_h5p: correct capability for plugin enabled state.
Paul Holden [Tue, 3 Jan 2023 21:26:04 +0000 (21:26 +0000)]
MDL-76787 tiny_h5p: correct capability for plugin enabled state.

3 weeks agoMDL-76375 quiz generator: Allow more than one attempt by Behat tests.
Luca Bösch [Tue, 22 Nov 2022 14:21:49 +0000 (15:21 +0100)]
MDL-76375 quiz generator: Allow more than one attempt by Behat tests.

3 weeks agoMDL-76725 mod_wiki: avoid named arguments in real path callback.
Paul Holden [Mon, 19 Dec 2022 16:07:34 +0000 (16:07 +0000)]
MDL-76725 mod_wiki: avoid named arguments in real path callback.

See also f4fb91ae. PHP8 now supports named arguments in calls to
the `call_user_func_array` method, which can result in differing
behaviour compared to PHP7, e.g. in this case it was throwing an
exception due to an unknown named parameter.

3 weeks agoMDL-76657 grade: load required test libraries for grade helper.
Paul Holden [Wed, 4 Jan 2023 11:20:44 +0000 (11:20 +0000)]
MDL-76657 grade: load required test libraries for grade helper.

3 weeks agoMDL-76221 reportbuilder: improve report test generator methods.
Paul Holden [Thu, 17 Nov 2022 21:54:37 +0000 (21:54 +0000)]
MDL-76221 reportbuilder: improve report test generator methods.

Test generators for creating report columns, filters and conditions
now allow for setting all persistent properties.

3 weeks agoMDL-76601 block_myoverview: Remove hover action before clicking on menu
Jun Pataleta [Wed, 4 Jan 2023 09:21:47 +0000 (17:21 +0800)]
MDL-76601 block_myoverview: Remove hover action before clicking on menu

With the course card menu now always displayed, there's no need to hover
first before clicking on the menus on block_myoverview Behat tests.

3 weeks agoMDL-76601 blocks: Always display course card menus
Jun Pataleta [Wed, 4 Jan 2023 09:00:04 +0000 (17:00 +0800)]
MDL-76601 blocks: Always display course card menus

Displaying the course card menu only on hover is bad in terms of
accessibility as it prevents keyboard-only users from accessing the
menu. So it's better to always display them.

3 weeks agoMDL-76657 gradebook: Remove hard-coded plugin names from unit test
Shamim Rezaie [Thu, 29 Dec 2022 06:32:32 +0000 (17:32 +1100)]
MDL-76657 gradebook: Remove hard-coded plugin names from unit test

3 weeks agoMDL-32105 mod_glossary: Improve behat test
Andrew Nicols [Tue, 3 Jan 2023 07:27:30 +0000 (15:27 +0800)]
MDL-32105 mod_glossary: Improve behat test

3 weeks agoMDL-32105 mod_glossary: Restrict glossary aliases by set of keywords
Peter [Wed, 16 Jan 2019 07:12:01 +0000 (15:12 +0800)]
MDL-32105 mod_glossary: Restrict glossary aliases by set of keywords

3 weeks agoMDL-74822 usertours: Fix accessibility issues with user tours
Huong Nguyen [Wed, 15 Jun 2022 07:01:07 +0000 (14:01 +0700)]
MDL-74822 usertours: Fix accessibility issues with user tours

Including in this commit:
 - Prevent the tour to be displayed if the CSS is disabled by the browser
 - Removed redundant tabindex=0 attribute on the target
 - Created extra code to re-calculate the suitable position of the tour
 - Fixed tour issue in 200% and 400% zoom
 - Fixed tour highlight is not correct in 200% and 400%

3 weeks agoMDL-71506 mod_choice: suppress non respondents in downloads if set so.
Luca Bösch [Thu, 17 Jun 2021 16:19:29 +0000 (18:19 +0200)]
MDL-71506 mod_choice: suppress non respondents in downloads if set so.

4 weeks agoMDL-76181 reportbuilder: sort columns during stress testing.
Paul Holden [Wed, 2 Nov 2022 20:40:14 +0000 (20:40 +0000)]
MDL-76181 reportbuilder: sort columns during stress testing.

4 weeks agoweekly release 4.1+
Sara Arjona [Thu, 29 Dec 2022 11:57:44 +0000 (12:57 +0100)]
weekly release 4.1+

4 weeks agoMDL-76399 behat: switch to appropriate Behat step for selects.
Ilya Tregubov [Thu, 29 Dec 2022 07:33:55 +0000 (14:33 +0700)]
MDL-76399 behat: switch to appropriate Behat step for selects.