From 8f725ade780c9ba1b91280ff1f8d1961593f2fa1 Mon Sep 17 00:00:00 2001 From: Charles Fulton Date: Thu, 27 Oct 2011 13:25:45 -0700 Subject: [PATCH] MDL-29970 question preview: Fill correct only if qtype supports it --- question/preview.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/question/preview.php b/question/preview.php index e027be67f0f..6981dd414b0 100644 --- a/question/preview.php +++ b/question/preview.php @@ -153,12 +153,13 @@ if (data_submitted() && confirm_sesskey()) { } else if (optional_param('fill', null, PARAM_BOOL)) { $correctresponse = $quba->get_correct_response($slot); - $quba->process_action($slot, $correctresponse); - - $transaction = $DB->start_delegated_transaction(); - question_engine::save_questions_usage_by_activity($quba); - $transaction->allow_commit(); + if (!is_null($correctresponse)) { + $quba->process_action($slot, $correctresponse); + $transaction = $DB->start_delegated_transaction(); + question_engine::save_questions_usage_by_activity($quba); + $transaction->allow_commit(); + } redirect($actionurl); } else if (optional_param('finish', null, PARAM_BOOL)) { @@ -210,6 +211,8 @@ $filldisabled = ''; if ($quba->get_question_state($slot)->is_finished()) { $finishdisabled = ' disabled="disabled"'; $filldisabled = ' disabled="disabled"'; +} else if (is_null($quba->get_correct_response($slot))) { + $filldisabled = ' disabled="disabled"'; } if (!$previewid) { $restartdisabled = ' disabled="disabled"'; -- 2.17.1