From 04b32359bfed6d2988c8d1e4d7a29fd0a84fccdf Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Sat, 28 Aug 2010 12:25:14 +0000 Subject: [PATCH] MDL-23979 PARAM_CLEAN should not be used in new code at all ,there is nothing like universal cleaning, sorry --- lib/simpletest/testmoodlelib.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lib/simpletest/testmoodlelib.php b/lib/simpletest/testmoodlelib.php index 80fdddb80c1..5d3b7f2d0fd 100644 --- a/lib/simpletest/testmoodlelib.php +++ b/lib/simpletest/testmoodlelib.php @@ -231,13 +231,13 @@ class moodlelib_test extends UnitTestCase { function test_optional_param() { $_POST['username'] = 'post_user'; $_GET['username'] = 'get_user'; - $this->assertEqual(optional_param('username', 'default_user', PARAM_CLEAN), 'post_user'); + $this->assertEqual(optional_param('username', 'default_user', PARAM_RAW), 'post_user'); unset($_POST['username']); - $this->assertEqual(optional_param('username', 'default_user', PARAM_CLEAN), 'get_user'); + $this->assertEqual(optional_param('username', 'default_user', PARAM_RAW), 'get_user'); unset($_GET['username']); - $this->assertEqual(optional_param('username', 'default_user', PARAM_CLEAN), 'default_user'); + $this->assertEqual(optional_param('username', 'default_user', PARAM_RAW), 'default_user'); } function test_clean_param_raw() { @@ -246,8 +246,8 @@ class moodlelib_test extends UnitTestCase { } function test_clean_param_clean() { - $this->assertEqual(clean_param('#()*#,9789\'".,<42897>assertEqual(clean_param('xx