From 08015e1895fc2660902ed6c19d227a0f4aa62adf Mon Sep 17 00:00:00 2001
From: David Monllao <davidm@moodle.com>
Date: Fri, 23 Jun 2017 08:30:50 +0200
Subject: [PATCH] MDL-57791 analytics: Add missing 'new' to throw

Also other code refinements. Credit to Mark Nelson.
---
 analytics/classes/calculable.php | 2 +-
 analytics/classes/manager.php    | 4 ++--
 analytics/classes/model.php      | 3 +--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/analytics/classes/calculable.php b/analytics/classes/calculable.php
index 72813d7fa3b..cda4fc3b92f 100644
--- a/analytics/classes/calculable.php
+++ b/analytics/classes/calculable.php
@@ -208,7 +208,7 @@ abstract class calculable {
             $match = false;
 
             if (count($range) != 2) {
-                throw \coding_exception('classify_value() $ranges array param should contain 2 items, the predicate ' .
+                throw new \coding_exception('classify_value() $ranges array param should contain 2 items, the predicate ' .
                     'e.g. greater (gt), lower or equal (le)... and the value.');
             }
 
diff --git a/analytics/classes/manager.php b/analytics/classes/manager.php
index afea72da9c2..3bc24bd1e30 100644
--- a/analytics/classes/manager.php
+++ b/analytics/classes/manager.php
@@ -76,7 +76,7 @@ class manager {
      *
      * @param bool $enabled
      * @param bool $trained
-     * @param \context $predictioncontext
+     * @param \context|false $predictioncontext
      * @return \core_analytics\model[]
      */
     public static function get_all_models($enabled = false, $trained = false, $predictioncontext = false) {
@@ -163,7 +163,7 @@ class manager {
     /**
      * Return all system predictions processors.
      *
-     * @return \core_analytics\predictor
+     * @return \core_analytics\predictor[]
      */
     public static function get_all_prediction_processors() {
 
diff --git a/analytics/classes/model.php b/analytics/classes/model.php
index 2999767ca86..461daec27b3 100644
--- a/analytics/classes/model.php
+++ b/analytics/classes/model.php
@@ -145,7 +145,6 @@ class model {
         if (!$target) {
             return false;
         }
-        $analyser = $this->get_target();
 
         $classname = $target->get_analyser_class();
         if (!class_exists($classname)) {
@@ -296,7 +295,7 @@ class model {
 
         $classname = $target->get_analyser_class();
         if (!class_exists($classname)) {
-            throw \coding_exception($classname . ' class does not exists');
+            throw new \coding_exception($classname . ' class does not exists');
         }
 
         // Returns a \core_analytics\local\analyser\base class.
-- 
2.43.0