From 0d352dbcdd9e48987328c108f168452835de60a8 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Wed, 17 Jul 2013 09:45:42 +0800 Subject: [PATCH] MDL-40424 user: Incorrect use of named parameters --- user/externallib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/user/externallib.php b/user/externallib.php index 356b55666bc..bbaa87ae9f1 100644 --- a/user/externallib.php +++ b/user/externallib.php @@ -678,7 +678,7 @@ class core_user_external extends external_api { $params = self::validate_parameters(self::get_users_by_id_parameters(), array('userids'=>$userids)); - list($sqluserids, $params) = $DB->get_in_or_equal($userids); + list($sqluserids, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED); $uselect = ', ' . context_helper::get_preload_record_columns_sql('ctx'); $ujoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = u.id AND ctx.contextlevel = :contextlevel)"; $params['contextlevel'] = CONTEXT_USER; @@ -780,7 +780,7 @@ class core_user_external extends external_api { // cache all courses $courses = array(); - list($sqlcourseids, $params) = $DB->get_in_or_equal(array_unique($courseids)); + list($sqlcourseids, $params) = $DB->get_in_or_equal(array_unique($courseids), SQL_PARAMS_NAMED); $cselect = ', ' . context_helper::get_preload_record_columns_sql('ctx'); $cjoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = c.id AND ctx.contextlevel = :contextlevel)"; $params['contextlevel'] = CONTEXT_COURSE; @@ -796,7 +796,7 @@ class core_user_external extends external_api { } $rs->close(); - list($sqluserids, $params) = $DB->get_in_or_equal($userids); + list($sqluserids, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED); $uselect = ', ' . context_helper::get_preload_record_columns_sql('ctx'); $ujoin = "LEFT JOIN {context} ctx ON (ctx.instanceid = u.id AND ctx.contextlevel = :contextlevel)"; $params['contextlevel'] = CONTEXT_USER; -- 2.17.1