From 12ffe203719ab17a0e8d24721eece3794bf44353 Mon Sep 17 00:00:00 2001 From: Eloy Lafuente Date: Wed, 26 May 2010 17:45:40 +0000 Subject: [PATCH] NOBUG: Formatting and adding some comments about row versioning required --- lib/dml/mssql_native_moodle_database.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/dml/mssql_native_moodle_database.php b/lib/dml/mssql_native_moodle_database.php index aba8011f8ac..d5197a64da7 100644 --- a/lib/dml/mssql_native_moodle_database.php +++ b/lib/dml/mssql_native_moodle_database.php @@ -193,6 +193,7 @@ class mssql_native_moodle_database extends moodle_database { // Set transactions isolation level to READ_COMMITTED // prevents dirty reads when using transactions + // is the default isolation level of MSSQL + // Requires database to run with READ_COMMITTED_SNAPSHOT ON $sql = "SET TRANSACTION ISOLATION LEVEL READ COMMITTED"; $this->query_start($sql, NULL, SQL_QUERY_AUX); $result = mssql_query($sql, $this->mssql); @@ -1179,7 +1180,8 @@ s only returning name of SQL substring function, it now requires all parameters. * this can not be used directly in code. * @return void */ - protected function begin_transaction() { + protected function begin_transaction() { + // requires database to run with READ_COMMITTED_SNAPSHOT ON $sql = "BEGIN TRANSACTION"; // Will be using READ COMMITTED isolation $this->query_start($sql, NULL, SQL_QUERY_AUX); $result = mssql_query($sql, $this->mssql); @@ -1193,7 +1195,7 @@ s only returning name of SQL substring function, it now requires all parameters. * this can not be used directly in code. * @return void */ - protected function commit_transaction() { + protected function commit_transaction() { $sql = "COMMIT TRANSACTION"; $this->query_start($sql, NULL, SQL_QUERY_AUX); $result = mssql_query($sql, $this->mssql); @@ -1207,7 +1209,7 @@ s only returning name of SQL substring function, it now requires all parameters. * this can not be used directly in code. * @return void */ - protected function rollback_transaction() { + protected function rollback_transaction() { $sql = "ROLLBACK TRANSACTION"; $this->query_start($sql, NULL, SQL_QUERY_AUX); $result = mssql_query($sql, $this->mssql); -- 2.17.1