From 23fe1e2bed5ed41eb4891de8e4171c7b66be4a88 Mon Sep 17 00:00:00 2001 From: Cameron Ball Date: Thu, 11 Jan 2018 16:38:00 +0800 Subject: [PATCH] MDL-61194 assignfeedback_editpdf: Check if we can convert online text This patch adds a check to make sure there is a converter available that will be able to handle html->pdf conversion before adding onlinetext submissions to the list of files to combine. --- mod/assign/feedback/editpdf/classes/document_services.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/assign/feedback/editpdf/classes/document_services.php b/mod/assign/feedback/editpdf/classes/document_services.php index 0920bbc1887..fa6dbfbb598 100644 --- a/mod/assign/feedback/editpdf/classes/document_services.php +++ b/mod/assign/feedback/editpdf/classes/document_services.php @@ -188,7 +188,7 @@ EOD; } else if ($convertedfile = $converter->start_conversion($file, 'pdf')) { $files[$filename] = $convertedfile; } - } else { + } else if ($converter->can_convert_format_to('html', 'pdf')) { // Create a tmp stored_file from this html string. $file = reset($file); // Strip image tags, because they will not be resolvable. -- 2.36.1