From 33be3558ee2ce72721f6c0e274cf3541259d8797 Mon Sep 17 00:00:00 2001 From: Jamie Pratt Date: Thu, 13 Oct 2011 21:19:30 +0700 Subject: [PATCH] MDL-47494 gapselect: NOBUG took out the appended group no in box id. It is not needed place nos are unique already. --- question/type/gapselect/renderer.php | 2 +- question/type/gapselect/rendererbase.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/question/type/gapselect/renderer.php b/question/type/gapselect/renderer.php index 2e4d9d920f7..c3a0ec71e8f 100755 --- a/question/type/gapselect/renderer.php +++ b/question/type/gapselect/renderer.php @@ -46,7 +46,7 @@ class qtype_gapselect_renderer extends qtype_elements_embedded_in_question_text_ $value = $qa->get_last_qt_var($question->field($place)); $attributes = array( - 'id' => $this->box_id($qa, 'p' . $place, $group), + 'id' => $this->box_id($qa, 'p' . $place), ); $groupclass = 'group' . $group; diff --git a/question/type/gapselect/rendererbase.php b/question/type/gapselect/rendererbase.php index 49c44cfe172..4ededd3058e 100755 --- a/question/type/gapselect/rendererbase.php +++ b/question/type/gapselect/rendererbase.php @@ -81,8 +81,8 @@ abstract class qtype_elements_embedded_in_question_text_renderer return ''; } - protected function box_id(question_attempt $qa, $place, $group) { - return $qa->get_qt_field_name($place) . '_' . $group; + protected function box_id(question_attempt $qa, $place) { + return str_replace(':', '_', $qa->get_qt_field_name($place)); } public function specific_feedback(question_attempt $qa) { -- 2.17.1