From 425a634b5816cbf7c14ba03869f1cc53ba4b569c Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Wed, 16 Jan 2013 12:26:23 +0800 Subject: [PATCH] MDL-37527 Assignment - Change query for print_overview so it uses an index (postgres) Reported by Mark Neilsen. --- mod/assign/lib.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mod/assign/lib.php b/mod/assign/lib.php index e2d7e01b872..81c945667a9 100644 --- a/mod/assign/lib.php +++ b/mod/assign/lib.php @@ -358,7 +358,7 @@ function assign_print_overview($courses, &$htmlarray) { $rs->close(); // Get all user submissions, indexed by assignment id. - $dbparams = array_merge(array($USER->id, $USER->id), $assignmentidparams); + $dbparams = array($USER->id, $USER->id); $mysubmissions = $DB->get_records_sql('SELECT a.id AS assignment, a.nosubmissions AS nosubmissions, @@ -372,8 +372,8 @@ function assign_print_overview($courses, &$htmlarray) { g.userid = ? LEFT JOIN {assign_submission} s ON s.assignment = a.id AND - s.userid = ? AND - a.id ' . $sqlassignmentids, $dbparams); + s.userid = ? + WHERE a.id ' . $sqlassignmentids, $dbparams); foreach ($assignments as $assignment) { // Do not show assignments that are not open. -- 2.36.1